chore: post-review cleanup — docs drift, CONTEXT.md section order, review nits - #375
Merged
Conversation
…view nits Two-axis review of today's 62-commit range (both axes PASS, info findings): - AGENTS.md gate prose/table updated to Typecheck + Unit Tests (linux) (#370 drift) - CONTEXT.md: Conventions section moved after the full Invariants list — the #348 edit had demoted 5 original Invariants (incl. the engine-enforced gated-checkpoint obligation) under the new header - memory-search: identical if-branches folded back to || - blocks.ts: BLK-02 collision check extracted from an IIFE into aggregatorEvidenceMapping per the Style Guide - #340's serve-mode behavioral e2e documented as a covered-by-composition delta (e2e-loop behavior tests + the wiring probe for the failure class) Closes#374
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#374
What
Info-level findings from the two-axis review of
44c58434d..HEAD(both axes PASS, 0 blocking):Typecheck + Unit Tests (linux)(drift left by chore(ci): raise the dev PR gate to Typecheck + Unit Tests (linux) (middle-tier gating) #370's gate raise).## Conventionsheader from decide(dag): 'one live DAG per user goal' is documented as an Invariant but is an unenforced convention #348 was inserted mid-list and accidentally captured 5 original Invariants (model-facing schema, spec_path, legacy YAML, admission separation, and the engine-enforced gated-checkpoint/output_schema obligation). Section reordered: full Invariants list first, Conventions after. Those 5 are Invariants again.||.aggregatorEvidenceMapping(Style Guide: supporting details in small named helpers).Verification