Skip to content

chore: post-review cleanup — docs drift, CONTEXT.md section order, review nits - #375

Merged
LeXwDeX merged 4 commits into
devfrom
feat/375-issue375
Aug 19, 2026
Merged

chore: post-review cleanup — docs drift, CONTEXT.md section order, review nits#375
LeXwDeX merged 4 commits into
devfrom
feat/375-issue375

Conversation

@LeXwDeX

Copy link
Copy Markdown
Owner

Closes#374

What

Info-level findings from the two-axis review of 44c58434d..HEAD (both axes PASS, 0 blocking):

  1. AGENTS.md — Git Workflow diagram/table/prose updated: dev PR gate is now Typecheck + Unit Tests (linux) (drift left by chore(ci): raise the dev PR gate to Typecheck + Unit Tests (linux) (middle-tier gating) #370's gate raise).
  2. CONTEXT.md — the ## Conventions header from decide(dag): 'one live DAG per user goal' is documented as an Invariant but is an unenforced convention #348 was inserted mid-list and accidentally captured 5 original Invariants (model-facing schema, spec_path, legacy YAML, admission separation, and the engine-enforced gated-checkpoint/output_schema obligation). Section reordered: full Invariants list first, Conventions after. Those 5 are Invariants again.
  3. memory-search.ts — identical if-branches folded back to ||.
  4. blocks.ts — BLK-02 collision check extracted from the inline IIFE into aggregatorEvidenceMapping (Style Guide: supporting details in small named helpers).
  5. fix(goal): GoalLoop not wired into server request-context node graph — standing goals stall on headless serve/web/desktop #340 acceptance delta documented — the "serve-mode goal continuing past turn 1" line is covered by composition (e2e-loop.test.ts behavior suite + the wiring probe asserting the exact failure class); no third harness is built.

Verification

  • typecheck green; blocks tests 23/23; lint delta zero

…view nits
Two-axis review of today's 62-commit range (both axes PASS, info findings):
- AGENTS.md gate prose/table updated to Typecheck + Unit Tests (linux) (#370 drift)
- CONTEXT.md: Conventions section moved after the full Invariants list — the
#348 edit had demoted 5 original Invariants (incl. the engine-enforced
gated-checkpoint obligation) under the new header
- memory-search: identical if-branches folded back to ||
- blocks.ts: BLK-02 collision check extracted from an IIFE into
aggregatorEvidenceMapping per the Style Guide
- #340's serve-mode behavioral e2e documented as a covered-by-composition
delta (e2e-loop behavior tests + the wiring probe for the failure class)
Closes#374
@LeXwDeX
LeXwDeX merged commit 638ae7e into devAug 19, 2026
9 of 10 checks passed
@LeXwDeX
LeXwDeX deleted the feat/375-issue375 branch August 19, 2026 12:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@LeXwDeX