fix: dag inspector shows empty list - #428
Merged
Merged
Conversation
…on context Root cause analysis for the intermittent empty /dag pane under concurrent workflows: the mount-time dag.summary request had no timeout, so an RPC stall pinned the route on its first attempt forever (spinner/empty pane), and the no-sessionID branch silently rendered the loaded-empty state as if no workflows existed. Conservative fix, inspector-local only: - wrap the mount fetch in a race timeout (dag_fetch_timeout_ms, default 15s) - retry once after 400ms before surfacing "Unable to load workflows" - render explicit guidance when the route carries no sessionID instead of the misleading "No workflows for this session" Both behaviors are pinned by new tests at the existing harness seam (retry spy reaches >=2 calls; guidance copy renders with zero network calls).
LeXwDeX
marked this pull request as ready for review
August 24, 2026 06:09
…ness alignment) # Conflicts: # .specgit.yaml
# Conflicts: # .specgit.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#427
Why
双 DAG 并发运行时 /dag 出现"无任何 list/内容"的空态(非 100% 复现,本会话实测)。诊断结论:inspector 的数据发现完全依赖路由参数继承的 sessionID——
dag.open从route.current.params取值,任一环节缺失即走零请求分支直接渲染空列表(dag-inspector.tsx:133);且挂载 fetch 无超时,负载下悬挂时无任何用户可见反馈。项目级GET /dag端点已存在但未被使用。What changed
dag.list()为发现源兜底,sessionID 仅作过滤提示;消除对 params 继承的单点依赖Evidence
Checklist
specgit finishexits 0.