fix(ci): designate a single bun cache saver per OS to stop save races - #56
Merged
Conversation
Concurrent Linux/Windows jobs across ci-test.yml, ci-typecheck.yml, and
release-fork.yml all computed the same {OS}-bun-{hash} cache key and raced
to save it, causing "Unable to reserve cache... another job may be
creating this cache" warnings and the cache never actually updating.
Now only one job per OS saves (ci-typecheck linux, ci-test e2e windows,
release-fork macos); everything else only restores.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci-test.yml,ci-typecheck.yml, andrelease-fork.ymlall compute the same{OS}-bun-{hash}cache key and race to save it, producing "Unable to reserve cache... another job may be creating this cache" warnings and the cache never actually landing.ci-typecheck.yml(linux),ci-test.ymle2e-tests (windows, unchanged),release-fork.yml(macos, the only job touching macOS). Every other job now only restores.Test plan
bun turbo typecheckpasses (ran via pre-commit hook)release-fork.ymlvia workflow_dispatch alongside a push todev/mainand confirm no more "Unable to reserve cache" warnings, and that cache saves succeed on the designated jobs