Skip to content

Bug fix - Video Processing failed#2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
makarandhinge wants to merge 2 commits into
base:main
Choose a base branch
from
Open

Bug fix - Video Processing failed #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0b319f
bug-fix: Video processing issue fix
makarandhinge Dec 5, 2024
463776f
bug-fix:Testing successful
makarandhinge Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spring-stream-backend/src/main/java/com/stream/app/controllers/VideoController.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@

@RestController
@RequestMapping("/api/v1/videos")
@CrossOrigin("http://localhost:5173")
@CrossOrigin("http://localhost:5173")
public class VideoController {


Expand Down
85 changes: 28 additions & 57 deletions spring-stream-backend/src/main/java/com/stream/app/services/impl/VideoServiceImpl.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,6 +18,7 @@
import java.nio.file.Paths;
import java.nio.file.StandardCopyOption;
import java.util.List;
import java.io.*;

@Service
public class VideoServiceImpl implements VideoService {
Expand DownExpand Up@@ -126,70 +127,40 @@ public List<Video> getAll() {
return videoRepository.findAll();
}

@Override
public String processVideo(String videoId) {
@Override
public String processVideo(String videoId) {
Video video = this.get(videoId);
String filePath = video.getFilePath();

Video video = this.get(videoId);
String filePath = video.getFilePath();
// Path where to store data:
Path videoPath = Paths.get(filePath);

//path where to store data:
Path videoPath = Paths.get(filePath);
try {
// ffmpeg command
Path outputPath = Paths.get(HSL_DIR, videoId);
Files.createDirectories(outputPath);

String ffmpegCmd = "ffmpeg -i \"" + videoPath.toString() + "\" -c:v libx264 -c:a aac -strict -2 -f hls -hls_time 10 -hls_list_size 0 -hls_segment_filename \"" + outputPath.toString() + "\\segment_%03d.ts\" \"" + outputPath.toString() + "\\master.m3u8\"";

// String output360p = HSL_DIR + videoId + "/360p/";
// String output720p = HSL_DIR + videoId + "/720p/";
// String output1080p = HSL_DIR + videoId + "/1080p/";
System.out.println("Running ffmpeg command: " + ffmpegCmd);

try {
// Files.createDirectories(Paths.get(output360p));
// Files.createDirectories(Paths.get(output720p));
// Files.createDirectories(Paths.get(output1080p));

// ffmpeg command
Path outputPath = Paths.get(HSL_DIR, videoId);

Files.createDirectories(outputPath);


String ffmpegCmd = String.format(
"ffmpeg -i \"%s\" -c:v libx264 -c:a aac -strict -2 -f hls -hls_time 10 -hls_list_size 0 -hls_segment_filename \"%s/segment_%%3d.ts\" \"%s/master.m3u8\" ",
videoPath, outputPath, outputPath
);

// StringBuilder ffmpegCmd = new StringBuilder();
// ffmpegCmd.append("ffmpeg -i ")
// .append(videoPath.toString())
// .append(" -c:v libx264 -c:a aac")
// .append(" ")
// .append("-map 0:v -map 0:a -s:v:0 640x360 -b:v:0 800k ")
// .append("-map 0:v -map 0:a -s:v:1 1280x720 -b:v:1 2800k ")
// .append("-map 0:v -map 0:a -s:v:2 1920x1080 -b:v:2 5000k ")
// .append("-var_stream_map \"v:0,a:0 v:1,a:0 v:2,a:0\" ")
// .append("-master_pl_name ").append(HSL_DIR).append(videoId).append("/master.m3u8 ")
// .append("-f hls -hls_time 10 -hls_list_size 0 ")
// .append("-hls_segment_filename \"").append(HSL_DIR).append(videoId).append("/v%v/fileSequence%d.ts\" ")
// .append("\"").append(HSL_DIR).append(videoId).append("/v%v/prog_index.m3u8\"");


System.out.println(ffmpegCmd);
//file this command
ProcessBuilder processBuilder = new ProcessBuilder("/bin/bash", "-c", ffmpegCmd);
processBuilder.inheritIO();
Process process = processBuilder.start();
int exit = process.waitFor();
if (exit != 0) {
throw new RuntimeException("video processing failed!!");
}

return videoId;


} catch (IOException ex) {
throw new RuntimeException("Video processing fail!!");
} catch (InterruptedException e) {
throw new RuntimeException(e);
// Run the command on Windows using cmd.exe
ProcessBuilder processBuilder = new ProcessBuilder("cmd.exe", "/c", ffmpegCmd);
processBuilder.inheritIO();
Process process = processBuilder.start();
int exitCode = process.waitFor();

if (exitCode != 0) {
throw new RuntimeException("Video processing failed!");
}

return videoId;

} catch (IOException ex) {
throw new RuntimeException("Video processing failed due to IOException!", ex);
} catch (InterruptedException ex) {
throw new RuntimeException("Video processing was interrupted!", ex);
}
}

}
4 changes: 2 additions & 2 deletions spring-stream-backend/src/main/resources/application.properties
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,9 +5,9 @@ spring.application.name=spring-stream-backend


# MySQL connection
spring.datasource.url=jdbc:mysql://localhost:3306/learn
spring.datasource.url=jdbc:mysql://localhost:3306/stream
spring.datasource.username=root
spring.datasource.password=root1234
spring.datasource.password=Makarand@2002


# JPA properties
Expand Down
24 changes: 0 additions & 24 deletions spring-stream-backend/src/test/java/com/stream/app/SpringStreamBackendApplicationTests.java
View file
Open in desktop

This file was deleted.