Name changer and channel changer#13

jfredett · 2012-08-14T00:27:32Z

Just a note, this is another good place to use the guard-style as noted in my other comment about UserRole#approved?

jfredett · 2012-08-14T02:25:53Z

On thing to note here (not a major issue)
It's good practice to ask what something can do rather than what something is. For instance, if I were to build a proxy object for Cinch::User which provided some extra methods or something, it might not .is_a? the way you think, but it still can fulfill the contract of this method (since it just proxies down to Cinch::User#name, perhaps).
A concrete example might be a multi-name tracker, we might have a model Cinch::MultiUser, which tracks a user who uses multiple names that don't fit some schema, but we want to grant approval to all of them. We might also want to have a Cinch::AuthenticatedUser, which represents a Freenode auth'd user. etc.
Just something to keep in mind.

jfredett · 2012-08-14T00:27:32Z

Just a note, this is another good place to use the guard-style as noted in my other comment about UserRole#approved?

jfredett · 2012-08-14T02:25:53Z

On thing to note here (not a major issue)
It's good practice to ask what something can do rather than what something is. For instance, if I were to build a proxy object for Cinch::User which provided some extra methods or something, it might not .is_a? the way you think, but it still can fulfill the contract of this method (since it just proxies down to Cinch::User#name, perhaps).
A concrete example might be a multi-name tracker, we might have a model Cinch::MultiUser, which tracks a user who uses multiple names that don't fit some schema, but we want to grant approval to all of them. We might also want to have a Cinch::AuthenticatedUser, which represents a Freenode auth'd user. etc.
Just something to keep in mind.

jfredett · 2012-08-14T00:27:32Z

Just a note, this is another good place to use the guard-style as noted in my other comment about UserRole#approved?

jfredett · 2012-08-14T02:25:53Z

On thing to note here (not a major issue)
It's good practice to ask what something can do rather than what something is. For instance, if I were to build a proxy object for Cinch::User which provided some extra methods or something, it might not .is_a? the way you think, but it still can fulfill the contract of this method (since it just proxies down to Cinch::User#name, perhaps).
A concrete example might be a multi-name tracker, we might have a model Cinch::MultiUser, which tracks a user who uses multiple names that don't fit some schema, but we want to grant approval to all of them. We might also want to have a Cinch::AuthenticatedUser, which represents a Freenode auth'd user. etc.
Just something to keep in mind.

jfredett · 2012-08-14T00:27:32Z

Just a note, this is another good place to use the guard-style as noted in my other comment about UserRole#approved?

jfredett · 2012-08-14T02:25:53Z

On thing to note here (not a major issue)
It's good practice to ask what something can do rather than what something is. For instance, if I were to build a proxy object for Cinch::User which provided some extra methods or something, it might not .is_a? the way you think, but it still can fulfill the contract of this method (since it just proxies down to Cinch::User#name, perhaps).
A concrete example might be a multi-name tracker, we might have a model Cinch::MultiUser, which tracks a user who uses multiple names that don't fit some schema, but we want to grant approval to all of them. We might also want to have a Cinch::AuthenticatedUser, which represents a Freenode auth'd user. etc.
Just something to keep in mind.

jfredett · 2012-08-14T00:27:32Z

Just a note, this is another good place to use the guard-style as noted in my other comment about UserRole#approved?

jfredett · 2012-08-14T02:25:53Z

On thing to note here (not a major issue)
It's good practice to ask what something can do rather than what something is. For instance, if I were to build a proxy object for Cinch::User which provided some extra methods or something, it might not .is_a? the way you think, but it still can fulfill the contract of this method (since it just proxies down to Cinch::User#name, perhaps).
A concrete example might be a multi-name tracker, we might have a model Cinch::MultiUser, which tracks a user who uses multiple names that don't fit some schema, but we want to grant approval to all of them. We might also want to have a Cinch::AuthenticatedUser, which represents a Freenode auth'd user. etc.
Just something to keep in mind.

jfredett · 2012-08-14T00:27:32Z

Just a note, this is another good place to use the guard-style as noted in my other comment about UserRole#approved?

jfredett · 2012-08-14T02:25:53Z

On thing to note here (not a major issue)
It's good practice to ask what something can do rather than what something is. For instance, if I were to build a proxy object for Cinch::User which provided some extra methods or something, it might not .is_a? the way you think, but it still can fulfill the contract of this method (since it just proxies down to Cinch::User#name, perhaps).
A concrete example might be a multi-name tracker, we might have a model Cinch::MultiUser, which tracks a user who uses multiple names that don't fit some schema, but we want to grant approval to all of them. We might also want to have a Cinch::AuthenticatedUser, which represents a Freenode auth'd user. etc.
Just something to keep in mind.

jfredett · 2012-08-14T00:27:32Z

Just a note, this is another good place to use the guard-style as noted in my other comment about UserRole#approved?

jfredett · 2012-08-14T02:25:53Z

On thing to note here (not a major issue)
It's good practice to ask what something can do rather than what something is. For instance, if I were to build a proxy object for Cinch::User which provided some extra methods or something, it might not .is_a? the way you think, but it still can fulfill the contract of this method (since it just proxies down to Cinch::User#name, perhaps).
A concrete example might be a multi-name tracker, we might have a model Cinch::MultiUser, which tracks a user who uses multiple names that don't fit some schema, but we want to grant approval to all of them. We might also want to have a Cinch::AuthenticatedUser, which represents a Freenode auth'd user. etc.
Just something to keep in mind.

jfredett · 2012-08-14T00:27:32Z

Just a note, this is another good place to use the guard-style as noted in my other comment about UserRole#approved?

jfredett · 2012-08-14T02:25:53Z

On thing to note here (not a major issue)
It's good practice to ask what something can do rather than what something is. For instance, if I were to build a proxy object for Cinch::User which provided some extra methods or something, it might not .is_a? the way you think, but it still can fulfill the contract of this method (since it just proxies down to Cinch::User#name, perhaps).
A concrete example might be a multi-name tracker, we might have a model Cinch::MultiUser, which tracks a user who uses multiple names that don't fit some schema, but we want to grant approval to all of them. We might also want to have a Cinch::AuthenticatedUser, which represents a Freenode auth'd user. etc.
Just something to keep in mind.

-Original file line number
+Diff line change
@@ Expand Up / @@ -9,5 +9,11 @@ coverage/ @@
 data/
 .rbx
 *.swp
 *~
+#emacs files
+\#*
+.#*

-Original file line number
+Diff line change
@@ Expand Up / @@ -21,7 +21,8 @@ end @@
 desc "start percival, connect to all channels in the CHANNELS env var"
 task :start do
  system 'mkdir -p data/timesheets/'
- channels = ENV["CHANNELS"].split(/,\s*/)
+ channels = ENV["CHANNELS"] && ENV["CHANNELS"].split(/,\s*/) || ["#lpmc-bot"]
+ nick = ENV["NICK"] || "percival"
  server = 'irc.freenode.com'
  require 'percival'
@@ Expand All / @@ -30,8 +31,11 @@ task :start do @@
  configure do |c|
  c.server = server
  c.channels = channels
- c.nick = 'percival'
- c.plugins.plugins = [ClockPlugin, LoggerPlugin]
+ c.nick = nick
+ c.plugins.plugins = [ClockPlugin,
+ LoggerPlugin,
+ ChannelChangerPlugin,
+ NameChangerPlugin]
  end
  end
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -3,6 +3,8 @@ @@
 require 'percival/version'
 require 'percival/clock'
 require 'percival/logger'
+require 'percival/channel_changer'
+require 'percival/name_changer'
 PERCIVAL_ROOT = File.dirname(File.dirname(__FILE__))

Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		require 'percival/channel_changer/plugin'
		require 'percival/channel_changer/user_role'

-Original file line number
+Diff line change
@@ -0,0 +1,27 @@
+class ChannelChangerPlugin
+ include Cinch::Plugin
+ match /join-channel\s+(\S+)/, :method => :join
+ match /leave-channel(?:\s+(\S+))?/, :method => :leave
+ listen_to :error, method: :error
+ def error irc
+ debug( irc.to_s )
+ end
+ def leave( irc, channel )
+ if UserRole.approved? irc.user, :channel_changer
+ channel ||= irc.channel
+ Channel(channel).part
+ end
+ end
+ def join( irc, channel )
+ Channel(channel).join() if UserRole.approved? irc.user, :channel_changer
+ end
+end

-Original file line number
+Diff line change
@@ -0,0 +1,13 @@
+class UserRole
+ @test_users = ["colwem", "jfredett"]
+ @roles = {
+ super_user: @test_users,
+ channel_changer: @test_users,
+ name_changer: @test_users}
+ def self.approved?(user, role)
+ user = user.name if user.is_a? Cinch::User
+ raise "user not in String, Cinch::User" unless user.is_a? String
+ @roles[role].include? user
+ end
+end

-Original file line number
+Diff line change
@@ -0,0 +1,11 @@
+class NameChangerPlugin
+ include Cinch::Plugin
+ match /change-name\s+(\S+)/, :method => :change_name
+ def change_name( irc, name )
+ if UserRole.approved? irc.user, :name_changer
+ bot.nick = name
+ end
+ end
+end

Uh oh!

Name changer and channel changer#13

Uh oh!

Name changer and channel changer #13

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Name changer and channel changer#13

Uh oh!

Name changer and channel changer #13

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Name changer and channel changer#13

Uh oh!

Name changer and channel changer #13

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Name changer and channel changer#13

Uh oh!

Name changer and channel changer #13

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Name changer and channel changer#13

Uh oh!

Name changer and channel changer #13

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Name changer and channel changer#13

Uh oh!

Name changer and channel changer #13

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Name changer and channel changer#13