Skip to content

[4주차] ejy - #28

Closed
jeongyuneo wants to merge 11 commits into
Learning-Now:mainfrom
jeongyuneo:4주차

Hidden character warning

The head ref may contain hidden characters: "4\uc8fc\ucc28"
Closed

[4주차] ejy#28
jeongyuneo wants to merge 11 commits into
Learning-Now:mainfrom
jeongyuneo:4주차

Conversation

@jeongyuneo

@jeongyuneojeongyuneo commented Jan 24, 2021

Copy link
Copy Markdown

No description provided.

Livenow14
Livenow14 reviewed Jan 29, 2021
View reviewed changes

@Livenow14Livenow14 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vo, 객체 역할 책임 협력은 자바개발자라면 평생 알고있어야할 지식입니다.

Comment thread4주차/VO(Value Object).md Outdated
Comment thread4주차/VO(Value Object).md
Comment on lines 74 to 77

@Livenow14Livenow14Jan 29, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이는 프로그래밍 과제에서 확인해볼 수 있겠네요.

Comment thread4주차/객체 지향-역할, 책임, 협력.md Outdated
Comment thread4주차/객체 지향-역할, 책임, 협력.md
Comment thread4주차/객체 지향-역할, 책임, 협력.md Outdated
Comment thread4주차/객체 지향-역할, 책임, 협력.md Outdated
Comment thread4주차/객체 지향-역할, 책임, 협력.md
Comment on lines 32 to 40

@Livenow14Livenow14Jan 29, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calculator에서 하는 것과 아는것을 한번 분리해보는게 어때요?

@Livenow14Livenow14Jan 29, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그게 예제가 되겠네요.

Comment thread4주차/객체 지향-역할, 책임, 협력.md
Comment thread4주차/객체 지향-역할, 책임, 협력.md
Comment thread4주차/객체 지향-역할, 책임, 협력.md
PandaHun
PandaHun requested changes Jan 29, 2021
View reviewed changes

@PandaHunPandaHun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

조금 더 고민 부탁드려요:)

Comment thread4주차/프로그래밍과제1/src/main/java/Calculator.java

@PandaHunPandaHunJan 29, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

float, double, long에 대한 지원은 안되나요?

Comment thread4주차/프로그래밍과제1/src/main/java/Operator.java

@PandaHunPandaHunJan 29, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이게 외부로 노출 될 필요있을까요?

Comment thread4주차/프로그래밍과제1/src/main/java/Operator.java

@PandaHunPandaHunJan 29, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

쉼표로 구분되는 계산기라면 동작을 정상적으로 할 수 있을 까요?

Comment thread4주차/프로그래밍과제1/src/main/java/Operator.java

@PandaHunPandaHunJan 29, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0번 인덱스 데이터가 의미하는게 무엇인가요?

Comment thread4주차/프로그래밍과제1/src/main/java/Operator.java

@PandaHunPandaHunJan 29, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arr는 뭔가요?

Comment thread4주차/프로그래밍과제1/src/main/java/Operator.java

@PandaHunPandaHunJan 29, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

무슨 exception이든 다 여기서 걸리겠네요?

Comment thread4주차/프로그래밍과제1/src/main/java/Operator.java

@PandaHunPandaHunJan 29, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+2는 어떤 기준인가요?

Comment thread4주차/프로그래밍과제1/src/main/java/Operator.java

@PandaHunPandaHunJan 29, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

무슨 예외 처리에요?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Livenow14Livenow14Livenow14 left review comments
@PandaHunPandaHunPandaHun requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeongyuneo@PandaHun@Livenow14