Skip to content

[8주차] LDH - #51

Open
DongLee99 wants to merge 34 commits into
Learning-Now:ldhfrom
DongLee99:8week
Open

[8주차] LDH#51
DongLee99 wants to merge 34 commits into
Learning-Now:ldhfrom
DongLee99:8week

Conversation

@DongLee99

@DongLee99DongLee99 commented Mar 22, 2021

Copy link
Copy Markdown

No description provided.

PandaHun
PandaHun requested changes Mar 24, 2021
View reviewed changes

@PandaHunPandaHun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

많은 부분을 생각해보시면 좋겠습니다

Comment thread8week/racingcar/src/main/java/domain/Car.java Outdated
Comment thread8week/racingcar/src/main/java/domain/Car.java Outdated
Comment thread8week/racingcar/src/main/java/service/RacingCarGame.java Outdated
Comment thread8week/racingcar/src/main/java/service/RacingCarGame.java Outdated
Comment thread8week/racingcar/src/main/java/service/RacingCarGame.java Outdated
Comment thread8week/racingcar/src/main/java/service/RacingCarGame.java Outdated
Comment thread8week/racingcar/src/main/java/utils/Input.java Outdated
Comment thread8week/racingcar/src/main/java/utils/RandomUtils.java Outdated
Comment thread8week/racingcar/src/main/java/utils/View.java
PandaHun
PandaHun requested changes Mar 26, 2021
View reviewed changes

@PandaHunPandaHun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

의견 반영 부탁드려요
생각해보고 질문 주셔도 됩니다

Comment thread8week/racingcar/src/main/java/service/RacingCarGame.java Outdated
Comment thread8week/racingcar/src/main/java/service/RacingCarGameController.java Outdated
Comment thread8week/racingcar/src/main/java/service/RacingCarGameController.java Outdated
Comment thread8week/racingcar/src/main/java/service/RacingCarGameController.java Outdated
PandaHun
PandaHun requested changes Apr 6, 2021
View reviewed changes

@PandaHunPandaHun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

컨벤션과 네이밍을 주의해주시고
몇몇 궁금증 남겨뒀습니다

Comment thread8week/racingcar/src/main/java/domain/Car.java Outdated
}

public void movePosition() {
if (RandomUtils.randomIntGenerator(START_NUMBER, FINISH_NUMBER) > CONTROL_POINT) {

@PandaHunPandaHunApr 6, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분을 매번 생성하는게 아니라
메세지를 보내면 RandomUtils안에서 수행해주면 코드가 더 간결하겠죠?

Comment thread8week/racingcar/src/main/java/domain/Car.java Outdated
Comment thread8week/racingcar/src/main/java/domain/Car.java
Comment thread8week/racingcar/src/main/java/domain/Cars.java Outdated
Comment thread8week/racingcar/src/main/java/domain/Cars.java Outdated
Comment thread8week/racingcar/src/main/java/service/RacingCarGame.java Outdated
Comment thread8week/racingcar/src/main/java/service/RacingCarGameController.java Outdated
Comment thread8week/racingcar/src/main/java/utils/Input.java Outdated
Comment thread8week/racingcar/src/main/java/utils/Input.java Outdated
Comment thread8week/racingcar/src/main/java/utils/RandomUtils.java
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PandaHunPandaHunPandaHun requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DongLee99@PandaHun