Skip to content

Apply mdEngine to preview webview - #257

Merged
jdneo merged 12 commits into
LeetCode-OpenSource:masterfrom
Vigilans:webview-md-preview
Apr 14, 2019
Merged

Apply mdEngine to preview webview#257
jdneo merged 12 commits into
LeetCode-OpenSource:masterfrom
Vigilans:webview-md-preview

Conversation

@Vigilans

@VigilansVigilans commented Apr 3, 2019

Copy link
Copy Markdown
Contributor

Prerequisities

before merging this PR.

Demonstration

demo3

image

image

image

image

image

@Vigilans
Vigilans requested a review from jdneoApril 3, 2019 11:06
Comment threadsrc/commands/show.ts
Comment threadsrc/leetCodeExecutor.ts Outdated
await commands.executeCommand("leetcode.showProblem", this.node);
this.dispose();
return;
await commands.executeCommand("workbench.action.focusSecondEditorGroup");

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line relates to (maybe) a bug in vscode, and I have reported in a issue:
microsoft/vscode#71608, which makes me have to create column 2 first before moving (by calling reveal(ViewColumn.Two)) the webview panel to it.

I've successfully build the vscode repository locally in the aftertoon, and I'd like to have a try to debug the vscode myself.

Comment threadsrc/webview/leetCodePreviewProvider.ts Outdated
private parseDescription(descString: string, problem: IProblem): IDescription {
const [
/* title */, ,
url, ,

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each comma without variable before it means ignore this line (normally empty line, or something not needed)

@VigilansVigilans added this to the 0.13.3 milestone Apr 3, 2019
@jdneojdneo modified the milestones: 0.13.3, 0.13.4Apr 4, 2019
@poppinlp

Copy link
Copy Markdown
Contributor

Looks cool! 👍

Comment threadsrc/commands/show.ts
Comment threadsrc/leetCodeExecutor.ts Outdated
Comment threadsrc/webview/leetCodePreviewProvider.ts
Comment threadsrc/webview/leetCodePreviewProvider.ts
@jdneo
jdneo merged commit ecac298 into LeetCode-OpenSource:masterApr 14, 2019
@VigilansVigilans mentioned this pull request Apr 14, 2019
@Vigilans
Vigilans deleted the webview-md-preview branch April 14, 2019 05:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Vigilans@poppinlp@jdneo