Skip to content

Updated smaller footer - #138

Open
perdi8 wants to merge 6 commits into
Lemoncode:masterfrom
perdi8:master
Open

Updated smaller footer#138
perdi8 wants to merge 6 commits into
Lemoncode:masterfrom
perdi8:master

Conversation

@perdi8

Copy link
Copy Markdown
Collaborator

No description provided.

height: ${spacing(37.5)};
padding: ${spacing(2.5)} ${spacing(12.5)};
height: ${spacing(20.5)};
padding: ${spacing(2)} ${spacing(12.5)};

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is not a good idea you use these properties in the container and each container element, don't necessary and are confusing. This is my propsed CSS for your analysis and study. :-)
`import { css } from 'emotion';
import { theme } from 'core/theme';

const { palette, spacing, breakpoints } = theme;
const color = palette.customPalette;

export const footerContainer = cssdisplay: flex; flex-direction: column; justify-content: space-between; background-color: ${color.secondary};;

// you have change the name in footer.component.tsx
export const logoContainer = cssdisplay: flex; justify-content: center; align-items: center;;

export const bottomContainer = cssdisplay: flex; justify-content: space-between; padding: ${spacing(3)}; border-top: 1px solid ${color.primary}; @media (max-width: ${breakpoints.values.md}px) { flex-direction: column; justify-content: center; align-items: center; };

export const lemoncodeIcon = cssmax-width: 100px; padding: ${spacing(3)} 0;;

export const iconContainer = cssdisplay: flex; justify-content: space-between; width: 50%; margin: 0; padding: 0 0 ${spacing(1)}; list-style: none; @media (min-width: ${breakpoints.values.sm}px) { width: 20%; } @media (min-width: ${breakpoints.values.lg}px) { width: 10%; };

export const icon = cssfont-size: 1.5rem; color: ${color.greyLight}; &:hover { cursor: pointer; color: ${color.primary}; };

export const githubIcon = cssheight: ${spacing(2.75)}; fill: ${color.greyLight}; &:hover { cursor: pointer; fill: ${color.primary}; };

export const copyright = csscolor: ${color.greyLight}; @media (max-width: ${breakpoints.values.xs}px) { margin-top: ${spacing(0.8)}; };
`


export const lemoncodeIcon = css`
height: ${spacing(12.5)};
height: ${spacing(12)};

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same

Comment threadfront/static/styles.css Outdated
height: 30rem;
padding: 2rem 10rem;
height: 16rem;
padding: 0rem 10rem;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same

Comment threadfront/static/styles.css Outdated
.footer__logo {
height: 9rem;
width: 8.5rem;
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same

Comment threadfront/static/styles.css Outdated
height: 10rem;
width: 10rem;
height: 8rem;
width: 8rem;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same

<footer class="footer">
<div class="footer__top-container">
<div class="footer-container">
<nav>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think isn't necessary because the top menu is fixed

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@perdi8@juanpms2