Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Dec 20, 2024. It is now read-only.
Conversation
This was referenced Sep 25, 2021
vweevers added a commit
to Level/subleveldown
that referenced
this pull request
Sep 28, 2021
This works thanks to the `encodings` option that was added to the test suite (originally for `levelup` compatibility testing) and changes the expected outputs (from buffers by default to strings by default).
vweevers
marked this pull request as ready for review
September 29, 2021 19:41
ralphtheninja
approved these changes
Sep 30, 2021
vweevers added a commit
to Level/subleveldown
that referenced
this pull request
Oct 1, 2021
vweevers added a commit
to Level/subleveldown
that referenced
this pull request
Oct 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref Level/community#101. Depends on Level/abstract-leveldown#381 and Level/memdown#212 (for tests).
I also added the
abstract-leveldowntest suite 😃 (18e1fd1).