Skip to content
This repository was archived by the owner on Dec 20, 2024. It is now read-only.
/encoding-downPublic archive

Add manifest - #93

Merged
vweevers merged 5 commits into
masterfrom
manifest
Oct 13, 2019
Merged

Add manifest#93
vweevers merged 5 commits into
masterfrom
manifest

Conversation

@vweevers

@vweeversvweevers commented Oct 1, 2019

Copy link
Copy Markdown
Member

See Level/community#83. Also closes#92.

@vweeversvweevers added the semver-minor New features that are backward compatible label Oct 1, 2019
This was referenced Oct 1, 2019
Closed
Closed
ralphtheninja
ralphtheninja reviewed Oct 1, 2019
View reviewed changes
Comment threadindex.js Outdated
ralphtheninja
ralphtheninja reviewed Oct 1, 2019
View reviewed changes
Comment threadindex.js Outdated
@vweevers

vweevers commented Oct 2, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@ralphtheninja Any ideas to simplify? This thing is kinda cool, but it also crossed my mind that the complexity may not be worth it, if you weigh it against e.g. making approximateSize part of abstract-leveldown again, where it can have a well-defined function signature - and no arguments shenanigans during runtime.

@vweevers

vweevers commented Oct 4, 2019

Copy link
Copy Markdown
MemberAuthor

Opening this up for review, because I'm kinda out of ideas.

@vweevers
vweevers marked this pull request as ready for review October 4, 2019 18:14
vweevers
vweevers commented Oct 4, 2019
View reviewed changes
Comment threadindex.js Outdated
vweevers
vweevers commented Oct 12, 2019
View reviewed changes
Comment threadindex.js Outdated
@vweevers
vweevers removed the request for review from ralphtheninjaOctober 12, 2019 09:34
@vweeversvweevers self-assigned this Oct 12, 2019
@vweeversvweevers removed their assignment Oct 13, 2019
ralphtheninja
ralphtheninja approved these changes Oct 13, 2019
View reviewed changes

@ralphtheninjaralphtheninja left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vweevers
vweevers merged commit ecefdca into masterOct 13, 2019
@vweevers
vweevers deleted the manifest branch October 13, 2019 12:58
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@ralphtheninjaralphtheninjaralphtheninja approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

semver-minorNew features that are backward compatible

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Encode compactRange arguments

2 participants

@vweevers@ralphtheninja