Skip to content

Making new gpCAM gen class - #1316

Merged
shuds13 merged 9 commits into
experimental/jlnav_plus_shuds_asktellfrom
experimental/gen_classes
Jun 4, 2024
Merged

Making new gpCAM gen class#1316
shuds13 merged 9 commits into
experimental/jlnav_plus_shuds_asktellfrom
experimental/gen_classes

Conversation

@shuds13

@shuds13shuds13 commented May 30, 2024

Copy link
Copy Markdown
Member

Make ask/tell classes for gpCAM and RandSample, separate from existing user functions

  • Make gpCAM and Randsample classes
  • Revert gen functions to original

Note for review:

  • New gen_classes directory alongside gen_funcs

Parameters to ask/tell constructor:
H, gen_specs, persis_info, libE_info | original
gen_specs H, persis_info, libE_info | Required parameter first, followed by optional.
gen_specs, persis_info, H, libE_info |

Change H to H0?
Should we have libE_info?

Alt. we could pull this in to parent branch and decide there - going with this.

@shuds13shuds13 mentioned this pull request May 31, 2024
@shuds13
shuds13 marked this pull request as ready for review June 3, 2024 21:02
@codecov

codecovBot commented Jun 3, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 36.92308% with 41 lines in your changes missing coverage. Please review.

Please upload report for BASE (experimental/jlnav_plus_shuds_asktell@fa87f59). Learn more about missing BASE report.

Files with missing linesPatch %Lines
libensemble/gen_funcs/persistent_gpCAM.py0.00%39 Missing ⚠️
libensemble/gen_classes/sampling.py91.66%1 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## experimental/jlnav_plus_shuds_asktell #1316 +/- ##
========================================================================
Coverage ? 73.99% ========================================================================
Files ? 93 Lines ? 8490 Branches ? 1500 ========================================================================
Hits ? 6282 Misses ? 1984 Partials ? 224 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shuds13
shuds13 requested review from jlnav and jmlarson1June 4, 2024 21:04
@shuds13
shuds13 merged commit 86e268d into experimental/jlnav_plus_shuds_asktellJun 4, 2024
@jmlarson1
jmlarson1 deleted the experimental/gen_classes branch July 2, 2024 20:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@shuds13