Uh oh!
There was an error while loading. Please reload this page.
Making new gpCAM gen class - #1316
Merged
shuds13 merged 9 commits intoJun 4, 2024
Merged
Conversation
Merged
shuds13
marked this pull request as ready for review
June 3, 2024 21:02
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## experimental/jlnav_plus_shuds_asktell #1316 +/- ##
========================================================================
Coverage ? 73.99% ========================================================================
Files ? 93 Lines ? 8490 Branches ? 1500 ========================================================================
Hits ? 6282 Misses ? 1984 Partials ? 224 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make ask/tell classes for gpCAM and RandSample, separate from existing user functions
Note for review:
Parameters to ask/tell constructor:
H, gen_specs, persis_info, libE_info | original
gen_specs H, persis_info, libE_info | Required parameter first, followed by optional.
gen_specs, persis_info, H, libE_info |
Change H to H0?
Should we have libE_info?
Alt. we could pull this in to parent branch and decide there - going with this.