Uh oh!
There was an error while loading. Please reload this page.
Examples/optimas ax generators - #1635
Merged
jlnav merged 24 commits intoFeb 20, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@## experimental/jlnav_plus_shuds_asktell #1635 +/- ##
==========================================================================
+ Coverage 78.44% 93.27% +14.82%
==========================================================================
Files 81 81 Lines 8176 8207 +31 Branches 1239 1253 +14 ==========================================================================
+ Hits 6414 7655 +1241 + Misses 1535 356 -1179 + Partials 227 196 -31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shuds13
commented
Feb 9, 2026
| # Set inputs: same as persis_in for gest-api generators (needed for H0 ingestion) | ||
| if not self.inputs and self.generator is not None: | ||
| self.inputs = self.persis_in | ||
| print(f"inputs: {self.inputs}") |
…timas_ax_generators
…timas_ax_generators
jlnav
reviewed
Feb 12, 2026
| if not isinstance(list_dicts, list): | ||
| return list_dicts | ||
| if not list_dicts: |
Member
There was a problem hiding this comment.
Is this to accommodate
gen.ask(0) ??
Either way it looks like a safe/faster fix
jlnav
reviewed
Feb 12, 2026
| self.resources.resource_manager.free_rsets(w) | ||
| def _ensure_sim_id_in_persis_in(self, D: npt.NDArray) -> None: | ||
| """Add sim_id to gen_specs persis_in if generator output contains sim_id (gest-api style generators only)""" |
Member
There was a problem hiding this comment.
And such gens will only return sim_id if we're already explicitly mapping _id to it... right?
jlnav
approved these changes
Feb 12, 2026
jlnav
merged commit Feb 20, 2026
e89e62d
into
experimental/jlnav_plus_shuds_asktell
24 of 31 checks passed
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #1634
_idas its own history field (instead of mapping tosim_id).multitask_uses_idbranch - rem to change (prob bring that in first)._idis treated.