Skip to content

Docs for ask/tell gens - #1656

Merged
jlnav merged 19 commits into
experimental/jlnav_plus_shuds_asktellfrom
asktell/emphasize_asktell_gens
Mar 2, 2026
Merged

Docs for ask/tell gens#1656
jlnav merged 19 commits into
experimental/jlnav_plus_shuds_asktellfrom
asktell/emphasize_asktell_gens

Conversation

@jlnav

Copy link
Copy Markdown
Member

No description provided.

@jlnav
jlnav marked this pull request as ready for review January 21, 2026 17:18
@codecov

codecovBot commented Jan 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.65%. Comparing base (9b5cb8d) to head (14f2909).

Additional details and impacted files
@@ Coverage Diff @@## experimental/jlnav_plus_shuds_asktell #1656 +/- ##
======================================================================
Coverage 47.65% 47.65% ======================================================================
Files 80 80 Lines 8127 8127 Branches 1235 1235 ======================================================================
Hits 3873 3873 Misses 4034 4034 Partials 220 220 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment threaddocs/examples/gest_api.rst Outdated
.. _gpcam: https://gpcam.lbl.gov/
.. _paper: https://link.springer.com/article/10.1007/s12532-017-0131-4

.. _Expected Improvement: https://github.com/xopt-org/Xopt/blob/v3.0/xopt/generators/bayesian/expected_improvement.py

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we know if these branches are persistent.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likely not - I'll have it point to the valid main-branch path

Xopt - https://github.com/xopt-org/Xopt
---------------------------------------

`Expected Improvement`_

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could state as examples.

@jlnav
jlnav requested a review from shuds13January 29, 2026 17:05
@jlnavjlnav changed the title [WIP] Docs for ask/tell gensDocs for ask/tell gensFeb 5, 2026
@shuds13

Copy link
Copy Markdown
Member

As my comment above. in section

Verified Third Party Examples

I think it makes it look like only [Expected Improvement] [Nelder Mead]Grid sampling will work.

Maybe link to generators directories...

If want to give examples link to tutorial. Can link to the tutorial https://libensemble--1656.org.readthedocs.build/en/1656/tutorials/xopt_bayesian_gen.html

or link to our tests.

@shuds13shuds13 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve but see above comment

@jlnav
jlnav merged commit 718df76 into experimental/jlnav_plus_shuds_asktellMar 2, 2026
1 of 14 checks passed
@jlnav
jlnav deleted the asktell/emphasize_asktell_gens branch March 11, 2026 18:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jlnav@shuds13