Skip to content

Asktell/aposmm reg test with vocs + other changes - #1679

Merged
shuds13 merged 12 commits into
experimental/jlnav_plus_shuds_asktellfrom
asktell/aposmm_reg_test_vocs
Feb 27, 2026
Merged

Asktell/aposmm reg test with vocs + other changes#1679
shuds13 merged 12 commits into
experimental/jlnav_plus_shuds_asktellfrom
asktell/aposmm_reg_test_vocs

Conversation

@jlnav

Copy link
Copy Markdown
Member

Note several things:

  • We're still doing numpy back and forth for aposmm
  • But aposmm's x and f need to be "mapped" to core,edge,energy for vocs, since vocs also decides history
  • So mapping is needed, but not np_to_list_dicts mapping.
  • unmap_numpy_array is useful. the reverse was added, map_numpy_array.
  • the mapping of "sim_id" is special. if _id comes in, we swap it with sim_id. If sim_id goes out, we obviously want sim_id to come back
  • Simplification of list_dicts_to_np was more possible once we treated only the mapping fields as base truth if its in sync with the input data

…eGenInterfacer's, plus refactoring the aposmm calling script into how I'd like it to look eventually.
…y array into the H constructed from VOCS, then do the reverse for the numpy array from H back into APOSMM. Also ensure that _id data becomes sim_id, and vice-versa
- Hint towards easy bug where user may have intended to set sim_specs.simulator instead of sim_specs.sim_f
the regression test:
- use vocs for second test iteration
misc.py
- more reliably build the dtype out of mapping keys that are present in the input data
runners.py
- some cleanup
@codecov

codecovBot commented Feb 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.87879% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.44%. Comparing base (c5e5183) to head (7bfabce).

Files with missing linesPatch %Lines
libensemble/manager.py33.33%6 Missing ⚠️
libensemble/gen_classes/aposmm.py75.00%1 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## experimental/jlnav_plus_shuds_asktell #1679 +/- ##
==========================================================================
+ Coverage 78.27% 91.44% +13.17% 
==========================================================================
Files 81 81 Lines 8210 8255 +45 Branches 1254 1266 +12 ==========================================================================
+ Hits 6426 7549 +1123 + Misses 1549 519 -1030 + Partials 235 187 -48 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jlnav
jlnav requested a review from shuds13February 19, 2026 16:13
…rong simulator/sim_f parameter is set in sim_specs, and accordingly the wrong data is returned. test for this
@jlnav
jlnav changed the base branch from examples/optimas_ax_generators to experimental/jlnav_plus_shuds_asktellFebruary 24, 2026 21:10
Comment threadpyproject.toml
"proxystore>=0.8.3,<0.9",
"redis>=7.1.0,<8",
"surmise>=0.3.0,<0.5",
"optimas @ git+https://github.com/optimas-org/optimas@multitask_uses_id",

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we still need this...?

@shuds13
shuds13 merged commit 9ab4f93 into experimental/jlnav_plus_shuds_asktellFeb 27, 2026
24 of 31 checks passed
@jlnav
jlnav deleted the asktell/aposmm_reg_test_vocs branch March 11, 2026 18:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jlnav@shuds13