Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Jan 13, 2023. It is now read-only.
Fix NumberFormatException stack performance. - #6
Merged
Conversation
Creating exceptions is not cheap, since they construct stack frames. This shouldn't affect performance much, but fix/optimize it anyway.
TheDGOfficial
enabled auto-merge (squash)
February 17, 2021 16:32
TheDGOfficial
disabled auto-merge
February 17, 2021 16:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made in this Pull Request
Creating exceptions is not cheap, since they construct stack frames.
This shouldn't affect performance much, but fix/optimize it anyway.
Reason of the above changes are
We do not need to parse the input as integer, and this causes constructing useless NumberFormatException instances, which allocate more memory/consume time than needed.
Other information about this Pull Request
N/A