Uh oh!
There was an error while loading. Please reload this page.
chore: bump lib versions - #2296
Conversation
Entire-Checkpoint: b50f5875b462
📝 WalkthroughWalkthroughThis pull request bumps the version of the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
sdk-libs/token-sdk/Cargo.toml (1)
9-10: 🛠️ Refactor suggestion | 🟠 MajorMissing
compressiblefeature gate required by coding guidelines.The
default = []block doesn't define acompressiblefeature, yetlight-compressible(line 35) is wired in as a mandatory, non-optional dependency. The coding guidelines forsdk-libs/token-sdk/**/Cargo.tomlexplicitly require this feature to exist so downstream consumers can opt into compressible SDK macro utilities.♻️ Proposed addition
[features] default = [] v1 = ["light-compressed-token-sdk/v1"] +compressible = ["light-compressible"] anchor = ["anchor-lang", "light-token-types/anchor", "light-token-interface/anchor", "light-compressed-token-sdk/anchor", "dep:light-sdk-macros"]And make the dependency optional:
-light-compressible = { workspace = true }+light-compressible = { workspace = true, optional = true }As per coding guidelines: "Enable the 'compressible' feature to use utility functions for compressible SDK macros."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@sdk-libs/token-sdk/Cargo.toml` around lines 9 - 10, Add a "compressible" feature to the crate's features list and make the "light-compressible" dependency optional so downstream consumers can opt into compressible SDK macro utilities; specifically, add a feature named compressible to the default/features table and mark the dependency "light-compressible" as optional and tied to that feature (reference the feature name "compressible" and the dependency key "light-compressible" in Cargo.toml and ensure the new feature is wired to enable that optional dependency).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@sdk-libs/token-sdk/Cargo.toml`:
- Line 3: Add the missing feature flag "compressible = []" to the crate's
features section so the compressible SDK macros utilities are available; update
the Cargo.toml features block (alongside existing entries that use { workspace =
true }) to include compressible = [] and ensure it aligns with other workspace
crates' feature names and formatting.
---
Outside diff comments:
In `@sdk-libs/token-sdk/Cargo.toml`:
- Around line 9-10: Add a "compressible" feature to the crate's features list
and make the "light-compressible" dependency optional so downstream consumers
can opt into compressible SDK macro utilities; specifically, add a feature named
compressible to the default/features table and mark the dependency
"light-compressible" as optional and tied to that feature (reference the feature
name "compressible" and the dependency key "light-compressible" in Cargo.toml
and ensure the new feature is wired to enable that optional dependency).
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Version Bumps
Published to crates.io via
scripts/release/publish-local.sh.Generated by
scripts/release/publish-local.shSummary by CodeRabbit