Skip to content

fix: transfer nullify network fee from queue account - #2334

Closed
ananas-block wants to merge 1 commit into
mainfrom
jorrit/fix-smt-fee-transfer
Closed

fix: transfer nullify network fee from queue account#2334
ananas-block wants to merge 1 commit into
mainfrom
jorrit/fix-smt-fee-transfer

Conversation

@ananas-block

@ananas-blockananas-block commented Mar 11, 2026•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Updated fee reimbursement handling during leaf nullification to ensure correct account debiting.

@ananas-block
fix: transfer nullify network fee from queue account instead of tree …
1303c47
…account
The queue account accumulates fees from queue insertions, so the
reimbursement to the fee payer should come from the queue, not the tree.
@coderabbitai

coderabbitaiBot commented Mar 11, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 76623be5-5df8-41a1-a508-1f3f4f23e38a

📥 Commits

Reviewing files that changed from the base of the PR and between 8a609d6 and 1303c47.

📒 Files selected for processing (1)
  • programs/account-compression/src/instructions/nullify_leaves.rs
📝 Walkthrough

Walkthrough

The fee reimbursement logic in process_nullify_leaves now sources lamports from the nullifier_queue account instead of the merkle_tree account when reimbursing the fee_payer for network costs.

Changes

Cohort / File(s)Summary
Fee Reimbursement Account Source
programs/account-compression/src/instructions/nullify_leaves.rs		Changed lamport transfer source from merkle_tree to nullifier_queue when reimbursing the fee_payer in process_nullify_leaves.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • sergeytimoshin
  • SwenSchaeferjohann

Poem

💰 A single line shifts the burden right,
From merkle_tree to nullifier's sight,
The fee finds home where it belongs,
Correcting an account all along! ✨

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jorrit/fix-smt-fee-transfer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ananas-block
ananas-block deleted the jorrit/fix-smt-fee-transfer branch March 11, 2026 00:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ananas-block