chore: token-interface

[SwenSchaeferjohann]

No description provided.

[coderabbitai]

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (64)

• .github/workflows/js-token-interface-v2.yml is excluded by none and included by none
• .gitignore is excluded by none and included by none
• js/compressed-token/src/v3/instructions/unwrap.ts is excluded by none and included by none
• js/compressed-token/src/v3/instructions/wrap.ts is excluded by none and included by none
• js/compressed-token/tests/e2e/approve-revoke-light-token.test.ts is excluded by none and included by none
• js/compressed-token/tests/e2e/transfer-delegated-failures.test.ts is excluded by none and included by none
• js/justfile is excluded by none and included by none
• js/token-interface/.prettierrc is excluded by none and included by none
• js/token-interface/README.md is excluded by none and included by none
• js/token-interface/eslint.config.cjs is excluded by none and included by none
• js/token-interface/package.json is excluded by none and included by none
• js/token-interface/rollup.config.js is excluded by none and included by none
• js/token-interface/src/account.ts is excluded by none and included by none
• js/token-interface/src/constants.ts is excluded by none and included by none
• js/token-interface/src/errors.ts is excluded by none and included by none
• js/token-interface/src/helpers.ts is excluded by none and included by none
• js/token-interface/src/index.ts is excluded by none and included by none
• js/token-interface/src/instructions/_plan.ts is excluded by none and included by none
• js/token-interface/src/instructions/approve.ts is excluded by none and included by none
• js/token-interface/src/instructions/ata.ts is excluded by none and included by none
• js/token-interface/src/instructions/burn.ts is excluded by none and included by none
• js/token-interface/src/instructions/freeze.ts is excluded by none and included by none
• js/token-interface/src/instructions/index.ts is excluded by none and included by none
• js/token-interface/src/instructions/layout/layout-mint-action.ts is excluded by none and included by none
• js/token-interface/src/instructions/layout/layout-mint.ts is excluded by none and included by none
• js/token-interface/src/instructions/layout/layout-transfer2.ts is excluded by none and included by none
• js/token-interface/src/instructions/layout/layout.ts is excluded by none and included by none
• js/token-interface/src/instructions/load.ts is excluded by none and included by none
• js/token-interface/src/instructions/load/decompress.ts is excluded by none and included by none
• js/token-interface/src/instructions/load/select-primary-cold-account.ts is excluded by none and included by none
• js/token-interface/src/instructions/revoke.ts is excluded by none and included by none
• js/token-interface/src/instructions/thaw.ts is excluded by none and included by none
• js/token-interface/src/instructions/transfer.ts is excluded by none and included by none
• js/token-interface/src/instructions/unwrap.ts is excluded by none and included by none
• js/token-interface/src/instructions/wrap.ts is excluded by none and included by none
• js/token-interface/src/kit/index.ts is excluded by none and included by none
• js/token-interface/src/load-options.ts is excluded by none and included by none
• js/token-interface/src/nowrap/index.ts is excluded by none and included by none
• js/token-interface/src/nowrap/instructions.ts is excluded by none and included by none
• js/token-interface/src/read/associated-token-address.ts is excluded by none and included by none
• js/token-interface/src/read/ata-utils.ts is excluded by none and included by none
• js/token-interface/src/read/get-account.ts is excluded by none and included by none
• js/token-interface/src/read/get-mint.ts is excluded by none and included by none
• js/token-interface/src/read/index.ts is excluded by none and included by none
• js/token-interface/src/spl-interface.ts is excluded by none and included by none
• js/token-interface/src/types.ts is excluded by none and included by none
• js/token-interface/tests/e2e/approve-revoke.test.ts is excluded by none and included by none
• js/token-interface/tests/e2e/ata-read.test.ts is excluded by none and included by none
• js/token-interface/tests/e2e/burn.test.ts is excluded by none and included by none
• js/token-interface/tests/e2e/freeze-thaw.test.ts is excluded by none and included by none
• js/token-interface/tests/e2e/helpers.ts is excluded by none and included by none
• js/token-interface/tests/e2e/load.test.ts is excluded by none and included by none
• js/token-interface/tests/e2e/transfer.test.ts is excluded by none and included by none
• js/token-interface/tests/unit/account.test.ts is excluded by none and included by none
• js/token-interface/tests/unit/instruction-builders.test.ts is excluded by none and included by none
• js/token-interface/tests/unit/kit.test.ts is excluded by none and included by none
• js/token-interface/tests/unit/public-api.test.ts is excluded by none and included by none
• js/token-interface/tsconfig.json is excluded by none and included by none
• js/token-interface/tsconfig.test.json is excluded by none and included by none
• js/token-interface/vitest.config.ts is excluded by none and included by none
• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml and included by none
• pnpm-workspace.yaml is excluded by none and included by none
• scripts/format.sh is excluded by none and included by none
• scripts/lint.sh is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: e90eab3f-7842-4ef3-b8e3-a136cfcf6a2f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch swen/single-ix

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ananas-block]

nit: duplicated toBigIntAmount helper

toBigIntAmount(amount: number | bigint): bigint is identically defined in three files:

• js/token-interface/src/instructions/transfer.ts:26
• js/token-interface/src/instructions/approve.ts:14
• js/token-interface/src/instructions/burn.ts:16

Extract to a shared utility.

[ananas-block]

nit: inconsistent discriminator type declarations

Some discriminators are number constants written via writeUInt8(), others are Buffer used directly as instruction data:

// number (transfer.ts, approve.ts, burn.ts)constLIGHT_TOKEN_TRANSFER_CHECKED_DISCRIMINATOR=12;constLIGHT_TOKEN_APPROVE_DISCRIMINATOR=4;// Buffer (freeze.ts, thaw.ts)constLIGHT_TOKEN_FREEZE_ACCOUNT_DISCRIMINATOR=Buffer.from([10]);constLIGHT_TOKEN_THAW_ACCOUNT_DISCRIMINATOR=Buffer.from([11]);

Pick one convention.

[ananas-block]

nit: buffer over-allocation in ATA encoding

js/token-interface/src/instructions/ata.ts:119:

constbuffer=Buffer.alloc(2000);

The Borsh-encoded CompressibleConfig is ~50 bytes. 2000 is 40x what's needed.

[ananas-block]

Code Review Comments

1. getVersionFromDiscriminator silently defaults to ShaFlat for unknown discriminators

js/token-interface/src/instructions/load/decompress.ts:148-172

getVersionFromDiscriminator silently defaults to ShaFlat for unrecognized discriminators. This won't cause security issues (on-chain proof verification catches the mismatch), but it turns what should be a clear "unknown discriminator" error into an opaque Merkle proof failure. The JS detection logic is also looser than the Rust side -- JS checks single bytes (discriminator[0], discriminator[7]) while Rust requires exact 8-byte matches, so edge cases like [2, 1, 0, 0, 0, 0, 0, 4] would match V1 in JS but fail in Rust. Consider throwing for unrecognized discriminators to match Rust behavior.

2. Failure tests use bare .rejects.toThrow() without message matching

js/compressed-token/tests/e2e/transfer-delegated-failures.test.ts, approve-revoke-light-token.test.ts

4 failure tests use bare .rejects.toThrow() without matching a specific error message -- any error (network timeout, serialization bug) would pass. The rest of the test suite already uses specific matchers (string, regex, error class) in ~50 other places, so this is an inconsistency. Suggest adding at least a regex match for the expected error.

3. Wrap/nowrap duplication across 6 instruction types

js/token-interface/src/instructions/transfer.ts, approve.ts, revoke.ts, burn.ts, freeze.ts, thaw.ts

Each of these files has a createXxxInstructions / createXxxInstructionsNowrap pair that is 80-100% identical, differing only in wrap: true vs wrap: false. That's 6 pairs of near-duplicate functions. A single wrap parameter on the main function would eliminate all of it.

4. Dead code

• js/token-interface/src/helpers.ts:36 -- normalizeInstructionBatches is exported but never imported or called anywhere (including tests)
• js/token-interface/src/instructions/transfer.ts:98 -- recipientLoadInstructions is always empty; the spread on line 150 is a no-op
• _SPL_TOKEN_PROGRAM_INDEX is defined but never used in 3 files: js/token-interface/src/instructions/wrap.ts:65, js/compressed-token/src/v3/instructions/unwrap.ts:80, js/compressed-token/src/v3/instructions/wrap.ts:49

5. Hard-coded buffer allocations

js/token-interface/src/instructions/layout/layout-mint-action.ts:329, layout-transfer2.ts:390, layout-transfer2.ts:194

Hard-coded buffer allocations (10KB, 4KB, 1KB) with no documentation of why those sizes are sufficient. The data is correctly trimmed with .subarray(0, len), so no corruption risk, but there's no overflow protection if data exceeds the buffer. ata.ts:123-139 already demonstrates a retry-with-doubling pattern that handles this more defensively.

6. async function that never awaits

js/token-interface/src/instructions/ata.ts:428-435

createAtaInstructions is marked async but contains no await -- the body is fully synchronous. This forces callers to await unnecessarily.

[SwenSchaeferjohann]

Code Review Comments

• applied changes for 1-4 and 6
• improved the nowrap implementation
• 5 is not applicable. hardcoded buffer is fine

[SwenSchaeferjohann]

superseded by #2366