Parse non byte aligned number - #17
Merged
Merged
Conversation
Murmeleforce-pushed
the
parseNonByteAlignedNumber
branch
from
February 16, 2023 16:57
19d3e04 to
2f50209CompareLinuxDevon
commented
Jul 27, 2023
Owner
@Murmele do you need this in the release before I make it? |
Murmele
commented
Jul 27, 2023
ContributorAuthor
Yes please :) |
ContributorAuthor
I will rebase it, then you can merge it. I will let you know when I am ready. |
Reason: When including the project with FetchContent into a cmake project the headers are just needed for building, so the headers are not needed to be installed. In this case ignore them
Reason: With it the source can be included directly and it does not install the header files
Murmeleforce-pushed
the
parseNonByteAlignedNumber
branch
from
July 29, 2023 13:02
ca69d0d to
0de0d34CompareMurmele
marked this pull request as ready for review
July 30, 2023 09:09
Murmele
commented
Jul 30, 2023
ContributorAuthor
I tested with labplot and it looks good! Thanks for merging! |
LinuxDevon
approved these changes
Aug 1, 2023
LinuxDevon
left a comment
Owner
There was a problem hiding this comment.
Appreciate the work here! Appologize for the delay again. I think the release flow is broken so I will just give it a tag for now and work on an official release when I get some time and motivation.
Murmele
commented
Aug 2, 2023
ContributorAuthor
@LinuxDevon don't worry. Thanks for merging! I will update in Labplot to your release 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.