Uh oh!
There was an error while loading. Please reload this page.
fix: emit canonical two-binding TSEL and restore check closure - #41
Open
zhoubot wants to merge 3 commits into
Open
fix: emit canonical two-binding TSEL and restore check closure#41zhoubot wants to merge 3 commits into
zhoubot wants to merge 3 commits into
Conversation
This was referenced Aug 31, 2026
Open
zhoubot
commented
Aug 31, 2026
CollaboratorAuthor
Hosted gate resultRequired check is green on run 33359574673: Exact evidence from the run: The first run exposed a pre-existing cache correctness bug: the cache key included only LLVM SHA but also restored installed TileOP headers. Commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
B.IOTbindings:lastor destination;lastand the new destination;B.IOR.RegSrc1row stride is expressed in bytes.The PTO ISA contract is unchanged. The model's rejection of the previous single-
B.IOTbundle remains correct fail-closed behavior.Root cause
The public in-place API
TSEL(dst, mask, true_src)emitted one terminatingB.IOTand implicitly treated the destination's prior value as the false source. Current PTO-SPEC requires that false source to be bound explicitly. SuperScalarModel therefore rejected the generated ELF before execution.The existing target frontend script also loaded the packaged TileOP API before the checkout under test, so it could not prove source changes. The resource overlay in this PR preserves Clang builtin headers while replacing only
tileop-apiwith the current repository.Validation
The TSEL probe disassembles to:
Tracking
Fixes#39.
Related to #31.
Cross-repository context: