Skip to content
This repository was archived by the owner on Oct 13, 2024. It is now read-only.

refactor: restructure source code - #584

Draft
ReenigneArcher wants to merge 1 commit into
masterfrom
refactor/restructure-source-code
Draft

refactor: restructure source code#584
ReenigneArcher wants to merge 1 commit into
masterfrom
refactor/restructure-source-code

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Changes mostly based on LizardByte/Themerr-plex#497

In the future maybe we can combine these into one project...

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher
ReenigneArcherforce-pushed the refactor/restructure-source-code branch 2 times, most recently from eec9586 to 121ebe7CompareAugust 9, 2024 23:17
@codecov

codecovBot commented Aug 9, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 62.40000% with 47 lines in your changes missing coverage. Please review.

Project coverage is 66.19%. Comparing base (01d4d90) to head (5457d27).

FilesPatch %Lines
src/retroarcher.py0.00%23 Missing ⚠️
src/common/webapp.py60.97%16 Missing ⚠️
src/common/config.py73.07%7 Missing ⚠️
src/common/__init__.py80.00%1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (01d4d90) and HEAD (5457d27). Click for more details.

HEAD has 1 upload less than BASE
FlagBASE (01d4d90)HEAD (5457d27)
Windows-x6410
Additional details and impacted files
@@ Coverage Diff @@## master #584 +/- ##
==========================================
- Coverage 74.03% 66.19% -7.84% 
==========================================
Files 10 11 +1 Lines 905 1056 +151 ==========================================
+ Hits 670 699 +29 - Misses 235 357 +122 
FlagCoverage Δ
Linux-x6462.40% <60.80%> (-7.21%)⬇️
Windows-x64?
Windows-x8665.53% <62.40%> (-7.73%)⬇️
macOS-x6465.71% <62.40%> (-7.77%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

FilesCoverage Δ
src/common/definitions.py83.33% <100.00%> (ø)
src/common/hardware.py78.26% <100.00%> (ø)
src/common/helpers.py70.58% <ø> (ø)
src/common/locales.py83.72% <100.00%> (ø)
src/common/logger.py61.03% <100.00%> (ø)
src/common/threads.py100.00% <ø> (ø)
src/common/tray_icon.py83.03% <100.00%> (ø)
src/common/__init__.py63.63% <80.00%> (ø)
src/common/config.py80.73% <73.07%> (ø)
src/common/webapp.py70.14% <60.97%> (ø)
... and 1 more

@ReenigneArcher
ReenigneArcherforce-pushed the refactor/restructure-source-code branch 18 times, most recently from bba5e71 to 82c8c64CompareAugust 15, 2024 03:16
@ReenigneArcher
ReenigneArcherforce-pushed the refactor/restructure-source-code branch from 82c8c64 to 4111982CompareSeptember 3, 2024 02:24
@ReenigneArcher
ReenigneArcherforce-pushed the refactor/restructure-source-code branch from 4111982 to 3c242bfCompareSeptember 22, 2024 01:09
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate FailedQuality Gate failed

Failed conditions
31 New issues
4 Security Hotspots
31 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@ReenigneArcher