feat: add min_fps_target setting by ReenigneArcher · Pull Request #1043 · LizardByte/Sunshine

ReenigneArcher · 2023-03-15T22:31:43Z

Description

Add minimum fps target setting to help in situations where 10 fps is too low.

Screenshot

Issues Fixed or Closed

FixesChromebook Screen Flickering Issues #1042
Fixes #1009
FixesScreen flicker on Chromebook #988

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

I want maintainers to keep my branch updated

ReenigneArcher · 2023-03-16T15:41:30Z

This is working now. I was missing the part where it reads the config option from the saved config file so it was always using the default value.

I also renamed the setting to min_fps_target as setting this to a high value wouldn't guarantee a high FPS, which would have probably been misleading.

For me, if I set the value to 1 FPS, my stream is about 7-8 FPS (according to Moonlight) with static content. If I set to 240 FPS, I get about 65-68 FPS. I only tested on my laptop with integrated AMD graphics, with all other options as default.

ReenigneArcher · 2023-05-05T01:14:56Z

@cgutman do you think this PR should be resumed? I know there's been a lot of activity to try to improve streaming performance, and I don't know if this is still relevant.

Jocelyn-JE · 2024-03-21T14:21:51Z

This change seems to improve slightly the number of microstutters when switching from a static image to an active one and back. Needs further testing / changes.

codecov · 2024-06-18T21:54:23Z

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 8.96%. Comparing base (d6dd1ab) to head (f651fc9).
Report is 144 commits behind head on master.

Files with missing lines	Patch %	Lines
src/video.cpp	0.00%	0 Missing and 3 partials ⚠️
src/config.cpp	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #1043 +/- ##
=========================================
- Coverage 8.97% 8.96% -0.01% 
=========================================
Files 94 94 Lines 17389 17392 +3 Branches 8267 8270 +3 =========================================
Hits 1560 1560 Misses 12967 12967 - Partials 2862 2865 +3

Flag	Coverage Δ
Linux	`6.79% <0.00%> (-0.01%)`	⬇️
Windows	`4.16% <0.00%> (-0.01%)`	⬇️
macOS-12	`10.04% <0.00%> (-0.01%)`	⬇️
macOS-13	`9.95% <0.00%> (+<0.01%)`	⬆️
macOS-14	`10.24% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/config.h	`0.00% <ø> (ø)`
src/config.cpp	`4.77% <0.00%> (-0.01%)`	⬇️
src/video.cpp	`25.23% <0.00%> (-0.05%)`	⬇️

ReenigneArcher · 2023-03-15T22:31:43Z

Description

Add minimum fps target setting to help in situations where 10 fps is too low.

Screenshot

Issues Fixed or Closed

FixesChromebook Screen Flickering Issues #1042
Fixes #1009
FixesScreen flicker on Chromebook #988

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

I want maintainers to keep my branch updated

ReenigneArcher · 2023-03-16T15:41:30Z

This is working now. I was missing the part where it reads the config option from the saved config file so it was always using the default value.

I also renamed the setting to min_fps_target as setting this to a high value wouldn't guarantee a high FPS, which would have probably been misleading.

For me, if I set the value to 1 FPS, my stream is about 7-8 FPS (according to Moonlight) with static content. If I set to 240 FPS, I get about 65-68 FPS. I only tested on my laptop with integrated AMD graphics, with all other options as default.

ReenigneArcher · 2023-05-05T01:14:56Z

@cgutman do you think this PR should be resumed? I know there's been a lot of activity to try to improve streaming performance, and I don't know if this is still relevant.

Jocelyn-JE · 2024-03-21T14:21:51Z

This change seems to improve slightly the number of microstutters when switching from a static image to an active one and back. Needs further testing / changes.

codecov · 2024-06-18T21:54:23Z

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 8.96%. Comparing base (d6dd1ab) to head (f651fc9).
Report is 144 commits behind head on master.

Files with missing lines	Patch %	Lines
src/video.cpp	0.00%	0 Missing and 3 partials ⚠️
src/config.cpp	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #1043 +/- ##
=========================================
- Coverage 8.97% 8.96% -0.01% 
=========================================
Files 94 94 Lines 17389 17392 +3 Branches 8267 8270 +3 =========================================
Hits 1560 1560 Misses 12967 12967 - Partials 2862 2865 +3

Flag	Coverage Δ
Linux	`6.79% <0.00%> (-0.01%)`	⬇️
Windows	`4.16% <0.00%> (-0.01%)`	⬇️
macOS-12	`10.04% <0.00%> (-0.01%)`	⬇️
macOS-13	`9.95% <0.00%> (+<0.01%)`	⬆️
macOS-14	`10.24% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/config.h	`0.00% <ø> (ø)`
src/config.cpp	`4.77% <0.00%> (-0.01%)`	⬇️
src/video.cpp	`25.23% <0.00%> (-0.05%)`	⬇️

ReenigneArcher · 2023-03-15T22:31:43Z

Description

Add minimum fps target setting to help in situations where 10 fps is too low.

Screenshot

Issues Fixed or Closed

FixesChromebook Screen Flickering Issues #1042
Fixes #1009
FixesScreen flicker on Chromebook #988

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

I want maintainers to keep my branch updated

ReenigneArcher · 2023-03-16T15:41:30Z

This is working now. I was missing the part where it reads the config option from the saved config file so it was always using the default value.

I also renamed the setting to min_fps_target as setting this to a high value wouldn't guarantee a high FPS, which would have probably been misleading.

For me, if I set the value to 1 FPS, my stream is about 7-8 FPS (according to Moonlight) with static content. If I set to 240 FPS, I get about 65-68 FPS. I only tested on my laptop with integrated AMD graphics, with all other options as default.

ReenigneArcher · 2023-05-05T01:14:56Z

@cgutman do you think this PR should be resumed? I know there's been a lot of activity to try to improve streaming performance, and I don't know if this is still relevant.

Jocelyn-JE · 2024-03-21T14:21:51Z

This change seems to improve slightly the number of microstutters when switching from a static image to an active one and back. Needs further testing / changes.

codecov · 2024-06-18T21:54:23Z

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 8.96%. Comparing base (d6dd1ab) to head (f651fc9).
Report is 144 commits behind head on master.

Files with missing lines	Patch %	Lines
src/video.cpp	0.00%	0 Missing and 3 partials ⚠️
src/config.cpp	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #1043 +/- ##
=========================================
- Coverage 8.97% 8.96% -0.01% 
=========================================
Files 94 94 Lines 17389 17392 +3 Branches 8267 8270 +3 =========================================
Hits 1560 1560 Misses 12967 12967 - Partials 2862 2865 +3

Flag	Coverage Δ
Linux	`6.79% <0.00%> (-0.01%)`	⬇️
Windows	`4.16% <0.00%> (-0.01%)`	⬇️
macOS-12	`10.04% <0.00%> (-0.01%)`	⬇️
macOS-13	`9.95% <0.00%> (+<0.01%)`	⬆️
macOS-14	`10.24% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/config.h	`0.00% <ø> (ø)`
src/config.cpp	`4.77% <0.00%> (-0.01%)`	⬇️
src/video.cpp	`25.23% <0.00%> (-0.05%)`	⬇️

ReenigneArcher · 2023-03-15T22:31:43Z

Description

Add minimum fps target setting to help in situations where 10 fps is too low.

Screenshot

Issues Fixed or Closed

FixesChromebook Screen Flickering Issues #1042
Fixes #1009
FixesScreen flicker on Chromebook #988

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

I want maintainers to keep my branch updated

ReenigneArcher · 2023-03-16T15:41:30Z

This is working now. I was missing the part where it reads the config option from the saved config file so it was always using the default value.

I also renamed the setting to min_fps_target as setting this to a high value wouldn't guarantee a high FPS, which would have probably been misleading.

For me, if I set the value to 1 FPS, my stream is about 7-8 FPS (according to Moonlight) with static content. If I set to 240 FPS, I get about 65-68 FPS. I only tested on my laptop with integrated AMD graphics, with all other options as default.

ReenigneArcher · 2023-05-05T01:14:56Z

@cgutman do you think this PR should be resumed? I know there's been a lot of activity to try to improve streaming performance, and I don't know if this is still relevant.

Jocelyn-JE · 2024-03-21T14:21:51Z

This change seems to improve slightly the number of microstutters when switching from a static image to an active one and back. Needs further testing / changes.

codecov · 2024-06-18T21:54:23Z

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 8.96%. Comparing base (d6dd1ab) to head (f651fc9).
Report is 144 commits behind head on master.

Files with missing lines	Patch %	Lines
src/video.cpp	0.00%	0 Missing and 3 partials ⚠️
src/config.cpp	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #1043 +/- ##
=========================================
- Coverage 8.97% 8.96% -0.01% 
=========================================
Files 94 94 Lines 17389 17392 +3 Branches 8267 8270 +3 =========================================
Hits 1560 1560 Misses 12967 12967 - Partials 2862 2865 +3

Flag	Coverage Δ
Linux	`6.79% <0.00%> (-0.01%)`	⬇️
Windows	`4.16% <0.00%> (-0.01%)`	⬇️
macOS-12	`10.04% <0.00%> (-0.01%)`	⬇️
macOS-13	`9.95% <0.00%> (+<0.01%)`	⬆️
macOS-14	`10.24% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/config.h	`0.00% <ø> (ø)`
src/config.cpp	`4.77% <0.00%> (-0.01%)`	⬇️
src/video.cpp	`25.23% <0.00%> (-0.05%)`	⬇️

ReenigneArcher · 2023-03-15T22:31:43Z

Description

Add minimum fps target setting to help in situations where 10 fps is too low.

Screenshot

Issues Fixed or Closed

FixesChromebook Screen Flickering Issues #1042
Fixes #1009
FixesScreen flicker on Chromebook #988

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

I want maintainers to keep my branch updated

ReenigneArcher · 2023-03-16T15:41:30Z

This is working now. I was missing the part where it reads the config option from the saved config file so it was always using the default value.

I also renamed the setting to min_fps_target as setting this to a high value wouldn't guarantee a high FPS, which would have probably been misleading.

For me, if I set the value to 1 FPS, my stream is about 7-8 FPS (according to Moonlight) with static content. If I set to 240 FPS, I get about 65-68 FPS. I only tested on my laptop with integrated AMD graphics, with all other options as default.

ReenigneArcher · 2023-05-05T01:14:56Z

@cgutman do you think this PR should be resumed? I know there's been a lot of activity to try to improve streaming performance, and I don't know if this is still relevant.

Jocelyn-JE · 2024-03-21T14:21:51Z

This change seems to improve slightly the number of microstutters when switching from a static image to an active one and back. Needs further testing / changes.

codecov · 2024-06-18T21:54:23Z

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 8.96%. Comparing base (d6dd1ab) to head (f651fc9).
Report is 144 commits behind head on master.

Files with missing lines	Patch %	Lines
src/video.cpp	0.00%	0 Missing and 3 partials ⚠️
src/config.cpp	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #1043 +/- ##
=========================================
- Coverage 8.97% 8.96% -0.01% 
=========================================
Files 94 94 Lines 17389 17392 +3 Branches 8267 8270 +3 =========================================
Hits 1560 1560 Misses 12967 12967 - Partials 2862 2865 +3

Flag	Coverage Δ
Linux	`6.79% <0.00%> (-0.01%)`	⬇️
Windows	`4.16% <0.00%> (-0.01%)`	⬇️
macOS-12	`10.04% <0.00%> (-0.01%)`	⬇️
macOS-13	`9.95% <0.00%> (+<0.01%)`	⬆️
macOS-14	`10.24% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/config.h	`0.00% <ø> (ø)`
src/config.cpp	`4.77% <0.00%> (-0.01%)`	⬇️
src/video.cpp	`25.23% <0.00%> (-0.05%)`	⬇️

ReenigneArcher · 2023-03-15T22:31:43Z

Description

Add minimum fps target setting to help in situations where 10 fps is too low.

Screenshot

Issues Fixed or Closed

FixesChromebook Screen Flickering Issues #1042
Fixes #1009
FixesScreen flicker on Chromebook #988

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

I want maintainers to keep my branch updated

ReenigneArcher · 2023-03-16T15:41:30Z

This is working now. I was missing the part where it reads the config option from the saved config file so it was always using the default value.

I also renamed the setting to min_fps_target as setting this to a high value wouldn't guarantee a high FPS, which would have probably been misleading.

For me, if I set the value to 1 FPS, my stream is about 7-8 FPS (according to Moonlight) with static content. If I set to 240 FPS, I get about 65-68 FPS. I only tested on my laptop with integrated AMD graphics, with all other options as default.

ReenigneArcher · 2023-05-05T01:14:56Z

@cgutman do you think this PR should be resumed? I know there's been a lot of activity to try to improve streaming performance, and I don't know if this is still relevant.

Jocelyn-JE · 2024-03-21T14:21:51Z

This change seems to improve slightly the number of microstutters when switching from a static image to an active one and back. Needs further testing / changes.

codecov · 2024-06-18T21:54:23Z

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 8.96%. Comparing base (d6dd1ab) to head (f651fc9).
Report is 144 commits behind head on master.

Files with missing lines	Patch %	Lines
src/video.cpp	0.00%	0 Missing and 3 partials ⚠️
src/config.cpp	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #1043 +/- ##
=========================================
- Coverage 8.97% 8.96% -0.01% 
=========================================
Files 94 94 Lines 17389 17392 +3 Branches 8267 8270 +3 =========================================
Hits 1560 1560 Misses 12967 12967 - Partials 2862 2865 +3

Flag	Coverage Δ
Linux	`6.79% <0.00%> (-0.01%)`	⬇️
Windows	`4.16% <0.00%> (-0.01%)`	⬇️
macOS-12	`10.04% <0.00%> (-0.01%)`	⬇️
macOS-13	`9.95% <0.00%> (+<0.01%)`	⬆️
macOS-14	`10.24% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/config.h	`0.00% <ø> (ø)`
src/config.cpp	`4.77% <0.00%> (-0.01%)`	⬇️
src/video.cpp	`25.23% <0.00%> (-0.05%)`	⬇️

ReenigneArcher · 2023-03-15T22:31:43Z

Description

Add minimum fps target setting to help in situations where 10 fps is too low.

Screenshot

Issues Fixed or Closed

FixesChromebook Screen Flickering Issues #1042
Fixes #1009
FixesScreen flicker on Chromebook #988

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

I want maintainers to keep my branch updated

ReenigneArcher · 2023-03-16T15:41:30Z

This is working now. I was missing the part where it reads the config option from the saved config file so it was always using the default value.

I also renamed the setting to min_fps_target as setting this to a high value wouldn't guarantee a high FPS, which would have probably been misleading.

For me, if I set the value to 1 FPS, my stream is about 7-8 FPS (according to Moonlight) with static content. If I set to 240 FPS, I get about 65-68 FPS. I only tested on my laptop with integrated AMD graphics, with all other options as default.

ReenigneArcher · 2023-05-05T01:14:56Z

@cgutman do you think this PR should be resumed? I know there's been a lot of activity to try to improve streaming performance, and I don't know if this is still relevant.

Jocelyn-JE · 2024-03-21T14:21:51Z

This change seems to improve slightly the number of microstutters when switching from a static image to an active one and back. Needs further testing / changes.

codecov · 2024-06-18T21:54:23Z

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 8.96%. Comparing base (d6dd1ab) to head (f651fc9).
Report is 144 commits behind head on master.

Files with missing lines	Patch %	Lines
src/video.cpp	0.00%	0 Missing and 3 partials ⚠️
src/config.cpp	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #1043 +/- ##
=========================================
- Coverage 8.97% 8.96% -0.01% 
=========================================
Files 94 94 Lines 17389 17392 +3 Branches 8267 8270 +3 =========================================
Hits 1560 1560 Misses 12967 12967 - Partials 2862 2865 +3

Flag	Coverage Δ
Linux	`6.79% <0.00%> (-0.01%)`	⬇️
Windows	`4.16% <0.00%> (-0.01%)`	⬇️
macOS-12	`10.04% <0.00%> (-0.01%)`	⬇️
macOS-13	`9.95% <0.00%> (+<0.01%)`	⬆️
macOS-14	`10.24% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/config.h	`0.00% <ø> (ø)`
src/config.cpp	`4.77% <0.00%> (-0.01%)`	⬇️
src/video.cpp	`25.23% <0.00%> (-0.05%)`	⬇️

ReenigneArcher · 2023-03-15T22:31:43Z

Description

Add minimum fps target setting to help in situations where 10 fps is too low.

Screenshot

Issues Fixed or Closed

FixesChromebook Screen Flickering Issues #1042
Fixes #1009
FixesScreen flicker on Chromebook #988

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

I want maintainers to keep my branch updated

ReenigneArcher · 2023-03-16T15:41:30Z

This is working now. I was missing the part where it reads the config option from the saved config file so it was always using the default value.

I also renamed the setting to min_fps_target as setting this to a high value wouldn't guarantee a high FPS, which would have probably been misleading.

For me, if I set the value to 1 FPS, my stream is about 7-8 FPS (according to Moonlight) with static content. If I set to 240 FPS, I get about 65-68 FPS. I only tested on my laptop with integrated AMD graphics, with all other options as default.

ReenigneArcher · 2023-05-05T01:14:56Z

@cgutman do you think this PR should be resumed? I know there's been a lot of activity to try to improve streaming performance, and I don't know if this is still relevant.

Jocelyn-JE · 2024-03-21T14:21:51Z

This change seems to improve slightly the number of microstutters when switching from a static image to an active one and back. Needs further testing / changes.

codecov · 2024-06-18T21:54:23Z

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 8.96%. Comparing base (d6dd1ab) to head (f651fc9).
Report is 144 commits behind head on master.

Files with missing lines	Patch %	Lines
src/video.cpp	0.00%	0 Missing and 3 partials ⚠️
src/config.cpp	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #1043 +/- ##
=========================================
- Coverage 8.97% 8.96% -0.01% 
=========================================
Files 94 94 Lines 17389 17392 +3 Branches 8267 8270 +3 =========================================
Hits 1560 1560 Misses 12967 12967 - Partials 2862 2865 +3

Flag	Coverage Δ
Linux	`6.79% <0.00%> (-0.01%)`	⬇️
Windows	`4.16% <0.00%> (-0.01%)`	⬇️
macOS-12	`10.04% <0.00%> (-0.01%)`	⬇️
macOS-13	`9.95% <0.00%> (+<0.01%)`	⬆️
macOS-14	`10.24% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/config.h	`0.00% <ø> (ø)`
src/config.cpp	`4.77% <0.00%> (-0.01%)`	⬇️
src/video.cpp	`25.23% <0.00%> (-0.05%)`	⬇️

ReenigneArcher force-pushed the config-add-fps-floor-setting branch 2 times, most recently from efc275f to ad20ac1Compare March 15, 2023 22:38

This comment was marked as resolved.
Sign in to view

ReenigneArcher force-pushed the config-add-fps-floor-setting branch 2 times, most recently from 0867994 to 900655eCompare March 16, 2023 00:39

psyke83 reviewed Mar 16, 2023
View reviewed changes

Comment threadsrc_assets/common/assets/web/config.html Outdated

ReenigneArcher force-pushed the config-add-fps-floor-setting branch from 900655e to 6721fe4Compare March 16, 2023 01:44

This comment was marked as resolved.
Sign in to view

ReenigneArcher marked this pull request as draft March 16, 2023 02:24

This comment was marked as outdated.
Sign in to view

This comment was marked as resolved.
Sign in to view

ReenigneArcher force-pushed the config-add-fps-floor-setting branch from 6721fe4 to 0870c09Compare March 16, 2023 15:27

ReenigneArcher changed the title ~~config: add min_fps setting~~config: add min_fps_target settingMar 16, 2023

ReenigneArcher force-pushed the config-add-fps-floor-setting branch from 0870c09 to af76a8aCompare March 16, 2023 15:31

ReenigneArcher marked this pull request as ready for review March 16, 2023 15:37

psyke83 reviewed Mar 23, 2023
View reviewed changes

Comment threadsrc/video.cpp Outdated

ReenigneArcher commented Mar 23, 2023
View reviewed changes

Comment threadsrc/video.cpp Outdated

ReenigneArcher marked this pull request as draft March 28, 2023 01:06

This comment was marked as resolved.
Sign in to view

ReenigneArcher force-pushed the config-add-fps-floor-setting branch 5 times, most recently from 854a8a2 to acb1750Compare March 28, 2023 14:53

ReenigneArcher force-pushed the config-add-fps-floor-setting branch from acb1750 to 84ae8a9Compare April 5, 2023 14:44

This comment was marked as off-topic.
Sign in to view

ReenigneArcher closed this May 7, 2023

ReenigneArcher deleted the config-add-fps-floor-setting branch May 7, 2023 19:44

ReenigneArcher restored the config-add-fps-floor-setting branch March 21, 2024 13:21

ReenigneArcher reopened this Mar 21, 2024

ReenigneArcher mentioned this pull request Apr 19, 2024
Stuttering and video decoding time shot up when waking up from standby. #2387
Closed
3 tasks

ReenigneArcher force-pushed the config-add-fps-floor-setting branch from 84ae8a9 to 369dcffCompare June 18, 2024 21:43

ReenigneArcher force-pushed the config-add-fps-floor-setting branch 2 times, most recently from d3a4f39 to 18b0b3cCompare June 18, 2024 23:09

feat: add min_fps_factor setting
f651fc9

ReenigneArcher force-pushed the config-add-fps-floor-setting branch from 18b0b3c to f651fc9Compare June 18, 2024 23:15

ReenigneArcher marked this pull request as ready for review June 18, 2024 23:19

ReenigneArcher changed the title ~~config: add min_fps_target setting~~feat: add min_fps_target settingJun 18, 2024

ReenigneArcher enabled auto-merge (squash) June 19, 2024 00:00

ReenigneArcher merged commit 722e560 into masterJun 19, 2024

ReenigneArcher deleted the config-add-fps-floor-setting branch June 19, 2024 00:09

KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Oct 9, 2024
feat: add min_fps_target setting (LizardByte#1043)
dd25e06

ReenigneArcher mentioned this pull request Jan 11, 2025
Frame rate drops when idle #3419
Closed
2 tasks

hello-world-321 mentioned this pull request Jan 20, 2025
Option to set minimum fps, fps too low on desktop ClassicOldSong/Apollo#249
Closed

ReenigneArcher mentioned this pull request Jan 22, 2025
chore: Update dev.lizardbyte.app.Sunshine to v2025.122.141614 flathub/dev.lizardbyte.app.Sunshine#185
Merged

c2vi pushed a commit to c2vi/Sunshine that referenced this pull request Mar 27, 2025
feat: add min_fps_target setting (LizardByte#1043)
c3484ff