Improved Pulse/Pipewire Compatibility for Linux. - #130

Merged
ReenigneArcher merged 4 commits into
LizardByte:nightlyfrom
Logical-sh:pipewire-compatibility
Apr 29, 2022
Merged

Improved Pulse/Pipewire Compatibility for Linux.#130
ReenigneArcher merged 4 commits into
LizardByte:nightlyfrom
Logical-sh:pipewire-compatibility

Conversation

@Logical-sh

@Logical-shLogical-sh commented Apr 11, 2022•
edited by ReenigneArcher
Loading

Copy link
Copy Markdown
Contributor

Description

A number of small improvements were made to the Linux platform audio code to improve user experience and improve Pipewire compatibility.

  • Fixed a bug in the base Audio code that caused it to select the virtual sink even if you had a different on selected in the config.
  • Added functionality to get monitor names and default sink names.
  • The recording code now properly uses the monitor of the provided/selected sink.
  • Records the default sink as the sink to restore after streaming instead of the last sink encountered in the list.
  • Reliably switches the recorded sink to be the default
  • Updated example config to be clear to provide the SINK name to monitor.

I have tested the following scenarios to work correctly under Pipewire. Additional testing under pulse would be ideal. The code should have no effect on non-Linux platforms.

No configured sink, play audio on host.

  • Stays on on default audio sink
  • Host audio works
  • Device Audio works

No configured sink, do not play on host audio.

  • Switched to virtual sink.
  • No host audio,
  • Device plays audio
  • Audio sink reset to previous sink on disconnect.

Configured sink

  • Switches to provided sink.
  • Audible on device
  • Audible on sink

I will try to setup a pulse VM or switch my packages around to test pure pulse later this week if no one beats me to it!

Issues Fixed or Closed

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the documentation blocks for new or existing components

@Logical-sh

Logical-sh commented Apr 11, 2022

Copy link
Copy Markdown
ContributorAuthor

I also removed the block in the README about it picking up the mic, as that was happening due to behavior of "@DEFAULT_MONITOR@" which should no longer be an issue. The new code will always try to get a proper monitor device of a sink instead of possibly picking up a random source.

@HomerSp

HomerSp commented Apr 12, 2022

Copy link
Copy Markdown
Contributor

This basically mirrors what I have locally (I haven't created a PR yet since I was still trying to solve a few issues) - and it seems to work fine on both pipewire and pulseaudio.

@Logical-sh

Logical-sh commented Apr 12, 2022

Copy link
Copy Markdown
ContributorAuthor

This basically mirrors what I have locally (I haven't created a PR yet since I was still trying to solve a few issues) - and it seems to work fine on both pipewire and pulseaudio.

Thanks for the test @HomerSp!

@KuleRucket

KuleRucket commented Apr 29, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Is this PR likely to fix #46? I'll try it.

EDIT: And the answer is: yes it does. I can now use pipewire-pulse in Arch

@Logical-sh

Logical-sh commented Apr 29, 2022 via email

Copy link
Copy Markdown
ContributorAuthor

@ReenigneArcher

ReenigneArcher commented Apr 29, 2022

Copy link
Copy Markdown
Member

@Logical-sh If you fix the 2 conflicts, I will merge this. We want those files how they exist on the nightly branch.

Documentation is now done mostly in the docs folder using sphinx and rst (reStructuredText). You can see the result here: https://sunshinestream.readthedocs.io/en/nightly/

@Logical-sh

Logical-sh commented Apr 29, 2022

Copy link
Copy Markdown
ContributorAuthor

Sure thing! I'll get to that today.

@Logical-sh
Logical-shforce-pushed the pipewire-compatibility branch from 05fc9e3 to 63a83cdCompareApril 29, 2022 16:27
@Logical-sh

Logical-sh commented Apr 29, 2022

Copy link
Copy Markdown
ContributorAuthor

Re-based dropping the conflicting commits!

@ReenigneArcher
ReenigneArcher merged commit b0df4ea into LizardByte:nightlyApr 29, 2022
@kyriacos

kyriacos commented May 10, 2022

Copy link
Copy Markdown

Just tried the nightly branch and no audio still

[2022:05:10:08:36:49]: Error: Couldn't connect to pulseaudio: Access denied
[2022:05:10:08:36:49]: Warning: There will be no audio

Is there anything else i can try? I'm on Arch with an Nvidia 1070 gpu.

Linux apollo-desktop 5.17.5-arch1-1 #1 SMP PREEMPT Wed, 27 Apr 2022 20:56:11 +0000 x86_64 GNU/Linux

Thanks!

@Logical-sh

Logical-sh commented May 10, 2022

Copy link
Copy Markdown
ContributorAuthor

Just tried the nightly branch and no audio still

[2022:05:10:08:36:49]: Error: Couldn't connect to pulseaudio: Access denied
[2022:05:10:08:36:49]: Warning: There will be no audio

Is there anything else i can try? I'm on Arch with an Nvidia 1070 gpu.

Linux apollo-desktop 5.17.5-arch1-1 #1 SMP PREEMPT Wed, 27 Apr 2022 20:56:11 +0000 x86_64 GNU/Linux

Thanks!

This looks like a totally different issue.
This change doesn't touch the connection logic.
Maybe open a separate issue with details of your setup and we could take a look!
@kyriacos

@kyriacos

kyriacos commented May 10, 2022

Copy link
Copy Markdown

Thank will do. Now that i know it doesn't fix this - at least i know it's something else. I'll debug a bit more then and post an issue with more details hopefully.

@Logical-sh

Logical-sh commented May 10, 2022

Copy link
Copy Markdown
ContributorAuthor

My immediate guesses would be running the service as a different user or sudoing it, or running it in something like flatpack with the permissions wrong.

@TheElixZammutoTheElixZammuto mentioned this pull request Jul 2, 2022
Closed
5 tasks
Nonary referenced this pull request in Nonary/vibeshine Oct 3, 2025
@ClassicOldSong
Fix password is always saved issue#130
7d3b695
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheElixZammutoTheElixZammutoAwaiting requested review from TheElixZammuto

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Logical-sh@HomerSp@KuleRucket@ReenigneArcher@kyriacos
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Improved Pulse/Pipewire Compatibility for Linux. - #130
Merged
ReenigneArcher merged 4 commits into
LizardByte:nightlyfrom 
Logical-sh:pipewire-compatibility
Apr 29, 2022
Merged
Improved Pulse/Pipewire Compatibility for Linux.#130
ReenigneArcher merged 4 commits into
LizardByte:nightlyfrom 
Logical-sh:pipewire-compatibility
Conversation
@Logical-sh
@Logical-shLogical-sh
commented
Apr 11, 2022•

edited by ReenigneArcher

Loading

Copy link


Copy Markdown

Contributor
Description
A number of small improvements were made to the Linux platform audio code to improve user experience and improve Pipewire compatibility.
  • Fixed a bug in the base Audio code that caused it to select the virtual sink even if you had a different on selected in the config.
  • Added functionality to get monitor names and default sink names.
  • The recording code now properly uses the monitor of the provided/selected sink.
  • Records the default sink as the sink to restore after streaming instead of the last sink encountered in the list.
  • Reliably switches the recorded sink to be the default
  • Updated example config to be clear to provide the SINK name to monitor.
I have tested the following scenarios to work correctly under Pipewire. Additional testing under pulse would be ideal. The code should have no effect on non-Linux platforms.
No configured sink, play audio on host.
  • Stays on on default audio sink
  • Host audio works
  • Device Audio works
No configured sink, do not play on host audio.
  • Switched to virtual sink.
  • No host audio,
  • Device plays audio
  • Audio sink reset to previous sink on disconnect.
Configured sink
  • Switches to provided sink.
  • Audible on device
  • Audible on sink
I will try to setup a pulse VM or switch my packages around to test pure pulse later this week if no one beats me to it!
Issues Fixed or Closed
Type of Change
Please delete options that are not relevant.
  •  Bug fix (non-breaking change which fixes an issue)
Checklist
  •  My code follows the style guidelines of this project
  •  I have performed a self-review of my own code
  •  I have commented my code, particularly in hard-to-understand areas
  •  I have added or updated the documentation blocks for new or existing components
@Logical-sh
Logical-sh
commented
Apr 11, 2022

Copy link


Copy Markdown

ContributorAuthor
I also removed the block in the README about it picking up the mic, as that was happening due to behavior of "@DEFAULT_MONITOR@" which should no longer be an issue. The new code will always try to get a proper monitor device of a sink instead of possibly picking up a random source.
@HomerSp
HomerSp
commented
Apr 12, 2022

Copy link


Copy Markdown

Contributor
This basically mirrors what I have locally (I haven't created a PR yet since I was still trying to solve a few issues) - and it seems to work fine on both pipewire and pulseaudio.
@Logical-sh
Logical-sh
commented
Apr 12, 2022

Copy link


Copy Markdown

ContributorAuthor
This basically mirrors what I have locally (I haven't created a PR yet since I was still trying to solve a few issues) - and it seems to work fine on both pipewire and pulseaudio.
Thanks for the test @HomerSp!
@KuleRucket
KuleRucket
commented
Apr 29, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Is this PR likely to fix #46? I'll try it.
EDIT: And the answer is: yes it does. I can now use pipewire-pulse in Arch
@Logical-sh
Logical-sh
commented
Apr 29, 2022
via email 

Copy link


Copy Markdown

ContributorAuthor
@ReenigneArcher
ReenigneArcher
commented
Apr 29, 2022

Copy link


Copy Markdown

Member
@Logical-sh If you fix the 2 conflicts, I will merge this. We want those files how they exist on the nightly branch.
Documentation is now done mostly in the docs folder using sphinx and rst (reStructuredText). You can see the result here: https://sunshinestream.readthedocs.io/en/nightly/
@Logical-sh
Logical-sh
commented
Apr 29, 2022

Copy link


Copy Markdown

ContributorAuthor
Sure thing! I'll get to that today.
@Logical-sh
Logical-shforce-pushed
the
pipewire-compatibility
branch
from
05fc9e3 to
63a83cdCompareApril 29, 2022 16:27
@Logical-sh
Logical-sh
commented
Apr 29, 2022

Copy link


Copy Markdown

ContributorAuthor
Re-based dropping the conflicting commits!
@ReenigneArcher
ReenigneArcher
merged commit b0df4ea
into
LizardByte:nightlyApr 29, 2022
@kyriacos
kyriacos
commented
May 10, 2022

Copy link


Copy Markdown

Just tried the nightly branch and no audio still
[2022:05:10:08:36:49]: Error: Couldn't connect to pulseaudio: Access denied
[2022:05:10:08:36:49]: Warning: There will be no audio

Is there anything else i can try? I'm on Arch with an Nvidia 1070 gpu.
Linux apollo-desktop 5.17.5-arch1-1 #1 SMP PREEMPT Wed, 27 Apr 2022 20:56:11 +0000 x86_64 GNU/Linux
Thanks!
@Logical-sh
Logical-sh
commented
May 10, 2022

Copy link


Copy Markdown

ContributorAuthor
Just tried the nightly branch and no audio still
[2022:05:10:08:36:49]: Error: Couldn't connect to pulseaudio: Access denied
[2022:05:10:08:36:49]: Warning: There will be no audio

Is there anything else i can try? I'm on Arch with an Nvidia 1070 gpu.
Linux apollo-desktop 5.17.5-arch1-1 #1 SMP PREEMPT Wed, 27 Apr 2022 20:56:11 +0000 x86_64 GNU/Linux
Thanks!
This looks like a totally different issue.

This change doesn't touch the connection logic.

Maybe open a separate issue with details of your setup and we could take a look!
@kyriacos
@kyriacos
kyriacos
commented
May 10, 2022

Copy link


Copy Markdown

Thank will do. Now that i know it doesn't fix this - at least i know it's something else. I'll debug a bit more then and post an issue with more details hopefully.
@Logical-sh
Logical-sh
commented
May 10, 2022

Copy link


Copy Markdown

ContributorAuthor
My immediate guesses would be running the service as a different user or sudoing it, or running it in something like flatpack with the permissions wrong.
@TheElixZammutoTheElixZammuto
mentioned this pull request
Jul 2, 2022
 Closed

5 tasks
Nonary referenced
this pull request
in Nonary/vibeshine
Oct 3, 2025
@ClassicOldSong
Fix password is always saved issue#130
7d3b695
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheElixZammutoTheElixZammutoAwaiting requested review from TheElixZammuto

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@Logical-sh@HomerSp@KuleRucket@ReenigneArcher@kyriacos

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Improved Pulse/Pipewire Compatibility for Linux. - #130
Merged
ReenigneArcher merged 4 commits into
LizardByte:nightlyfrom 
Logical-sh:pipewire-compatibility
Apr 29, 2022
Merged
Improved Pulse/Pipewire Compatibility for Linux.#130
ReenigneArcher merged 4 commits into
LizardByte:nightlyfrom 
Logical-sh:pipewire-compatibility
Conversation
@Logical-sh
@Logical-shLogical-sh
commented
Apr 11, 2022•

edited by ReenigneArcher

Loading

Copy link


Copy Markdown

Contributor
Description
A number of small improvements were made to the Linux platform audio code to improve user experience and improve Pipewire compatibility.
  • Fixed a bug in the base Audio code that caused it to select the virtual sink even if you had a different on selected in the config.
  • Added functionality to get monitor names and default sink names.
  • The recording code now properly uses the monitor of the provided/selected sink.
  • Records the default sink as the sink to restore after streaming instead of the last sink encountered in the list.
  • Reliably switches the recorded sink to be the default
  • Updated example config to be clear to provide the SINK name to monitor.
I have tested the following scenarios to work correctly under Pipewire. Additional testing under pulse would be ideal. The code should have no effect on non-Linux platforms.
No configured sink, play audio on host.
  • Stays on on default audio sink
  • Host audio works
  • Device Audio works
No configured sink, do not play on host audio.
  • Switched to virtual sink.
  • No host audio,
  • Device plays audio
  • Audio sink reset to previous sink on disconnect.
Configured sink
  • Switches to provided sink.
  • Audible on device
  • Audible on sink
I will try to setup a pulse VM or switch my packages around to test pure pulse later this week if no one beats me to it!
Issues Fixed or Closed
Type of Change
Please delete options that are not relevant.
  •  Bug fix (non-breaking change which fixes an issue)
Checklist
  •  My code follows the style guidelines of this project
  •  I have performed a self-review of my own code
  •  I have commented my code, particularly in hard-to-understand areas
  •  I have added or updated the documentation blocks for new or existing components
@Logical-sh
Logical-sh
commented
Apr 11, 2022

Copy link


Copy Markdown

ContributorAuthor
I also removed the block in the README about it picking up the mic, as that was happening due to behavior of "@DEFAULT_MONITOR@" which should no longer be an issue. The new code will always try to get a proper monitor device of a sink instead of possibly picking up a random source.
@HomerSp
HomerSp
commented
Apr 12, 2022

Copy link


Copy Markdown

Contributor
This basically mirrors what I have locally (I haven't created a PR yet since I was still trying to solve a few issues) - and it seems to work fine on both pipewire and pulseaudio.
@Logical-sh
Logical-sh
commented
Apr 12, 2022

Copy link


Copy Markdown

ContributorAuthor
This basically mirrors what I have locally (I haven't created a PR yet since I was still trying to solve a few issues) - and it seems to work fine on both pipewire and pulseaudio.
Thanks for the test @HomerSp!
@KuleRucket
KuleRucket
commented
Apr 29, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Is this PR likely to fix #46? I'll try it.
EDIT: And the answer is: yes it does. I can now use pipewire-pulse in Arch
@Logical-sh
Logical-sh
commented
Apr 29, 2022
via email 

Copy link


Copy Markdown

ContributorAuthor
@ReenigneArcher
ReenigneArcher
commented
Apr 29, 2022

Copy link


Copy Markdown

Member
@Logical-sh If you fix the 2 conflicts, I will merge this. We want those files how they exist on the nightly branch.
Documentation is now done mostly in the docs folder using sphinx and rst (reStructuredText). You can see the result here: https://sunshinestream.readthedocs.io/en/nightly/
@Logical-sh
Logical-sh
commented
Apr 29, 2022

Copy link


Copy Markdown

ContributorAuthor
Sure thing! I'll get to that today.
@Logical-sh
Logical-shforce-pushed
the
pipewire-compatibility
branch
from
05fc9e3 to
63a83cdCompareApril 29, 2022 16:27
@Logical-sh
Logical-sh
commented
Apr 29, 2022

Copy link


Copy Markdown

ContributorAuthor
Re-based dropping the conflicting commits!
@ReenigneArcher
ReenigneArcher
merged commit b0df4ea
into
LizardByte:nightlyApr 29, 2022
@kyriacos
kyriacos
commented
May 10, 2022

Copy link


Copy Markdown

Just tried the nightly branch and no audio still
[2022:05:10:08:36:49]: Error: Couldn't connect to pulseaudio: Access denied
[2022:05:10:08:36:49]: Warning: There will be no audio

Is there anything else i can try? I'm on Arch with an Nvidia 1070 gpu.
Linux apollo-desktop 5.17.5-arch1-1 #1 SMP PREEMPT Wed, 27 Apr 2022 20:56:11 +0000 x86_64 GNU/Linux
Thanks!
@Logical-sh
Logical-sh
commented
May 10, 2022

Copy link


Copy Markdown

ContributorAuthor
Just tried the nightly branch and no audio still
[2022:05:10:08:36:49]: Error: Couldn't connect to pulseaudio: Access denied
[2022:05:10:08:36:49]: Warning: There will be no audio

Is there anything else i can try? I'm on Arch with an Nvidia 1070 gpu.
Linux apollo-desktop 5.17.5-arch1-1 #1 SMP PREEMPT Wed, 27 Apr 2022 20:56:11 +0000 x86_64 GNU/Linux
Thanks!
This looks like a totally different issue.

This change doesn't touch the connection logic.

Maybe open a separate issue with details of your setup and we could take a look!
@kyriacos
@kyriacos
kyriacos
commented
May 10, 2022

Copy link


Copy Markdown

Thank will do. Now that i know it doesn't fix this - at least i know it's something else. I'll debug a bit more then and post an issue with more details hopefully.
@Logical-sh
Logical-sh
commented
May 10, 2022

Copy link


Copy Markdown

ContributorAuthor
My immediate guesses would be running the service as a different user or sudoing it, or running it in something like flatpack with the permissions wrong.
@TheElixZammutoTheElixZammuto
mentioned this pull request
Jul 2, 2022
 Closed

5 tasks
Nonary referenced
this pull request
in Nonary/vibeshine
Oct 3, 2025
@ClassicOldSong
Fix password is always saved issue#130
7d3b695
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheElixZammutoTheElixZammutoAwaiting requested review from TheElixZammuto

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@Logical-sh@HomerSp@KuleRucket@ReenigneArcher@kyriacos

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Improved Pulse/Pipewire Compatibility for Linux. - #130
Merged
ReenigneArcher merged 4 commits into
LizardByte:nightlyfrom 
Logical-sh:pipewire-compatibility
Apr 29, 2022
Merged
Improved Pulse/Pipewire Compatibility for Linux.#130
ReenigneArcher merged 4 commits into
LizardByte:nightlyfrom 
Logical-sh:pipewire-compatibility
Conversation
@Logical-sh
@Logical-shLogical-sh
commented
Apr 11, 2022•

edited by ReenigneArcher

Loading

Copy link


Copy Markdown

Contributor
Description
A number of small improvements were made to the Linux platform audio code to improve user experience and improve Pipewire compatibility.
  • Fixed a bug in the base Audio code that caused it to select the virtual sink even if you had a different on selected in the config.
  • Added functionality to get monitor names and default sink names.
  • The recording code now properly uses the monitor of the provided/selected sink.
  • Records the default sink as the sink to restore after streaming instead of the last sink encountered in the list.
  • Reliably switches the recorded sink to be the default
  • Updated example config to be clear to provide the SINK name to monitor.
I have tested the following scenarios to work correctly under Pipewire. Additional testing under pulse would be ideal. The code should have no effect on non-Linux platforms.
No configured sink, play audio on host.
  • Stays on on default audio sink
  • Host audio works
  • Device Audio works
No configured sink, do not play on host audio.
  • Switched to virtual sink.
  • No host audio,
  • Device plays audio
  • Audio sink reset to previous sink on disconnect.
Configured sink
  • Switches to provided sink.
  • Audible on device
  • Audible on sink
I will try to setup a pulse VM or switch my packages around to test pure pulse later this week if no one beats me to it!
Issues Fixed or Closed
Type of Change
Please delete options that are not relevant.
  •  Bug fix (non-breaking change which fixes an issue)
Checklist
  •  My code follows the style guidelines of this project
  •  I have performed a self-review of my own code
  •  I have commented my code, particularly in hard-to-understand areas
  •  I have added or updated the documentation blocks for new or existing components
@Logical-sh
Logical-sh
commented
Apr 11, 2022

Copy link


Copy Markdown

ContributorAuthor
I also removed the block in the README about it picking up the mic, as that was happening due to behavior of "@DEFAULT_MONITOR@" which should no longer be an issue. The new code will always try to get a proper monitor device of a sink instead of possibly picking up a random source.
@HomerSp
HomerSp
commented
Apr 12, 2022

Copy link


Copy Markdown

Contributor
This basically mirrors what I have locally (I haven't created a PR yet since I was still trying to solve a few issues) - and it seems to work fine on both pipewire and pulseaudio.
@Logical-sh
Logical-sh
commented
Apr 12, 2022

Copy link


Copy Markdown

ContributorAuthor
This basically mirrors what I have locally (I haven't created a PR yet since I was still trying to solve a few issues) - and it seems to work fine on both pipewire and pulseaudio.
Thanks for the test @HomerSp!
@KuleRucket
KuleRucket
commented
Apr 29, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Is this PR likely to fix #46? I'll try it.
EDIT: And the answer is: yes it does. I can now use pipewire-pulse in Arch
@Logical-sh
Logical-sh
commented
Apr 29, 2022
via email 

Copy link


Copy Markdown

ContributorAuthor
@ReenigneArcher
ReenigneArcher
commented
Apr 29, 2022

Copy link


Copy Markdown

Member
@Logical-sh If you fix the 2 conflicts, I will merge this. We want those files how they exist on the nightly branch.
Documentation is now done mostly in the docs folder using sphinx and rst (reStructuredText). You can see the result here: https://sunshinestream.readthedocs.io/en/nightly/
@Logical-sh
Logical-sh
commented
Apr 29, 2022

Copy link


Copy Markdown

ContributorAuthor
Sure thing! I'll get to that today.
@Logical-sh
Logical-shforce-pushed
the
pipewire-compatibility
branch
from
05fc9e3 to
63a83cdCompareApril 29, 2022 16:27
@Logical-sh
Logical-sh
commented
Apr 29, 2022

Copy link


Copy Markdown

ContributorAuthor
Re-based dropping the conflicting commits!
@ReenigneArcher
ReenigneArcher
merged commit b0df4ea
into
LizardByte:nightlyApr 29, 2022
@kyriacos
kyriacos
commented
May 10, 2022

Copy link


Copy Markdown

Just tried the nightly branch and no audio still
[2022:05:10:08:36:49]: Error: Couldn't connect to pulseaudio: Access denied
[2022:05:10:08:36:49]: Warning: There will be no audio

Is there anything else i can try? I'm on Arch with an Nvidia 1070 gpu.
Linux apollo-desktop 5.17.5-arch1-1 #1 SMP PREEMPT Wed, 27 Apr 2022 20:56:11 +0000 x86_64 GNU/Linux
Thanks!
@Logical-sh
Logical-sh
commented
May 10, 2022

Copy link


Copy Markdown

ContributorAuthor
Just tried the nightly branch and no audio still
[2022:05:10:08:36:49]: Error: Couldn't connect to pulseaudio: Access denied
[2022:05:10:08:36:49]: Warning: There will be no audio

Is there anything else i can try? I'm on Arch with an Nvidia 1070 gpu.
Linux apollo-desktop 5.17.5-arch1-1 #1 SMP PREEMPT Wed, 27 Apr 2022 20:56:11 +0000 x86_64 GNU/Linux
Thanks!
This looks like a totally different issue.

This change doesn't touch the connection logic.

Maybe open a separate issue with details of your setup and we could take a look!
@kyriacos
@kyriacos
kyriacos
commented
May 10, 2022

Copy link


Copy Markdown

Thank will do. Now that i know it doesn't fix this - at least i know it's something else. I'll debug a bit more then and post an issue with more details hopefully.
@Logical-sh
Logical-sh
commented
May 10, 2022

Copy link


Copy Markdown

ContributorAuthor
My immediate guesses would be running the service as a different user or sudoing it, or running it in something like flatpack with the permissions wrong.
@TheElixZammutoTheElixZammuto
mentioned this pull request
Jul 2, 2022
 Closed

5 tasks
Nonary referenced
this pull request
in Nonary/vibeshine
Oct 3, 2025
@ClassicOldSong
Fix password is always saved issue#130
7d3b695
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheElixZammutoTheElixZammutoAwaiting requested review from TheElixZammuto

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@Logical-sh@HomerSp@KuleRucket@ReenigneArcher@kyriacos

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Improved Pulse/Pipewire Compatibility for Linux. - #130
Merged
ReenigneArcher merged 4 commits into
LizardByte:nightlyfrom 
Logical-sh:pipewire-compatibility
Apr 29, 2022
Merged
Improved Pulse/Pipewire Compatibility for Linux.#130
ReenigneArcher merged 4 commits into
LizardByte:nightlyfrom 
Logical-sh:pipewire-compatibility
Conversation
@Logical-sh
@Logical-shLogical-sh
commented
Apr 11, 2022•

edited by ReenigneArcher

Loading

Copy link


Copy Markdown

Contributor
Description
A number of small improvements were made to the Linux platform audio code to improve user experience and improve Pipewire compatibility.
  • Fixed a bug in the base Audio code that caused it to select the virtual sink even if you had a different on selected in the config.
  • Added functionality to get monitor names and default sink names.
  • The recording code now properly uses the monitor of the provided/selected sink.
  • Records the default sink as the sink to restore after streaming instead of the last sink encountered in the list.
  • Reliably switches the recorded sink to be the default
  • Updated example config to be clear to provide the SINK name to monitor.
I have tested the following scenarios to work correctly under Pipewire. Additional testing under pulse would be ideal. The code should have no effect on non-Linux platforms.
No configured sink, play audio on host.
  • Stays on on default audio sink
  • Host audio works
  • Device Audio works
No configured sink, do not play on host audio.
  • Switched to virtual sink.
  • No host audio,
  • Device plays audio
  • Audio sink reset to previous sink on disconnect.
Configured sink
  • Switches to provided sink.
  • Audible on device
  • Audible on sink
I will try to setup a pulse VM or switch my packages around to test pure pulse later this week if no one beats me to it!
Issues Fixed or Closed
Type of Change
Please delete options that are not relevant.
  •  Bug fix (non-breaking change which fixes an issue)
Checklist
  •  My code follows the style guidelines of this project
  •  I have performed a self-review of my own code
  •  I have commented my code, particularly in hard-to-understand areas
  •  I have added or updated the documentation blocks for new or existing components
@Logical-sh
Logical-sh
commented
Apr 11, 2022

Copy link


Copy Markdown

ContributorAuthor
I also removed the block in the README about it picking up the mic, as that was happening due to behavior of "@DEFAULT_MONITOR@" which should no longer be an issue. The new code will always try to get a proper monitor device of a sink instead of possibly picking up a random source.
@HomerSp
HomerSp
commented
Apr 12, 2022

Copy link


Copy Markdown

Contributor
This basically mirrors what I have locally (I haven't created a PR yet since I was still trying to solve a few issues) - and it seems to work fine on both pipewire and pulseaudio.
@Logical-sh
Logical-sh
commented
Apr 12, 2022

Copy link


Copy Markdown

ContributorAuthor
This basically mirrors what I have locally (I haven't created a PR yet since I was still trying to solve a few issues) - and it seems to work fine on both pipewire and pulseaudio.
Thanks for the test @HomerSp!
@KuleRucket
KuleRucket
commented
Apr 29, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Is this PR likely to fix #46? I'll try it.
EDIT: And the answer is: yes it does. I can now use pipewire-pulse in Arch
@Logical-sh
Logical-sh
commented
Apr 29, 2022
via email 

Copy link


Copy Markdown

ContributorAuthor
@ReenigneArcher
ReenigneArcher
commented
Apr 29, 2022

Copy link


Copy Markdown

Member
@Logical-sh If you fix the 2 conflicts, I will merge this. We want those files how they exist on the nightly branch.
Documentation is now done mostly in the docs folder using sphinx and rst (reStructuredText). You can see the result here: https://sunshinestream.readthedocs.io/en/nightly/
@Logical-sh
Logical-sh
commented
Apr 29, 2022

Copy link


Copy Markdown

ContributorAuthor
Sure thing! I'll get to that today.
@Logical-sh
Logical-shforce-pushed
the
pipewire-compatibility
branch
from
05fc9e3 to
63a83cdCompareApril 29, 2022 16:27
@Logical-sh
Logical-sh
commented
Apr 29, 2022

Copy link


Copy Markdown

ContributorAuthor
Re-based dropping the conflicting commits!
@ReenigneArcher
ReenigneArcher
merged commit b0df4ea
into
LizardByte:nightlyApr 29, 2022
@kyriacos
kyriacos
commented
May 10, 2022

Copy link


Copy Markdown

Just tried the nightly branch and no audio still
[2022:05:10:08:36:49]: Error: Couldn't connect to pulseaudio: Access denied
[2022:05:10:08:36:49]: Warning: There will be no audio

Is there anything else i can try? I'm on Arch with an Nvidia 1070 gpu.
Linux apollo-desktop 5.17.5-arch1-1 #1 SMP PREEMPT Wed, 27 Apr 2022 20:56:11 +0000 x86_64 GNU/Linux
Thanks!
@Logical-sh
Logical-sh
commented
May 10, 2022

Copy link


Copy Markdown

ContributorAuthor
Just tried the nightly branch and no audio still
[2022:05:10:08:36:49]: Error: Couldn't connect to pulseaudio: Access denied
[2022:05:10:08:36:49]: Warning: There will be no audio

Is there anything else i can try? I'm on Arch with an Nvidia 1070 gpu.
Linux apollo-desktop 5.17.5-arch1-1 #1 SMP PREEMPT Wed, 27 Apr 2022 20:56:11 +0000 x86_64 GNU/Linux
Thanks!
This looks like a totally different issue.

This change doesn't touch the connection logic.

Maybe open a separate issue with details of your setup and we could take a look!
@kyriacos
@kyriacos
kyriacos
commented
May 10, 2022

Copy link


Copy Markdown

Thank will do. Now that i know it doesn't fix this - at least i know it's something else. I'll debug a bit more then and post an issue with more details hopefully.
@Logical-sh
Logical-sh
commented
May 10, 2022

Copy link


Copy Markdown

ContributorAuthor
My immediate guesses would be running the service as a different user or sudoing it, or running it in something like flatpack with the permissions wrong.
@TheElixZammutoTheElixZammuto
mentioned this pull request
Jul 2, 2022
 Closed

5 tasks
Nonary referenced
this pull request
in Nonary/vibeshine
Oct 3, 2025
@ClassicOldSong
Fix password is always saved issue#130
7d3b695
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheElixZammutoTheElixZammutoAwaiting requested review from TheElixZammuto

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@Logical-sh@HomerSp@KuleRucket@ReenigneArcher@kyriacos

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Improved Pulse/Pipewire Compatibility for Linux. - #130
Merged
ReenigneArcher merged 4 commits into
LizardByte:nightlyfrom 
Logical-sh:pipewire-compatibility
Apr 29, 2022
Merged
Improved Pulse/Pipewire Compatibility for Linux.#130
ReenigneArcher merged 4 commits into
LizardByte:nightlyfrom 
Logical-sh:pipewire-compatibility
Conversation
@Logical-sh
@Logical-shLogical-sh
commented
Apr 11, 2022•

edited by ReenigneArcher

Loading

Copy link


Copy Markdown

Contributor
Description
A number of small improvements were made to the Linux platform audio code to improve user experience and improve Pipewire compatibility.
  • Fixed a bug in the base Audio code that caused it to select the virtual sink even if you had a different on selected in the config.
  • Added functionality to get monitor names and default sink names.
  • The recording code now properly uses the monitor of the provided/selected sink.
  • Records the default sink as the sink to restore after streaming instead of the last sink encountered in the list.
  • Reliably switches the recorded sink to be the default
  • Updated example config to be clear to provide the SINK name to monitor.
I have tested the following scenarios to work correctly under Pipewire. Additional testing under pulse would be ideal. The code should have no effect on non-Linux platforms.
No configured sink, play audio on host.
  • Stays on on default audio sink
  • Host audio works
  • Device Audio works
No configured sink, do not play on host audio.
  • Switched to virtual sink.
  • No host audio,
  • Device plays audio
  • Audio sink reset to previous sink on disconnect.
Configured sink
  • Switches to provided sink.
  • Audible on device
  • Audible on sink
I will try to setup a pulse VM or switch my packages around to test pure pulse later this week if no one beats me to it!
Issues Fixed or Closed
Type of Change
Please delete options that are not relevant.
  •  Bug fix (non-breaking change which fixes an issue)
Checklist
  •  My code follows the style guidelines of this project
  •  I have performed a self-review of my own code
  •  I have commented my code, particularly in hard-to-understand areas
  •  I have added or updated the documentation blocks for new or existing components
@Logical-sh
Logical-sh
commented
Apr 11, 2022

Copy link


Copy Markdown

ContributorAuthor
I also removed the block in the README about it picking up the mic, as that was happening due to behavior of "@DEFAULT_MONITOR@" which should no longer be an issue. The new code will always try to get a proper monitor device of a sink instead of possibly picking up a random source.
@HomerSp
HomerSp
commented
Apr 12, 2022

Copy link


Copy Markdown

Contributor
This basically mirrors what I have locally (I haven't created a PR yet since I was still trying to solve a few issues) - and it seems to work fine on both pipewire and pulseaudio.
@Logical-sh
Logical-sh
commented
Apr 12, 2022

Copy link


Copy Markdown

ContributorAuthor
This basically mirrors what I have locally (I haven't created a PR yet since I was still trying to solve a few issues) - and it seems to work fine on both pipewire and pulseaudio.
Thanks for the test @HomerSp!
@KuleRucket
KuleRucket
commented
Apr 29, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Is this PR likely to fix #46? I'll try it.
EDIT: And the answer is: yes it does. I can now use pipewire-pulse in Arch
@Logical-sh
Logical-sh
commented
Apr 29, 2022
via email 

Copy link


Copy Markdown

ContributorAuthor
@ReenigneArcher
ReenigneArcher
commented
Apr 29, 2022

Copy link


Copy Markdown

Member
@Logical-sh If you fix the 2 conflicts, I will merge this. We want those files how they exist on the nightly branch.
Documentation is now done mostly in the docs folder using sphinx and rst (reStructuredText). You can see the result here: https://sunshinestream.readthedocs.io/en/nightly/
@Logical-sh
Logical-sh
commented
Apr 29, 2022

Copy link


Copy Markdown

ContributorAuthor
Sure thing! I'll get to that today.
@Logical-sh
Logical-shforce-pushed
the
pipewire-compatibility
branch
from
05fc9e3 to
63a83cdCompareApril 29, 2022 16:27
@Logical-sh
Logical-sh
commented
Apr 29, 2022

Copy link


Copy Markdown

ContributorAuthor
Re-based dropping the conflicting commits!
@ReenigneArcher
ReenigneArcher
merged commit b0df4ea
into
LizardByte:nightlyApr 29, 2022
@kyriacos
kyriacos
commented
May 10, 2022

Copy link


Copy Markdown

Just tried the nightly branch and no audio still
[2022:05:10:08:36:49]: Error: Couldn't connect to pulseaudio: Access denied
[2022:05:10:08:36:49]: Warning: There will be no audio

Is there anything else i can try? I'm on Arch with an Nvidia 1070 gpu.
Linux apollo-desktop 5.17.5-arch1-1 #1 SMP PREEMPT Wed, 27 Apr 2022 20:56:11 +0000 x86_64 GNU/Linux
Thanks!
@Logical-sh
Logical-sh
commented
May 10, 2022

Copy link


Copy Markdown

ContributorAuthor
Just tried the nightly branch and no audio still
[2022:05:10:08:36:49]: Error: Couldn't connect to pulseaudio: Access denied
[2022:05:10:08:36:49]: Warning: There will be no audio

Is there anything else i can try? I'm on Arch with an Nvidia 1070 gpu.
Linux apollo-desktop 5.17.5-arch1-1 #1 SMP PREEMPT Wed, 27 Apr 2022 20:56:11 +0000 x86_64 GNU/Linux
Thanks!
This looks like a totally different issue.

This change doesn't touch the connection logic.

Maybe open a separate issue with details of your setup and we could take a look!
@kyriacos
@kyriacos
kyriacos
commented
May 10, 2022

Copy link


Copy Markdown

Thank will do. Now that i know it doesn't fix this - at least i know it's something else. I'll debug a bit more then and post an issue with more details hopefully.
@Logical-sh
Logical-sh
commented
May 10, 2022

Copy link


Copy Markdown

ContributorAuthor
My immediate guesses would be running the service as a different user or sudoing it, or running it in something like flatpack with the permissions wrong.
@TheElixZammutoTheElixZammuto
mentioned this pull request
Jul 2, 2022
 Closed

5 tasks
Nonary referenced
this pull request
in Nonary/vibeshine
Oct 3, 2025
@ClassicOldSong
Fix password is always saved issue#130
7d3b695
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheElixZammutoTheElixZammutoAwaiting requested review from TheElixZammuto

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@Logical-sh@HomerSp@KuleRucket@ReenigneArcher@kyriacos

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Improved Pulse/Pipewire Compatibility for Linux. - #130
Merged
ReenigneArcher merged 4 commits into
LizardByte:nightlyfrom 
Logical-sh:pipewire-compatibility
Apr 29, 2022
Merged
Improved Pulse/Pipewire Compatibility for Linux.#130
ReenigneArcher merged 4 commits into
LizardByte:nightlyfrom 
Logical-sh:pipewire-compatibility
Conversation
@Logical-sh
@Logical-shLogical-sh
commented
Apr 11, 2022•

edited by ReenigneArcher

Loading

Copy link


Copy Markdown

Contributor
Description
A number of small improvements were made to the Linux platform audio code to improve user experience and improve Pipewire compatibility.
  • Fixed a bug in the base Audio code that caused it to select the virtual sink even if you had a different on selected in the config.
  • Added functionality to get monitor names and default sink names.
  • The recording code now properly uses the monitor of the provided/selected sink.
  • Records the default sink as the sink to restore after streaming instead of the last sink encountered in the list.
  • Reliably switches the recorded sink to be the default
  • Updated example config to be clear to provide the SINK name to monitor.
I have tested the following scenarios to work correctly under Pipewire. Additional testing under pulse would be ideal. The code should have no effect on non-Linux platforms.
No configured sink, play audio on host.
  • Stays on on default audio sink
  • Host audio works
  • Device Audio works
No configured sink, do not play on host audio.
  • Switched to virtual sink.
  • No host audio,
  • Device plays audio
  • Audio sink reset to previous sink on disconnect.
Configured sink
  • Switches to provided sink.
  • Audible on device
  • Audible on sink
I will try to setup a pulse VM or switch my packages around to test pure pulse later this week if no one beats me to it!
Issues Fixed or Closed
Type of Change
Please delete options that are not relevant.
  •  Bug fix (non-breaking change which fixes an issue)
Checklist
  •  My code follows the style guidelines of this project
  •  I have performed a self-review of my own code
  •  I have commented my code, particularly in hard-to-understand areas
  •  I have added or updated the documentation blocks for new or existing components
@Logical-sh
Logical-sh
commented
Apr 11, 2022

Copy link


Copy Markdown

ContributorAuthor
I also removed the block in the README about it picking up the mic, as that was happening due to behavior of "@DEFAULT_MONITOR@" which should no longer be an issue. The new code will always try to get a proper monitor device of a sink instead of possibly picking up a random source.
@HomerSp
HomerSp
commented
Apr 12, 2022

Copy link


Copy Markdown

Contributor
This basically mirrors what I have locally (I haven't created a PR yet since I was still trying to solve a few issues) - and it seems to work fine on both pipewire and pulseaudio.
@Logical-sh
Logical-sh
commented
Apr 12, 2022

Copy link


Copy Markdown

ContributorAuthor
This basically mirrors what I have locally (I haven't created a PR yet since I was still trying to solve a few issues) - and it seems to work fine on both pipewire and pulseaudio.
Thanks for the test @HomerSp!
@KuleRucket
KuleRucket
commented
Apr 29, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Is this PR likely to fix #46? I'll try it.
EDIT: And the answer is: yes it does. I can now use pipewire-pulse in Arch
@Logical-sh
Logical-sh
commented
Apr 29, 2022
via email 

Copy link


Copy Markdown

ContributorAuthor
@ReenigneArcher
ReenigneArcher
commented
Apr 29, 2022

Copy link


Copy Markdown

Member
@Logical-sh If you fix the 2 conflicts, I will merge this. We want those files how they exist on the nightly branch.
Documentation is now done mostly in the docs folder using sphinx and rst (reStructuredText). You can see the result here: https://sunshinestream.readthedocs.io/en/nightly/
@Logical-sh
Logical-sh
commented
Apr 29, 2022

Copy link


Copy Markdown

ContributorAuthor
Sure thing! I'll get to that today.
@Logical-sh
Logical-shforce-pushed
the
pipewire-compatibility
branch
from
05fc9e3 to
63a83cdCompareApril 29, 2022 16:27
@Logical-sh
Logical-sh
commented
Apr 29, 2022

Copy link


Copy Markdown

ContributorAuthor
Re-based dropping the conflicting commits!
@ReenigneArcher
ReenigneArcher
merged commit b0df4ea
into
LizardByte:nightlyApr 29, 2022
@kyriacos
kyriacos
commented
May 10, 2022

Copy link


Copy Markdown

Just tried the nightly branch and no audio still
[2022:05:10:08:36:49]: Error: Couldn't connect to pulseaudio: Access denied
[2022:05:10:08:36:49]: Warning: There will be no audio

Is there anything else i can try? I'm on Arch with an Nvidia 1070 gpu.
Linux apollo-desktop 5.17.5-arch1-1 #1 SMP PREEMPT Wed, 27 Apr 2022 20:56:11 +0000 x86_64 GNU/Linux
Thanks!
@Logical-sh
Logical-sh
commented
May 10, 2022

Copy link


Copy Markdown

ContributorAuthor
Just tried the nightly branch and no audio still
[2022:05:10:08:36:49]: Error: Couldn't connect to pulseaudio: Access denied
[2022:05:10:08:36:49]: Warning: There will be no audio

Is there anything else i can try? I'm on Arch with an Nvidia 1070 gpu.
Linux apollo-desktop 5.17.5-arch1-1 #1 SMP PREEMPT Wed, 27 Apr 2022 20:56:11 +0000 x86_64 GNU/Linux
Thanks!
This looks like a totally different issue.

This change doesn't touch the connection logic.

Maybe open a separate issue with details of your setup and we could take a look!
@kyriacos
@kyriacos
kyriacos
commented
May 10, 2022

Copy link


Copy Markdown

Thank will do. Now that i know it doesn't fix this - at least i know it's something else. I'll debug a bit more then and post an issue with more details hopefully.
@Logical-sh
Logical-sh
commented
May 10, 2022

Copy link


Copy Markdown

ContributorAuthor
My immediate guesses would be running the service as a different user or sudoing it, or running it in something like flatpack with the permissions wrong.
@TheElixZammutoTheElixZammuto
mentioned this pull request
Jul 2, 2022
 Closed

5 tasks
Nonary referenced
this pull request
in Nonary/vibeshine
Oct 3, 2025
@ClassicOldSong
Fix password is always saved issue#130
7d3b695
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheElixZammutoTheElixZammutoAwaiting requested review from TheElixZammuto

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@Logical-sh@HomerSp@KuleRucket@ReenigneArcher@kyriacos

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Improved Pulse/Pipewire Compatibility for Linux. - #130
Merged
ReenigneArcher merged 4 commits into
LizardByte:nightlyfrom 
Logical-sh:pipewire-compatibility
Apr 29, 2022
Merged
Improved Pulse/Pipewire Compatibility for Linux.#130
ReenigneArcher merged 4 commits into
LizardByte:nightlyfrom 
Logical-sh:pipewire-compatibility
Conversation
@Logical-sh
@Logical-shLogical-sh
commented
Apr 11, 2022•

edited by ReenigneArcher

Loading

Copy link


Copy Markdown

Contributor
Description
A number of small improvements were made to the Linux platform audio code to improve user experience and improve Pipewire compatibility.
  • Fixed a bug in the base Audio code that caused it to select the virtual sink even if you had a different on selected in the config.
  • Added functionality to get monitor names and default sink names.
  • The recording code now properly uses the monitor of the provided/selected sink.
  • Records the default sink as the sink to restore after streaming instead of the last sink encountered in the list.
  • Reliably switches the recorded sink to be the default
  • Updated example config to be clear to provide the SINK name to monitor.
I have tested the following scenarios to work correctly under Pipewire. Additional testing under pulse would be ideal. The code should have no effect on non-Linux platforms.
No configured sink, play audio on host.
  • Stays on on default audio sink
  • Host audio works
  • Device Audio works
No configured sink, do not play on host audio.
  • Switched to virtual sink.
  • No host audio,
  • Device plays audio
  • Audio sink reset to previous sink on disconnect.
Configured sink
  • Switches to provided sink.
  • Audible on device
  • Audible on sink
I will try to setup a pulse VM or switch my packages around to test pure pulse later this week if no one beats me to it!
Issues Fixed or Closed
Type of Change
Please delete options that are not relevant.
  •  Bug fix (non-breaking change which fixes an issue)
Checklist
  •  My code follows the style guidelines of this project
  •  I have performed a self-review of my own code
  •  I have commented my code, particularly in hard-to-understand areas
  •  I have added or updated the documentation blocks for new or existing components
@Logical-sh
Logical-sh
commented
Apr 11, 2022

Copy link


Copy Markdown

ContributorAuthor
I also removed the block in the README about it picking up the mic, as that was happening due to behavior of "@DEFAULT_MONITOR@" which should no longer be an issue. The new code will always try to get a proper monitor device of a sink instead of possibly picking up a random source.
@HomerSp
HomerSp
commented
Apr 12, 2022

Copy link


Copy Markdown

Contributor
This basically mirrors what I have locally (I haven't created a PR yet since I was still trying to solve a few issues) - and it seems to work fine on both pipewire and pulseaudio.
@Logical-sh
Logical-sh
commented
Apr 12, 2022

Copy link


Copy Markdown

ContributorAuthor
This basically mirrors what I have locally (I haven't created a PR yet since I was still trying to solve a few issues) - and it seems to work fine on both pipewire and pulseaudio.
Thanks for the test @HomerSp!
@KuleRucket
KuleRucket
commented
Apr 29, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Is this PR likely to fix #46? I'll try it.
EDIT: And the answer is: yes it does. I can now use pipewire-pulse in Arch
@Logical-sh
Logical-sh
commented
Apr 29, 2022
via email 

Copy link


Copy Markdown

ContributorAuthor
@ReenigneArcher
ReenigneArcher
commented
Apr 29, 2022

Copy link


Copy Markdown

Member
@Logical-sh If you fix the 2 conflicts, I will merge this. We want those files how they exist on the nightly branch.
Documentation is now done mostly in the docs folder using sphinx and rst (reStructuredText). You can see the result here: https://sunshinestream.readthedocs.io/en/nightly/
@Logical-sh
Logical-sh
commented
Apr 29, 2022

Copy link


Copy Markdown

ContributorAuthor
Sure thing! I'll get to that today.
@Logical-sh
Logical-shforce-pushed
the
pipewire-compatibility
branch
from
05fc9e3 to
63a83cdCompareApril 29, 2022 16:27
@Logical-sh
Logical-sh
commented
Apr 29, 2022

Copy link


Copy Markdown

ContributorAuthor
Re-based dropping the conflicting commits!
@ReenigneArcher
ReenigneArcher
merged commit b0df4ea
into
LizardByte:nightlyApr 29, 2022
@kyriacos
kyriacos
commented
May 10, 2022

Copy link


Copy Markdown

Just tried the nightly branch and no audio still
[2022:05:10:08:36:49]: Error: Couldn't connect to pulseaudio: Access denied
[2022:05:10:08:36:49]: Warning: There will be no audio

Is there anything else i can try? I'm on Arch with an Nvidia 1070 gpu.
Linux apollo-desktop 5.17.5-arch1-1 #1 SMP PREEMPT Wed, 27 Apr 2022 20:56:11 +0000 x86_64 GNU/Linux
Thanks!
@Logical-sh
Logical-sh
commented
May 10, 2022

Copy link


Copy Markdown

ContributorAuthor
Just tried the nightly branch and no audio still
[2022:05:10:08:36:49]: Error: Couldn't connect to pulseaudio: Access denied
[2022:05:10:08:36:49]: Warning: There will be no audio

Is there anything else i can try? I'm on Arch with an Nvidia 1070 gpu.
Linux apollo-desktop 5.17.5-arch1-1 #1 SMP PREEMPT Wed, 27 Apr 2022 20:56:11 +0000 x86_64 GNU/Linux
Thanks!
This looks like a totally different issue.

This change doesn't touch the connection logic.

Maybe open a separate issue with details of your setup and we could take a look!
@kyriacos
@kyriacos
kyriacos
commented
May 10, 2022

Copy link


Copy Markdown

Thank will do. Now that i know it doesn't fix this - at least i know it's something else. I'll debug a bit more then and post an issue with more details hopefully.
@Logical-sh
Logical-sh
commented
May 10, 2022

Copy link


Copy Markdown

ContributorAuthor
My immediate guesses would be running the service as a different user or sudoing it, or running it in something like flatpack with the permissions wrong.
@TheElixZammutoTheElixZammuto
mentioned this pull request
Jul 2, 2022
 Closed

5 tasks
Nonary referenced
this pull request
in Nonary/vibeshine
Oct 3, 2025
@ClassicOldSong
Fix password is always saved issue#130
7d3b695
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TheElixZammutoTheElixZammutoAwaiting requested review from TheElixZammuto

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@Logical-sh@HomerSp@KuleRucket@ReenigneArcher@kyriacos