Add TEMPLATES and WORKFLOWS by ReenigneArcher · Pull Request #2 · LizardByte/Sunshine

ReenigneArcher · 2021-12-16T15:43:15Z

Description

Add .github folder:

ISSUE_TEMPLATE
workflows
etc.

Screenshot

Include screenshots if the changes are UI-related.

Issues Fixed or Closed

Fixes #(issue)

Type of Change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the documentation blocks for new or existing components

-Add lines for gpu information and capture method

-Fix path for discussions url

Build Checks - Fixed Windows Build

fix: correct append_struct reserve calculation and optimize insertion

… ctor CodeQL alert #2: Multiplication result converted to larger type. Frames, frame_size, channels_out are std::uint32_t. The product (std::max(frames, frame_size) * 2 * channels_out) computes in uint32_t, which can overflow before being widened to size_t for the std::vector constructor. In practice for sane audio sample rates this doesn't trigger (48kHz * 2 * 8ch = 768K floats * 4 = 3MB, well under uint32_t max). But the type is wrong, and CodeQL is right. Fix: static_cast<size_t>(std::max(frames, frame_size)) * 2 * channels_out so the multiplication happens in 64 bits. Windows-only file (the CachyOS box doesn't compile it), but it lives in master and counts against the alert count.

ReenigneArcher · 2021-12-16T15:43:15Z

Description

Add .github folder:

ISSUE_TEMPLATE
workflows
etc.

Screenshot

Include screenshots if the changes are UI-related.

Issues Fixed or Closed

Fixes #(issue)

Type of Change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the documentation blocks for new or existing components

-Add lines for gpu information and capture method

-Fix path for discussions url

Build Checks - Fixed Windows Build

fix: correct append_struct reserve calculation and optimize insertion

… ctor CodeQL alert #2: Multiplication result converted to larger type. Frames, frame_size, channels_out are std::uint32_t. The product (std::max(frames, frame_size) * 2 * channels_out) computes in uint32_t, which can overflow before being widened to size_t for the std::vector constructor. In practice for sane audio sample rates this doesn't trigger (48kHz * 2 * 8ch = 768K floats * 4 = 3MB, well under uint32_t max). But the type is wrong, and CodeQL is right. Fix: static_cast<size_t>(std::max(frames, frame_size)) * 2 * channels_out so the multiplication happens in 64 bits. Windows-only file (the CachyOS box doesn't compile it), but it lives in master and counts against the alert count.

ReenigneArcher · 2021-12-16T15:43:15Z

Description

Add .github folder:

ISSUE_TEMPLATE
workflows
etc.

Screenshot

Include screenshots if the changes are UI-related.

Issues Fixed or Closed

Fixes #(issue)

Type of Change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the documentation blocks for new or existing components

-Add lines for gpu information and capture method

-Fix path for discussions url

Build Checks - Fixed Windows Build

fix: correct append_struct reserve calculation and optimize insertion

… ctor CodeQL alert #2: Multiplication result converted to larger type. Frames, frame_size, channels_out are std::uint32_t. The product (std::max(frames, frame_size) * 2 * channels_out) computes in uint32_t, which can overflow before being widened to size_t for the std::vector constructor. In practice for sane audio sample rates this doesn't trigger (48kHz * 2 * 8ch = 768K floats * 4 = 3MB, well under uint32_t max). But the type is wrong, and CodeQL is right. Fix: static_cast<size_t>(std::max(frames, frame_size)) * 2 * channels_out so the multiplication happens in 64 bits. Windows-only file (the CachyOS box doesn't compile it), but it lives in master and counts against the alert count.

ReenigneArcher · 2021-12-16T15:43:15Z

Description

Add .github folder:

ISSUE_TEMPLATE
workflows
etc.

Screenshot

Include screenshots if the changes are UI-related.

Issues Fixed or Closed

Fixes #(issue)

Type of Change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the documentation blocks for new or existing components

-Add lines for gpu information and capture method

-Fix path for discussions url

Build Checks - Fixed Windows Build

fix: correct append_struct reserve calculation and optimize insertion

… ctor CodeQL alert #2: Multiplication result converted to larger type. Frames, frame_size, channels_out are std::uint32_t. The product (std::max(frames, frame_size) * 2 * channels_out) computes in uint32_t, which can overflow before being widened to size_t for the std::vector constructor. In practice for sane audio sample rates this doesn't trigger (48kHz * 2 * 8ch = 768K floats * 4 = 3MB, well under uint32_t max). But the type is wrong, and CodeQL is right. Fix: static_cast<size_t>(std::max(frames, frame_size)) * 2 * channels_out so the multiplication happens in 64 bits. Windows-only file (the CachyOS box doesn't compile it), but it lives in master and counts against the alert count.

ReenigneArcher · 2021-12-16T15:43:15Z

Description

Add .github folder:

ISSUE_TEMPLATE
workflows
etc.

Screenshot

Include screenshots if the changes are UI-related.

Issues Fixed or Closed

Fixes #(issue)

Type of Change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the documentation blocks for new or existing components

-Add lines for gpu information and capture method

-Fix path for discussions url

Build Checks - Fixed Windows Build

fix: correct append_struct reserve calculation and optimize insertion

… ctor CodeQL alert #2: Multiplication result converted to larger type. Frames, frame_size, channels_out are std::uint32_t. The product (std::max(frames, frame_size) * 2 * channels_out) computes in uint32_t, which can overflow before being widened to size_t for the std::vector constructor. In practice for sane audio sample rates this doesn't trigger (48kHz * 2 * 8ch = 768K floats * 4 = 3MB, well under uint32_t max). But the type is wrong, and CodeQL is right. Fix: static_cast<size_t>(std::max(frames, frame_size)) * 2 * channels_out so the multiplication happens in 64 bits. Windows-only file (the CachyOS box doesn't compile it), but it lives in master and counts against the alert count.

ReenigneArcher · 2021-12-16T15:43:15Z

Description

Add .github folder:

ISSUE_TEMPLATE
workflows
etc.

Screenshot

Include screenshots if the changes are UI-related.

Issues Fixed or Closed

Fixes #(issue)

Type of Change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the documentation blocks for new or existing components

-Add lines for gpu information and capture method

-Fix path for discussions url

Build Checks - Fixed Windows Build

fix: correct append_struct reserve calculation and optimize insertion

… ctor CodeQL alert #2: Multiplication result converted to larger type. Frames, frame_size, channels_out are std::uint32_t. The product (std::max(frames, frame_size) * 2 * channels_out) computes in uint32_t, which can overflow before being widened to size_t for the std::vector constructor. In practice for sane audio sample rates this doesn't trigger (48kHz * 2 * 8ch = 768K floats * 4 = 3MB, well under uint32_t max). But the type is wrong, and CodeQL is right. Fix: static_cast<size_t>(std::max(frames, frame_size)) * 2 * channels_out so the multiplication happens in 64 bits. Windows-only file (the CachyOS box doesn't compile it), but it lives in master and counts against the alert count.

ReenigneArcher · 2021-12-16T15:43:15Z

Description

Add .github folder:

ISSUE_TEMPLATE
workflows
etc.

Screenshot

Include screenshots if the changes are UI-related.

Issues Fixed or Closed

Fixes #(issue)

Type of Change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the documentation blocks for new or existing components

-Add lines for gpu information and capture method

-Fix path for discussions url

Build Checks - Fixed Windows Build

fix: correct append_struct reserve calculation and optimize insertion

… ctor CodeQL alert #2: Multiplication result converted to larger type. Frames, frame_size, channels_out are std::uint32_t. The product (std::max(frames, frame_size) * 2 * channels_out) computes in uint32_t, which can overflow before being widened to size_t for the std::vector constructor. In practice for sane audio sample rates this doesn't trigger (48kHz * 2 * 8ch = 768K floats * 4 = 3MB, well under uint32_t max). But the type is wrong, and CodeQL is right. Fix: static_cast<size_t>(std::max(frames, frame_size)) * 2 * channels_out so the multiplication happens in 64 bits. Windows-only file (the CachyOS box doesn't compile it), but it lives in master and counts against the alert count.

ReenigneArcher · 2021-12-16T15:43:15Z

Description

Add .github folder:

ISSUE_TEMPLATE
workflows
etc.

Screenshot

Include screenshots if the changes are UI-related.

Issues Fixed or Closed

Fixes #(issue)

Type of Change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the documentation blocks for new or existing components

-Add lines for gpu information and capture method

-Fix path for discussions url

Build Checks - Fixed Windows Build

fix: correct append_struct reserve calculation and optimize insertion

… ctor CodeQL alert #2: Multiplication result converted to larger type. Frames, frame_size, channels_out are std::uint32_t. The product (std::max(frames, frame_size) * 2 * channels_out) computes in uint32_t, which can overflow before being widened to size_t for the std::vector constructor. In practice for sane audio sample rates this doesn't trigger (48kHz * 2 * 8ch = 768K floats * 4 = 3MB, well under uint32_t max). But the type is wrong, and CodeQL is right. Fix: static_cast<size_t>(std::max(frames, frame_size)) * 2 * channels_out so the multiplication happens in 64 bits. Windows-only file (the CachyOS box doesn't compile it), but it lives in master and counts against the alert count.

Add .github
95ced89

ReenigneArcher requested a review from a teamDecember 16, 2021 15:43

TheElixZammuto reviewed Dec 16, 2021
View reviewed changes

Comment thread.github/ISSUE_TEMPLATE/bug-report.md

ReenigneArcher added 2 commits December 16, 2021 11:13

Update bug-report.md
caf70d7
-Add lines for gpu information and capture method

Update config.yml
8730980
-Fix path for discussions url

ReenigneArcher changed the title ~~Add .github~~Add TEMPLATES and WORKFLOWSDec 20, 2021

ReenigneArcher merged commit 0fa4a89 into masterDec 20, 2021

ReenigneArcher added a commit that referenced this pull request Jan 12, 2022
Merge pull request#2from TheElixZammuto/build-patch-windows
732f5bf
Build Checks - Fixed Windows Build

KuleRucket mentioned this pull request Feb 22, 2022
free(): invalid pointer with ffmpeg 5.0 #63
Closed

HomerSp mentioned this pull request Mar 9, 2022
Fix hwdevice being destroyed before context causing sigsegv on AMD #88
Merged
5 tasks

This was referenced Jul 16, 2022
Crash and black screen on login with sunshine systemd service enabled #254
Closed
Crash when resuming from suspend #253
Closed

qdore mentioned this pull request Jul 7, 2023
MacPort 0.20.0 and up returns segmentation fault 11 #1348
Closed
3 tasks

Sidefix mentioned this pull request Aug 7, 2024
Random segmentation fault on start #2944
Closed
2 tasks

LLJY pushed a commit to LLJY/Sunshine that referenced this pull request Dec 1, 2025
Merge pull requestLizardByte#2from chaowyc/perf-optimize-append-struct
8934dd1
fix: correct append_struct reserve calculation and optimize insertion

psyke83 mentioned this pull request Apr 11, 2026
fix: Resolve minimum_fps_target related issues on all platforms #4967
Merged
21 tasks

kabooHD mentioned this pull request Apr 20, 2026
fix(linux): multi-GPU segfault + wlr GPU auto selection, DMA-BUF metadata planes and revert wlr vulkan support #5030
Merged
21 tasks

darman84 mentioned this pull request May 22, 2026
System tray failure causes 'Main loop has exited', preventing headless/server operation on Linux #5170
Closed

Shintaro-66 mentioned this pull request Jul 6, 2026
[Linux] rtsp::handler segfault (SIGSEGV) on client disconnect (reproduced twice) #5378
Closed
2 tasks

HaydenKSmith mentioned this pull request Aug 29, 2026
Sunshine session::video segfault on stream start (AMD RDNA4 / KMS capture) #5471
Open
2 tasks