refactor(ui): break down config.html into smaller pieces - #2491

Merged
ReenigneArcher merged 11 commits into
LizardByte:nightlyfrom
Hazer:refactor/big-chungus-expurgus
May 13, 2024
Merged

refactor(ui): break down config.html into smaller pieces#2491
ReenigneArcher merged 11 commits into
LizardByte:nightlyfrom
Hazer:refactor/big-chungus-expurgus

Conversation

@Hazer

@HazerHazer commented May 2, 2024

Copy link
Copy Markdown
Contributor

Description

Breaks that big chungus of a vue file into smaller readable vue files, also includes some QoL improvements, $tp for i18n $t but knows platforms, PlatformLayout for slotted platform layout, making it clearer what should load per platform and easier to add new as needed, refactored some duplicated layouts using those new tools.

We can improve further by pushing more logic into each Component, instead of parsing and filtering data in config.html, but I wanted to avoid refactoring the load/save part in this PR.

PS: Fixed _common.*_cmd labels in General Tab.

Screenshot

No visual changes.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@HazerHazer mentioned this pull request May 2, 2024
9 tasks

@ReenigneArcherReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This is just my first pass review. I still need to review the bulk of the new files.

Comment thread.gitignore
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue Outdated
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue
Comment threadsrc_assets/common/assets/web/public/assets/locale/en.json Outdated
Comment threadsrc_assets/common/assets/web/platform-i18n.js Outdated
Comment threadsrc_assets/common/assets/web/index.html Outdated
@HazerHazer mentioned this pull request May 2, 2024
16 tasks
@Hazer
Hazerforce-pushed the refactor/big-chungus-expurgus branch from 4d3ffb6 to 3aa823cCompareMay 6, 2024 01:25
@Hazer
Hazer requested a review from ReenigneArcherMay 7, 2024 06:13

@ReenigneArcherReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not review every line in the new vue files. Hopefully things are in the same order as before and functionally equivalent, but once these couple of comments are addressed I will test the build and do a spot check.

Comment threadsrc_assets/common/assets/web/public/assets/locale/de.json
Comment threadsrc_assets/common/assets/web/platform-i18n.js
Comment threadsrc_assets/common/assets/web/configs/tabs/AudioVideo.vue Outdated
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue Outdated
Comment threadsrc_assets/common/assets/web/configs/tabs/Advanced.vue
Comment threadsrc_assets/common/assets/web/platform-i18n.js
Comment threadsrc_assets/common/assets/web/configs/tabs/AudioVideo.vue Outdated
Comment threadsrc_assets/common/assets/web/configs/tabs/AudioVideo.vue Outdated
@Hazer
Hazer requested a review from ReenigneArcherMay 12, 2024 20:45
@codecov

codecovBot commented May 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.94%. Comparing base (81c2ecf) to head (92dfaa4).

Additional details and impacted files
@@ Coverage Diff @@## nightly #2491 +/- ##
=========================================
Coverage 6.94% 6.94% =========================================
Files 87 87 Lines 17673 17673 Branches 8399 8399 =========================================
Hits 1227 1227 - Misses 13717 15761 +2044 + Partials 2729 685 -2044 
FlagCoverage Δ
Linux5.34% <ø> (ø)
Windows2.56% <ø> (ø)
macOS-148.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes

@ReenigneArcherReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested your changes locally, and visually everything appears to be in place.

These will be my last changes to request.

Comment threadsrc_assets/common/assets/web/PlatformLayout.vue
Comment threadsrc_assets/common/assets/web/configs/tabs/Advanced.vue
Comment threadsrc_assets/common/assets/web/configs/tabs/Files.vue
Comment threadsrc_assets/common/assets/web/configs/tabs/Inputs.vue
@Hazer

Copy link
Copy Markdown
ContributorAuthor

@ReenigneArcher if any of the current open PR gets conflict with my changes, you can point to me for help, if needed.

@Hazer
Hazer requested a review from ReenigneArcherMay 13, 2024 14:23
Hazerand others added 11 commits May 13, 2024 10:54
Breaks that big chungus of a vue file into smaller readable vue files,
Also includes some QoL improvements, `$tp` for i18n `$t` but knows platforms,
`PlatformLayout` for slotted platform layout,
making it clearer what should load per platform and easier to add new as needed.
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
@ReenigneArcher
ReenigneArcherforce-pushed the refactor/big-chungus-expurgus branch from b810b45 to 92dfaa4CompareMay 13, 2024 14:54
@ReenigneArcher
ReenigneArcher merged commit 4b6ff37 into LizardByte:nightlyMay 13, 2024
@Hazer
Hazer deleted the refactor/big-chungus-expurgus branch May 13, 2024 18:59
@HazerHazer mentioned this pull request May 30, 2024
11 tasks
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
…2491)
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
c2vi pushed a commit to c2vi/Sunshine that referenced this pull request Mar 27, 2025
…2491)
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Hazer@ReenigneArcher
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

refactor(ui): break down config.html into smaller pieces - #2491

Merged
ReenigneArcher merged 11 commits into
LizardByte:nightlyfrom
Hazer:refactor/big-chungus-expurgus
May 13, 2024
Merged

refactor(ui): break down config.html into smaller pieces#2491
ReenigneArcher merged 11 commits into
LizardByte:nightlyfrom
Hazer:refactor/big-chungus-expurgus

Conversation

@Hazer

@HazerHazer commented May 2, 2024

Copy link
Copy Markdown
Contributor

Description

Breaks that big chungus of a vue file into smaller readable vue files, also includes some QoL improvements, $tp for i18n $t but knows platforms, PlatformLayout for slotted platform layout, making it clearer what should load per platform and easier to add new as needed, refactored some duplicated layouts using those new tools.

We can improve further by pushing more logic into each Component, instead of parsing and filtering data in config.html, but I wanted to avoid refactoring the load/save part in this PR.

PS: Fixed _common.*_cmd labels in General Tab.

Screenshot

No visual changes.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@HazerHazer mentioned this pull request May 2, 2024
9 tasks

@ReenigneArcherReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This is just my first pass review. I still need to review the bulk of the new files.

Comment thread.gitignore
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue Outdated
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue
Comment threadsrc_assets/common/assets/web/public/assets/locale/en.json Outdated
Comment threadsrc_assets/common/assets/web/platform-i18n.js Outdated
Comment threadsrc_assets/common/assets/web/index.html Outdated
@HazerHazer mentioned this pull request May 2, 2024
16 tasks
@Hazer
Hazerforce-pushed the refactor/big-chungus-expurgus branch from 4d3ffb6 to 3aa823cCompareMay 6, 2024 01:25
@Hazer
Hazer requested a review from ReenigneArcherMay 7, 2024 06:13

@ReenigneArcherReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not review every line in the new vue files. Hopefully things are in the same order as before and functionally equivalent, but once these couple of comments are addressed I will test the build and do a spot check.

Comment threadsrc_assets/common/assets/web/public/assets/locale/de.json
Comment threadsrc_assets/common/assets/web/platform-i18n.js
Comment threadsrc_assets/common/assets/web/configs/tabs/AudioVideo.vue Outdated
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue Outdated
Comment threadsrc_assets/common/assets/web/configs/tabs/Advanced.vue
Comment threadsrc_assets/common/assets/web/platform-i18n.js
Comment threadsrc_assets/common/assets/web/configs/tabs/AudioVideo.vue Outdated
Comment threadsrc_assets/common/assets/web/configs/tabs/AudioVideo.vue Outdated
@Hazer
Hazer requested a review from ReenigneArcherMay 12, 2024 20:45
@codecov

codecovBot commented May 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.94%. Comparing base (81c2ecf) to head (92dfaa4).

Additional details and impacted files
@@ Coverage Diff @@## nightly #2491 +/- ##
=========================================
Coverage 6.94% 6.94% =========================================
Files 87 87 Lines 17673 17673 Branches 8399 8399 =========================================
Hits 1227 1227 - Misses 13717 15761 +2044 + Partials 2729 685 -2044 
FlagCoverage Δ
Linux5.34% <ø> (ø)
Windows2.56% <ø> (ø)
macOS-148.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes

@ReenigneArcherReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested your changes locally, and visually everything appears to be in place.

These will be my last changes to request.

Comment threadsrc_assets/common/assets/web/PlatformLayout.vue
Comment threadsrc_assets/common/assets/web/configs/tabs/Advanced.vue
Comment threadsrc_assets/common/assets/web/configs/tabs/Files.vue
Comment threadsrc_assets/common/assets/web/configs/tabs/Inputs.vue
@Hazer

Copy link
Copy Markdown
ContributorAuthor

@ReenigneArcher if any of the current open PR gets conflict with my changes, you can point to me for help, if needed.

@Hazer
Hazer requested a review from ReenigneArcherMay 13, 2024 14:23
Hazerand others added 11 commits May 13, 2024 10:54
Breaks that big chungus of a vue file into smaller readable vue files,
Also includes some QoL improvements, `$tp` for i18n `$t` but knows platforms,
`PlatformLayout` for slotted platform layout,
making it clearer what should load per platform and easier to add new as needed.
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
@ReenigneArcher
ReenigneArcherforce-pushed the refactor/big-chungus-expurgus branch from b810b45 to 92dfaa4CompareMay 13, 2024 14:54
@ReenigneArcher
ReenigneArcher merged commit 4b6ff37 into LizardByte:nightlyMay 13, 2024
@Hazer
Hazer deleted the refactor/big-chungus-expurgus branch May 13, 2024 18:59
@HazerHazer mentioned this pull request May 30, 2024
11 tasks
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
…2491)
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
c2vi pushed a commit to c2vi/Sunshine that referenced this pull request Mar 27, 2025
…2491)
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Hazer@ReenigneArcher
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

refactor(ui): break down config.html into smaller pieces - #2491

Merged
ReenigneArcher merged 11 commits into
LizardByte:nightlyfrom
Hazer:refactor/big-chungus-expurgus
May 13, 2024
Merged

refactor(ui): break down config.html into smaller pieces#2491
ReenigneArcher merged 11 commits into
LizardByte:nightlyfrom
Hazer:refactor/big-chungus-expurgus

Conversation

@Hazer

@HazerHazer commented May 2, 2024

Copy link
Copy Markdown
Contributor

Description

Breaks that big chungus of a vue file into smaller readable vue files, also includes some QoL improvements, $tp for i18n $t but knows platforms, PlatformLayout for slotted platform layout, making it clearer what should load per platform and easier to add new as needed, refactored some duplicated layouts using those new tools.

We can improve further by pushing more logic into each Component, instead of parsing and filtering data in config.html, but I wanted to avoid refactoring the load/save part in this PR.

PS: Fixed _common.*_cmd labels in General Tab.

Screenshot

No visual changes.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@HazerHazer mentioned this pull request May 2, 2024
9 tasks

@ReenigneArcherReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This is just my first pass review. I still need to review the bulk of the new files.

Comment thread.gitignore
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue Outdated
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue
Comment threadsrc_assets/common/assets/web/public/assets/locale/en.json Outdated
Comment threadsrc_assets/common/assets/web/platform-i18n.js Outdated
Comment threadsrc_assets/common/assets/web/index.html Outdated
@HazerHazer mentioned this pull request May 2, 2024
16 tasks
@Hazer
Hazerforce-pushed the refactor/big-chungus-expurgus branch from 4d3ffb6 to 3aa823cCompareMay 6, 2024 01:25
@Hazer
Hazer requested a review from ReenigneArcherMay 7, 2024 06:13

@ReenigneArcherReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not review every line in the new vue files. Hopefully things are in the same order as before and functionally equivalent, but once these couple of comments are addressed I will test the build and do a spot check.

Comment threadsrc_assets/common/assets/web/public/assets/locale/de.json
Comment threadsrc_assets/common/assets/web/platform-i18n.js
Comment threadsrc_assets/common/assets/web/configs/tabs/AudioVideo.vue Outdated
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue Outdated
Comment threadsrc_assets/common/assets/web/configs/tabs/Advanced.vue
Comment threadsrc_assets/common/assets/web/platform-i18n.js
Comment threadsrc_assets/common/assets/web/configs/tabs/AudioVideo.vue Outdated
Comment threadsrc_assets/common/assets/web/configs/tabs/AudioVideo.vue Outdated
@Hazer
Hazer requested a review from ReenigneArcherMay 12, 2024 20:45
@codecov

codecovBot commented May 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.94%. Comparing base (81c2ecf) to head (92dfaa4).

Additional details and impacted files
@@ Coverage Diff @@## nightly #2491 +/- ##
=========================================
Coverage 6.94% 6.94% =========================================
Files 87 87 Lines 17673 17673 Branches 8399 8399 =========================================
Hits 1227 1227 - Misses 13717 15761 +2044 + Partials 2729 685 -2044 
FlagCoverage Δ
Linux5.34% <ø> (ø)
Windows2.56% <ø> (ø)
macOS-148.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes

@ReenigneArcherReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested your changes locally, and visually everything appears to be in place.

These will be my last changes to request.

Comment threadsrc_assets/common/assets/web/PlatformLayout.vue
Comment threadsrc_assets/common/assets/web/configs/tabs/Advanced.vue
Comment threadsrc_assets/common/assets/web/configs/tabs/Files.vue
Comment threadsrc_assets/common/assets/web/configs/tabs/Inputs.vue
@Hazer

Copy link
Copy Markdown
ContributorAuthor

@ReenigneArcher if any of the current open PR gets conflict with my changes, you can point to me for help, if needed.

@Hazer
Hazer requested a review from ReenigneArcherMay 13, 2024 14:23
Hazerand others added 11 commits May 13, 2024 10:54
Breaks that big chungus of a vue file into smaller readable vue files,
Also includes some QoL improvements, `$tp` for i18n `$t` but knows platforms,
`PlatformLayout` for slotted platform layout,
making it clearer what should load per platform and easier to add new as needed.
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
@ReenigneArcher
ReenigneArcherforce-pushed the refactor/big-chungus-expurgus branch from b810b45 to 92dfaa4CompareMay 13, 2024 14:54
@ReenigneArcher
ReenigneArcher merged commit 4b6ff37 into LizardByte:nightlyMay 13, 2024
@Hazer
Hazer deleted the refactor/big-chungus-expurgus branch May 13, 2024 18:59
@HazerHazer mentioned this pull request May 30, 2024
11 tasks
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
…2491)
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
c2vi pushed a commit to c2vi/Sunshine that referenced this pull request Mar 27, 2025
…2491)
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Hazer@ReenigneArcher
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

refactor(ui): break down config.html into smaller pieces - #2491

Merged
ReenigneArcher merged 11 commits into
LizardByte:nightlyfrom
Hazer:refactor/big-chungus-expurgus
May 13, 2024
Merged

refactor(ui): break down config.html into smaller pieces#2491
ReenigneArcher merged 11 commits into
LizardByte:nightlyfrom
Hazer:refactor/big-chungus-expurgus

Conversation

@Hazer

@HazerHazer commented May 2, 2024

Copy link
Copy Markdown
Contributor

Description

Breaks that big chungus of a vue file into smaller readable vue files, also includes some QoL improvements, $tp for i18n $t but knows platforms, PlatformLayout for slotted platform layout, making it clearer what should load per platform and easier to add new as needed, refactored some duplicated layouts using those new tools.

We can improve further by pushing more logic into each Component, instead of parsing and filtering data in config.html, but I wanted to avoid refactoring the load/save part in this PR.

PS: Fixed _common.*_cmd labels in General Tab.

Screenshot

No visual changes.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@HazerHazer mentioned this pull request May 2, 2024
9 tasks

@ReenigneArcherReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This is just my first pass review. I still need to review the bulk of the new files.

Comment thread.gitignore
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue Outdated
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue
Comment threadsrc_assets/common/assets/web/public/assets/locale/en.json Outdated
Comment threadsrc_assets/common/assets/web/platform-i18n.js Outdated
Comment threadsrc_assets/common/assets/web/index.html Outdated
@HazerHazer mentioned this pull request May 2, 2024
16 tasks
@Hazer
Hazerforce-pushed the refactor/big-chungus-expurgus branch from 4d3ffb6 to 3aa823cCompareMay 6, 2024 01:25
@Hazer
Hazer requested a review from ReenigneArcherMay 7, 2024 06:13

@ReenigneArcherReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not review every line in the new vue files. Hopefully things are in the same order as before and functionally equivalent, but once these couple of comments are addressed I will test the build and do a spot check.

Comment threadsrc_assets/common/assets/web/public/assets/locale/de.json
Comment threadsrc_assets/common/assets/web/platform-i18n.js
Comment threadsrc_assets/common/assets/web/configs/tabs/AudioVideo.vue Outdated
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue Outdated
Comment threadsrc_assets/common/assets/web/configs/tabs/Advanced.vue
Comment threadsrc_assets/common/assets/web/platform-i18n.js
Comment threadsrc_assets/common/assets/web/configs/tabs/AudioVideo.vue Outdated
Comment threadsrc_assets/common/assets/web/configs/tabs/AudioVideo.vue Outdated
@Hazer
Hazer requested a review from ReenigneArcherMay 12, 2024 20:45
@codecov

codecovBot commented May 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.94%. Comparing base (81c2ecf) to head (92dfaa4).

Additional details and impacted files
@@ Coverage Diff @@## nightly #2491 +/- ##
=========================================
Coverage 6.94% 6.94% =========================================
Files 87 87 Lines 17673 17673 Branches 8399 8399 =========================================
Hits 1227 1227 - Misses 13717 15761 +2044 + Partials 2729 685 -2044 
FlagCoverage Δ
Linux5.34% <ø> (ø)
Windows2.56% <ø> (ø)
macOS-148.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes

@ReenigneArcherReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested your changes locally, and visually everything appears to be in place.

These will be my last changes to request.

Comment threadsrc_assets/common/assets/web/PlatformLayout.vue
Comment threadsrc_assets/common/assets/web/configs/tabs/Advanced.vue
Comment threadsrc_assets/common/assets/web/configs/tabs/Files.vue
Comment threadsrc_assets/common/assets/web/configs/tabs/Inputs.vue
@Hazer

Copy link
Copy Markdown
ContributorAuthor

@ReenigneArcher if any of the current open PR gets conflict with my changes, you can point to me for help, if needed.

@Hazer
Hazer requested a review from ReenigneArcherMay 13, 2024 14:23
Hazerand others added 11 commits May 13, 2024 10:54
Breaks that big chungus of a vue file into smaller readable vue files,
Also includes some QoL improvements, `$tp` for i18n `$t` but knows platforms,
`PlatformLayout` for slotted platform layout,
making it clearer what should load per platform and easier to add new as needed.
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
@ReenigneArcher
ReenigneArcherforce-pushed the refactor/big-chungus-expurgus branch from b810b45 to 92dfaa4CompareMay 13, 2024 14:54
@ReenigneArcher
ReenigneArcher merged commit 4b6ff37 into LizardByte:nightlyMay 13, 2024
@Hazer
Hazer deleted the refactor/big-chungus-expurgus branch May 13, 2024 18:59
@HazerHazer mentioned this pull request May 30, 2024
11 tasks
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
…2491)
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
c2vi pushed a commit to c2vi/Sunshine that referenced this pull request Mar 27, 2025
…2491)
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Hazer@ReenigneArcher
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

refactor(ui): break down config.html into smaller pieces - #2491

Merged
ReenigneArcher merged 11 commits into
LizardByte:nightlyfrom
Hazer:refactor/big-chungus-expurgus
May 13, 2024
Merged

refactor(ui): break down config.html into smaller pieces#2491
ReenigneArcher merged 11 commits into
LizardByte:nightlyfrom
Hazer:refactor/big-chungus-expurgus

Conversation

@Hazer

@HazerHazer commented May 2, 2024

Copy link
Copy Markdown
Contributor

Description

Breaks that big chungus of a vue file into smaller readable vue files, also includes some QoL improvements, $tp for i18n $t but knows platforms, PlatformLayout for slotted platform layout, making it clearer what should load per platform and easier to add new as needed, refactored some duplicated layouts using those new tools.

We can improve further by pushing more logic into each Component, instead of parsing and filtering data in config.html, but I wanted to avoid refactoring the load/save part in this PR.

PS: Fixed _common.*_cmd labels in General Tab.

Screenshot

No visual changes.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@HazerHazer mentioned this pull request May 2, 2024
9 tasks

@ReenigneArcherReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This is just my first pass review. I still need to review the bulk of the new files.

Comment thread.gitignore
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue Outdated
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue
Comment threadsrc_assets/common/assets/web/public/assets/locale/en.json Outdated
Comment threadsrc_assets/common/assets/web/platform-i18n.js Outdated
Comment threadsrc_assets/common/assets/web/index.html Outdated
@HazerHazer mentioned this pull request May 2, 2024
16 tasks
@Hazer
Hazerforce-pushed the refactor/big-chungus-expurgus branch from 4d3ffb6 to 3aa823cCompareMay 6, 2024 01:25
@Hazer
Hazer requested a review from ReenigneArcherMay 7, 2024 06:13

@ReenigneArcherReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not review every line in the new vue files. Hopefully things are in the same order as before and functionally equivalent, but once these couple of comments are addressed I will test the build and do a spot check.

Comment threadsrc_assets/common/assets/web/public/assets/locale/de.json
Comment threadsrc_assets/common/assets/web/platform-i18n.js
Comment threadsrc_assets/common/assets/web/configs/tabs/AudioVideo.vue Outdated
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue Outdated
Comment threadsrc_assets/common/assets/web/configs/tabs/Advanced.vue
Comment threadsrc_assets/common/assets/web/platform-i18n.js
Comment threadsrc_assets/common/assets/web/configs/tabs/AudioVideo.vue Outdated
Comment threadsrc_assets/common/assets/web/configs/tabs/AudioVideo.vue Outdated
@Hazer
Hazer requested a review from ReenigneArcherMay 12, 2024 20:45
@codecov

codecovBot commented May 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.94%. Comparing base (81c2ecf) to head (92dfaa4).

Additional details and impacted files
@@ Coverage Diff @@## nightly #2491 +/- ##
=========================================
Coverage 6.94% 6.94% =========================================
Files 87 87 Lines 17673 17673 Branches 8399 8399 =========================================
Hits 1227 1227 - Misses 13717 15761 +2044 + Partials 2729 685 -2044 
FlagCoverage Δ
Linux5.34% <ø> (ø)
Windows2.56% <ø> (ø)
macOS-148.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes

@ReenigneArcherReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested your changes locally, and visually everything appears to be in place.

These will be my last changes to request.

Comment threadsrc_assets/common/assets/web/PlatformLayout.vue
Comment threadsrc_assets/common/assets/web/configs/tabs/Advanced.vue
Comment threadsrc_assets/common/assets/web/configs/tabs/Files.vue
Comment threadsrc_assets/common/assets/web/configs/tabs/Inputs.vue
@Hazer

Copy link
Copy Markdown
ContributorAuthor

@ReenigneArcher if any of the current open PR gets conflict with my changes, you can point to me for help, if needed.

@Hazer
Hazer requested a review from ReenigneArcherMay 13, 2024 14:23
Hazerand others added 11 commits May 13, 2024 10:54
Breaks that big chungus of a vue file into smaller readable vue files,
Also includes some QoL improvements, `$tp` for i18n `$t` but knows platforms,
`PlatformLayout` for slotted platform layout,
making it clearer what should load per platform and easier to add new as needed.
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
@ReenigneArcher
ReenigneArcherforce-pushed the refactor/big-chungus-expurgus branch from b810b45 to 92dfaa4CompareMay 13, 2024 14:54
@ReenigneArcher
ReenigneArcher merged commit 4b6ff37 into LizardByte:nightlyMay 13, 2024
@Hazer
Hazer deleted the refactor/big-chungus-expurgus branch May 13, 2024 18:59
@HazerHazer mentioned this pull request May 30, 2024
11 tasks
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
…2491)
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
c2vi pushed a commit to c2vi/Sunshine that referenced this pull request Mar 27, 2025
…2491)
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Hazer@ReenigneArcher
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

refactor(ui): break down config.html into smaller pieces - #2491

Merged
ReenigneArcher merged 11 commits into
LizardByte:nightlyfrom
Hazer:refactor/big-chungus-expurgus
May 13, 2024
Merged

refactor(ui): break down config.html into smaller pieces#2491
ReenigneArcher merged 11 commits into
LizardByte:nightlyfrom
Hazer:refactor/big-chungus-expurgus

Conversation

@Hazer

@HazerHazer commented May 2, 2024

Copy link
Copy Markdown
Contributor

Description

Breaks that big chungus of a vue file into smaller readable vue files, also includes some QoL improvements, $tp for i18n $t but knows platforms, PlatformLayout for slotted platform layout, making it clearer what should load per platform and easier to add new as needed, refactored some duplicated layouts using those new tools.

We can improve further by pushing more logic into each Component, instead of parsing and filtering data in config.html, but I wanted to avoid refactoring the load/save part in this PR.

PS: Fixed _common.*_cmd labels in General Tab.

Screenshot

No visual changes.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@HazerHazer mentioned this pull request May 2, 2024
9 tasks

@ReenigneArcherReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This is just my first pass review. I still need to review the bulk of the new files.

Comment thread.gitignore
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue Outdated
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue
Comment threadsrc_assets/common/assets/web/public/assets/locale/en.json Outdated
Comment threadsrc_assets/common/assets/web/platform-i18n.js Outdated
Comment threadsrc_assets/common/assets/web/index.html Outdated
@HazerHazer mentioned this pull request May 2, 2024
16 tasks
@Hazer
Hazerforce-pushed the refactor/big-chungus-expurgus branch from 4d3ffb6 to 3aa823cCompareMay 6, 2024 01:25
@Hazer
Hazer requested a review from ReenigneArcherMay 7, 2024 06:13

@ReenigneArcherReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not review every line in the new vue files. Hopefully things are in the same order as before and functionally equivalent, but once these couple of comments are addressed I will test the build and do a spot check.

Comment threadsrc_assets/common/assets/web/public/assets/locale/de.json
Comment threadsrc_assets/common/assets/web/platform-i18n.js
Comment threadsrc_assets/common/assets/web/configs/tabs/AudioVideo.vue Outdated
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue Outdated
Comment threadsrc_assets/common/assets/web/configs/tabs/Advanced.vue
Comment threadsrc_assets/common/assets/web/platform-i18n.js
Comment threadsrc_assets/common/assets/web/configs/tabs/AudioVideo.vue Outdated
Comment threadsrc_assets/common/assets/web/configs/tabs/AudioVideo.vue Outdated
@Hazer
Hazer requested a review from ReenigneArcherMay 12, 2024 20:45
@codecov

codecovBot commented May 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.94%. Comparing base (81c2ecf) to head (92dfaa4).

Additional details and impacted files
@@ Coverage Diff @@## nightly #2491 +/- ##
=========================================
Coverage 6.94% 6.94% =========================================
Files 87 87 Lines 17673 17673 Branches 8399 8399 =========================================
Hits 1227 1227 - Misses 13717 15761 +2044 + Partials 2729 685 -2044 
FlagCoverage Δ
Linux5.34% <ø> (ø)
Windows2.56% <ø> (ø)
macOS-148.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes

@ReenigneArcherReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested your changes locally, and visually everything appears to be in place.

These will be my last changes to request.

Comment threadsrc_assets/common/assets/web/PlatformLayout.vue
Comment threadsrc_assets/common/assets/web/configs/tabs/Advanced.vue
Comment threadsrc_assets/common/assets/web/configs/tabs/Files.vue
Comment threadsrc_assets/common/assets/web/configs/tabs/Inputs.vue
@Hazer

Copy link
Copy Markdown
ContributorAuthor

@ReenigneArcher if any of the current open PR gets conflict with my changes, you can point to me for help, if needed.

@Hazer
Hazer requested a review from ReenigneArcherMay 13, 2024 14:23
Hazerand others added 11 commits May 13, 2024 10:54
Breaks that big chungus of a vue file into smaller readable vue files,
Also includes some QoL improvements, `$tp` for i18n `$t` but knows platforms,
`PlatformLayout` for slotted platform layout,
making it clearer what should load per platform and easier to add new as needed.
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
@ReenigneArcher
ReenigneArcherforce-pushed the refactor/big-chungus-expurgus branch from b810b45 to 92dfaa4CompareMay 13, 2024 14:54
@ReenigneArcher
ReenigneArcher merged commit 4b6ff37 into LizardByte:nightlyMay 13, 2024
@Hazer
Hazer deleted the refactor/big-chungus-expurgus branch May 13, 2024 18:59
@HazerHazer mentioned this pull request May 30, 2024
11 tasks
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
…2491)
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
c2vi pushed a commit to c2vi/Sunshine that referenced this pull request Mar 27, 2025
…2491)
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Hazer@ReenigneArcher
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

refactor(ui): break down config.html into smaller pieces - #2491

Merged
ReenigneArcher merged 11 commits into
LizardByte:nightlyfrom
Hazer:refactor/big-chungus-expurgus
May 13, 2024
Merged

refactor(ui): break down config.html into smaller pieces#2491
ReenigneArcher merged 11 commits into
LizardByte:nightlyfrom
Hazer:refactor/big-chungus-expurgus

Conversation

@Hazer

@HazerHazer commented May 2, 2024

Copy link
Copy Markdown
Contributor

Description

Breaks that big chungus of a vue file into smaller readable vue files, also includes some QoL improvements, $tp for i18n $t but knows platforms, PlatformLayout for slotted platform layout, making it clearer what should load per platform and easier to add new as needed, refactored some duplicated layouts using those new tools.

We can improve further by pushing more logic into each Component, instead of parsing and filtering data in config.html, but I wanted to avoid refactoring the load/save part in this PR.

PS: Fixed _common.*_cmd labels in General Tab.

Screenshot

No visual changes.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@HazerHazer mentioned this pull request May 2, 2024
9 tasks

@ReenigneArcherReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This is just my first pass review. I still need to review the bulk of the new files.

Comment thread.gitignore
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue Outdated
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue
Comment threadsrc_assets/common/assets/web/public/assets/locale/en.json Outdated
Comment threadsrc_assets/common/assets/web/platform-i18n.js Outdated
Comment threadsrc_assets/common/assets/web/index.html Outdated
@HazerHazer mentioned this pull request May 2, 2024
16 tasks
@Hazer
Hazerforce-pushed the refactor/big-chungus-expurgus branch from 4d3ffb6 to 3aa823cCompareMay 6, 2024 01:25
@Hazer
Hazer requested a review from ReenigneArcherMay 7, 2024 06:13

@ReenigneArcherReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not review every line in the new vue files. Hopefully things are in the same order as before and functionally equivalent, but once these couple of comments are addressed I will test the build and do a spot check.

Comment threadsrc_assets/common/assets/web/public/assets/locale/de.json
Comment threadsrc_assets/common/assets/web/platform-i18n.js
Comment threadsrc_assets/common/assets/web/configs/tabs/AudioVideo.vue Outdated
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue Outdated
Comment threadsrc_assets/common/assets/web/configs/tabs/Advanced.vue
Comment threadsrc_assets/common/assets/web/platform-i18n.js
Comment threadsrc_assets/common/assets/web/configs/tabs/AudioVideo.vue Outdated
Comment threadsrc_assets/common/assets/web/configs/tabs/AudioVideo.vue Outdated
@Hazer
Hazer requested a review from ReenigneArcherMay 12, 2024 20:45
@codecov

codecovBot commented May 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.94%. Comparing base (81c2ecf) to head (92dfaa4).

Additional details and impacted files
@@ Coverage Diff @@## nightly #2491 +/- ##
=========================================
Coverage 6.94% 6.94% =========================================
Files 87 87 Lines 17673 17673 Branches 8399 8399 =========================================
Hits 1227 1227 - Misses 13717 15761 +2044 + Partials 2729 685 -2044 
FlagCoverage Δ
Linux5.34% <ø> (ø)
Windows2.56% <ø> (ø)
macOS-148.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes

@ReenigneArcherReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested your changes locally, and visually everything appears to be in place.

These will be my last changes to request.

Comment threadsrc_assets/common/assets/web/PlatformLayout.vue
Comment threadsrc_assets/common/assets/web/configs/tabs/Advanced.vue
Comment threadsrc_assets/common/assets/web/configs/tabs/Files.vue
Comment threadsrc_assets/common/assets/web/configs/tabs/Inputs.vue
@Hazer

Copy link
Copy Markdown
ContributorAuthor

@ReenigneArcher if any of the current open PR gets conflict with my changes, you can point to me for help, if needed.

@Hazer
Hazer requested a review from ReenigneArcherMay 13, 2024 14:23
Hazerand others added 11 commits May 13, 2024 10:54
Breaks that big chungus of a vue file into smaller readable vue files,
Also includes some QoL improvements, `$tp` for i18n `$t` but knows platforms,
`PlatformLayout` for slotted platform layout,
making it clearer what should load per platform and easier to add new as needed.
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
@ReenigneArcher
ReenigneArcherforce-pushed the refactor/big-chungus-expurgus branch from b810b45 to 92dfaa4CompareMay 13, 2024 14:54
@ReenigneArcher
ReenigneArcher merged commit 4b6ff37 into LizardByte:nightlyMay 13, 2024
@Hazer
Hazer deleted the refactor/big-chungus-expurgus branch May 13, 2024 18:59
@HazerHazer mentioned this pull request May 30, 2024
11 tasks
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
…2491)
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
c2vi pushed a commit to c2vi/Sunshine that referenced this pull request Mar 27, 2025
…2491)
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Hazer@ReenigneArcher
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

refactor(ui): break down config.html into smaller pieces - #2491

Merged
ReenigneArcher merged 11 commits into
LizardByte:nightlyfrom
Hazer:refactor/big-chungus-expurgus
May 13, 2024
Merged

refactor(ui): break down config.html into smaller pieces#2491
ReenigneArcher merged 11 commits into
LizardByte:nightlyfrom
Hazer:refactor/big-chungus-expurgus

Conversation

@Hazer

@HazerHazer commented May 2, 2024

Copy link
Copy Markdown
Contributor

Description

Breaks that big chungus of a vue file into smaller readable vue files, also includes some QoL improvements, $tp for i18n $t but knows platforms, PlatformLayout for slotted platform layout, making it clearer what should load per platform and easier to add new as needed, refactored some duplicated layouts using those new tools.

We can improve further by pushing more logic into each Component, instead of parsing and filtering data in config.html, but I wanted to avoid refactoring the load/save part in this PR.

PS: Fixed _common.*_cmd labels in General Tab.

Screenshot

No visual changes.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@HazerHazer mentioned this pull request May 2, 2024
9 tasks

@ReenigneArcherReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This is just my first pass review. I still need to review the bulk of the new files.

Comment thread.gitignore
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue Outdated
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue
Comment threadsrc_assets/common/assets/web/public/assets/locale/en.json Outdated
Comment threadsrc_assets/common/assets/web/platform-i18n.js Outdated
Comment threadsrc_assets/common/assets/web/index.html Outdated
@HazerHazer mentioned this pull request May 2, 2024
16 tasks
@Hazer
Hazerforce-pushed the refactor/big-chungus-expurgus branch from 4d3ffb6 to 3aa823cCompareMay 6, 2024 01:25
@Hazer
Hazer requested a review from ReenigneArcherMay 7, 2024 06:13

@ReenigneArcherReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not review every line in the new vue files. Hopefully things are in the same order as before and functionally equivalent, but once these couple of comments are addressed I will test the build and do a spot check.

Comment threadsrc_assets/common/assets/web/public/assets/locale/de.json
Comment threadsrc_assets/common/assets/web/platform-i18n.js
Comment threadsrc_assets/common/assets/web/configs/tabs/AudioVideo.vue Outdated
Comment threadsrc_assets/common/assets/web/PlatformLayout.vue Outdated
Comment threadsrc_assets/common/assets/web/configs/tabs/Advanced.vue
Comment threadsrc_assets/common/assets/web/platform-i18n.js
Comment threadsrc_assets/common/assets/web/configs/tabs/AudioVideo.vue Outdated
Comment threadsrc_assets/common/assets/web/configs/tabs/AudioVideo.vue Outdated
@Hazer
Hazer requested a review from ReenigneArcherMay 12, 2024 20:45
@codecov

codecovBot commented May 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.94%. Comparing base (81c2ecf) to head (92dfaa4).

Additional details and impacted files
@@ Coverage Diff @@## nightly #2491 +/- ##
=========================================
Coverage 6.94% 6.94% =========================================
Files 87 87 Lines 17673 17673 Branches 8399 8399 =========================================
Hits 1227 1227 - Misses 13717 15761 +2044 + Partials 2729 685 -2044 
FlagCoverage Δ
Linux5.34% <ø> (ø)
Windows2.56% <ø> (ø)
macOS-148.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes

@ReenigneArcherReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested your changes locally, and visually everything appears to be in place.

These will be my last changes to request.

Comment threadsrc_assets/common/assets/web/PlatformLayout.vue
Comment threadsrc_assets/common/assets/web/configs/tabs/Advanced.vue
Comment threadsrc_assets/common/assets/web/configs/tabs/Files.vue
Comment threadsrc_assets/common/assets/web/configs/tabs/Inputs.vue
@Hazer

Copy link
Copy Markdown
ContributorAuthor

@ReenigneArcher if any of the current open PR gets conflict with my changes, you can point to me for help, if needed.

@Hazer
Hazer requested a review from ReenigneArcherMay 13, 2024 14:23
Hazerand others added 11 commits May 13, 2024 10:54
Breaks that big chungus of a vue file into smaller readable vue files,
Also includes some QoL improvements, `$tp` for i18n `$t` but knows platforms,
`PlatformLayout` for slotted platform layout,
making it clearer what should load per platform and easier to add new as needed.
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
@ReenigneArcher
ReenigneArcherforce-pushed the refactor/big-chungus-expurgus branch from b810b45 to 92dfaa4CompareMay 13, 2024 14:54
@ReenigneArcher
ReenigneArcher merged commit 4b6ff37 into LizardByte:nightlyMay 13, 2024
@Hazer
Hazer deleted the refactor/big-chungus-expurgus branch May 13, 2024 18:59
@HazerHazer mentioned this pull request May 30, 2024
11 tasks
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
…2491)
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
c2vi pushed a commit to c2vi/Sunshine that referenced this pull request Mar 27, 2025
…2491)
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Hazer@ReenigneArcher