fix(linux): ensure NvFBC capture works after multiple sessions by insanemal · Pull Request #3020 · LizardByte/Sunshine

insanemal · 2024-08-15T15:01:05Z

Description

Please excuse the code. Basically I had a suspicion that the 'ctx_t' helper in the NvFBC code path was releasing the context early and that the exhaustion of session handles was causing the "can only reconnect 2-4 times" before it fails to reconnect bug. #2974

So I tried a dirty workaround of binding the context before destroying the session handle. And guess what, it works.

I also added some error logs around when it binds and unbinds the context to confirm my suspicions.

Really the whole code needs to be reworked to ensure the ctx_t class remains in scope correctly. But that's a little above my skill level.

Issues Fixed or Closed

Fixes#2974

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

CLAassistant · 2024-08-15T15:01:15Z

All committers have signed the CLA.

ns6089 · 2024-08-15T16:42:26Z

It ain't stupid if it works.
Just remove needless log lines and we should be able to merge this.

insanemal · 2024-08-16T00:02:59Z

Ok Done.

Dirty hack testing

fixup dirty hack to actually compile

One last try at this horrible hack

Dirty debuging

No idea let's try this

Remove log lines as fix works

sonarqubecloud · 2024-08-16T00:16:51Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov · 2024-08-16T00:33:11Z

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 9.69%. Comparing base (a669b36) to head (8d7742c).
Report is 137 commits behind head on master.

Files with missing lines	Patch %	Lines
src/platform/linux/cuda.cpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #3020 +/- ##
=========================================
- Coverage 9.69% 9.69% -0.01% 
=========================================
Files 97 97 Lines 17524 17525 +1 Branches 8204 8204 =========================================
Hits 1699 1699 - Misses 12987 12988 +1 
Partials 2838 2838

Flag	Coverage Δ
Linux	`7.20% <0.00%> (-0.01%)`	⬇️
Windows	`5.11% <ø> (ø)`
macOS-12	`10.35% <ø> (ø)`
macOS-13	`10.27% <ø> (+0.01%)`	⬆️
macOS-14	`10.58% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/platform/linux/cuda.cpp	`1.59% <0.00%> (-0.01%)`	⬇️

…dByte#3020)

insanemal · 2024-08-15T15:01:05Z

Description

Please excuse the code. Basically I had a suspicion that the 'ctx_t' helper in the NvFBC code path was releasing the context early and that the exhaustion of session handles was causing the "can only reconnect 2-4 times" before it fails to reconnect bug. #2974

So I tried a dirty workaround of binding the context before destroying the session handle. And guess what, it works.

I also added some error logs around when it binds and unbinds the context to confirm my suspicions.

Really the whole code needs to be reworked to ensure the ctx_t class remains in scope correctly. But that's a little above my skill level.

Issues Fixed or Closed

Fixes#2974

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

CLAassistant · 2024-08-15T15:01:15Z

All committers have signed the CLA.

ns6089 · 2024-08-15T16:42:26Z

It ain't stupid if it works.
Just remove needless log lines and we should be able to merge this.

insanemal · 2024-08-16T00:02:59Z

Ok Done.

Dirty hack testing

fixup dirty hack to actually compile

One last try at this horrible hack

Dirty debuging

No idea let's try this

Remove log lines as fix works

sonarqubecloud · 2024-08-16T00:16:51Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov · 2024-08-16T00:33:11Z

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 9.69%. Comparing base (a669b36) to head (8d7742c).
Report is 137 commits behind head on master.

Files with missing lines	Patch %	Lines
src/platform/linux/cuda.cpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #3020 +/- ##
=========================================
- Coverage 9.69% 9.69% -0.01% 
=========================================
Files 97 97 Lines 17524 17525 +1 Branches 8204 8204 =========================================
Hits 1699 1699 - Misses 12987 12988 +1 
Partials 2838 2838

Flag	Coverage Δ
Linux	`7.20% <0.00%> (-0.01%)`	⬇️
Windows	`5.11% <ø> (ø)`
macOS-12	`10.35% <ø> (ø)`
macOS-13	`10.27% <ø> (+0.01%)`	⬆️
macOS-14	`10.58% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/platform/linux/cuda.cpp	`1.59% <0.00%> (-0.01%)`	⬇️

…dByte#3020)

insanemal · 2024-08-15T15:01:05Z

Description

Please excuse the code. Basically I had a suspicion that the 'ctx_t' helper in the NvFBC code path was releasing the context early and that the exhaustion of session handles was causing the "can only reconnect 2-4 times" before it fails to reconnect bug. #2974

So I tried a dirty workaround of binding the context before destroying the session handle. And guess what, it works.

I also added some error logs around when it binds and unbinds the context to confirm my suspicions.

Really the whole code needs to be reworked to ensure the ctx_t class remains in scope correctly. But that's a little above my skill level.

Issues Fixed or Closed

Fixes#2974

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

CLAassistant · 2024-08-15T15:01:15Z

All committers have signed the CLA.

ns6089 · 2024-08-15T16:42:26Z

It ain't stupid if it works.
Just remove needless log lines and we should be able to merge this.

insanemal · 2024-08-16T00:02:59Z

Ok Done.

Dirty hack testing

fixup dirty hack to actually compile

One last try at this horrible hack

Dirty debuging

No idea let's try this

Remove log lines as fix works

sonarqubecloud · 2024-08-16T00:16:51Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov · 2024-08-16T00:33:11Z

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 9.69%. Comparing base (a669b36) to head (8d7742c).
Report is 137 commits behind head on master.

Files with missing lines	Patch %	Lines
src/platform/linux/cuda.cpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #3020 +/- ##
=========================================
- Coverage 9.69% 9.69% -0.01% 
=========================================
Files 97 97 Lines 17524 17525 +1 Branches 8204 8204 =========================================
Hits 1699 1699 - Misses 12987 12988 +1 
Partials 2838 2838

Flag	Coverage Δ
Linux	`7.20% <0.00%> (-0.01%)`	⬇️
Windows	`5.11% <ø> (ø)`
macOS-12	`10.35% <ø> (ø)`
macOS-13	`10.27% <ø> (+0.01%)`	⬆️
macOS-14	`10.58% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/platform/linux/cuda.cpp	`1.59% <0.00%> (-0.01%)`	⬇️

…dByte#3020)

insanemal · 2024-08-15T15:01:05Z

Description

Please excuse the code. Basically I had a suspicion that the 'ctx_t' helper in the NvFBC code path was releasing the context early and that the exhaustion of session handles was causing the "can only reconnect 2-4 times" before it fails to reconnect bug. #2974

So I tried a dirty workaround of binding the context before destroying the session handle. And guess what, it works.

I also added some error logs around when it binds and unbinds the context to confirm my suspicions.

Really the whole code needs to be reworked to ensure the ctx_t class remains in scope correctly. But that's a little above my skill level.

Issues Fixed or Closed

Fixes#2974

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

CLAassistant · 2024-08-15T15:01:15Z

All committers have signed the CLA.

ns6089 · 2024-08-15T16:42:26Z

It ain't stupid if it works.
Just remove needless log lines and we should be able to merge this.

insanemal · 2024-08-16T00:02:59Z

Ok Done.

Dirty hack testing

fixup dirty hack to actually compile

One last try at this horrible hack

Dirty debuging

No idea let's try this

Remove log lines as fix works

sonarqubecloud · 2024-08-16T00:16:51Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov · 2024-08-16T00:33:11Z

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 9.69%. Comparing base (a669b36) to head (8d7742c).
Report is 137 commits behind head on master.

Files with missing lines	Patch %	Lines
src/platform/linux/cuda.cpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #3020 +/- ##
=========================================
- Coverage 9.69% 9.69% -0.01% 
=========================================
Files 97 97 Lines 17524 17525 +1 Branches 8204 8204 =========================================
Hits 1699 1699 - Misses 12987 12988 +1 
Partials 2838 2838

Flag	Coverage Δ
Linux	`7.20% <0.00%> (-0.01%)`	⬇️
Windows	`5.11% <ø> (ø)`
macOS-12	`10.35% <ø> (ø)`
macOS-13	`10.27% <ø> (+0.01%)`	⬆️
macOS-14	`10.58% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/platform/linux/cuda.cpp	`1.59% <0.00%> (-0.01%)`	⬇️

…dByte#3020)

insanemal · 2024-08-15T15:01:05Z

Description

Please excuse the code. Basically I had a suspicion that the 'ctx_t' helper in the NvFBC code path was releasing the context early and that the exhaustion of session handles was causing the "can only reconnect 2-4 times" before it fails to reconnect bug. #2974

So I tried a dirty workaround of binding the context before destroying the session handle. And guess what, it works.

I also added some error logs around when it binds and unbinds the context to confirm my suspicions.

Really the whole code needs to be reworked to ensure the ctx_t class remains in scope correctly. But that's a little above my skill level.

Issues Fixed or Closed

Fixes#2974

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

CLAassistant · 2024-08-15T15:01:15Z

All committers have signed the CLA.

ns6089 · 2024-08-15T16:42:26Z

It ain't stupid if it works.
Just remove needless log lines and we should be able to merge this.

insanemal · 2024-08-16T00:02:59Z

Ok Done.

Dirty hack testing

fixup dirty hack to actually compile

One last try at this horrible hack

Dirty debuging

No idea let's try this

Remove log lines as fix works

sonarqubecloud · 2024-08-16T00:16:51Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov · 2024-08-16T00:33:11Z

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 9.69%. Comparing base (a669b36) to head (8d7742c).
Report is 137 commits behind head on master.

Files with missing lines	Patch %	Lines
src/platform/linux/cuda.cpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #3020 +/- ##
=========================================
- Coverage 9.69% 9.69% -0.01% 
=========================================
Files 97 97 Lines 17524 17525 +1 Branches 8204 8204 =========================================
Hits 1699 1699 - Misses 12987 12988 +1 
Partials 2838 2838

Flag	Coverage Δ
Linux	`7.20% <0.00%> (-0.01%)`	⬇️
Windows	`5.11% <ø> (ø)`
macOS-12	`10.35% <ø> (ø)`
macOS-13	`10.27% <ø> (+0.01%)`	⬆️
macOS-14	`10.58% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/platform/linux/cuda.cpp	`1.59% <0.00%> (-0.01%)`	⬇️

…dByte#3020)

insanemal · 2024-08-15T15:01:05Z

Description

Please excuse the code. Basically I had a suspicion that the 'ctx_t' helper in the NvFBC code path was releasing the context early and that the exhaustion of session handles was causing the "can only reconnect 2-4 times" before it fails to reconnect bug. #2974

So I tried a dirty workaround of binding the context before destroying the session handle. And guess what, it works.

I also added some error logs around when it binds and unbinds the context to confirm my suspicions.

Really the whole code needs to be reworked to ensure the ctx_t class remains in scope correctly. But that's a little above my skill level.

Issues Fixed or Closed

Fixes#2974

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

CLAassistant · 2024-08-15T15:01:15Z

All committers have signed the CLA.

ns6089 · 2024-08-15T16:42:26Z

It ain't stupid if it works.
Just remove needless log lines and we should be able to merge this.

insanemal · 2024-08-16T00:02:59Z

Ok Done.

Dirty hack testing

fixup dirty hack to actually compile

One last try at this horrible hack

Dirty debuging

No idea let's try this

Remove log lines as fix works

sonarqubecloud · 2024-08-16T00:16:51Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov · 2024-08-16T00:33:11Z

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 9.69%. Comparing base (a669b36) to head (8d7742c).
Report is 137 commits behind head on master.

Files with missing lines	Patch %	Lines
src/platform/linux/cuda.cpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #3020 +/- ##
=========================================
- Coverage 9.69% 9.69% -0.01% 
=========================================
Files 97 97 Lines 17524 17525 +1 Branches 8204 8204 =========================================
Hits 1699 1699 - Misses 12987 12988 +1 
Partials 2838 2838

Flag	Coverage Δ
Linux	`7.20% <0.00%> (-0.01%)`	⬇️
Windows	`5.11% <ø> (ø)`
macOS-12	`10.35% <ø> (ø)`
macOS-13	`10.27% <ø> (+0.01%)`	⬆️
macOS-14	`10.58% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/platform/linux/cuda.cpp	`1.59% <0.00%> (-0.01%)`	⬇️

…dByte#3020)

insanemal · 2024-08-15T15:01:05Z

Description

Please excuse the code. Basically I had a suspicion that the 'ctx_t' helper in the NvFBC code path was releasing the context early and that the exhaustion of session handles was causing the "can only reconnect 2-4 times" before it fails to reconnect bug. #2974

So I tried a dirty workaround of binding the context before destroying the session handle. And guess what, it works.

I also added some error logs around when it binds and unbinds the context to confirm my suspicions.

Really the whole code needs to be reworked to ensure the ctx_t class remains in scope correctly. But that's a little above my skill level.

Issues Fixed or Closed

Fixes#2974

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

CLAassistant · 2024-08-15T15:01:15Z

All committers have signed the CLA.

ns6089 · 2024-08-15T16:42:26Z

It ain't stupid if it works.
Just remove needless log lines and we should be able to merge this.

insanemal · 2024-08-16T00:02:59Z

Ok Done.

Dirty hack testing

fixup dirty hack to actually compile

One last try at this horrible hack

Dirty debuging

No idea let's try this

Remove log lines as fix works

sonarqubecloud · 2024-08-16T00:16:51Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov · 2024-08-16T00:33:11Z

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 9.69%. Comparing base (a669b36) to head (8d7742c).
Report is 137 commits behind head on master.

Files with missing lines	Patch %	Lines
src/platform/linux/cuda.cpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #3020 +/- ##
=========================================
- Coverage 9.69% 9.69% -0.01% 
=========================================
Files 97 97 Lines 17524 17525 +1 Branches 8204 8204 =========================================
Hits 1699 1699 - Misses 12987 12988 +1 
Partials 2838 2838

Flag	Coverage Δ
Linux	`7.20% <0.00%> (-0.01%)`	⬇️
Windows	`5.11% <ø> (ø)`
macOS-12	`10.35% <ø> (ø)`
macOS-13	`10.27% <ø> (+0.01%)`	⬆️
macOS-14	`10.58% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/platform/linux/cuda.cpp	`1.59% <0.00%> (-0.01%)`	⬇️

…dByte#3020)

insanemal · 2024-08-15T15:01:05Z

Description

Please excuse the code. Basically I had a suspicion that the 'ctx_t' helper in the NvFBC code path was releasing the context early and that the exhaustion of session handles was causing the "can only reconnect 2-4 times" before it fails to reconnect bug. #2974

So I tried a dirty workaround of binding the context before destroying the session handle. And guess what, it works.

I also added some error logs around when it binds and unbinds the context to confirm my suspicions.

Really the whole code needs to be reworked to ensure the ctx_t class remains in scope correctly. But that's a little above my skill level.

Issues Fixed or Closed

Fixes#2974

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

CLAassistant · 2024-08-15T15:01:15Z

All committers have signed the CLA.

ns6089 · 2024-08-15T16:42:26Z

It ain't stupid if it works.
Just remove needless log lines and we should be able to merge this.

insanemal · 2024-08-16T00:02:59Z

Ok Done.

Dirty hack testing

fixup dirty hack to actually compile

One last try at this horrible hack

Dirty debuging

No idea let's try this

Remove log lines as fix works

sonarqubecloud · 2024-08-16T00:16:51Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov · 2024-08-16T00:33:11Z

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 9.69%. Comparing base (a669b36) to head (8d7742c).
Report is 137 commits behind head on master.

Files with missing lines	Patch %	Lines
src/platform/linux/cuda.cpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #3020 +/- ##
=========================================
- Coverage 9.69% 9.69% -0.01% 
=========================================
Files 97 97 Lines 17524 17525 +1 Branches 8204 8204 =========================================
Hits 1699 1699 - Misses 12987 12988 +1 
Partials 2838 2838

Flag	Coverage Δ
Linux	`7.20% <0.00%> (-0.01%)`	⬇️
Windows	`5.11% <ø> (ø)`
macOS-12	`10.35% <ø> (ø)`
macOS-13	`10.27% <ø> (+0.01%)`	⬆️
macOS-14	`10.58% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/platform/linux/cuda.cpp	`1.59% <0.00%> (-0.01%)`	⬇️

…dByte#3020)

ReenigneArcher reviewed Aug 16, 2024
View reviewed changes

Comment threadsrc/platform/linux/cuda.cpp Outdated
Comment threadsrc/platform/linux/cuda.cpp Outdated

ReenigneArcher changed the title ~~Dirty workaround for NvFBC issues on linux~~fix(linux): ensure NvFBC capture works after multiple sessionsAug 16, 2024

insanemaland others added 7 commits August 15, 2024 20:07

Update cuda.cpp
eb7759f
Dirty hack testing

Whoops this is C++....
603c57f
fixup dirty hack to actually compile

Update cuda.cpp
bb41611
One last try at this horrible hack

Update cuda.cpp
9ec1ec7
Dirty debuging

Update cuda.cpp
d171904
No idea let's try this

Update cuda.cpp
ab04ee0
Remove log lines as fix works

Apply suggestions from code review
8d7742c

ReenigneArcher force-pushed the master branch from 9ad5eab to 8d7742cCompare August 16, 2024 00:07

ReenigneArcher merged commit c246c78 into LizardByte:masterAug 16, 2024

KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Oct 9, 2024
fix(linux): ensure NvFBC capture works after multiple sessions (Lizar…
88f8a92
…dByte#3020)

ReenigneArcher mentioned this pull request Jan 22, 2025
chore: Update dev.lizardbyte.app.Sunshine to v2025.122.141614 flathub/dev.lizardbyte.app.Sunshine#185
Merged

c2vi pushed a commit to c2vi/Sunshine that referenced this pull request Mar 27, 2025
fix(linux): ensure NvFBC capture works after multiple sessions (Lizar…
4b4396f
…dByte#3020)

Nonary pushed a commit to Nonary/vibeshine that referenced this pull request Oct 3, 2025
fix(linux): ensure NvFBC capture works after multiple sessions (Lizar…
7b74db3
…dByte#3020)