fix(mdns): don't hardcode mDNS instance name by cgutman · Pull Request #3084 · LizardByte/Sunshine

cgutman · 2024-08-25T00:48:04Z

Description

All platform mDNS implemenations currently hardcode the instance name to Sunshine. This causes reliable name collisions during mDNS registration when more than one Sunshine host is running on the same network. The collision is eventually resolved by appending a number to the name, but this is unnecessary work and delay for nothing. We should just register using our hostname as the instance name most other mDNS services do.

Screenshot

Issues Fixed or Closed

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

ReenigneArcher · 2024-08-25T00:59:31Z

+ */
+ std::string
+ mdns_instance_name() {
+ std::string hostname = boost::asio::ip::host_name();


If this became an argument for the function, the unit testing could be parametrized with various hostnames to check if it will work for all the scenarios provided.

Added in the latest commit.

codecov · 2024-08-25T01:11:45Z

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 9.54%. Comparing base (f048510) to head (a7b43d3).
Report is 116 commits behind head on master.

Files with missing lines	Patch %	Lines
src/platform/windows/publish.cpp	0.00%	3 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #3084 +/- ##
=========================================
- Coverage 9.66% 9.54% -0.13% 
=========================================
Files 101 77 -24 Lines 17942 14040 -3902 Branches 8381 6442 -1939 =========================================
- Hits 1734 1340 -394 + Misses 13328 10082 -3246 + Partials 2880 2618 -262

Flag	Coverage Δ
Linux	`?`
Windows	`5.08% <78.57%> (+0.08%)`	⬆️
macOS-12	`10.46% <63.63%> (+0.04%)`	⬆️
macOS-13	`10.37% <63.63%> (+0.04%)`	⬆️
macOS-14	`10.68% <63.63%> (+0.06%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/network.cpp	`24.56% <100.00%> (+8.87%)`	⬆️
src/network.h	`0.00% <ø> (ø)`
src/platform/macos/publish.cpp	`5.12% <ø> (-2.57%)`	⬇️
src/platform/windows/publish.cpp	`0.00% <0.00%> (ø)`

... and 54 files with indirect coverage changes

---- 🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

Hazer · 2024-08-25T05:06:42Z

 0, // flags
 0, // interfaceIndex
- SERVICE_NAME, SERVICE_TYPE,
+ nullptr, // name


Since you're giving it a nullptr, it won't use net::mdns_instance_name() for macOS at all, and the tests aren't useful for macOS right?

Correct, the function is unused on macOS.

sonarqubecloud · 2024-08-25T22:06:15Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

cgutman · 2024-08-25T00:48:04Z

Description

All platform mDNS implemenations currently hardcode the instance name to Sunshine. This causes reliable name collisions during mDNS registration when more than one Sunshine host is running on the same network. The collision is eventually resolved by appending a number to the name, but this is unnecessary work and delay for nothing. We should just register using our hostname as the instance name most other mDNS services do.

Screenshot

Issues Fixed or Closed

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

ReenigneArcher · 2024-08-25T00:59:31Z

+ */
+ std::string
+ mdns_instance_name() {
+ std::string hostname = boost::asio::ip::host_name();


If this became an argument for the function, the unit testing could be parametrized with various hostnames to check if it will work for all the scenarios provided.

Added in the latest commit.

codecov · 2024-08-25T01:11:45Z

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 9.54%. Comparing base (f048510) to head (a7b43d3).
Report is 116 commits behind head on master.

Files with missing lines	Patch %	Lines
src/platform/windows/publish.cpp	0.00%	3 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #3084 +/- ##
=========================================
- Coverage 9.66% 9.54% -0.13% 
=========================================
Files 101 77 -24 Lines 17942 14040 -3902 Branches 8381 6442 -1939 =========================================
- Hits 1734 1340 -394 + Misses 13328 10082 -3246 + Partials 2880 2618 -262

Flag	Coverage Δ
Linux	`?`
Windows	`5.08% <78.57%> (+0.08%)`	⬆️
macOS-12	`10.46% <63.63%> (+0.04%)`	⬆️
macOS-13	`10.37% <63.63%> (+0.04%)`	⬆️
macOS-14	`10.68% <63.63%> (+0.06%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/network.cpp	`24.56% <100.00%> (+8.87%)`	⬆️
src/network.h	`0.00% <ø> (ø)`
src/platform/macos/publish.cpp	`5.12% <ø> (-2.57%)`	⬇️
src/platform/windows/publish.cpp	`0.00% <0.00%> (ø)`

... and 54 files with indirect coverage changes

---- 🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

Hazer · 2024-08-25T05:06:42Z

 0, // flags
 0, // interfaceIndex
- SERVICE_NAME, SERVICE_TYPE,
+ nullptr, // name


Since you're giving it a nullptr, it won't use net::mdns_instance_name() for macOS at all, and the tests aren't useful for macOS right?

Correct, the function is unused on macOS.

sonarqubecloud · 2024-08-25T22:06:15Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

cgutman · 2024-08-25T00:48:04Z

Description

All platform mDNS implemenations currently hardcode the instance name to Sunshine. This causes reliable name collisions during mDNS registration when more than one Sunshine host is running on the same network. The collision is eventually resolved by appending a number to the name, but this is unnecessary work and delay for nothing. We should just register using our hostname as the instance name most other mDNS services do.

Screenshot

Issues Fixed or Closed

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

ReenigneArcher · 2024-08-25T00:59:31Z

+ */
+ std::string
+ mdns_instance_name() {
+ std::string hostname = boost::asio::ip::host_name();


If this became an argument for the function, the unit testing could be parametrized with various hostnames to check if it will work for all the scenarios provided.

Added in the latest commit.

codecov · 2024-08-25T01:11:45Z

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 9.54%. Comparing base (f048510) to head (a7b43d3).
Report is 116 commits behind head on master.

Files with missing lines	Patch %	Lines
src/platform/windows/publish.cpp	0.00%	3 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #3084 +/- ##
=========================================
- Coverage 9.66% 9.54% -0.13% 
=========================================
Files 101 77 -24 Lines 17942 14040 -3902 Branches 8381 6442 -1939 =========================================
- Hits 1734 1340 -394 + Misses 13328 10082 -3246 + Partials 2880 2618 -262

Flag	Coverage Δ
Linux	`?`
Windows	`5.08% <78.57%> (+0.08%)`	⬆️
macOS-12	`10.46% <63.63%> (+0.04%)`	⬆️
macOS-13	`10.37% <63.63%> (+0.04%)`	⬆️
macOS-14	`10.68% <63.63%> (+0.06%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/network.cpp	`24.56% <100.00%> (+8.87%)`	⬆️
src/network.h	`0.00% <ø> (ø)`
src/platform/macos/publish.cpp	`5.12% <ø> (-2.57%)`	⬇️
src/platform/windows/publish.cpp	`0.00% <0.00%> (ø)`

... and 54 files with indirect coverage changes

---- 🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

Hazer · 2024-08-25T05:06:42Z

 0, // flags
 0, // interfaceIndex
- SERVICE_NAME, SERVICE_TYPE,
+ nullptr, // name


Since you're giving it a nullptr, it won't use net::mdns_instance_name() for macOS at all, and the tests aren't useful for macOS right?

Correct, the function is unused on macOS.

sonarqubecloud · 2024-08-25T22:06:15Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

cgutman · 2024-08-25T00:48:04Z

Description

All platform mDNS implemenations currently hardcode the instance name to Sunshine. This causes reliable name collisions during mDNS registration when more than one Sunshine host is running on the same network. The collision is eventually resolved by appending a number to the name, but this is unnecessary work and delay for nothing. We should just register using our hostname as the instance name most other mDNS services do.

Screenshot

Issues Fixed or Closed

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

ReenigneArcher · 2024-08-25T00:59:31Z

+ */
+ std::string
+ mdns_instance_name() {
+ std::string hostname = boost::asio::ip::host_name();


If this became an argument for the function, the unit testing could be parametrized with various hostnames to check if it will work for all the scenarios provided.

Added in the latest commit.

codecov · 2024-08-25T01:11:45Z

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 9.54%. Comparing base (f048510) to head (a7b43d3).
Report is 116 commits behind head on master.

Files with missing lines	Patch %	Lines
src/platform/windows/publish.cpp	0.00%	3 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #3084 +/- ##
=========================================
- Coverage 9.66% 9.54% -0.13% 
=========================================
Files 101 77 -24 Lines 17942 14040 -3902 Branches 8381 6442 -1939 =========================================
- Hits 1734 1340 -394 + Misses 13328 10082 -3246 + Partials 2880 2618 -262

Flag	Coverage Δ
Linux	`?`
Windows	`5.08% <78.57%> (+0.08%)`	⬆️
macOS-12	`10.46% <63.63%> (+0.04%)`	⬆️
macOS-13	`10.37% <63.63%> (+0.04%)`	⬆️
macOS-14	`10.68% <63.63%> (+0.06%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/network.cpp	`24.56% <100.00%> (+8.87%)`	⬆️
src/network.h	`0.00% <ø> (ø)`
src/platform/macos/publish.cpp	`5.12% <ø> (-2.57%)`	⬇️
src/platform/windows/publish.cpp	`0.00% <0.00%> (ø)`

... and 54 files with indirect coverage changes

---- 🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

Hazer · 2024-08-25T05:06:42Z

 0, // flags
 0, // interfaceIndex
- SERVICE_NAME, SERVICE_TYPE,
+ nullptr, // name


Since you're giving it a nullptr, it won't use net::mdns_instance_name() for macOS at all, and the tests aren't useful for macOS right?

Correct, the function is unused on macOS.

sonarqubecloud · 2024-08-25T22:06:15Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

cgutman · 2024-08-25T00:48:04Z

Description

All platform mDNS implemenations currently hardcode the instance name to Sunshine. This causes reliable name collisions during mDNS registration when more than one Sunshine host is running on the same network. The collision is eventually resolved by appending a number to the name, but this is unnecessary work and delay for nothing. We should just register using our hostname as the instance name most other mDNS services do.

Screenshot

Issues Fixed or Closed

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

ReenigneArcher · 2024-08-25T00:59:31Z

+ */
+ std::string
+ mdns_instance_name() {
+ std::string hostname = boost::asio::ip::host_name();


If this became an argument for the function, the unit testing could be parametrized with various hostnames to check if it will work for all the scenarios provided.

Added in the latest commit.

codecov · 2024-08-25T01:11:45Z

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 9.54%. Comparing base (f048510) to head (a7b43d3).
Report is 116 commits behind head on master.

Files with missing lines	Patch %	Lines
src/platform/windows/publish.cpp	0.00%	3 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #3084 +/- ##
=========================================
- Coverage 9.66% 9.54% -0.13% 
=========================================
Files 101 77 -24 Lines 17942 14040 -3902 Branches 8381 6442 -1939 =========================================
- Hits 1734 1340 -394 + Misses 13328 10082 -3246 + Partials 2880 2618 -262

Flag	Coverage Δ
Linux	`?`
Windows	`5.08% <78.57%> (+0.08%)`	⬆️
macOS-12	`10.46% <63.63%> (+0.04%)`	⬆️
macOS-13	`10.37% <63.63%> (+0.04%)`	⬆️
macOS-14	`10.68% <63.63%> (+0.06%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/network.cpp	`24.56% <100.00%> (+8.87%)`	⬆️
src/network.h	`0.00% <ø> (ø)`
src/platform/macos/publish.cpp	`5.12% <ø> (-2.57%)`	⬇️
src/platform/windows/publish.cpp	`0.00% <0.00%> (ø)`

... and 54 files with indirect coverage changes

---- 🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

Hazer · 2024-08-25T05:06:42Z

 0, // flags
 0, // interfaceIndex
- SERVICE_NAME, SERVICE_TYPE,
+ nullptr, // name


Since you're giving it a nullptr, it won't use net::mdns_instance_name() for macOS at all, and the tests aren't useful for macOS right?

Correct, the function is unused on macOS.

sonarqubecloud · 2024-08-25T22:06:15Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

cgutman · 2024-08-25T00:48:04Z

Description

All platform mDNS implemenations currently hardcode the instance name to Sunshine. This causes reliable name collisions during mDNS registration when more than one Sunshine host is running on the same network. The collision is eventually resolved by appending a number to the name, but this is unnecessary work and delay for nothing. We should just register using our hostname as the instance name most other mDNS services do.

Screenshot

Issues Fixed or Closed

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

ReenigneArcher · 2024-08-25T00:59:31Z

+ */
+ std::string
+ mdns_instance_name() {
+ std::string hostname = boost::asio::ip::host_name();


If this became an argument for the function, the unit testing could be parametrized with various hostnames to check if it will work for all the scenarios provided.

Added in the latest commit.

codecov · 2024-08-25T01:11:45Z

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 9.54%. Comparing base (f048510) to head (a7b43d3).
Report is 116 commits behind head on master.

Files with missing lines	Patch %	Lines
src/platform/windows/publish.cpp	0.00%	3 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #3084 +/- ##
=========================================
- Coverage 9.66% 9.54% -0.13% 
=========================================
Files 101 77 -24 Lines 17942 14040 -3902 Branches 8381 6442 -1939 =========================================
- Hits 1734 1340 -394 + Misses 13328 10082 -3246 + Partials 2880 2618 -262

Flag	Coverage Δ
Linux	`?`
Windows	`5.08% <78.57%> (+0.08%)`	⬆️
macOS-12	`10.46% <63.63%> (+0.04%)`	⬆️
macOS-13	`10.37% <63.63%> (+0.04%)`	⬆️
macOS-14	`10.68% <63.63%> (+0.06%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/network.cpp	`24.56% <100.00%> (+8.87%)`	⬆️
src/network.h	`0.00% <ø> (ø)`
src/platform/macos/publish.cpp	`5.12% <ø> (-2.57%)`	⬇️
src/platform/windows/publish.cpp	`0.00% <0.00%> (ø)`

... and 54 files with indirect coverage changes

---- 🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

Hazer · 2024-08-25T05:06:42Z

 0, // flags
 0, // interfaceIndex
- SERVICE_NAME, SERVICE_TYPE,
+ nullptr, // name


Since you're giving it a nullptr, it won't use net::mdns_instance_name() for macOS at all, and the tests aren't useful for macOS right?

Correct, the function is unused on macOS.

sonarqubecloud · 2024-08-25T22:06:15Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

cgutman · 2024-08-25T00:48:04Z

Description

All platform mDNS implemenations currently hardcode the instance name to Sunshine. This causes reliable name collisions during mDNS registration when more than one Sunshine host is running on the same network. The collision is eventually resolved by appending a number to the name, but this is unnecessary work and delay for nothing. We should just register using our hostname as the instance name most other mDNS services do.

Screenshot

Issues Fixed or Closed

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

ReenigneArcher · 2024-08-25T00:59:31Z

+ */
+ std::string
+ mdns_instance_name() {
+ std::string hostname = boost::asio::ip::host_name();


If this became an argument for the function, the unit testing could be parametrized with various hostnames to check if it will work for all the scenarios provided.

Added in the latest commit.

codecov · 2024-08-25T01:11:45Z

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 9.54%. Comparing base (f048510) to head (a7b43d3).
Report is 116 commits behind head on master.

Files with missing lines	Patch %	Lines
src/platform/windows/publish.cpp	0.00%	3 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #3084 +/- ##
=========================================
- Coverage 9.66% 9.54% -0.13% 
=========================================
Files 101 77 -24 Lines 17942 14040 -3902 Branches 8381 6442 -1939 =========================================
- Hits 1734 1340 -394 + Misses 13328 10082 -3246 + Partials 2880 2618 -262

Flag	Coverage Δ
Linux	`?`
Windows	`5.08% <78.57%> (+0.08%)`	⬆️
macOS-12	`10.46% <63.63%> (+0.04%)`	⬆️
macOS-13	`10.37% <63.63%> (+0.04%)`	⬆️
macOS-14	`10.68% <63.63%> (+0.06%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/network.cpp	`24.56% <100.00%> (+8.87%)`	⬆️
src/network.h	`0.00% <ø> (ø)`
src/platform/macos/publish.cpp	`5.12% <ø> (-2.57%)`	⬇️
src/platform/windows/publish.cpp	`0.00% <0.00%> (ø)`

... and 54 files with indirect coverage changes

---- 🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

Hazer · 2024-08-25T05:06:42Z

 0, // flags
 0, // interfaceIndex
- SERVICE_NAME, SERVICE_TYPE,
+ nullptr, // name


Since you're giving it a nullptr, it won't use net::mdns_instance_name() for macOS at all, and the tests aren't useful for macOS right?

Correct, the function is unused on macOS.

sonarqubecloud · 2024-08-25T22:06:15Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

cgutman · 2024-08-25T00:48:04Z

Description

All platform mDNS implemenations currently hardcode the instance name to Sunshine. This causes reliable name collisions during mDNS registration when more than one Sunshine host is running on the same network. The collision is eventually resolved by appending a number to the name, but this is unnecessary work and delay for nothing. We should just register using our hostname as the instance name most other mDNS services do.

Screenshot

Issues Fixed or Closed

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

ReenigneArcher · 2024-08-25T00:59:31Z

+ */
+ std::string
+ mdns_instance_name() {
+ std::string hostname = boost::asio::ip::host_name();


If this became an argument for the function, the unit testing could be parametrized with various hostnames to check if it will work for all the scenarios provided.

Added in the latest commit.

codecov · 2024-08-25T01:11:45Z

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 9.54%. Comparing base (f048510) to head (a7b43d3).
Report is 116 commits behind head on master.

Files with missing lines	Patch %	Lines
src/platform/windows/publish.cpp	0.00%	3 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## master #3084 +/- ##
=========================================
- Coverage 9.66% 9.54% -0.13% 
=========================================
Files 101 77 -24 Lines 17942 14040 -3902 Branches 8381 6442 -1939 =========================================
- Hits 1734 1340 -394 + Misses 13328 10082 -3246 + Partials 2880 2618 -262

Flag	Coverage Δ
Linux	`?`
Windows	`5.08% <78.57%> (+0.08%)`	⬆️
macOS-12	`10.46% <63.63%> (+0.04%)`	⬆️
macOS-13	`10.37% <63.63%> (+0.04%)`	⬆️
macOS-14	`10.68% <63.63%> (+0.06%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/network.cpp	`24.56% <100.00%> (+8.87%)`	⬆️
src/network.h	`0.00% <ø> (ø)`
src/platform/macos/publish.cpp	`5.12% <ø> (-2.57%)`	⬇️
src/platform/windows/publish.cpp	`0.00% <0.00%> (ø)`

... and 54 files with indirect coverage changes

---- 🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

Hazer · 2024-08-25T05:06:42Z

 0, // flags
 0, // interfaceIndex
- SERVICE_NAME, SERVICE_TYPE,
+ nullptr, // name


Since you're giving it a nullptr, it won't use net::mdns_instance_name() for macOS at all, and the tests aren't useful for macOS right?

Correct, the function is unused on macOS.

sonarqubecloud · 2024-08-25T22:06:15Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ReenigneArcher reviewed Aug 25, 2024
View reviewed changes

Hazer reviewed Aug 25, 2024
View reviewed changes

cgutman added 2 commits August 25, 2024 17:57

fix(mdns): don't hardcode mDNS instance name
b752aa2

Improve testability of new code
a7b43d3

ReenigneArcher force-pushed the unique_mdns_names branch from 87b5ede to a7b43d3Compare August 25, 2024 21:57

ReenigneArcher merged commit 88ce507 into LizardByte:masterAug 25, 2024

KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Oct 9, 2024
fix(mdns): don't hardcode mDNS instance name (LizardByte#3084)
9f6ebe6

ReenigneArcher mentioned this pull request Jan 22, 2025
chore: Update dev.lizardbyte.app.Sunshine to v2025.122.141614 flathub/dev.lizardbyte.app.Sunshine#185
Merged

c2vi pushed a commit to c2vi/Sunshine that referenced this pull request Mar 27, 2025
fix(mdns): don't hardcode mDNS instance name (LizardByte#3084)
97206df

ReenigneArcher reviewed Aug 25, 2024
View reviewed changes

Hazer reviewed Aug 25, 2024
View reviewed changes

cgutman added 2 commits August 25, 2024 17:57

fix(mdns): don't hardcode mDNS instance name
b752aa2

Improve testability of new code
a7b43d3

ReenigneArcher force-pushed the unique_mdns_names branch from 87b5ede to a7b43d3Compare August 25, 2024 21:57

ReenigneArcher merged commit 88ce507 into LizardByte:masterAug 25, 2024

KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Oct 9, 2024
fix(mdns): don't hardcode mDNS instance name (LizardByte#3084)
9f6ebe6

ReenigneArcher mentioned this pull request Jan 22, 2025
chore: Update dev.lizardbyte.app.Sunshine to v2025.122.141614 flathub/dev.lizardbyte.app.Sunshine#185
Merged

c2vi pushed a commit to c2vi/Sunshine that referenced this pull request Mar 27, 2025
fix(mdns): don't hardcode mDNS instance name (LizardByte#3084)
97206df

ReenigneArcher reviewed Aug 25, 2024
View reviewed changes

Hazer reviewed Aug 25, 2024
View reviewed changes

cgutman added 2 commits August 25, 2024 17:57

fix(mdns): don't hardcode mDNS instance name
b752aa2

Improve testability of new code
a7b43d3

ReenigneArcher force-pushed the unique_mdns_names branch from 87b5ede to a7b43d3Compare August 25, 2024 21:57

ReenigneArcher merged commit 88ce507 into LizardByte:masterAug 25, 2024

KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Oct 9, 2024
fix(mdns): don't hardcode mDNS instance name (LizardByte#3084)
9f6ebe6

ReenigneArcher mentioned this pull request Jan 22, 2025
chore: Update dev.lizardbyte.app.Sunshine to v2025.122.141614 flathub/dev.lizardbyte.app.Sunshine#185
Merged

c2vi pushed a commit to c2vi/Sunshine that referenced this pull request Mar 27, 2025
fix(mdns): don't hardcode mDNS instance name (LizardByte#3084)
97206df

ReenigneArcher reviewed Aug 25, 2024
View reviewed changes

Hazer reviewed Aug 25, 2024
View reviewed changes

cgutman added 2 commits August 25, 2024 17:57

fix(mdns): don't hardcode mDNS instance name
b752aa2

Improve testability of new code
a7b43d3

ReenigneArcher force-pushed the unique_mdns_names branch from 87b5ede to a7b43d3Compare August 25, 2024 21:57

ReenigneArcher merged commit 88ce507 into LizardByte:masterAug 25, 2024

KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Oct 9, 2024
fix(mdns): don't hardcode mDNS instance name (LizardByte#3084)
9f6ebe6

ReenigneArcher mentioned this pull request Jan 22, 2025
chore: Update dev.lizardbyte.app.Sunshine to v2025.122.141614 flathub/dev.lizardbyte.app.Sunshine#185
Merged

c2vi pushed a commit to c2vi/Sunshine that referenced this pull request Mar 27, 2025
fix(mdns): don't hardcode mDNS instance name (LizardByte#3084)
97206df

ReenigneArcher reviewed Aug 25, 2024
View reviewed changes

Hazer reviewed Aug 25, 2024
View reviewed changes

cgutman added 2 commits August 25, 2024 17:57

fix(mdns): don't hardcode mDNS instance name
b752aa2

Improve testability of new code
a7b43d3

ReenigneArcher force-pushed the unique_mdns_names branch from 87b5ede to a7b43d3Compare August 25, 2024 21:57

ReenigneArcher merged commit 88ce507 into LizardByte:masterAug 25, 2024

KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Oct 9, 2024
fix(mdns): don't hardcode mDNS instance name (LizardByte#3084)
9f6ebe6

ReenigneArcher mentioned this pull request Jan 22, 2025
chore: Update dev.lizardbyte.app.Sunshine to v2025.122.141614 flathub/dev.lizardbyte.app.Sunshine#185
Merged

c2vi pushed a commit to c2vi/Sunshine that referenced this pull request Mar 27, 2025
fix(mdns): don't hardcode mDNS instance name (LizardByte#3084)
97206df

ReenigneArcher reviewed Aug 25, 2024
View reviewed changes

Hazer reviewed Aug 25, 2024
View reviewed changes

cgutman added 2 commits August 25, 2024 17:57

fix(mdns): don't hardcode mDNS instance name
b752aa2

Improve testability of new code
a7b43d3

ReenigneArcher force-pushed the unique_mdns_names branch from 87b5ede to a7b43d3Compare August 25, 2024 21:57

ReenigneArcher merged commit 88ce507 into LizardByte:masterAug 25, 2024

KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Oct 9, 2024
fix(mdns): don't hardcode mDNS instance name (LizardByte#3084)
9f6ebe6

ReenigneArcher mentioned this pull request Jan 22, 2025
chore: Update dev.lizardbyte.app.Sunshine to v2025.122.141614 flathub/dev.lizardbyte.app.Sunshine#185
Merged

c2vi pushed a commit to c2vi/Sunshine that referenced this pull request Mar 27, 2025
fix(mdns): don't hardcode mDNS instance name (LizardByte#3084)
97206df

ReenigneArcher reviewed Aug 25, 2024
View reviewed changes

Hazer reviewed Aug 25, 2024
View reviewed changes

cgutman added 2 commits August 25, 2024 17:57

fix(mdns): don't hardcode mDNS instance name
b752aa2

Improve testability of new code
a7b43d3

ReenigneArcher force-pushed the unique_mdns_names branch from 87b5ede to a7b43d3Compare August 25, 2024 21:57

ReenigneArcher merged commit 88ce507 into LizardByte:masterAug 25, 2024

KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Oct 9, 2024
fix(mdns): don't hardcode mDNS instance name (LizardByte#3084)
9f6ebe6

ReenigneArcher mentioned this pull request Jan 22, 2025
chore: Update dev.lizardbyte.app.Sunshine to v2025.122.141614 flathub/dev.lizardbyte.app.Sunshine#185
Merged

c2vi pushed a commit to c2vi/Sunshine that referenced this pull request Mar 27, 2025
fix(mdns): don't hardcode mDNS instance name (LizardByte#3084)
97206df

ReenigneArcher reviewed Aug 25, 2024
View reviewed changes

Hazer reviewed Aug 25, 2024
View reviewed changes

cgutman added 2 commits August 25, 2024 17:57

fix(mdns): don't hardcode mDNS instance name
b752aa2

Improve testability of new code
a7b43d3

ReenigneArcher force-pushed the unique_mdns_names branch from 87b5ede to a7b43d3Compare August 25, 2024 21:57

ReenigneArcher merged commit 88ce507 into LizardByte:masterAug 25, 2024

KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Oct 9, 2024
fix(mdns): don't hardcode mDNS instance name (LizardByte#3084)
9f6ebe6

ReenigneArcher mentioned this pull request Jan 22, 2025
chore: Update dev.lizardbyte.app.Sunshine to v2025.122.141614 flathub/dev.lizardbyte.app.Sunshine#185
Merged

c2vi pushed a commit to c2vi/Sunshine that referenced this pull request Mar 27, 2025
fix(mdns): don't hardcode mDNS instance name (LizardByte#3084)
97206df

Uh oh!

Uh oh!

Conversation

cgutman commented Aug 25, 2024

Description

Screenshot

Issues Fixed or Closed

Type of Change

Checklist

Uh oh!

ReenigneArcherAug 25, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecovBot commented Aug 25, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloudBot commented Aug 25, 2024

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

cgutman commented Aug 25, 2024

Description

Screenshot

Issues Fixed or Closed

Type of Change

Checklist

Uh oh!

ReenigneArcherAug 25, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecovBot commented Aug 25, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloudBot commented Aug 25, 2024

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

cgutman commented Aug 25, 2024

Description

Screenshot

Issues Fixed or Closed

Type of Change

Checklist

Uh oh!

ReenigneArcherAug 25, 2024•
edited
Loading

codecovBot commented Aug 25, 2024•
edited
Loading

ReenigneArcherAug 25, 2024•
edited
Loading

codecovBot commented Aug 25, 2024•
edited
Loading

ReenigneArcherAug 25, 2024•
edited
Loading

codecovBot commented Aug 25, 2024•
edited
Loading

ReenigneArcherAug 25, 2024•
edited
Loading

codecovBot commented Aug 25, 2024•
edited
Loading