Uh oh!
There was an error while loading. Please reload this page.
fix(windows): resolve disappearing cursor after KVM switch - #4407
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Bundle ReportBundle size has no change ✅ |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## master #4407 +/- ##
=========================================
Coverage ? 15.41% =========================================
Files ? 93 Lines ? 19022 Branches ? 8769 =========================================
Hits ? 2933 Misses ? 14936 Partials ? 1153
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ReenigneArcher
previously approved these changes
Jan 8, 2026
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ReenigneArcher
approved these changes
Jan 16, 2026
Uh oh!
There was an error while loading. Please reload this page.
qiin2333 referenced
this pull request
in AlkaidLab/foundation-sunshine
Mar 25, 2026
qiin2333 referenced
this pull request
in AlkaidLab/foundation-sunshine
May 6, 2026
qiin2333 referenced
this pull request
in AlkaidLab/foundation-sunshine
May 6, 2026
* fix: DXGI adapter memory leak (upstream d3af56d, #4340) * fix: KVM cursor disappearing due to Mouse Keys (upstream fd2bfaa, #4407) * feat: continuous audio support (upstream fbcf211, #4261) * fix: clear tray icon when unpairing the last paired client (upstream d6bc76e3d, #4890) * fix(audio): close TOCTOU between has_audio_ctx_ref and get_audio_ctx_ref When the microphone redirect helpers do has_audio_ctx_ref() followed by get_audio_ctx_ref(), a release between the two calls would re-trigger start_audio_control() and attach mic ops to a brand-new isolated audio context. Add shared_t::try_ref() and audio::try_get_audio_ctx_ref() so init/release/write_mic_data acquire an existing reference atomically and never resurrect a stopped context. Reported-by: coderabbitai (PR #551 review) * fix(audio): satisfy mic-redirect virtual interface on Linux/macOS The upstream mic-redirect feature (init_mic_redirect_device, release_mic_redirect_device, write_mic_data, plus is_sink_available on macOS) declared four pure-virtual methods on audio_control_t but never provided overrides in the PulseAudio (Linux) or AVFoundation (macOS) backends. That left pa::server_t and macos_audio_control_t abstract, so std::make_unique<...>() in audio_control() failed to compile on both platforms (only the Windows backend builds today). Add minimal no-op stubs that return -1 / true / void as appropriate so the non-Windows targets build again. Mic redirect-to-host stays unimplemented on those platforms — wire-up can land later without re-touching every cross-platform site. Reported-by: coderabbitai (PR #551 review)
This was referenced May 16, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added continuous checks for a physical mouse while streaming rather than just at the start of streaming. This fix is intended for particular situations on the windows platform when using a KVM switch that changes the cursor from a hardware cursor to a virtual cursor causing windows to not detect a physical cursor while streaming.
Description
Changed the previous physical mouse checking:
// If there is no mouse connected, enable Mouse Keys to force the cursor to appearif (!GetSystemMetrics(SM_MOUSEPRESENT))...to it's own function
void enable_mouse_keys();. The function is still called at the end ofstreaming_will_start()and now invideo.cppto continuously check if a physical mouse is present.Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage