build(linux): Add Fedora 43 support to the build script

[craimasjien]

Description

Updated the linux build script to enable it to detect Fedora 43 as a valid build target.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

• feat: New feature (non-breaking change which adds functionality)
• fix: Bug fix (non-breaking change which fixes an issue)
• docs: Documentation only changes
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
• refactor: Code change that neither fixes a bug nor adds a feature
• perf: Code change that improves performance
• test: Adding missing tests or correcting existing tests
• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Other changes that don't modify src or test files
• revert: Reverts a previous commit
• BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

• Code follows the style guidelines of this project
• Code has been self-reviewed
• Code has been commented, particularly in hard-to-understand areas
• Code docstring/documentation-blocks for new or existing methods/components have been added or updated
• Unit tests have been added or updated for any new or modified functionality

AI Usage

• None: No AI tools were used in creating this PR
• Light: AI provided minor assistance (formatting, simple suggestions)
• Moderate: AI helped with code generation or debugging specific parts
• Heavy: AI generated most or all of the code changes

[craimasjien]

The script executed as expected after running it. I was able to build and compile sunshine just perfectly and install it using ninja.

sudo dnf install libstdc++-static
cmake -B build -G Ninja -S . -DSUNSHINE_ENABLE_CUDA=OFF
ninja -C build
sudo ninja install -C build/

I wanted to check with the maintainers whether they think making the libstdc++-static part of the linux build script, as it's required to be built but was missing after running the script.

Note: I disabled CUDA because I'm an AMD user by the way.

[craimasjien]

Can I also kindly request the maintainer of the Linux packaging to enable support for Fedora 43? I can't do this now as the packaging is done through Copr, and I obviously can not administrate that.

[ReenigneArcher]

Can I also kindly request the maintainer of the Linux packaging to enable support for Fedora 43? I can't do this now as the packaging is done through Copr, and I obviously can not administrate that.

It's enabled in the beta copr. It will be enabled in the stable the next time we create a release... But we are not going to align releases with any distro as that's too demanding on a small project.

[ReenigneArcher]

The script executed as expected after running it. I was able to build and compile sunshine just perfectly and install it using ninja.

sudo dnf install libstdc++-static
cmake -B build -G Ninja -S . -DSUNSHINE_ENABLE_CUDA=OFF
ninja -C build
sudo ninja install -C build/

I wanted to check with the maintainers whether they think making the libstdc++-static part of the linux build script, as it's required to be built but was missing after running the script.

Note: I disabled CUDA because I'm an AMD user by the way.

If you're asking if the package should be installed, I think it should.

We don't use this script anymore since we started using copr, so stuff may get missed from time to time.

[craimasjien]

The script executed as expected after running it. I was able to build and compile sunshine just perfectly and install it using ninja.

sudo dnf install libstdc++-static
cmake -B build -G Ninja -S . -DSUNSHINE_ENABLE_CUDA=OFF
ninja -C build
sudo ninja install -C build/

I wanted to check with the maintainers whether they think making the libstdc++-static part of the linux build script, as it's required to be built but was missing after running the script.
Note: I disabled CUDA because I'm an AMD user by the way.

If you're asking if the package should be installed, I think it should.

We don't use this script anymore since we started using copr, so stuff may get missed from time to time.

I can confirm the package does need to be installed, but I assumed the purpose of the script is to make the environment ready for building, meaning that package should probably be included.

But since you're not using the script anymore I'm not sure if you would want me to make it part of this PR, or have this PR exist in the first place.

The reason I went and changed the script is because there's no way for me to install Sunshine right now with the packages provided by the release on GitHub as that is missing a Fedora 43 build and the Fedora 42 build doesn't work.

[ReenigneArcher]

The reason I went and changed the script is because there's no way for me to install Sunshine right now with the packages provided by the release on GitHub as that is missing a Fedora 43 build and the Fedora 42 build doesn't work.

The PR is fine, we accept changes for the Fedora portion because some people self compile using this script.

For Fedora 43 support, you'll want to use our beta copr instead of our stable copr. I need to improve the docs to mention why this is, but they do tell you how to enable the beta copr. https://docs.lizardbyte.dev/projects/sunshine/latest/md_docs_2getting__started.html#fedora

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@8294ab2). Learn more about missing BASE report.
⚠️ Report is 202 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@## master #4532 +/- ##
=========================================
Coverage ? 15.45% =========================================
Files ? 93 Lines ? 19018 Branches ? 8768 =========================================
Hits ? 2939 Misses ? 14750 Partials ? 1329 

Flag	Coverage Δ
Archlinux	11.54% <ø> (?)
FreeBSD-14.3-amd64	13.82% <ø> (?)
Homebrew-ubuntu-22.04	13.82% <ø> (?)
Linux-AppImage	11.85% <ø> (?)
Windows-AMD64	13.41% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

[codecov]

Bundle Report

Bundle size has no change ✅

[craimasjien]

Description

Updated the linux build script to enable it to detect Fedora 43 as a valid build target.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

• feat: New feature (non-breaking change which adds functionality)
• fix: Bug fix (non-breaking change which fixes an issue)
• docs: Documentation only changes
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
• refactor: Code change that neither fixes a bug nor adds a feature
• perf: Code change that improves performance
• test: Adding missing tests or correcting existing tests
• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Other changes that don't modify src or test files
• revert: Reverts a previous commit
• BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

• Code follows the style guidelines of this project
• Code has been self-reviewed
• Code has been commented, particularly in hard-to-understand areas
• Code docstring/documentation-blocks for new or existing methods/components have been added or updated
• Unit tests have been added or updated for any new or modified functionality

AI Usage

• None: No AI tools were used in creating this PR
• Light: AI provided minor assistance (formatting, simple suggestions)
• Moderate: AI helped with code generation or debugging specific parts
• Heavy: AI generated most or all of the code changes

[craimasjien]

The script executed as expected after running it. I was able to build and compile sunshine just perfectly and install it using ninja.

sudo dnf install libstdc++-static
cmake -B build -G Ninja -S . -DSUNSHINE_ENABLE_CUDA=OFF
ninja -C build
sudo ninja install -C build/

I wanted to check with the maintainers whether they think making the libstdc++-static part of the linux build script, as it's required to be built but was missing after running the script.

Note: I disabled CUDA because I'm an AMD user by the way.

[craimasjien]

Can I also kindly request the maintainer of the Linux packaging to enable support for Fedora 43? I can't do this now as the packaging is done through Copr, and I obviously can not administrate that.

[ReenigneArcher]

Can I also kindly request the maintainer of the Linux packaging to enable support for Fedora 43? I can't do this now as the packaging is done through Copr, and I obviously can not administrate that.

It's enabled in the beta copr. It will be enabled in the stable the next time we create a release... But we are not going to align releases with any distro as that's too demanding on a small project.

[ReenigneArcher]

The script executed as expected after running it. I was able to build and compile sunshine just perfectly and install it using ninja.

sudo dnf install libstdc++-static
cmake -B build -G Ninja -S . -DSUNSHINE_ENABLE_CUDA=OFF
ninja -C build
sudo ninja install -C build/

I wanted to check with the maintainers whether they think making the libstdc++-static part of the linux build script, as it's required to be built but was missing after running the script.

Note: I disabled CUDA because I'm an AMD user by the way.

If you're asking if the package should be installed, I think it should.

We don't use this script anymore since we started using copr, so stuff may get missed from time to time.

[craimasjien]

The script executed as expected after running it. I was able to build and compile sunshine just perfectly and install it using ninja.

sudo dnf install libstdc++-static
cmake -B build -G Ninja -S . -DSUNSHINE_ENABLE_CUDA=OFF
ninja -C build
sudo ninja install -C build/

I wanted to check with the maintainers whether they think making the libstdc++-static part of the linux build script, as it's required to be built but was missing after running the script.
Note: I disabled CUDA because I'm an AMD user by the way.

If you're asking if the package should be installed, I think it should.

We don't use this script anymore since we started using copr, so stuff may get missed from time to time.

I can confirm the package does need to be installed, but I assumed the purpose of the script is to make the environment ready for building, meaning that package should probably be included.

But since you're not using the script anymore I'm not sure if you would want me to make it part of this PR, or have this PR exist in the first place.

The reason I went and changed the script is because there's no way for me to install Sunshine right now with the packages provided by the release on GitHub as that is missing a Fedora 43 build and the Fedora 42 build doesn't work.

[ReenigneArcher]

The reason I went and changed the script is because there's no way for me to install Sunshine right now with the packages provided by the release on GitHub as that is missing a Fedora 43 build and the Fedora 42 build doesn't work.

The PR is fine, we accept changes for the Fedora portion because some people self compile using this script.

For Fedora 43 support, you'll want to use our beta copr instead of our stable copr. I need to improve the docs to mention why this is, but they do tell you how to enable the beta copr. https://docs.lizardbyte.dev/projects/sunshine/latest/md_docs_2getting__started.html#fedora

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@8294ab2). Learn more about missing BASE report.
⚠️ Report is 202 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@## master #4532 +/- ##
=========================================
Coverage ? 15.45% =========================================
Files ? 93 Lines ? 19018 Branches ? 8768 =========================================
Hits ? 2939 Misses ? 14750 Partials ? 1329 

Flag	Coverage Δ
Archlinux	11.54% <ø> (?)
FreeBSD-14.3-amd64	13.82% <ø> (?)
Homebrew-ubuntu-22.04	13.82% <ø> (?)
Linux-AppImage	11.85% <ø> (?)
Windows-AMD64	13.41% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

[codecov]

Bundle Report

Bundle size has no change ✅

[craimasjien]

Description

Updated the linux build script to enable it to detect Fedora 43 as a valid build target.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

• feat: New feature (non-breaking change which adds functionality)
• fix: Bug fix (non-breaking change which fixes an issue)
• docs: Documentation only changes
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
• refactor: Code change that neither fixes a bug nor adds a feature
• perf: Code change that improves performance
• test: Adding missing tests or correcting existing tests
• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Other changes that don't modify src or test files
• revert: Reverts a previous commit
• BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

• Code follows the style guidelines of this project
• Code has been self-reviewed
• Code has been commented, particularly in hard-to-understand areas
• Code docstring/documentation-blocks for new or existing methods/components have been added or updated
• Unit tests have been added or updated for any new or modified functionality

AI Usage

• None: No AI tools were used in creating this PR
• Light: AI provided minor assistance (formatting, simple suggestions)
• Moderate: AI helped with code generation or debugging specific parts
• Heavy: AI generated most or all of the code changes

[craimasjien]

The script executed as expected after running it. I was able to build and compile sunshine just perfectly and install it using ninja.

sudo dnf install libstdc++-static
cmake -B build -G Ninja -S . -DSUNSHINE_ENABLE_CUDA=OFF
ninja -C build
sudo ninja install -C build/

I wanted to check with the maintainers whether they think making the libstdc++-static part of the linux build script, as it's required to be built but was missing after running the script.

Note: I disabled CUDA because I'm an AMD user by the way.

[craimasjien]

Can I also kindly request the maintainer of the Linux packaging to enable support for Fedora 43? I can't do this now as the packaging is done through Copr, and I obviously can not administrate that.

[ReenigneArcher]

Can I also kindly request the maintainer of the Linux packaging to enable support for Fedora 43? I can't do this now as the packaging is done through Copr, and I obviously can not administrate that.

It's enabled in the beta copr. It will be enabled in the stable the next time we create a release... But we are not going to align releases with any distro as that's too demanding on a small project.

[ReenigneArcher]

The script executed as expected after running it. I was able to build and compile sunshine just perfectly and install it using ninja.

sudo dnf install libstdc++-static
cmake -B build -G Ninja -S . -DSUNSHINE_ENABLE_CUDA=OFF
ninja -C build
sudo ninja install -C build/

I wanted to check with the maintainers whether they think making the libstdc++-static part of the linux build script, as it's required to be built but was missing after running the script.

Note: I disabled CUDA because I'm an AMD user by the way.

If you're asking if the package should be installed, I think it should.

We don't use this script anymore since we started using copr, so stuff may get missed from time to time.

[craimasjien]

The script executed as expected after running it. I was able to build and compile sunshine just perfectly and install it using ninja.

sudo dnf install libstdc++-static
cmake -B build -G Ninja -S . -DSUNSHINE_ENABLE_CUDA=OFF
ninja -C build
sudo ninja install -C build/

I wanted to check with the maintainers whether they think making the libstdc++-static part of the linux build script, as it's required to be built but was missing after running the script.
Note: I disabled CUDA because I'm an AMD user by the way.

If you're asking if the package should be installed, I think it should.

We don't use this script anymore since we started using copr, so stuff may get missed from time to time.

I can confirm the package does need to be installed, but I assumed the purpose of the script is to make the environment ready for building, meaning that package should probably be included.

But since you're not using the script anymore I'm not sure if you would want me to make it part of this PR, or have this PR exist in the first place.

The reason I went and changed the script is because there's no way for me to install Sunshine right now with the packages provided by the release on GitHub as that is missing a Fedora 43 build and the Fedora 42 build doesn't work.

[ReenigneArcher]

The reason I went and changed the script is because there's no way for me to install Sunshine right now with the packages provided by the release on GitHub as that is missing a Fedora 43 build and the Fedora 42 build doesn't work.

The PR is fine, we accept changes for the Fedora portion because some people self compile using this script.

For Fedora 43 support, you'll want to use our beta copr instead of our stable copr. I need to improve the docs to mention why this is, but they do tell you how to enable the beta copr. https://docs.lizardbyte.dev/projects/sunshine/latest/md_docs_2getting__started.html#fedora

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@8294ab2). Learn more about missing BASE report.
⚠️ Report is 202 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@## master #4532 +/- ##
=========================================
Coverage ? 15.45% =========================================
Files ? 93 Lines ? 19018 Branches ? 8768 =========================================
Hits ? 2939 Misses ? 14750 Partials ? 1329 

Flag	Coverage Δ
Archlinux	11.54% <ø> (?)
FreeBSD-14.3-amd64	13.82% <ø> (?)
Homebrew-ubuntu-22.04	13.82% <ø> (?)
Linux-AppImage	11.85% <ø> (?)
Windows-AMD64	13.41% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

[codecov]

Bundle Report

Bundle size has no change ✅

[craimasjien]

Description

Updated the linux build script to enable it to detect Fedora 43 as a valid build target.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

• feat: New feature (non-breaking change which adds functionality)
• fix: Bug fix (non-breaking change which fixes an issue)
• docs: Documentation only changes
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
• refactor: Code change that neither fixes a bug nor adds a feature
• perf: Code change that improves performance
• test: Adding missing tests or correcting existing tests
• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Other changes that don't modify src or test files
• revert: Reverts a previous commit
• BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

• Code follows the style guidelines of this project
• Code has been self-reviewed
• Code has been commented, particularly in hard-to-understand areas
• Code docstring/documentation-blocks for new or existing methods/components have been added or updated
• Unit tests have been added or updated for any new or modified functionality

AI Usage

• None: No AI tools were used in creating this PR
• Light: AI provided minor assistance (formatting, simple suggestions)
• Moderate: AI helped with code generation or debugging specific parts
• Heavy: AI generated most or all of the code changes

[craimasjien]

The script executed as expected after running it. I was able to build and compile sunshine just perfectly and install it using ninja.

sudo dnf install libstdc++-static
cmake -B build -G Ninja -S . -DSUNSHINE_ENABLE_CUDA=OFF
ninja -C build
sudo ninja install -C build/

I wanted to check with the maintainers whether they think making the libstdc++-static part of the linux build script, as it's required to be built but was missing after running the script.

Note: I disabled CUDA because I'm an AMD user by the way.

[craimasjien]

Can I also kindly request the maintainer of the Linux packaging to enable support for Fedora 43? I can't do this now as the packaging is done through Copr, and I obviously can not administrate that.

[ReenigneArcher]

Can I also kindly request the maintainer of the Linux packaging to enable support for Fedora 43? I can't do this now as the packaging is done through Copr, and I obviously can not administrate that.

It's enabled in the beta copr. It will be enabled in the stable the next time we create a release... But we are not going to align releases with any distro as that's too demanding on a small project.

[ReenigneArcher]

The script executed as expected after running it. I was able to build and compile sunshine just perfectly and install it using ninja.

sudo dnf install libstdc++-static
cmake -B build -G Ninja -S . -DSUNSHINE_ENABLE_CUDA=OFF
ninja -C build
sudo ninja install -C build/

I wanted to check with the maintainers whether they think making the libstdc++-static part of the linux build script, as it's required to be built but was missing after running the script.

Note: I disabled CUDA because I'm an AMD user by the way.

If you're asking if the package should be installed, I think it should.

We don't use this script anymore since we started using copr, so stuff may get missed from time to time.

[craimasjien]

The script executed as expected after running it. I was able to build and compile sunshine just perfectly and install it using ninja.

sudo dnf install libstdc++-static
cmake -B build -G Ninja -S . -DSUNSHINE_ENABLE_CUDA=OFF
ninja -C build
sudo ninja install -C build/

I wanted to check with the maintainers whether they think making the libstdc++-static part of the linux build script, as it's required to be built but was missing after running the script.
Note: I disabled CUDA because I'm an AMD user by the way.

If you're asking if the package should be installed, I think it should.

We don't use this script anymore since we started using copr, so stuff may get missed from time to time.

I can confirm the package does need to be installed, but I assumed the purpose of the script is to make the environment ready for building, meaning that package should probably be included.

But since you're not using the script anymore I'm not sure if you would want me to make it part of this PR, or have this PR exist in the first place.

The reason I went and changed the script is because there's no way for me to install Sunshine right now with the packages provided by the release on GitHub as that is missing a Fedora 43 build and the Fedora 42 build doesn't work.

[ReenigneArcher]

The reason I went and changed the script is because there's no way for me to install Sunshine right now with the packages provided by the release on GitHub as that is missing a Fedora 43 build and the Fedora 42 build doesn't work.

The PR is fine, we accept changes for the Fedora portion because some people self compile using this script.

For Fedora 43 support, you'll want to use our beta copr instead of our stable copr. I need to improve the docs to mention why this is, but they do tell you how to enable the beta copr. https://docs.lizardbyte.dev/projects/sunshine/latest/md_docs_2getting__started.html#fedora

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@8294ab2). Learn more about missing BASE report.
⚠️ Report is 202 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@## master #4532 +/- ##
=========================================
Coverage ? 15.45% =========================================
Files ? 93 Lines ? 19018 Branches ? 8768 =========================================
Hits ? 2939 Misses ? 14750 Partials ? 1329 

Flag	Coverage Δ
Archlinux	11.54% <ø> (?)
FreeBSD-14.3-amd64	13.82% <ø> (?)
Homebrew-ubuntu-22.04	13.82% <ø> (?)
Linux-AppImage	11.85% <ø> (?)
Windows-AMD64	13.41% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

[codecov]

Bundle Report

Bundle size has no change ✅

[craimasjien]

Description

Updated the linux build script to enable it to detect Fedora 43 as a valid build target.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

• feat: New feature (non-breaking change which adds functionality)
• fix: Bug fix (non-breaking change which fixes an issue)
• docs: Documentation only changes
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
• refactor: Code change that neither fixes a bug nor adds a feature
• perf: Code change that improves performance
• test: Adding missing tests or correcting existing tests
• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Other changes that don't modify src or test files
• revert: Reverts a previous commit
• BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

• Code follows the style guidelines of this project
• Code has been self-reviewed
• Code has been commented, particularly in hard-to-understand areas
• Code docstring/documentation-blocks for new or existing methods/components have been added or updated
• Unit tests have been added or updated for any new or modified functionality

AI Usage

• None: No AI tools were used in creating this PR
• Light: AI provided minor assistance (formatting, simple suggestions)
• Moderate: AI helped with code generation or debugging specific parts
• Heavy: AI generated most or all of the code changes

[craimasjien]

The script executed as expected after running it. I was able to build and compile sunshine just perfectly and install it using ninja.

sudo dnf install libstdc++-static
cmake -B build -G Ninja -S . -DSUNSHINE_ENABLE_CUDA=OFF
ninja -C build
sudo ninja install -C build/

I wanted to check with the maintainers whether they think making the libstdc++-static part of the linux build script, as it's required to be built but was missing after running the script.

Note: I disabled CUDA because I'm an AMD user by the way.

[craimasjien]

Can I also kindly request the maintainer of the Linux packaging to enable support for Fedora 43? I can't do this now as the packaging is done through Copr, and I obviously can not administrate that.

[ReenigneArcher]

Can I also kindly request the maintainer of the Linux packaging to enable support for Fedora 43? I can't do this now as the packaging is done through Copr, and I obviously can not administrate that.

It's enabled in the beta copr. It will be enabled in the stable the next time we create a release... But we are not going to align releases with any distro as that's too demanding on a small project.

[ReenigneArcher]

The script executed as expected after running it. I was able to build and compile sunshine just perfectly and install it using ninja.

sudo dnf install libstdc++-static
cmake -B build -G Ninja -S . -DSUNSHINE_ENABLE_CUDA=OFF
ninja -C build
sudo ninja install -C build/

I wanted to check with the maintainers whether they think making the libstdc++-static part of the linux build script, as it's required to be built but was missing after running the script.

Note: I disabled CUDA because I'm an AMD user by the way.

If you're asking if the package should be installed, I think it should.

We don't use this script anymore since we started using copr, so stuff may get missed from time to time.

[craimasjien]

The script executed as expected after running it. I was able to build and compile sunshine just perfectly and install it using ninja.

sudo dnf install libstdc++-static
cmake -B build -G Ninja -S . -DSUNSHINE_ENABLE_CUDA=OFF
ninja -C build
sudo ninja install -C build/

I wanted to check with the maintainers whether they think making the libstdc++-static part of the linux build script, as it's required to be built but was missing after running the script.
Note: I disabled CUDA because I'm an AMD user by the way.

If you're asking if the package should be installed, I think it should.

We don't use this script anymore since we started using copr, so stuff may get missed from time to time.

I can confirm the package does need to be installed, but I assumed the purpose of the script is to make the environment ready for building, meaning that package should probably be included.

But since you're not using the script anymore I'm not sure if you would want me to make it part of this PR, or have this PR exist in the first place.

The reason I went and changed the script is because there's no way for me to install Sunshine right now with the packages provided by the release on GitHub as that is missing a Fedora 43 build and the Fedora 42 build doesn't work.

[ReenigneArcher]

The reason I went and changed the script is because there's no way for me to install Sunshine right now with the packages provided by the release on GitHub as that is missing a Fedora 43 build and the Fedora 42 build doesn't work.

The PR is fine, we accept changes for the Fedora portion because some people self compile using this script.

For Fedora 43 support, you'll want to use our beta copr instead of our stable copr. I need to improve the docs to mention why this is, but they do tell you how to enable the beta copr. https://docs.lizardbyte.dev/projects/sunshine/latest/md_docs_2getting__started.html#fedora

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@8294ab2). Learn more about missing BASE report.
⚠️ Report is 202 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@## master #4532 +/- ##
=========================================
Coverage ? 15.45% =========================================
Files ? 93 Lines ? 19018 Branches ? 8768 =========================================
Hits ? 2939 Misses ? 14750 Partials ? 1329 

Flag	Coverage Δ
Archlinux	11.54% <ø> (?)
FreeBSD-14.3-amd64	13.82% <ø> (?)
Homebrew-ubuntu-22.04	13.82% <ø> (?)
Linux-AppImage	11.85% <ø> (?)
Windows-AMD64	13.41% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

[codecov]

Bundle Report

Bundle size has no change ✅

[craimasjien]

Description

Updated the linux build script to enable it to detect Fedora 43 as a valid build target.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

• feat: New feature (non-breaking change which adds functionality)
• fix: Bug fix (non-breaking change which fixes an issue)
• docs: Documentation only changes
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
• refactor: Code change that neither fixes a bug nor adds a feature
• perf: Code change that improves performance
• test: Adding missing tests or correcting existing tests
• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Other changes that don't modify src or test files
• revert: Reverts a previous commit
• BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

• Code follows the style guidelines of this project
• Code has been self-reviewed
• Code has been commented, particularly in hard-to-understand areas
• Code docstring/documentation-blocks for new or existing methods/components have been added or updated
• Unit tests have been added or updated for any new or modified functionality

AI Usage

• None: No AI tools were used in creating this PR
• Light: AI provided minor assistance (formatting, simple suggestions)
• Moderate: AI helped with code generation or debugging specific parts
• Heavy: AI generated most or all of the code changes

[craimasjien]

The script executed as expected after running it. I was able to build and compile sunshine just perfectly and install it using ninja.

sudo dnf install libstdc++-static
cmake -B build -G Ninja -S . -DSUNSHINE_ENABLE_CUDA=OFF
ninja -C build
sudo ninja install -C build/

I wanted to check with the maintainers whether they think making the libstdc++-static part of the linux build script, as it's required to be built but was missing after running the script.

Note: I disabled CUDA because I'm an AMD user by the way.

[craimasjien]

Can I also kindly request the maintainer of the Linux packaging to enable support for Fedora 43? I can't do this now as the packaging is done through Copr, and I obviously can not administrate that.

[ReenigneArcher]

Can I also kindly request the maintainer of the Linux packaging to enable support for Fedora 43? I can't do this now as the packaging is done through Copr, and I obviously can not administrate that.

It's enabled in the beta copr. It will be enabled in the stable the next time we create a release... But we are not going to align releases with any distro as that's too demanding on a small project.

[ReenigneArcher]

The script executed as expected after running it. I was able to build and compile sunshine just perfectly and install it using ninja.

sudo dnf install libstdc++-static
cmake -B build -G Ninja -S . -DSUNSHINE_ENABLE_CUDA=OFF
ninja -C build
sudo ninja install -C build/

I wanted to check with the maintainers whether they think making the libstdc++-static part of the linux build script, as it's required to be built but was missing after running the script.

Note: I disabled CUDA because I'm an AMD user by the way.

If you're asking if the package should be installed, I think it should.

We don't use this script anymore since we started using copr, so stuff may get missed from time to time.

[craimasjien]

The script executed as expected after running it. I was able to build and compile sunshine just perfectly and install it using ninja.

sudo dnf install libstdc++-static
cmake -B build -G Ninja -S . -DSUNSHINE_ENABLE_CUDA=OFF
ninja -C build
sudo ninja install -C build/

I wanted to check with the maintainers whether they think making the libstdc++-static part of the linux build script, as it's required to be built but was missing after running the script.
Note: I disabled CUDA because I'm an AMD user by the way.

If you're asking if the package should be installed, I think it should.

We don't use this script anymore since we started using copr, so stuff may get missed from time to time.

I can confirm the package does need to be installed, but I assumed the purpose of the script is to make the environment ready for building, meaning that package should probably be included.

But since you're not using the script anymore I'm not sure if you would want me to make it part of this PR, or have this PR exist in the first place.

The reason I went and changed the script is because there's no way for me to install Sunshine right now with the packages provided by the release on GitHub as that is missing a Fedora 43 build and the Fedora 42 build doesn't work.

[ReenigneArcher]

The reason I went and changed the script is because there's no way for me to install Sunshine right now with the packages provided by the release on GitHub as that is missing a Fedora 43 build and the Fedora 42 build doesn't work.

The PR is fine, we accept changes for the Fedora portion because some people self compile using this script.

For Fedora 43 support, you'll want to use our beta copr instead of our stable copr. I need to improve the docs to mention why this is, but they do tell you how to enable the beta copr. https://docs.lizardbyte.dev/projects/sunshine/latest/md_docs_2getting__started.html#fedora

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@8294ab2). Learn more about missing BASE report.
⚠️ Report is 202 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@## master #4532 +/- ##
=========================================
Coverage ? 15.45% =========================================
Files ? 93 Lines ? 19018 Branches ? 8768 =========================================
Hits ? 2939 Misses ? 14750 Partials ? 1329 

Flag	Coverage Δ
Archlinux	11.54% <ø> (?)
FreeBSD-14.3-amd64	13.82% <ø> (?)
Homebrew-ubuntu-22.04	13.82% <ø> (?)
Linux-AppImage	11.85% <ø> (?)
Windows-AMD64	13.41% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

[codecov]

Bundle Report

Bundle size has no change ✅

[craimasjien]

Description

Updated the linux build script to enable it to detect Fedora 43 as a valid build target.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

• feat: New feature (non-breaking change which adds functionality)
• fix: Bug fix (non-breaking change which fixes an issue)
• docs: Documentation only changes
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
• refactor: Code change that neither fixes a bug nor adds a feature
• perf: Code change that improves performance
• test: Adding missing tests or correcting existing tests
• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Other changes that don't modify src or test files
• revert: Reverts a previous commit
• BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

• Code follows the style guidelines of this project
• Code has been self-reviewed
• Code has been commented, particularly in hard-to-understand areas
• Code docstring/documentation-blocks for new or existing methods/components have been added or updated
• Unit tests have been added or updated for any new or modified functionality

AI Usage

• None: No AI tools were used in creating this PR
• Light: AI provided minor assistance (formatting, simple suggestions)
• Moderate: AI helped with code generation or debugging specific parts
• Heavy: AI generated most or all of the code changes

[craimasjien]

The script executed as expected after running it. I was able to build and compile sunshine just perfectly and install it using ninja.

sudo dnf install libstdc++-static
cmake -B build -G Ninja -S . -DSUNSHINE_ENABLE_CUDA=OFF
ninja -C build
sudo ninja install -C build/

I wanted to check with the maintainers whether they think making the libstdc++-static part of the linux build script, as it's required to be built but was missing after running the script.

Note: I disabled CUDA because I'm an AMD user by the way.

[craimasjien]

Can I also kindly request the maintainer of the Linux packaging to enable support for Fedora 43? I can't do this now as the packaging is done through Copr, and I obviously can not administrate that.

[ReenigneArcher]

Can I also kindly request the maintainer of the Linux packaging to enable support for Fedora 43? I can't do this now as the packaging is done through Copr, and I obviously can not administrate that.

It's enabled in the beta copr. It will be enabled in the stable the next time we create a release... But we are not going to align releases with any distro as that's too demanding on a small project.

[ReenigneArcher]

The script executed as expected after running it. I was able to build and compile sunshine just perfectly and install it using ninja.

sudo dnf install libstdc++-static
cmake -B build -G Ninja -S . -DSUNSHINE_ENABLE_CUDA=OFF
ninja -C build
sudo ninja install -C build/

I wanted to check with the maintainers whether they think making the libstdc++-static part of the linux build script, as it's required to be built but was missing after running the script.

Note: I disabled CUDA because I'm an AMD user by the way.

If you're asking if the package should be installed, I think it should.

We don't use this script anymore since we started using copr, so stuff may get missed from time to time.

[craimasjien]

The script executed as expected after running it. I was able to build and compile sunshine just perfectly and install it using ninja.

sudo dnf install libstdc++-static
cmake -B build -G Ninja -S . -DSUNSHINE_ENABLE_CUDA=OFF
ninja -C build
sudo ninja install -C build/

I wanted to check with the maintainers whether they think making the libstdc++-static part of the linux build script, as it's required to be built but was missing after running the script.
Note: I disabled CUDA because I'm an AMD user by the way.

If you're asking if the package should be installed, I think it should.

We don't use this script anymore since we started using copr, so stuff may get missed from time to time.

I can confirm the package does need to be installed, but I assumed the purpose of the script is to make the environment ready for building, meaning that package should probably be included.

But since you're not using the script anymore I'm not sure if you would want me to make it part of this PR, or have this PR exist in the first place.

The reason I went and changed the script is because there's no way for me to install Sunshine right now with the packages provided by the release on GitHub as that is missing a Fedora 43 build and the Fedora 42 build doesn't work.

[ReenigneArcher]

The reason I went and changed the script is because there's no way for me to install Sunshine right now with the packages provided by the release on GitHub as that is missing a Fedora 43 build and the Fedora 42 build doesn't work.

The PR is fine, we accept changes for the Fedora portion because some people self compile using this script.

For Fedora 43 support, you'll want to use our beta copr instead of our stable copr. I need to improve the docs to mention why this is, but they do tell you how to enable the beta copr. https://docs.lizardbyte.dev/projects/sunshine/latest/md_docs_2getting__started.html#fedora

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@8294ab2). Learn more about missing BASE report.
⚠️ Report is 202 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@## master #4532 +/- ##
=========================================
Coverage ? 15.45% =========================================
Files ? 93 Lines ? 19018 Branches ? 8768 =========================================
Hits ? 2939 Misses ? 14750 Partials ? 1329 

Flag	Coverage Δ
Archlinux	11.54% <ø> (?)
FreeBSD-14.3-amd64	13.82% <ø> (?)
Homebrew-ubuntu-22.04	13.82% <ø> (?)
Linux-AppImage	11.85% <ø> (?)
Windows-AMD64	13.41% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

[codecov]

Bundle Report

Bundle size has no change ✅

[craimasjien]

Description

Updated the linux build script to enable it to detect Fedora 43 as a valid build target.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

• feat: New feature (non-breaking change which adds functionality)
• fix: Bug fix (non-breaking change which fixes an issue)
• docs: Documentation only changes
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
• refactor: Code change that neither fixes a bug nor adds a feature
• perf: Code change that improves performance
• test: Adding missing tests or correcting existing tests
• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Other changes that don't modify src or test files
• revert: Reverts a previous commit
• BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

• Code follows the style guidelines of this project
• Code has been self-reviewed
• Code has been commented, particularly in hard-to-understand areas
• Code docstring/documentation-blocks for new or existing methods/components have been added or updated
• Unit tests have been added or updated for any new or modified functionality

AI Usage

• None: No AI tools were used in creating this PR
• Light: AI provided minor assistance (formatting, simple suggestions)
• Moderate: AI helped with code generation or debugging specific parts
• Heavy: AI generated most or all of the code changes

[craimasjien]

The script executed as expected after running it. I was able to build and compile sunshine just perfectly and install it using ninja.

sudo dnf install libstdc++-static
cmake -B build -G Ninja -S . -DSUNSHINE_ENABLE_CUDA=OFF
ninja -C build
sudo ninja install -C build/

I wanted to check with the maintainers whether they think making the libstdc++-static part of the linux build script, as it's required to be built but was missing after running the script.

Note: I disabled CUDA because I'm an AMD user by the way.

[craimasjien]

Can I also kindly request the maintainer of the Linux packaging to enable support for Fedora 43? I can't do this now as the packaging is done through Copr, and I obviously can not administrate that.

[ReenigneArcher]

Can I also kindly request the maintainer of the Linux packaging to enable support for Fedora 43? I can't do this now as the packaging is done through Copr, and I obviously can not administrate that.

It's enabled in the beta copr. It will be enabled in the stable the next time we create a release... But we are not going to align releases with any distro as that's too demanding on a small project.

[ReenigneArcher]

The script executed as expected after running it. I was able to build and compile sunshine just perfectly and install it using ninja.

sudo dnf install libstdc++-static
cmake -B build -G Ninja -S . -DSUNSHINE_ENABLE_CUDA=OFF
ninja -C build
sudo ninja install -C build/

I wanted to check with the maintainers whether they think making the libstdc++-static part of the linux build script, as it's required to be built but was missing after running the script.

Note: I disabled CUDA because I'm an AMD user by the way.

If you're asking if the package should be installed, I think it should.

We don't use this script anymore since we started using copr, so stuff may get missed from time to time.

[craimasjien]

The script executed as expected after running it. I was able to build and compile sunshine just perfectly and install it using ninja.

sudo dnf install libstdc++-static
cmake -B build -G Ninja -S . -DSUNSHINE_ENABLE_CUDA=OFF
ninja -C build
sudo ninja install -C build/

I wanted to check with the maintainers whether they think making the libstdc++-static part of the linux build script, as it's required to be built but was missing after running the script.
Note: I disabled CUDA because I'm an AMD user by the way.

If you're asking if the package should be installed, I think it should.

We don't use this script anymore since we started using copr, so stuff may get missed from time to time.

I can confirm the package does need to be installed, but I assumed the purpose of the script is to make the environment ready for building, meaning that package should probably be included.

But since you're not using the script anymore I'm not sure if you would want me to make it part of this PR, or have this PR exist in the first place.

The reason I went and changed the script is because there's no way for me to install Sunshine right now with the packages provided by the release on GitHub as that is missing a Fedora 43 build and the Fedora 42 build doesn't work.

[ReenigneArcher]

The reason I went and changed the script is because there's no way for me to install Sunshine right now with the packages provided by the release on GitHub as that is missing a Fedora 43 build and the Fedora 42 build doesn't work.

The PR is fine, we accept changes for the Fedora portion because some people self compile using this script.

For Fedora 43 support, you'll want to use our beta copr instead of our stable copr. I need to improve the docs to mention why this is, but they do tell you how to enable the beta copr. https://docs.lizardbyte.dev/projects/sunshine/latest/md_docs_2getting__started.html#fedora

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@8294ab2). Learn more about missing BASE report.
⚠️ Report is 202 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@## master #4532 +/- ##
=========================================
Coverage ? 15.45% =========================================
Files ? 93 Lines ? 19018 Branches ? 8768 =========================================
Hits ? 2939 Misses ? 14750 Partials ? 1329 

Flag	Coverage Δ
Archlinux	11.54% <ø> (?)
FreeBSD-14.3-amd64	13.82% <ø> (?)
Homebrew-ubuntu-22.04	13.82% <ø> (?)
Linux-AppImage	11.85% <ø> (?)
Windows-AMD64	13.41% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

[codecov]

Bundle Report

Bundle size has no change ✅