Automated PR tests and releases - #6

Merged
ReenigneArcher merged 105 commits into
LizardByte:nightlyfrom
ReenigneArcher:add-build-checks
Jan 12, 2022
Merged

Automated PR tests and releases#6
ReenigneArcher merged 105 commits into
LizardByte:nightlyfrom
ReenigneArcher:add-build-checks

Conversation

@ReenigneArcher

@ReenigneArcherReenigneArcher commented Jan 11, 2022

Copy link
Copy Markdown
Member

Description

  • Added CHANGELOG.md
  • Add build checks
  • Add automated release
    • CHANGELOG.md version must not match latest released tag_name
    • CHANGELOG version is compared to latest released version on Pull Request into master
  • Added Fedora build Dockerfiles (no packaging yet)
  • Improved readability of Dockerfiles
  • Use update-alternatives instead of cp for older Ubuntu distros
  • Added AppImage

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the documentation blocks for new or existing components

@ReenigneArcher
Create sunshine.png
1b0978f
@ReenigneArcher
Create sunshine.desktop
a268cb5
@ReenigneArcher
Create pull-requests_build-check.yml
8478ccc
@ReenigneArcher
Update pull-requests_build-check.yml
c5b8def
-Fix syntax error
@ReenigneArcher
Update pull-requests_build-check.yml
e2d3fef
-Attempt to fix build step at line 56
-Various tweaks to quoting and directory names
@ReenigneArcher
Update pull-requests_build-check.yml
89cfbc6
-Checkout recursively with submodules
@ReenigneArcher
Update pull-requests_build-check.yml
f272b86
-recursive submodules
-only run on PR for master or nightly branch
@ReenigneArcher
Update pull-requests_build-check.yml
502bf8e
-Add deb job with matrix strategy
@ReenigneArcher
Fix typo in docker build readme
47a7c5e
@ReenigneArcher
Update pull-requests_build-check.yml
69642d2
@ReenigneArcher
Update pull-requests_build-check.yml
23f9474
@ReenigneArcher
Update pull-requests_build-check.yml
bbdf961
@ReenigneArcher
Update pull-requests_build-check.yml
ca8917d
-build with -u for non interactive
@ReenigneArcher
Update pull-requests_build-check.yml
65b9b65
-Fix command that moves deb package
-Separate setup, build, and package steps
@ReenigneArcher
Update pull-requests_build-check.yml
b73ddc2
-Fix permission denied error when moving deb package
@ReenigneArcher
Update pull-requests_build-check.yml
2561886
-Add Windows build
@ReenigneArcher
Update pull-requests_build-check.yml
0fa6839
-Fix path issue for pacman command
@ReenigneArcher
Update pull-requests_build-check.yml
71b5495
-Boost debug on
@ReenigneArcher
Update pull-requests_build-check.yml
f6d9061
-Install boost
-Remove boost debug during cmake
@ReenigneArcher
Update pull-requests_build-check.yml
2b0e1fb
-Fix boost install directory
@ReenigneArcher
Update pull-requests_build-check.yml
de8cff0
-Add environment variable BOOST_ROOT
@ReenigneArcher
Update pull-requests_build-check.yml
c49cbd3
@ReenigneArcher
Update pull-requests_build-check.yml
2144787
-Try older version of boost, new version failing with cmake 3.22
@ReenigneArcher
Update pull-requests_build-check.yml
1039160
-Try boost v1.73.0 built on windows server 2019
@ReenigneArcher
Update pull-requests_build-check.yml
9fbfca5
-Try boost 1.72.0
@ReenigneArcher
Update pull-requests_build-check.yml
2512e7f
-Testing
@ReenigneArcher
Update pull-requests_build-check.yml
3f2ee64
-Testing
@ReenigneArcher
Update pull-requests_build-check.yml
ed38b7e
-Testing
@ReenigneArcher
Update pull-requests_build-check.yml
ff47a13
@ReenigneArcher
Update pull-requests_build-check.yml
17770fe
@ReenigneArcher

ReenigneArcher commented Jan 11, 2022•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

I apologize for all the commits. Workflows are not the easiest thing to test.

Here is a workflow run for creating a new release (when the release version was updated): https://github.com/ReenigneArcher/Sunshine/actions/runs/1683355353

And here is a workflow run when the release version was not updated in the CHANGELOG.md (this should also be caught when the PR is created against the master branch): https://github.com/ReenigneArcher/Sunshine/actions/runs/1683445817

And here is an example of the release: https://github.com/ReenigneArcher/Sunshine/releases

@ReenigneArcher

ReenigneArcher commented Jan 11, 2022

Copy link
Copy Markdown
MemberAuthor

This needs a little tweaking on the create release action due to the multiple steps, it fails on all except the first build. I have an idea to fix it though.

@ReenigneArcher
ReenigneArcher marked this pull request as draft January 11, 2022 21:52
@ReenigneArcher
Update create_package.yml
cefcaed
@ReenigneArcher
Update create_package.yml
a2c45f8
-Fix typo in Windows build
@ReenigneArcher
Update create_package.yml
8781fbc
- github.base_ref is needed for pull request check
@ReenigneArcher
Update create_package.yml
f2c53a5
-Verify changelog requires checkout
@ReenigneArcher

ReenigneArcher commented Jan 12, 2022

Copy link
Copy Markdown
MemberAuthor

Updated Examples:

PR into nightly branch
https://github.com/ReenigneArcher/Sunshine/actions/runs/1685200094
-No check on CHANGELOG.md
-Build each version
-Package everything except Fedora
-Upload artifacts

PR into master branch
When the release version from the changelog matches the latest released version: https://github.com/ReenigneArcher/Sunshine/actions/runs/1685245727/attempts/1
-Intentionally fail the workflow (gives an opportunity to fix the CHANGELOG.md before accepting the PR)
-Build each version
-Package everything except Fedora
-Upload artifacts

Release version in changelog was updated and does not match latest released version: https://github.com/ReenigneArcher/Sunshine/actions/runs/1685245727/attempts/2
-Same as attempt 1 except workflow passes beyond changelog check

push into master branch
https://github.com/ReenigneArcher/Sunshine/actions/runs/1685294883

  • Harder to fix anything at this point so:
    • The check on changelog is done earlier when the PR is made into master

Example of Created Release
https://github.com/ReenigneArcher/Sunshine/releases/tag/0.0.0

@ReenigneArcher
ReenigneArcher marked this pull request as ready for review January 12, 2022 00:37
@TheElixZammuto

TheElixZammuto commented Jan 12, 2022

Copy link
Copy Markdown
Member

Not an expert on the GitHub actions side, so all I can say is LGTM for the workflow side of things

@ReenigneArcher
ReenigneArcher merged commit d1a41ad into LizardByte:nightlyJan 12, 2022
@ReenigneArcher
ReenigneArcher deleted the add-build-checks branch January 12, 2022 22:19
ReenigneArcher added a commit that referenced this pull request Jan 13, 2022
@ReenigneArcher
Merge pull request#6from ReenigneArcher/add-build-checks
2c08733
Update create_package.yml
@KuleRucketKuleRucket mentioned this pull request Feb 22, 2022
Closed
@HomerSpHomerSp mentioned this pull request Mar 9, 2022
Merged
5 tasks
This was referenced Jul 16, 2022
Closed
Closed
@qdoreqdore mentioned this pull request Jul 7, 2023
Closed
3 tasks
@SidefixSidefix mentioned this pull request Aug 7, 2024
Closed
2 tasks
@magne4000magne4000 mentioned this pull request Dec 15, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@TheElixZammutoTheElixZammutoTheElixZammuto approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ReenigneArcher@TheElixZammuto
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Automated PR tests and releases - #6
Merged
ReenigneArcher merged 105 commits into
LizardByte:nightlyfrom 
ReenigneArcher:add-build-checks
Jan 12, 2022
Merged
Automated PR tests and releases#6
ReenigneArcher merged 105 commits into
LizardByte:nightlyfrom 
ReenigneArcher:add-build-checks
Conversation
@ReenigneArcher
@ReenigneArcherReenigneArcher
commented
Jan 11, 2022

Copy link


Copy Markdown

Member
Description
  • Added CHANGELOG.md
  • Add build checks
  • Add automated release

    • CHANGELOG.md version must not match latest released tag_name
    • CHANGELOG version is compared to latest released version on Pull Request into master
  • Added Fedora build Dockerfiles (no packaging yet)
  • Improved readability of Dockerfiles
  • Use update-alternatives instead of cp for older Ubuntu distros
  • Added AppImage
Type of Change
Please delete options that are not relevant.
  •  New feature (non-breaking change which adds functionality)
Checklist
  •  My code follows the style guidelines of this project
  •  I have performed a self-review of my own code
  •  I have commented my code, particularly in hard-to-understand areas
  •  I have added or updated the documentation blocks for new or existing components
@ReenigneArcher
Create sunshine.png
1b0978f
@ReenigneArcher
Create sunshine.desktop
a268cb5
@ReenigneArcher
Create pull-requests_build-check.yml
8478ccc
@ReenigneArcher
Update pull-requests_build-check.yml
c5b8def
-Fix syntax error
@ReenigneArcher
Update pull-requests_build-check.yml
e2d3fef
-Attempt to fix build step at line 56
-Various tweaks to quoting and directory names
@ReenigneArcher
Update pull-requests_build-check.yml
89cfbc6
-Checkout recursively with submodules
@ReenigneArcher
Update pull-requests_build-check.yml
f272b86
-recursive submodules
-only run on PR for master or nightly branch
@ReenigneArcher
Update pull-requests_build-check.yml
502bf8e
-Add deb job with matrix strategy
@ReenigneArcher
Fix typo in docker build readme
47a7c5e
@ReenigneArcher
Update pull-requests_build-check.yml
69642d2
@ReenigneArcher
Update pull-requests_build-check.yml
23f9474
@ReenigneArcher
Update pull-requests_build-check.yml
bbdf961
@ReenigneArcher
Update pull-requests_build-check.yml
ca8917d
-build with -u for non interactive
@ReenigneArcher
Update pull-requests_build-check.yml
65b9b65
-Fix command that moves deb package
-Separate setup, build, and package steps
@ReenigneArcher
Update pull-requests_build-check.yml
b73ddc2
-Fix permission denied error when moving deb package
@ReenigneArcher
Update pull-requests_build-check.yml
2561886
-Add Windows build
@ReenigneArcher
Update pull-requests_build-check.yml
0fa6839
-Fix path issue for pacman command
@ReenigneArcher
Update pull-requests_build-check.yml
71b5495
-Boost debug on
@ReenigneArcher
Update pull-requests_build-check.yml
f6d9061
-Install boost
-Remove boost debug during cmake
@ReenigneArcher
Update pull-requests_build-check.yml
2b0e1fb
-Fix boost install directory
@ReenigneArcher
Update pull-requests_build-check.yml
de8cff0
-Add environment variable BOOST_ROOT
@ReenigneArcher
Update pull-requests_build-check.yml
c49cbd3
@ReenigneArcher
Update pull-requests_build-check.yml
2144787
-Try older version of boost, new version failing with cmake 3.22
@ReenigneArcher
Update pull-requests_build-check.yml
1039160
-Try boost v1.73.0 built on windows server 2019
@ReenigneArcher
Update pull-requests_build-check.yml
9fbfca5
-Try boost 1.72.0
@ReenigneArcher
Update pull-requests_build-check.yml
2512e7f
-Testing
@ReenigneArcher
Update pull-requests_build-check.yml
3f2ee64
-Testing
@ReenigneArcher
Update pull-requests_build-check.yml
ed38b7e
-Testing
@ReenigneArcher
Update pull-requests_build-check.yml
ff47a13
@ReenigneArcher
Update pull-requests_build-check.yml
17770fe
@ReenigneArcher
ReenigneArcher
commented
Jan 11, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I apologize for all the commits. Workflows are not the easiest thing to test.
Here is a workflow run for creating a new release (when the release version was updated): https://github.com/ReenigneArcher/Sunshine/actions/runs/1683355353
And here is a workflow run when the release version was not updated in the CHANGELOG.md (this should also be caught when the PR is created against the master branch): https://github.com/ReenigneArcher/Sunshine/actions/runs/1683445817
And here is an example of the release: https://github.com/ReenigneArcher/Sunshine/releases
@ReenigneArcher
ReenigneArcher
commented
Jan 11, 2022

Copy link


Copy Markdown

MemberAuthor
This needs a little tweaking on the create release action due to the multiple steps, it fails on all except the first build. I have an idea to fix it though.
@ReenigneArcher
ReenigneArcher
marked this pull request as draft
January 11, 2022 21:52
@ReenigneArcher
Update create_package.yml
cefcaed
@ReenigneArcher
Update create_package.yml
a2c45f8
-Fix typo in Windows build
@ReenigneArcher
Update create_package.yml
8781fbc
- github.base_ref is needed for pull request check
@ReenigneArcher
Update create_package.yml
f2c53a5
-Verify changelog requires checkout
@ReenigneArcher
ReenigneArcher
commented
Jan 12, 2022

Copy link


Copy Markdown

MemberAuthor
Updated Examples:
PR into nightly branch
https://github.com/ReenigneArcher/Sunshine/actions/runs/1685200094

-No check on CHANGELOG.md

-Build each version

-Package everything except Fedora

-Upload artifacts
PR into master branch

When the release version from the changelog matches the latest released version: https://github.com/ReenigneArcher/Sunshine/actions/runs/1685245727/attempts/1

-Intentionally fail the workflow (gives an opportunity to fix the CHANGELOG.md before accepting the PR)

-Build each version

-Package everything except Fedora

-Upload artifacts
Release version in changelog was updated and does not match latest released version: https://github.com/ReenigneArcher/Sunshine/actions/runs/1685245727/attempts/2

-Same as attempt 1 except workflow passes beyond changelog check
push into master branch
https://github.com/ReenigneArcher/Sunshine/actions/runs/1685294883
  • Harder to fix anything at this point so:

    • The check on changelog is done earlier when the PR is made into master
Example of Created Release
https://github.com/ReenigneArcher/Sunshine/releases/tag/0.0.0
@ReenigneArcher
ReenigneArcher
marked this pull request as ready for review
January 12, 2022 00:37
@TheElixZammuto
TheElixZammuto
commented
Jan 12, 2022

Copy link


Copy Markdown

Member
Not an expert on the GitHub actions side, so all I can say is LGTM for the workflow side of things
@ReenigneArcher
ReenigneArcher
merged commit d1a41ad
into
LizardByte:nightlyJan 12, 2022
@ReenigneArcher
ReenigneArcher
deleted the

add-build-checks

branch
January 12, 2022 22:19
ReenigneArcher added a commit
that referenced
this pull request
Jan 13, 2022
@ReenigneArcher
Merge pull request#6from ReenigneArcher/add-build-checks
2c08733
Update create_package.yml
@KuleRucketKuleRucket
mentioned this pull request
Feb 22, 2022

Closed

@HomerSpHomerSp
mentioned this pull request
Mar 9, 2022
 Merged

5 tasks

This was referenced Jul 16, 2022

Closed


Closed

@qdoreqdore
mentioned this pull request
Jul 7, 2023

Closed

3 tasks
@SidefixSidefix
mentioned this pull request
Aug 7, 2024

Closed

2 tasks
@magne4000magne4000
mentioned this pull request
Dec 15, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@TheElixZammutoTheElixZammutoTheElixZammuto approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@ReenigneArcher@TheElixZammuto

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Automated PR tests and releases - #6
Merged
ReenigneArcher merged 105 commits into
LizardByte:nightlyfrom 
ReenigneArcher:add-build-checks
Jan 12, 2022
Merged
Automated PR tests and releases#6
ReenigneArcher merged 105 commits into
LizardByte:nightlyfrom 
ReenigneArcher:add-build-checks
Conversation
@ReenigneArcher
@ReenigneArcherReenigneArcher
commented
Jan 11, 2022

Copy link


Copy Markdown

Member
Description
  • Added CHANGELOG.md
  • Add build checks
  • Add automated release

    • CHANGELOG.md version must not match latest released tag_name
    • CHANGELOG version is compared to latest released version on Pull Request into master
  • Added Fedora build Dockerfiles (no packaging yet)
  • Improved readability of Dockerfiles
  • Use update-alternatives instead of cp for older Ubuntu distros
  • Added AppImage
Type of Change
Please delete options that are not relevant.
  •  New feature (non-breaking change which adds functionality)
Checklist
  •  My code follows the style guidelines of this project
  •  I have performed a self-review of my own code
  •  I have commented my code, particularly in hard-to-understand areas
  •  I have added or updated the documentation blocks for new or existing components
@ReenigneArcher
Create sunshine.png
1b0978f
@ReenigneArcher
Create sunshine.desktop
a268cb5
@ReenigneArcher
Create pull-requests_build-check.yml
8478ccc
@ReenigneArcher
Update pull-requests_build-check.yml
c5b8def
-Fix syntax error
@ReenigneArcher
Update pull-requests_build-check.yml
e2d3fef
-Attempt to fix build step at line 56
-Various tweaks to quoting and directory names
@ReenigneArcher
Update pull-requests_build-check.yml
89cfbc6
-Checkout recursively with submodules
@ReenigneArcher
Update pull-requests_build-check.yml
f272b86
-recursive submodules
-only run on PR for master or nightly branch
@ReenigneArcher
Update pull-requests_build-check.yml
502bf8e
-Add deb job with matrix strategy
@ReenigneArcher
Fix typo in docker build readme
47a7c5e
@ReenigneArcher
Update pull-requests_build-check.yml
69642d2
@ReenigneArcher
Update pull-requests_build-check.yml
23f9474
@ReenigneArcher
Update pull-requests_build-check.yml
bbdf961
@ReenigneArcher
Update pull-requests_build-check.yml
ca8917d
-build with -u for non interactive
@ReenigneArcher
Update pull-requests_build-check.yml
65b9b65
-Fix command that moves deb package
-Separate setup, build, and package steps
@ReenigneArcher
Update pull-requests_build-check.yml
b73ddc2
-Fix permission denied error when moving deb package
@ReenigneArcher
Update pull-requests_build-check.yml
2561886
-Add Windows build
@ReenigneArcher
Update pull-requests_build-check.yml
0fa6839
-Fix path issue for pacman command
@ReenigneArcher
Update pull-requests_build-check.yml
71b5495
-Boost debug on
@ReenigneArcher
Update pull-requests_build-check.yml
f6d9061
-Install boost
-Remove boost debug during cmake
@ReenigneArcher
Update pull-requests_build-check.yml
2b0e1fb
-Fix boost install directory
@ReenigneArcher
Update pull-requests_build-check.yml
de8cff0
-Add environment variable BOOST_ROOT
@ReenigneArcher
Update pull-requests_build-check.yml
c49cbd3
@ReenigneArcher
Update pull-requests_build-check.yml
2144787
-Try older version of boost, new version failing with cmake 3.22
@ReenigneArcher
Update pull-requests_build-check.yml
1039160
-Try boost v1.73.0 built on windows server 2019
@ReenigneArcher
Update pull-requests_build-check.yml
9fbfca5
-Try boost 1.72.0
@ReenigneArcher
Update pull-requests_build-check.yml
2512e7f
-Testing
@ReenigneArcher
Update pull-requests_build-check.yml
3f2ee64
-Testing
@ReenigneArcher
Update pull-requests_build-check.yml
ed38b7e
-Testing
@ReenigneArcher
Update pull-requests_build-check.yml
ff47a13
@ReenigneArcher
Update pull-requests_build-check.yml
17770fe
@ReenigneArcher
ReenigneArcher
commented
Jan 11, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I apologize for all the commits. Workflows are not the easiest thing to test.
Here is a workflow run for creating a new release (when the release version was updated): https://github.com/ReenigneArcher/Sunshine/actions/runs/1683355353
And here is a workflow run when the release version was not updated in the CHANGELOG.md (this should also be caught when the PR is created against the master branch): https://github.com/ReenigneArcher/Sunshine/actions/runs/1683445817
And here is an example of the release: https://github.com/ReenigneArcher/Sunshine/releases
@ReenigneArcher
ReenigneArcher
commented
Jan 11, 2022

Copy link


Copy Markdown

MemberAuthor
This needs a little tweaking on the create release action due to the multiple steps, it fails on all except the first build. I have an idea to fix it though.
@ReenigneArcher
ReenigneArcher
marked this pull request as draft
January 11, 2022 21:52
@ReenigneArcher
Update create_package.yml
cefcaed
@ReenigneArcher
Update create_package.yml
a2c45f8
-Fix typo in Windows build
@ReenigneArcher
Update create_package.yml
8781fbc
- github.base_ref is needed for pull request check
@ReenigneArcher
Update create_package.yml
f2c53a5
-Verify changelog requires checkout
@ReenigneArcher
ReenigneArcher
commented
Jan 12, 2022

Copy link


Copy Markdown

MemberAuthor
Updated Examples:
PR into nightly branch
https://github.com/ReenigneArcher/Sunshine/actions/runs/1685200094

-No check on CHANGELOG.md

-Build each version

-Package everything except Fedora

-Upload artifacts
PR into master branch

When the release version from the changelog matches the latest released version: https://github.com/ReenigneArcher/Sunshine/actions/runs/1685245727/attempts/1

-Intentionally fail the workflow (gives an opportunity to fix the CHANGELOG.md before accepting the PR)

-Build each version

-Package everything except Fedora

-Upload artifacts
Release version in changelog was updated and does not match latest released version: https://github.com/ReenigneArcher/Sunshine/actions/runs/1685245727/attempts/2

-Same as attempt 1 except workflow passes beyond changelog check
push into master branch
https://github.com/ReenigneArcher/Sunshine/actions/runs/1685294883
  • Harder to fix anything at this point so:

    • The check on changelog is done earlier when the PR is made into master
Example of Created Release
https://github.com/ReenigneArcher/Sunshine/releases/tag/0.0.0
@ReenigneArcher
ReenigneArcher
marked this pull request as ready for review
January 12, 2022 00:37
@TheElixZammuto
TheElixZammuto
commented
Jan 12, 2022

Copy link


Copy Markdown

Member
Not an expert on the GitHub actions side, so all I can say is LGTM for the workflow side of things
@ReenigneArcher
ReenigneArcher
merged commit d1a41ad
into
LizardByte:nightlyJan 12, 2022
@ReenigneArcher
ReenigneArcher
deleted the

add-build-checks

branch
January 12, 2022 22:19
ReenigneArcher added a commit
that referenced
this pull request
Jan 13, 2022
@ReenigneArcher
Merge pull request#6from ReenigneArcher/add-build-checks
2c08733
Update create_package.yml
@KuleRucketKuleRucket
mentioned this pull request
Feb 22, 2022

Closed

@HomerSpHomerSp
mentioned this pull request
Mar 9, 2022
 Merged

5 tasks

This was referenced Jul 16, 2022

Closed


Closed

@qdoreqdore
mentioned this pull request
Jul 7, 2023

Closed

3 tasks
@SidefixSidefix
mentioned this pull request
Aug 7, 2024

Closed

2 tasks
@magne4000magne4000
mentioned this pull request
Dec 15, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@TheElixZammutoTheElixZammutoTheElixZammuto approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@ReenigneArcher@TheElixZammuto

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Automated PR tests and releases - #6
Merged
ReenigneArcher merged 105 commits into
LizardByte:nightlyfrom 
ReenigneArcher:add-build-checks
Jan 12, 2022
Merged
Automated PR tests and releases#6
ReenigneArcher merged 105 commits into
LizardByte:nightlyfrom 
ReenigneArcher:add-build-checks
Conversation
@ReenigneArcher
@ReenigneArcherReenigneArcher
commented
Jan 11, 2022

Copy link


Copy Markdown

Member
Description
  • Added CHANGELOG.md
  • Add build checks
  • Add automated release

    • CHANGELOG.md version must not match latest released tag_name
    • CHANGELOG version is compared to latest released version on Pull Request into master
  • Added Fedora build Dockerfiles (no packaging yet)
  • Improved readability of Dockerfiles
  • Use update-alternatives instead of cp for older Ubuntu distros
  • Added AppImage
Type of Change
Please delete options that are not relevant.
  •  New feature (non-breaking change which adds functionality)
Checklist
  •  My code follows the style guidelines of this project
  •  I have performed a self-review of my own code
  •  I have commented my code, particularly in hard-to-understand areas
  •  I have added or updated the documentation blocks for new or existing components
@ReenigneArcher
Create sunshine.png
1b0978f
@ReenigneArcher
Create sunshine.desktop
a268cb5
@ReenigneArcher
Create pull-requests_build-check.yml
8478ccc
@ReenigneArcher
Update pull-requests_build-check.yml
c5b8def
-Fix syntax error
@ReenigneArcher
Update pull-requests_build-check.yml
e2d3fef
-Attempt to fix build step at line 56
-Various tweaks to quoting and directory names
@ReenigneArcher
Update pull-requests_build-check.yml
89cfbc6
-Checkout recursively with submodules
@ReenigneArcher
Update pull-requests_build-check.yml
f272b86
-recursive submodules
-only run on PR for master or nightly branch
@ReenigneArcher
Update pull-requests_build-check.yml
502bf8e
-Add deb job with matrix strategy
@ReenigneArcher
Fix typo in docker build readme
47a7c5e
@ReenigneArcher
Update pull-requests_build-check.yml
69642d2
@ReenigneArcher
Update pull-requests_build-check.yml
23f9474
@ReenigneArcher
Update pull-requests_build-check.yml
bbdf961
@ReenigneArcher
Update pull-requests_build-check.yml
ca8917d
-build with -u for non interactive
@ReenigneArcher
Update pull-requests_build-check.yml
65b9b65
-Fix command that moves deb package
-Separate setup, build, and package steps
@ReenigneArcher
Update pull-requests_build-check.yml
b73ddc2
-Fix permission denied error when moving deb package
@ReenigneArcher
Update pull-requests_build-check.yml
2561886
-Add Windows build
@ReenigneArcher
Update pull-requests_build-check.yml
0fa6839
-Fix path issue for pacman command
@ReenigneArcher
Update pull-requests_build-check.yml
71b5495
-Boost debug on
@ReenigneArcher
Update pull-requests_build-check.yml
f6d9061
-Install boost
-Remove boost debug during cmake
@ReenigneArcher
Update pull-requests_build-check.yml
2b0e1fb
-Fix boost install directory
@ReenigneArcher
Update pull-requests_build-check.yml
de8cff0
-Add environment variable BOOST_ROOT
@ReenigneArcher
Update pull-requests_build-check.yml
c49cbd3
@ReenigneArcher
Update pull-requests_build-check.yml
2144787
-Try older version of boost, new version failing with cmake 3.22
@ReenigneArcher
Update pull-requests_build-check.yml
1039160
-Try boost v1.73.0 built on windows server 2019
@ReenigneArcher
Update pull-requests_build-check.yml
9fbfca5
-Try boost 1.72.0
@ReenigneArcher
Update pull-requests_build-check.yml
2512e7f
-Testing
@ReenigneArcher
Update pull-requests_build-check.yml
3f2ee64
-Testing
@ReenigneArcher
Update pull-requests_build-check.yml
ed38b7e
-Testing
@ReenigneArcher
Update pull-requests_build-check.yml
ff47a13
@ReenigneArcher
Update pull-requests_build-check.yml
17770fe
@ReenigneArcher
ReenigneArcher
commented
Jan 11, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I apologize for all the commits. Workflows are not the easiest thing to test.
Here is a workflow run for creating a new release (when the release version was updated): https://github.com/ReenigneArcher/Sunshine/actions/runs/1683355353
And here is a workflow run when the release version was not updated in the CHANGELOG.md (this should also be caught when the PR is created against the master branch): https://github.com/ReenigneArcher/Sunshine/actions/runs/1683445817
And here is an example of the release: https://github.com/ReenigneArcher/Sunshine/releases
@ReenigneArcher
ReenigneArcher
commented
Jan 11, 2022

Copy link


Copy Markdown

MemberAuthor
This needs a little tweaking on the create release action due to the multiple steps, it fails on all except the first build. I have an idea to fix it though.
@ReenigneArcher
ReenigneArcher
marked this pull request as draft
January 11, 2022 21:52
@ReenigneArcher
Update create_package.yml
cefcaed
@ReenigneArcher
Update create_package.yml
a2c45f8
-Fix typo in Windows build
@ReenigneArcher
Update create_package.yml
8781fbc
- github.base_ref is needed for pull request check
@ReenigneArcher
Update create_package.yml
f2c53a5
-Verify changelog requires checkout
@ReenigneArcher
ReenigneArcher
commented
Jan 12, 2022

Copy link


Copy Markdown

MemberAuthor
Updated Examples:
PR into nightly branch
https://github.com/ReenigneArcher/Sunshine/actions/runs/1685200094

-No check on CHANGELOG.md

-Build each version

-Package everything except Fedora

-Upload artifacts
PR into master branch

When the release version from the changelog matches the latest released version: https://github.com/ReenigneArcher/Sunshine/actions/runs/1685245727/attempts/1

-Intentionally fail the workflow (gives an opportunity to fix the CHANGELOG.md before accepting the PR)

-Build each version

-Package everything except Fedora

-Upload artifacts
Release version in changelog was updated and does not match latest released version: https://github.com/ReenigneArcher/Sunshine/actions/runs/1685245727/attempts/2

-Same as attempt 1 except workflow passes beyond changelog check
push into master branch
https://github.com/ReenigneArcher/Sunshine/actions/runs/1685294883
  • Harder to fix anything at this point so:

    • The check on changelog is done earlier when the PR is made into master
Example of Created Release
https://github.com/ReenigneArcher/Sunshine/releases/tag/0.0.0
@ReenigneArcher
ReenigneArcher
marked this pull request as ready for review
January 12, 2022 00:37
@TheElixZammuto
TheElixZammuto
commented
Jan 12, 2022

Copy link


Copy Markdown

Member
Not an expert on the GitHub actions side, so all I can say is LGTM for the workflow side of things
@ReenigneArcher
ReenigneArcher
merged commit d1a41ad
into
LizardByte:nightlyJan 12, 2022
@ReenigneArcher
ReenigneArcher
deleted the

add-build-checks

branch
January 12, 2022 22:19
ReenigneArcher added a commit
that referenced
this pull request
Jan 13, 2022
@ReenigneArcher
Merge pull request#6from ReenigneArcher/add-build-checks
2c08733
Update create_package.yml
@KuleRucketKuleRucket
mentioned this pull request
Feb 22, 2022

Closed

@HomerSpHomerSp
mentioned this pull request
Mar 9, 2022
 Merged

5 tasks

This was referenced Jul 16, 2022

Closed


Closed

@qdoreqdore
mentioned this pull request
Jul 7, 2023

Closed

3 tasks
@SidefixSidefix
mentioned this pull request
Aug 7, 2024

Closed

2 tasks
@magne4000magne4000
mentioned this pull request
Dec 15, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@TheElixZammutoTheElixZammutoTheElixZammuto approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@ReenigneArcher@TheElixZammuto

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Automated PR tests and releases - #6
Merged
ReenigneArcher merged 105 commits into
LizardByte:nightlyfrom 
ReenigneArcher:add-build-checks
Jan 12, 2022
Merged
Automated PR tests and releases#6
ReenigneArcher merged 105 commits into
LizardByte:nightlyfrom 
ReenigneArcher:add-build-checks
Conversation
@ReenigneArcher
@ReenigneArcherReenigneArcher
commented
Jan 11, 2022

Copy link


Copy Markdown

Member
Description
  • Added CHANGELOG.md
  • Add build checks
  • Add automated release

    • CHANGELOG.md version must not match latest released tag_name
    • CHANGELOG version is compared to latest released version on Pull Request into master
  • Added Fedora build Dockerfiles (no packaging yet)
  • Improved readability of Dockerfiles
  • Use update-alternatives instead of cp for older Ubuntu distros
  • Added AppImage
Type of Change
Please delete options that are not relevant.
  •  New feature (non-breaking change which adds functionality)
Checklist
  •  My code follows the style guidelines of this project
  •  I have performed a self-review of my own code
  •  I have commented my code, particularly in hard-to-understand areas
  •  I have added or updated the documentation blocks for new or existing components
@ReenigneArcher
Create sunshine.png
1b0978f
@ReenigneArcher
Create sunshine.desktop
a268cb5
@ReenigneArcher
Create pull-requests_build-check.yml
8478ccc
@ReenigneArcher
Update pull-requests_build-check.yml
c5b8def
-Fix syntax error
@ReenigneArcher
Update pull-requests_build-check.yml
e2d3fef
-Attempt to fix build step at line 56
-Various tweaks to quoting and directory names
@ReenigneArcher
Update pull-requests_build-check.yml
89cfbc6
-Checkout recursively with submodules
@ReenigneArcher
Update pull-requests_build-check.yml
f272b86
-recursive submodules
-only run on PR for master or nightly branch
@ReenigneArcher
Update pull-requests_build-check.yml
502bf8e
-Add deb job with matrix strategy
@ReenigneArcher
Fix typo in docker build readme
47a7c5e
@ReenigneArcher
Update pull-requests_build-check.yml
69642d2
@ReenigneArcher
Update pull-requests_build-check.yml
23f9474
@ReenigneArcher
Update pull-requests_build-check.yml
bbdf961
@ReenigneArcher
Update pull-requests_build-check.yml
ca8917d
-build with -u for non interactive
@ReenigneArcher
Update pull-requests_build-check.yml
65b9b65
-Fix command that moves deb package
-Separate setup, build, and package steps
@ReenigneArcher
Update pull-requests_build-check.yml
b73ddc2
-Fix permission denied error when moving deb package
@ReenigneArcher
Update pull-requests_build-check.yml
2561886
-Add Windows build
@ReenigneArcher
Update pull-requests_build-check.yml
0fa6839
-Fix path issue for pacman command
@ReenigneArcher
Update pull-requests_build-check.yml
71b5495
-Boost debug on
@ReenigneArcher
Update pull-requests_build-check.yml
f6d9061
-Install boost
-Remove boost debug during cmake
@ReenigneArcher
Update pull-requests_build-check.yml
2b0e1fb
-Fix boost install directory
@ReenigneArcher
Update pull-requests_build-check.yml
de8cff0
-Add environment variable BOOST_ROOT
@ReenigneArcher
Update pull-requests_build-check.yml
c49cbd3
@ReenigneArcher
Update pull-requests_build-check.yml
2144787
-Try older version of boost, new version failing with cmake 3.22
@ReenigneArcher
Update pull-requests_build-check.yml
1039160
-Try boost v1.73.0 built on windows server 2019
@ReenigneArcher
Update pull-requests_build-check.yml
9fbfca5
-Try boost 1.72.0
@ReenigneArcher
Update pull-requests_build-check.yml
2512e7f
-Testing
@ReenigneArcher
Update pull-requests_build-check.yml
3f2ee64
-Testing
@ReenigneArcher
Update pull-requests_build-check.yml
ed38b7e
-Testing
@ReenigneArcher
Update pull-requests_build-check.yml
ff47a13
@ReenigneArcher
Update pull-requests_build-check.yml
17770fe
@ReenigneArcher
ReenigneArcher
commented
Jan 11, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I apologize for all the commits. Workflows are not the easiest thing to test.
Here is a workflow run for creating a new release (when the release version was updated): https://github.com/ReenigneArcher/Sunshine/actions/runs/1683355353
And here is a workflow run when the release version was not updated in the CHANGELOG.md (this should also be caught when the PR is created against the master branch): https://github.com/ReenigneArcher/Sunshine/actions/runs/1683445817
And here is an example of the release: https://github.com/ReenigneArcher/Sunshine/releases
@ReenigneArcher
ReenigneArcher
commented
Jan 11, 2022

Copy link


Copy Markdown

MemberAuthor
This needs a little tweaking on the create release action due to the multiple steps, it fails on all except the first build. I have an idea to fix it though.
@ReenigneArcher
ReenigneArcher
marked this pull request as draft
January 11, 2022 21:52
@ReenigneArcher
Update create_package.yml
cefcaed
@ReenigneArcher
Update create_package.yml
a2c45f8
-Fix typo in Windows build
@ReenigneArcher
Update create_package.yml
8781fbc
- github.base_ref is needed for pull request check
@ReenigneArcher
Update create_package.yml
f2c53a5
-Verify changelog requires checkout
@ReenigneArcher
ReenigneArcher
commented
Jan 12, 2022

Copy link


Copy Markdown

MemberAuthor
Updated Examples:
PR into nightly branch
https://github.com/ReenigneArcher/Sunshine/actions/runs/1685200094

-No check on CHANGELOG.md

-Build each version

-Package everything except Fedora

-Upload artifacts
PR into master branch

When the release version from the changelog matches the latest released version: https://github.com/ReenigneArcher/Sunshine/actions/runs/1685245727/attempts/1

-Intentionally fail the workflow (gives an opportunity to fix the CHANGELOG.md before accepting the PR)

-Build each version

-Package everything except Fedora

-Upload artifacts
Release version in changelog was updated and does not match latest released version: https://github.com/ReenigneArcher/Sunshine/actions/runs/1685245727/attempts/2

-Same as attempt 1 except workflow passes beyond changelog check
push into master branch
https://github.com/ReenigneArcher/Sunshine/actions/runs/1685294883
  • Harder to fix anything at this point so:

    • The check on changelog is done earlier when the PR is made into master
Example of Created Release
https://github.com/ReenigneArcher/Sunshine/releases/tag/0.0.0
@ReenigneArcher
ReenigneArcher
marked this pull request as ready for review
January 12, 2022 00:37
@TheElixZammuto
TheElixZammuto
commented
Jan 12, 2022

Copy link


Copy Markdown

Member
Not an expert on the GitHub actions side, so all I can say is LGTM for the workflow side of things
@ReenigneArcher
ReenigneArcher
merged commit d1a41ad
into
LizardByte:nightlyJan 12, 2022
@ReenigneArcher
ReenigneArcher
deleted the

add-build-checks

branch
January 12, 2022 22:19
ReenigneArcher added a commit
that referenced
this pull request
Jan 13, 2022
@ReenigneArcher
Merge pull request#6from ReenigneArcher/add-build-checks
2c08733
Update create_package.yml
@KuleRucketKuleRucket
mentioned this pull request
Feb 22, 2022

Closed

@HomerSpHomerSp
mentioned this pull request
Mar 9, 2022
 Merged

5 tasks

This was referenced Jul 16, 2022

Closed


Closed

@qdoreqdore
mentioned this pull request
Jul 7, 2023

Closed

3 tasks
@SidefixSidefix
mentioned this pull request
Aug 7, 2024

Closed

2 tasks
@magne4000magne4000
mentioned this pull request
Dec 15, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@TheElixZammutoTheElixZammutoTheElixZammuto approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@ReenigneArcher@TheElixZammuto

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Automated PR tests and releases - #6
Merged
ReenigneArcher merged 105 commits into
LizardByte:nightlyfrom 
ReenigneArcher:add-build-checks
Jan 12, 2022
Merged
Automated PR tests and releases#6
ReenigneArcher merged 105 commits into
LizardByte:nightlyfrom 
ReenigneArcher:add-build-checks
Conversation
@ReenigneArcher
@ReenigneArcherReenigneArcher
commented
Jan 11, 2022

Copy link


Copy Markdown

Member
Description
  • Added CHANGELOG.md
  • Add build checks
  • Add automated release

    • CHANGELOG.md version must not match latest released tag_name
    • CHANGELOG version is compared to latest released version on Pull Request into master
  • Added Fedora build Dockerfiles (no packaging yet)
  • Improved readability of Dockerfiles
  • Use update-alternatives instead of cp for older Ubuntu distros
  • Added AppImage
Type of Change
Please delete options that are not relevant.
  •  New feature (non-breaking change which adds functionality)
Checklist
  •  My code follows the style guidelines of this project
  •  I have performed a self-review of my own code
  •  I have commented my code, particularly in hard-to-understand areas
  •  I have added or updated the documentation blocks for new or existing components
@ReenigneArcher
Create sunshine.png
1b0978f
@ReenigneArcher
Create sunshine.desktop
a268cb5
@ReenigneArcher
Create pull-requests_build-check.yml
8478ccc
@ReenigneArcher
Update pull-requests_build-check.yml
c5b8def
-Fix syntax error
@ReenigneArcher
Update pull-requests_build-check.yml
e2d3fef
-Attempt to fix build step at line 56
-Various tweaks to quoting and directory names
@ReenigneArcher
Update pull-requests_build-check.yml
89cfbc6
-Checkout recursively with submodules
@ReenigneArcher
Update pull-requests_build-check.yml
f272b86
-recursive submodules
-only run on PR for master or nightly branch
@ReenigneArcher
Update pull-requests_build-check.yml
502bf8e
-Add deb job with matrix strategy
@ReenigneArcher
Fix typo in docker build readme
47a7c5e
@ReenigneArcher
Update pull-requests_build-check.yml
69642d2
@ReenigneArcher
Update pull-requests_build-check.yml
23f9474
@ReenigneArcher
Update pull-requests_build-check.yml
bbdf961
@ReenigneArcher
Update pull-requests_build-check.yml
ca8917d
-build with -u for non interactive
@ReenigneArcher
Update pull-requests_build-check.yml
65b9b65
-Fix command that moves deb package
-Separate setup, build, and package steps
@ReenigneArcher
Update pull-requests_build-check.yml
b73ddc2
-Fix permission denied error when moving deb package
@ReenigneArcher
Update pull-requests_build-check.yml
2561886
-Add Windows build
@ReenigneArcher
Update pull-requests_build-check.yml
0fa6839
-Fix path issue for pacman command
@ReenigneArcher
Update pull-requests_build-check.yml
71b5495
-Boost debug on
@ReenigneArcher
Update pull-requests_build-check.yml
f6d9061
-Install boost
-Remove boost debug during cmake
@ReenigneArcher
Update pull-requests_build-check.yml
2b0e1fb
-Fix boost install directory
@ReenigneArcher
Update pull-requests_build-check.yml
de8cff0
-Add environment variable BOOST_ROOT
@ReenigneArcher
Update pull-requests_build-check.yml
c49cbd3
@ReenigneArcher
Update pull-requests_build-check.yml
2144787
-Try older version of boost, new version failing with cmake 3.22
@ReenigneArcher
Update pull-requests_build-check.yml
1039160
-Try boost v1.73.0 built on windows server 2019
@ReenigneArcher
Update pull-requests_build-check.yml
9fbfca5
-Try boost 1.72.0
@ReenigneArcher
Update pull-requests_build-check.yml
2512e7f
-Testing
@ReenigneArcher
Update pull-requests_build-check.yml
3f2ee64
-Testing
@ReenigneArcher
Update pull-requests_build-check.yml
ed38b7e
-Testing
@ReenigneArcher
Update pull-requests_build-check.yml
ff47a13
@ReenigneArcher
Update pull-requests_build-check.yml
17770fe
@ReenigneArcher
ReenigneArcher
commented
Jan 11, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I apologize for all the commits. Workflows are not the easiest thing to test.
Here is a workflow run for creating a new release (when the release version was updated): https://github.com/ReenigneArcher/Sunshine/actions/runs/1683355353
And here is a workflow run when the release version was not updated in the CHANGELOG.md (this should also be caught when the PR is created against the master branch): https://github.com/ReenigneArcher/Sunshine/actions/runs/1683445817
And here is an example of the release: https://github.com/ReenigneArcher/Sunshine/releases
@ReenigneArcher
ReenigneArcher
commented
Jan 11, 2022

Copy link


Copy Markdown

MemberAuthor
This needs a little tweaking on the create release action due to the multiple steps, it fails on all except the first build. I have an idea to fix it though.
@ReenigneArcher
ReenigneArcher
marked this pull request as draft
January 11, 2022 21:52
@ReenigneArcher
Update create_package.yml
cefcaed
@ReenigneArcher
Update create_package.yml
a2c45f8
-Fix typo in Windows build
@ReenigneArcher
Update create_package.yml
8781fbc
- github.base_ref is needed for pull request check
@ReenigneArcher
Update create_package.yml
f2c53a5
-Verify changelog requires checkout
@ReenigneArcher
ReenigneArcher
commented
Jan 12, 2022

Copy link


Copy Markdown

MemberAuthor
Updated Examples:
PR into nightly branch
https://github.com/ReenigneArcher/Sunshine/actions/runs/1685200094

-No check on CHANGELOG.md

-Build each version

-Package everything except Fedora

-Upload artifacts
PR into master branch

When the release version from the changelog matches the latest released version: https://github.com/ReenigneArcher/Sunshine/actions/runs/1685245727/attempts/1

-Intentionally fail the workflow (gives an opportunity to fix the CHANGELOG.md before accepting the PR)

-Build each version

-Package everything except Fedora

-Upload artifacts
Release version in changelog was updated and does not match latest released version: https://github.com/ReenigneArcher/Sunshine/actions/runs/1685245727/attempts/2

-Same as attempt 1 except workflow passes beyond changelog check
push into master branch
https://github.com/ReenigneArcher/Sunshine/actions/runs/1685294883
  • Harder to fix anything at this point so:

    • The check on changelog is done earlier when the PR is made into master
Example of Created Release
https://github.com/ReenigneArcher/Sunshine/releases/tag/0.0.0
@ReenigneArcher
ReenigneArcher
marked this pull request as ready for review
January 12, 2022 00:37
@TheElixZammuto
TheElixZammuto
commented
Jan 12, 2022

Copy link


Copy Markdown

Member
Not an expert on the GitHub actions side, so all I can say is LGTM for the workflow side of things
@ReenigneArcher
ReenigneArcher
merged commit d1a41ad
into
LizardByte:nightlyJan 12, 2022
@ReenigneArcher
ReenigneArcher
deleted the

add-build-checks

branch
January 12, 2022 22:19
ReenigneArcher added a commit
that referenced
this pull request
Jan 13, 2022
@ReenigneArcher
Merge pull request#6from ReenigneArcher/add-build-checks
2c08733
Update create_package.yml
@KuleRucketKuleRucket
mentioned this pull request
Feb 22, 2022

Closed

@HomerSpHomerSp
mentioned this pull request
Mar 9, 2022
 Merged

5 tasks

This was referenced Jul 16, 2022

Closed


Closed

@qdoreqdore
mentioned this pull request
Jul 7, 2023

Closed

3 tasks
@SidefixSidefix
mentioned this pull request
Aug 7, 2024

Closed

2 tasks
@magne4000magne4000
mentioned this pull request
Dec 15, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@TheElixZammutoTheElixZammutoTheElixZammuto approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@ReenigneArcher@TheElixZammuto

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Automated PR tests and releases - #6
Merged
ReenigneArcher merged 105 commits into
LizardByte:nightlyfrom 
ReenigneArcher:add-build-checks
Jan 12, 2022
Merged
Automated PR tests and releases#6
ReenigneArcher merged 105 commits into
LizardByte:nightlyfrom 
ReenigneArcher:add-build-checks
Conversation
@ReenigneArcher
@ReenigneArcherReenigneArcher
commented
Jan 11, 2022

Copy link


Copy Markdown

Member
Description
  • Added CHANGELOG.md
  • Add build checks
  • Add automated release

    • CHANGELOG.md version must not match latest released tag_name
    • CHANGELOG version is compared to latest released version on Pull Request into master
  • Added Fedora build Dockerfiles (no packaging yet)
  • Improved readability of Dockerfiles
  • Use update-alternatives instead of cp for older Ubuntu distros
  • Added AppImage
Type of Change
Please delete options that are not relevant.
  •  New feature (non-breaking change which adds functionality)
Checklist
  •  My code follows the style guidelines of this project
  •  I have performed a self-review of my own code
  •  I have commented my code, particularly in hard-to-understand areas
  •  I have added or updated the documentation blocks for new or existing components
@ReenigneArcher
Create sunshine.png
1b0978f
@ReenigneArcher
Create sunshine.desktop
a268cb5
@ReenigneArcher
Create pull-requests_build-check.yml
8478ccc
@ReenigneArcher
Update pull-requests_build-check.yml
c5b8def
-Fix syntax error
@ReenigneArcher
Update pull-requests_build-check.yml
e2d3fef
-Attempt to fix build step at line 56
-Various tweaks to quoting and directory names
@ReenigneArcher
Update pull-requests_build-check.yml
89cfbc6
-Checkout recursively with submodules
@ReenigneArcher
Update pull-requests_build-check.yml
f272b86
-recursive submodules
-only run on PR for master or nightly branch
@ReenigneArcher
Update pull-requests_build-check.yml
502bf8e
-Add deb job with matrix strategy
@ReenigneArcher
Fix typo in docker build readme
47a7c5e
@ReenigneArcher
Update pull-requests_build-check.yml
69642d2
@ReenigneArcher
Update pull-requests_build-check.yml
23f9474
@ReenigneArcher
Update pull-requests_build-check.yml
bbdf961
@ReenigneArcher
Update pull-requests_build-check.yml
ca8917d
-build with -u for non interactive
@ReenigneArcher
Update pull-requests_build-check.yml
65b9b65
-Fix command that moves deb package
-Separate setup, build, and package steps
@ReenigneArcher
Update pull-requests_build-check.yml
b73ddc2
-Fix permission denied error when moving deb package
@ReenigneArcher
Update pull-requests_build-check.yml
2561886
-Add Windows build
@ReenigneArcher
Update pull-requests_build-check.yml
0fa6839
-Fix path issue for pacman command
@ReenigneArcher
Update pull-requests_build-check.yml
71b5495
-Boost debug on
@ReenigneArcher
Update pull-requests_build-check.yml
f6d9061
-Install boost
-Remove boost debug during cmake
@ReenigneArcher
Update pull-requests_build-check.yml
2b0e1fb
-Fix boost install directory
@ReenigneArcher
Update pull-requests_build-check.yml
de8cff0
-Add environment variable BOOST_ROOT
@ReenigneArcher
Update pull-requests_build-check.yml
c49cbd3
@ReenigneArcher
Update pull-requests_build-check.yml
2144787
-Try older version of boost, new version failing with cmake 3.22
@ReenigneArcher
Update pull-requests_build-check.yml
1039160
-Try boost v1.73.0 built on windows server 2019
@ReenigneArcher
Update pull-requests_build-check.yml
9fbfca5
-Try boost 1.72.0
@ReenigneArcher
Update pull-requests_build-check.yml
2512e7f
-Testing
@ReenigneArcher
Update pull-requests_build-check.yml
3f2ee64
-Testing
@ReenigneArcher
Update pull-requests_build-check.yml
ed38b7e
-Testing
@ReenigneArcher
Update pull-requests_build-check.yml
ff47a13
@ReenigneArcher
Update pull-requests_build-check.yml
17770fe
@ReenigneArcher
ReenigneArcher
commented
Jan 11, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I apologize for all the commits. Workflows are not the easiest thing to test.
Here is a workflow run for creating a new release (when the release version was updated): https://github.com/ReenigneArcher/Sunshine/actions/runs/1683355353
And here is a workflow run when the release version was not updated in the CHANGELOG.md (this should also be caught when the PR is created against the master branch): https://github.com/ReenigneArcher/Sunshine/actions/runs/1683445817
And here is an example of the release: https://github.com/ReenigneArcher/Sunshine/releases
@ReenigneArcher
ReenigneArcher
commented
Jan 11, 2022

Copy link


Copy Markdown

MemberAuthor
This needs a little tweaking on the create release action due to the multiple steps, it fails on all except the first build. I have an idea to fix it though.
@ReenigneArcher
ReenigneArcher
marked this pull request as draft
January 11, 2022 21:52
@ReenigneArcher
Update create_package.yml
cefcaed
@ReenigneArcher
Update create_package.yml
a2c45f8
-Fix typo in Windows build
@ReenigneArcher
Update create_package.yml
8781fbc
- github.base_ref is needed for pull request check
@ReenigneArcher
Update create_package.yml
f2c53a5
-Verify changelog requires checkout
@ReenigneArcher
ReenigneArcher
commented
Jan 12, 2022

Copy link


Copy Markdown

MemberAuthor
Updated Examples:
PR into nightly branch
https://github.com/ReenigneArcher/Sunshine/actions/runs/1685200094

-No check on CHANGELOG.md

-Build each version

-Package everything except Fedora

-Upload artifacts
PR into master branch

When the release version from the changelog matches the latest released version: https://github.com/ReenigneArcher/Sunshine/actions/runs/1685245727/attempts/1

-Intentionally fail the workflow (gives an opportunity to fix the CHANGELOG.md before accepting the PR)

-Build each version

-Package everything except Fedora

-Upload artifacts
Release version in changelog was updated and does not match latest released version: https://github.com/ReenigneArcher/Sunshine/actions/runs/1685245727/attempts/2

-Same as attempt 1 except workflow passes beyond changelog check
push into master branch
https://github.com/ReenigneArcher/Sunshine/actions/runs/1685294883
  • Harder to fix anything at this point so:

    • The check on changelog is done earlier when the PR is made into master
Example of Created Release
https://github.com/ReenigneArcher/Sunshine/releases/tag/0.0.0
@ReenigneArcher
ReenigneArcher
marked this pull request as ready for review
January 12, 2022 00:37
@TheElixZammuto
TheElixZammuto
commented
Jan 12, 2022

Copy link


Copy Markdown

Member
Not an expert on the GitHub actions side, so all I can say is LGTM for the workflow side of things
@ReenigneArcher
ReenigneArcher
merged commit d1a41ad
into
LizardByte:nightlyJan 12, 2022
@ReenigneArcher
ReenigneArcher
deleted the

add-build-checks

branch
January 12, 2022 22:19
ReenigneArcher added a commit
that referenced
this pull request
Jan 13, 2022
@ReenigneArcher
Merge pull request#6from ReenigneArcher/add-build-checks
2c08733
Update create_package.yml
@KuleRucketKuleRucket
mentioned this pull request
Feb 22, 2022

Closed

@HomerSpHomerSp
mentioned this pull request
Mar 9, 2022
 Merged

5 tasks

This was referenced Jul 16, 2022

Closed


Closed

@qdoreqdore
mentioned this pull request
Jul 7, 2023

Closed

3 tasks
@SidefixSidefix
mentioned this pull request
Aug 7, 2024

Closed

2 tasks
@magne4000magne4000
mentioned this pull request
Dec 15, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@TheElixZammutoTheElixZammutoTheElixZammuto approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@ReenigneArcher@TheElixZammuto

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Automated PR tests and releases - #6
Merged
ReenigneArcher merged 105 commits into
LizardByte:nightlyfrom 
ReenigneArcher:add-build-checks
Jan 12, 2022
Merged
Automated PR tests and releases#6
ReenigneArcher merged 105 commits into
LizardByte:nightlyfrom 
ReenigneArcher:add-build-checks
Conversation
@ReenigneArcher
@ReenigneArcherReenigneArcher
commented
Jan 11, 2022

Copy link


Copy Markdown

Member
Description
  • Added CHANGELOG.md
  • Add build checks
  • Add automated release

    • CHANGELOG.md version must not match latest released tag_name
    • CHANGELOG version is compared to latest released version on Pull Request into master
  • Added Fedora build Dockerfiles (no packaging yet)
  • Improved readability of Dockerfiles
  • Use update-alternatives instead of cp for older Ubuntu distros
  • Added AppImage
Type of Change
Please delete options that are not relevant.
  •  New feature (non-breaking change which adds functionality)
Checklist
  •  My code follows the style guidelines of this project
  •  I have performed a self-review of my own code
  •  I have commented my code, particularly in hard-to-understand areas
  •  I have added or updated the documentation blocks for new or existing components
@ReenigneArcher
Create sunshine.png
1b0978f
@ReenigneArcher
Create sunshine.desktop
a268cb5
@ReenigneArcher
Create pull-requests_build-check.yml
8478ccc
@ReenigneArcher
Update pull-requests_build-check.yml
c5b8def
-Fix syntax error
@ReenigneArcher
Update pull-requests_build-check.yml
e2d3fef
-Attempt to fix build step at line 56
-Various tweaks to quoting and directory names
@ReenigneArcher
Update pull-requests_build-check.yml
89cfbc6
-Checkout recursively with submodules
@ReenigneArcher
Update pull-requests_build-check.yml
f272b86
-recursive submodules
-only run on PR for master or nightly branch
@ReenigneArcher
Update pull-requests_build-check.yml
502bf8e
-Add deb job with matrix strategy
@ReenigneArcher
Fix typo in docker build readme
47a7c5e
@ReenigneArcher
Update pull-requests_build-check.yml
69642d2
@ReenigneArcher
Update pull-requests_build-check.yml
23f9474
@ReenigneArcher
Update pull-requests_build-check.yml
bbdf961
@ReenigneArcher
Update pull-requests_build-check.yml
ca8917d
-build with -u for non interactive
@ReenigneArcher
Update pull-requests_build-check.yml
65b9b65
-Fix command that moves deb package
-Separate setup, build, and package steps
@ReenigneArcher
Update pull-requests_build-check.yml
b73ddc2
-Fix permission denied error when moving deb package
@ReenigneArcher
Update pull-requests_build-check.yml
2561886
-Add Windows build
@ReenigneArcher
Update pull-requests_build-check.yml
0fa6839
-Fix path issue for pacman command
@ReenigneArcher
Update pull-requests_build-check.yml
71b5495
-Boost debug on
@ReenigneArcher
Update pull-requests_build-check.yml
f6d9061
-Install boost
-Remove boost debug during cmake
@ReenigneArcher
Update pull-requests_build-check.yml
2b0e1fb
-Fix boost install directory
@ReenigneArcher
Update pull-requests_build-check.yml
de8cff0
-Add environment variable BOOST_ROOT
@ReenigneArcher
Update pull-requests_build-check.yml
c49cbd3
@ReenigneArcher
Update pull-requests_build-check.yml
2144787
-Try older version of boost, new version failing with cmake 3.22
@ReenigneArcher
Update pull-requests_build-check.yml
1039160
-Try boost v1.73.0 built on windows server 2019
@ReenigneArcher
Update pull-requests_build-check.yml
9fbfca5
-Try boost 1.72.0
@ReenigneArcher
Update pull-requests_build-check.yml
2512e7f
-Testing
@ReenigneArcher
Update pull-requests_build-check.yml
3f2ee64
-Testing
@ReenigneArcher
Update pull-requests_build-check.yml
ed38b7e
-Testing
@ReenigneArcher
Update pull-requests_build-check.yml
ff47a13
@ReenigneArcher
Update pull-requests_build-check.yml
17770fe
@ReenigneArcher
ReenigneArcher
commented
Jan 11, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I apologize for all the commits. Workflows are not the easiest thing to test.
Here is a workflow run for creating a new release (when the release version was updated): https://github.com/ReenigneArcher/Sunshine/actions/runs/1683355353
And here is a workflow run when the release version was not updated in the CHANGELOG.md (this should also be caught when the PR is created against the master branch): https://github.com/ReenigneArcher/Sunshine/actions/runs/1683445817
And here is an example of the release: https://github.com/ReenigneArcher/Sunshine/releases
@ReenigneArcher
ReenigneArcher
commented
Jan 11, 2022

Copy link


Copy Markdown

MemberAuthor
This needs a little tweaking on the create release action due to the multiple steps, it fails on all except the first build. I have an idea to fix it though.
@ReenigneArcher
ReenigneArcher
marked this pull request as draft
January 11, 2022 21:52
@ReenigneArcher
Update create_package.yml
cefcaed
@ReenigneArcher
Update create_package.yml
a2c45f8
-Fix typo in Windows build
@ReenigneArcher
Update create_package.yml
8781fbc
- github.base_ref is needed for pull request check
@ReenigneArcher
Update create_package.yml
f2c53a5
-Verify changelog requires checkout
@ReenigneArcher
ReenigneArcher
commented
Jan 12, 2022

Copy link


Copy Markdown

MemberAuthor
Updated Examples:
PR into nightly branch
https://github.com/ReenigneArcher/Sunshine/actions/runs/1685200094

-No check on CHANGELOG.md

-Build each version

-Package everything except Fedora

-Upload artifacts
PR into master branch

When the release version from the changelog matches the latest released version: https://github.com/ReenigneArcher/Sunshine/actions/runs/1685245727/attempts/1

-Intentionally fail the workflow (gives an opportunity to fix the CHANGELOG.md before accepting the PR)

-Build each version

-Package everything except Fedora

-Upload artifacts
Release version in changelog was updated and does not match latest released version: https://github.com/ReenigneArcher/Sunshine/actions/runs/1685245727/attempts/2

-Same as attempt 1 except workflow passes beyond changelog check
push into master branch
https://github.com/ReenigneArcher/Sunshine/actions/runs/1685294883
  • Harder to fix anything at this point so:

    • The check on changelog is done earlier when the PR is made into master
Example of Created Release
https://github.com/ReenigneArcher/Sunshine/releases/tag/0.0.0
@ReenigneArcher
ReenigneArcher
marked this pull request as ready for review
January 12, 2022 00:37
@TheElixZammuto
TheElixZammuto
commented
Jan 12, 2022

Copy link


Copy Markdown

Member
Not an expert on the GitHub actions side, so all I can say is LGTM for the workflow side of things
@ReenigneArcher
ReenigneArcher
merged commit d1a41ad
into
LizardByte:nightlyJan 12, 2022
@ReenigneArcher
ReenigneArcher
deleted the

add-build-checks

branch
January 12, 2022 22:19
ReenigneArcher added a commit
that referenced
this pull request
Jan 13, 2022
@ReenigneArcher
Merge pull request#6from ReenigneArcher/add-build-checks
2c08733
Update create_package.yml
@KuleRucketKuleRucket
mentioned this pull request
Feb 22, 2022

Closed

@HomerSpHomerSp
mentioned this pull request
Mar 9, 2022
 Merged

5 tasks

This was referenced Jul 16, 2022

Closed


Closed

@qdoreqdore
mentioned this pull request
Jul 7, 2023

Closed

3 tasks
@SidefixSidefix
mentioned this pull request
Aug 7, 2024

Closed

2 tasks
@magne4000magne4000
mentioned this pull request
Dec 15, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@TheElixZammutoTheElixZammutoTheElixZammuto approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@ReenigneArcher@TheElixZammuto