Add support for global prep commands by pgrunzjr · Pull Request #977 · LizardByte/Sunshine

pgrunzjr · 2023-02-25T21:33:46Z

Description

Add the ability to add a global set of Prep Commands that will run for all applications. Global prep configuration is accessible in the UI through new tab on Applications page. Users can also enabled/disabled execution of global commands on a per applications basis. Default is Enabled.

Screenshot

Global Command Preparations on Configuration -> General page

Per-App Toggle of global prep command execution

Issues Fixed or Closed

NA

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

I want maintainers to keep my branch updated

CLAassistant · 2023-02-25T21:33:52Z

All committers have signed the CLA.

github-actions · 2023-02-25T21:34:00Z

Your PR was set to master, PRs should be sent to nightly.
The base branch of this PR has been automatically changed to nightly.
Please check that there are no merge conflicts

Nonary

I have some questions about these changes, I am not an expert at C++ but just curious on the changes as opposed to other common programing structures.

pgrunzjr · 2023-03-10T05:04:04Z

@pgrunzjr The global prep commands tab isn't working with the latest commits. I click on it and nothing happens.

Newer changes have moved global prep commands to the Configuration section and the Apps page tabs removed.

ReenigneArcher

Requesting a few small changes. We're going to need to add boost/json to our build process as well. I will take care of that in another PR so you don't have to dig through all the CI and packaging files.

I like the idea of using that though, can probably move the resolutions and fps options to use it as well, instead of that manual serialize function. I have some tweaks to how the config is handled in the UI in #1023, but I'll merge yours first so you don't have to fix any conflicts.

Edit: Can you also update the documentation, specifically "advanced_usage.rst". This is where we document each setting.

Edit 2: Apparently there's no libboost-json-dev library for debian distros. Do we need to install something additional?

Edit 3: boost-json was introduced in Boost 1.75. This is going to be a problem since Ubuntu 22.04 is on 1.74, and we're building Ubuntu 20.04 with Boost 1.71.

pgrunzjr · 2023-03-12T16:00:55Z

Edit 3: boost-json was introduced in Boost 1.75. This is going to be a problem since Ubuntu 22.04 is on 1.74, and we're building Ubuntu 20.04 with Boost 1.71.

For the purpose of this PR, I think I should be able to update it to use Boost PropertyTree for the JSON stuff for now. In the future, we could look into using another library for JSON, maybe https://github.com/nlohmann/json.

pgrunzjr · 2023-03-12T19:52:22Z

PR updated with documentation updates and to use Boost PropertyTree instead of Boost JSON.

pgrunzjr · 2023-02-25T21:33:46Z

Description

Add the ability to add a global set of Prep Commands that will run for all applications. Global prep configuration is accessible in the UI through new tab on Applications page. Users can also enabled/disabled execution of global commands on a per applications basis. Default is Enabled.

Screenshot

Global Command Preparations on Configuration -> General page

Per-App Toggle of global prep command execution

Issues Fixed or Closed

NA

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

I want maintainers to keep my branch updated

CLAassistant · 2023-02-25T21:33:52Z

All committers have signed the CLA.

github-actions · 2023-02-25T21:34:00Z

Your PR was set to master, PRs should be sent to nightly.
The base branch of this PR has been automatically changed to nightly.
Please check that there are no merge conflicts

Nonary

I have some questions about these changes, I am not an expert at C++ but just curious on the changes as opposed to other common programing structures.

pgrunzjr · 2023-03-10T05:04:04Z

@pgrunzjr The global prep commands tab isn't working with the latest commits. I click on it and nothing happens.

Newer changes have moved global prep commands to the Configuration section and the Apps page tabs removed.

ReenigneArcher

Requesting a few small changes. We're going to need to add boost/json to our build process as well. I will take care of that in another PR so you don't have to dig through all the CI and packaging files.

I like the idea of using that though, can probably move the resolutions and fps options to use it as well, instead of that manual serialize function. I have some tweaks to how the config is handled in the UI in #1023, but I'll merge yours first so you don't have to fix any conflicts.

Edit: Can you also update the documentation, specifically "advanced_usage.rst". This is where we document each setting.

Edit 2: Apparently there's no libboost-json-dev library for debian distros. Do we need to install something additional?

Edit 3: boost-json was introduced in Boost 1.75. This is going to be a problem since Ubuntu 22.04 is on 1.74, and we're building Ubuntu 20.04 with Boost 1.71.

pgrunzjr · 2023-03-12T16:00:55Z

Edit 3: boost-json was introduced in Boost 1.75. This is going to be a problem since Ubuntu 22.04 is on 1.74, and we're building Ubuntu 20.04 with Boost 1.71.

For the purpose of this PR, I think I should be able to update it to use Boost PropertyTree for the JSON stuff for now. In the future, we could look into using another library for JSON, maybe https://github.com/nlohmann/json.

pgrunzjr · 2023-03-12T19:52:22Z

PR updated with documentation updates and to use Boost PropertyTree instead of Boost JSON.

pgrunzjr · 2023-02-25T21:33:46Z

Description

Add the ability to add a global set of Prep Commands that will run for all applications. Global prep configuration is accessible in the UI through new tab on Applications page. Users can also enabled/disabled execution of global commands on a per applications basis. Default is Enabled.

Screenshot

Global Command Preparations on Configuration -> General page

Per-App Toggle of global prep command execution

Issues Fixed or Closed

NA

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

I want maintainers to keep my branch updated

CLAassistant · 2023-02-25T21:33:52Z

All committers have signed the CLA.

github-actions · 2023-02-25T21:34:00Z

Your PR was set to master, PRs should be sent to nightly.
The base branch of this PR has been automatically changed to nightly.
Please check that there are no merge conflicts

Nonary

I have some questions about these changes, I am not an expert at C++ but just curious on the changes as opposed to other common programing structures.

pgrunzjr · 2023-03-10T05:04:04Z

@pgrunzjr The global prep commands tab isn't working with the latest commits. I click on it and nothing happens.

Newer changes have moved global prep commands to the Configuration section and the Apps page tabs removed.

ReenigneArcher

Requesting a few small changes. We're going to need to add boost/json to our build process as well. I will take care of that in another PR so you don't have to dig through all the CI and packaging files.

I like the idea of using that though, can probably move the resolutions and fps options to use it as well, instead of that manual serialize function. I have some tweaks to how the config is handled in the UI in #1023, but I'll merge yours first so you don't have to fix any conflicts.

Edit: Can you also update the documentation, specifically "advanced_usage.rst". This is where we document each setting.

Edit 2: Apparently there's no libboost-json-dev library for debian distros. Do we need to install something additional?

Edit 3: boost-json was introduced in Boost 1.75. This is going to be a problem since Ubuntu 22.04 is on 1.74, and we're building Ubuntu 20.04 with Boost 1.71.

pgrunzjr · 2023-03-12T16:00:55Z

Edit 3: boost-json was introduced in Boost 1.75. This is going to be a problem since Ubuntu 22.04 is on 1.74, and we're building Ubuntu 20.04 with Boost 1.71.

For the purpose of this PR, I think I should be able to update it to use Boost PropertyTree for the JSON stuff for now. In the future, we could look into using another library for JSON, maybe https://github.com/nlohmann/json.

pgrunzjr · 2023-03-12T19:52:22Z

PR updated with documentation updates and to use Boost PropertyTree instead of Boost JSON.

pgrunzjr · 2023-02-25T21:33:46Z

Description

Add the ability to add a global set of Prep Commands that will run for all applications. Global prep configuration is accessible in the UI through new tab on Applications page. Users can also enabled/disabled execution of global commands on a per applications basis. Default is Enabled.

Screenshot

Global Command Preparations on Configuration -> General page

Per-App Toggle of global prep command execution

Issues Fixed or Closed

NA

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

I want maintainers to keep my branch updated

CLAassistant · 2023-02-25T21:33:52Z

All committers have signed the CLA.

github-actions · 2023-02-25T21:34:00Z

Your PR was set to master, PRs should be sent to nightly.
The base branch of this PR has been automatically changed to nightly.
Please check that there are no merge conflicts

Nonary

I have some questions about these changes, I am not an expert at C++ but just curious on the changes as opposed to other common programing structures.

pgrunzjr · 2023-03-10T05:04:04Z

@pgrunzjr The global prep commands tab isn't working with the latest commits. I click on it and nothing happens.

Newer changes have moved global prep commands to the Configuration section and the Apps page tabs removed.

ReenigneArcher

Requesting a few small changes. We're going to need to add boost/json to our build process as well. I will take care of that in another PR so you don't have to dig through all the CI and packaging files.

I like the idea of using that though, can probably move the resolutions and fps options to use it as well, instead of that manual serialize function. I have some tweaks to how the config is handled in the UI in #1023, but I'll merge yours first so you don't have to fix any conflicts.

Edit: Can you also update the documentation, specifically "advanced_usage.rst". This is where we document each setting.

Edit 2: Apparently there's no libboost-json-dev library for debian distros. Do we need to install something additional?

Edit 3: boost-json was introduced in Boost 1.75. This is going to be a problem since Ubuntu 22.04 is on 1.74, and we're building Ubuntu 20.04 with Boost 1.71.

pgrunzjr · 2023-03-12T16:00:55Z

Edit 3: boost-json was introduced in Boost 1.75. This is going to be a problem since Ubuntu 22.04 is on 1.74, and we're building Ubuntu 20.04 with Boost 1.71.

For the purpose of this PR, I think I should be able to update it to use Boost PropertyTree for the JSON stuff for now. In the future, we could look into using another library for JSON, maybe https://github.com/nlohmann/json.

pgrunzjr · 2023-03-12T19:52:22Z

PR updated with documentation updates and to use Boost PropertyTree instead of Boost JSON.

pgrunzjr · 2023-02-25T21:33:46Z

Description

Add the ability to add a global set of Prep Commands that will run for all applications. Global prep configuration is accessible in the UI through new tab on Applications page. Users can also enabled/disabled execution of global commands on a per applications basis. Default is Enabled.

Screenshot

Global Command Preparations on Configuration -> General page

Per-App Toggle of global prep command execution

Issues Fixed or Closed

NA

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

I want maintainers to keep my branch updated

CLAassistant · 2023-02-25T21:33:52Z

All committers have signed the CLA.

github-actions · 2023-02-25T21:34:00Z

Your PR was set to master, PRs should be sent to nightly.
The base branch of this PR has been automatically changed to nightly.
Please check that there are no merge conflicts

Nonary

I have some questions about these changes, I am not an expert at C++ but just curious on the changes as opposed to other common programing structures.

pgrunzjr · 2023-03-10T05:04:04Z

@pgrunzjr The global prep commands tab isn't working with the latest commits. I click on it and nothing happens.

Newer changes have moved global prep commands to the Configuration section and the Apps page tabs removed.

ReenigneArcher

Requesting a few small changes. We're going to need to add boost/json to our build process as well. I will take care of that in another PR so you don't have to dig through all the CI and packaging files.

I like the idea of using that though, can probably move the resolutions and fps options to use it as well, instead of that manual serialize function. I have some tweaks to how the config is handled in the UI in #1023, but I'll merge yours first so you don't have to fix any conflicts.

Edit: Can you also update the documentation, specifically "advanced_usage.rst". This is where we document each setting.

Edit 2: Apparently there's no libboost-json-dev library for debian distros. Do we need to install something additional?

Edit 3: boost-json was introduced in Boost 1.75. This is going to be a problem since Ubuntu 22.04 is on 1.74, and we're building Ubuntu 20.04 with Boost 1.71.

pgrunzjr · 2023-03-12T16:00:55Z

Edit 3: boost-json was introduced in Boost 1.75. This is going to be a problem since Ubuntu 22.04 is on 1.74, and we're building Ubuntu 20.04 with Boost 1.71.

For the purpose of this PR, I think I should be able to update it to use Boost PropertyTree for the JSON stuff for now. In the future, we could look into using another library for JSON, maybe https://github.com/nlohmann/json.

pgrunzjr · 2023-03-12T19:52:22Z

PR updated with documentation updates and to use Boost PropertyTree instead of Boost JSON.

pgrunzjr · 2023-02-25T21:33:46Z

Description

Add the ability to add a global set of Prep Commands that will run for all applications. Global prep configuration is accessible in the UI through new tab on Applications page. Users can also enabled/disabled execution of global commands on a per applications basis. Default is Enabled.

Screenshot

Global Command Preparations on Configuration -> General page

Per-App Toggle of global prep command execution

Issues Fixed or Closed

NA

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

I want maintainers to keep my branch updated

CLAassistant · 2023-02-25T21:33:52Z

All committers have signed the CLA.

github-actions · 2023-02-25T21:34:00Z

Your PR was set to master, PRs should be sent to nightly.
The base branch of this PR has been automatically changed to nightly.
Please check that there are no merge conflicts

Nonary

I have some questions about these changes, I am not an expert at C++ but just curious on the changes as opposed to other common programing structures.

pgrunzjr · 2023-03-10T05:04:04Z

@pgrunzjr The global prep commands tab isn't working with the latest commits. I click on it and nothing happens.

Newer changes have moved global prep commands to the Configuration section and the Apps page tabs removed.

ReenigneArcher

Requesting a few small changes. We're going to need to add boost/json to our build process as well. I will take care of that in another PR so you don't have to dig through all the CI and packaging files.

I like the idea of using that though, can probably move the resolutions and fps options to use it as well, instead of that manual serialize function. I have some tweaks to how the config is handled in the UI in #1023, but I'll merge yours first so you don't have to fix any conflicts.

Edit: Can you also update the documentation, specifically "advanced_usage.rst". This is where we document each setting.

Edit 2: Apparently there's no libboost-json-dev library for debian distros. Do we need to install something additional?

Edit 3: boost-json was introduced in Boost 1.75. This is going to be a problem since Ubuntu 22.04 is on 1.74, and we're building Ubuntu 20.04 with Boost 1.71.

pgrunzjr · 2023-03-12T16:00:55Z

Edit 3: boost-json was introduced in Boost 1.75. This is going to be a problem since Ubuntu 22.04 is on 1.74, and we're building Ubuntu 20.04 with Boost 1.71.

For the purpose of this PR, I think I should be able to update it to use Boost PropertyTree for the JSON stuff for now. In the future, we could look into using another library for JSON, maybe https://github.com/nlohmann/json.

pgrunzjr · 2023-03-12T19:52:22Z

PR updated with documentation updates and to use Boost PropertyTree instead of Boost JSON.

pgrunzjr · 2023-02-25T21:33:46Z

Description

Add the ability to add a global set of Prep Commands that will run for all applications. Global prep configuration is accessible in the UI through new tab on Applications page. Users can also enabled/disabled execution of global commands on a per applications basis. Default is Enabled.

Screenshot

Global Command Preparations on Configuration -> General page

Per-App Toggle of global prep command execution

Issues Fixed or Closed

NA

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

I want maintainers to keep my branch updated

CLAassistant · 2023-02-25T21:33:52Z

All committers have signed the CLA.

github-actions · 2023-02-25T21:34:00Z

Your PR was set to master, PRs should be sent to nightly.
The base branch of this PR has been automatically changed to nightly.
Please check that there are no merge conflicts

Nonary

I have some questions about these changes, I am not an expert at C++ but just curious on the changes as opposed to other common programing structures.

pgrunzjr · 2023-03-10T05:04:04Z

@pgrunzjr The global prep commands tab isn't working with the latest commits. I click on it and nothing happens.

Newer changes have moved global prep commands to the Configuration section and the Apps page tabs removed.

ReenigneArcher

Requesting a few small changes. We're going to need to add boost/json to our build process as well. I will take care of that in another PR so you don't have to dig through all the CI and packaging files.

I like the idea of using that though, can probably move the resolutions and fps options to use it as well, instead of that manual serialize function. I have some tweaks to how the config is handled in the UI in #1023, but I'll merge yours first so you don't have to fix any conflicts.

Edit: Can you also update the documentation, specifically "advanced_usage.rst". This is where we document each setting.

Edit 2: Apparently there's no libboost-json-dev library for debian distros. Do we need to install something additional?

Edit 3: boost-json was introduced in Boost 1.75. This is going to be a problem since Ubuntu 22.04 is on 1.74, and we're building Ubuntu 20.04 with Boost 1.71.

pgrunzjr · 2023-03-12T16:00:55Z

Edit 3: boost-json was introduced in Boost 1.75. This is going to be a problem since Ubuntu 22.04 is on 1.74, and we're building Ubuntu 20.04 with Boost 1.71.

For the purpose of this PR, I think I should be able to update it to use Boost PropertyTree for the JSON stuff for now. In the future, we could look into using another library for JSON, maybe https://github.com/nlohmann/json.

pgrunzjr · 2023-03-12T19:52:22Z

PR updated with documentation updates and to use Boost PropertyTree instead of Boost JSON.

pgrunzjr · 2023-02-25T21:33:46Z

Description

Add the ability to add a global set of Prep Commands that will run for all applications. Global prep configuration is accessible in the UI through new tab on Applications page. Users can also enabled/disabled execution of global commands on a per applications basis. Default is Enabled.

Screenshot

Global Command Preparations on Configuration -> General page

Per-App Toggle of global prep command execution

Issues Fixed or Closed

NA

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

I want maintainers to keep my branch updated

CLAassistant · 2023-02-25T21:33:52Z

All committers have signed the CLA.

github-actions · 2023-02-25T21:34:00Z

Your PR was set to master, PRs should be sent to nightly.
The base branch of this PR has been automatically changed to nightly.
Please check that there are no merge conflicts

Nonary

I have some questions about these changes, I am not an expert at C++ but just curious on the changes as opposed to other common programing structures.

pgrunzjr · 2023-03-10T05:04:04Z

@pgrunzjr The global prep commands tab isn't working with the latest commits. I click on it and nothing happens.

Newer changes have moved global prep commands to the Configuration section and the Apps page tabs removed.

ReenigneArcher

Requesting a few small changes. We're going to need to add boost/json to our build process as well. I will take care of that in another PR so you don't have to dig through all the CI and packaging files.

I like the idea of using that though, can probably move the resolutions and fps options to use it as well, instead of that manual serialize function. I have some tweaks to how the config is handled in the UI in #1023, but I'll merge yours first so you don't have to fix any conflicts.

Edit: Can you also update the documentation, specifically "advanced_usage.rst". This is where we document each setting.

Edit 2: Apparently there's no libboost-json-dev library for debian distros. Do we need to install something additional?

Edit 3: boost-json was introduced in Boost 1.75. This is going to be a problem since Ubuntu 22.04 is on 1.74, and we're building Ubuntu 20.04 with Boost 1.71.

pgrunzjr · 2023-03-12T16:00:55Z

Edit 3: boost-json was introduced in Boost 1.75. This is going to be a problem since Ubuntu 22.04 is on 1.74, and we're building Ubuntu 20.04 with Boost 1.71.

For the purpose of this PR, I think I should be able to update it to use Boost PropertyTree for the JSON stuff for now. In the future, we could look into using another library for JSON, maybe https://github.com/nlohmann/json.

pgrunzjr · 2023-03-12T19:52:22Z

PR updated with documentation updates and to use Boost PropertyTree instead of Boost JSON.

github-actionsBot changed the base branch from master to nightlyFebruary 25, 2023 21:33

pgrunzjr force-pushed the feature/global-do-undo-commands branch 2 times, most recently from cd03c07 to 288fcc9Compare February 25, 2023 21:37

Nonary reviewed Mar 5, 2023
View reviewed changes

Comment threadsrc/process.cpp Outdated
Comment threadsrc/process.cpp Outdated
Comment threadsrc/process.cpp Outdated
Comment threadsrc/process.cpp
Comment threadsrc/process.h Outdated

This comment was marked as spam.
Sign in to view

ReenigneArcher requested changes Mar 8, 2023
View reviewed changes

Comment threadsrc/confighttp.cpp Outdated
Comment threadsrc/process.cpp Outdated

This comment was marked as spam.
Sign in to view

ReenigneArcher requested changes Mar 10, 2023
View reviewed changes

Comment threadsrc/config.cpp Outdated
Comment threadsrc/config.cpp Outdated

ReenigneArcher mentioned this pull request Mar 10, 2023
boost: add json #1025
Closed
11 tasks

ReenigneArcher reviewed Mar 17, 2023
View reviewed changes

Comment threadsrc_assets/common/assets/web/config.html

pgrunzjr force-pushed the feature/global-do-undo-commands branch from 7658996 to 8d8593cCompare March 19, 2023 14:25

ReenigneArcher force-pushed the feature/global-do-undo-commands branch from 8d8593c to b712970Compare March 24, 2023 23:43

pgrunzjr added 13 commits March 27, 2023 09:31

Add support for global prep commands
b12172a

Invert global prep exclusion
34c4e5f

Combine global commands with app commands on load
00cc2a2

Remove now unused exclude_global_prep member from ctx_t
07c116c

Rememove elevation changes
c27cd61

Move prep commands to config instead of apps
a6b2b1c

Fix comments
fd88fe7

Remove unnecessary whitespace
aada501

Used boost::property_tree instead of boost::json
0b794d0

Add advanced_usage documentation
9fb02d0

Add prep command default values
cb2ca6c

Fix linting errors
ece1eb6

Missed whitespace
249592a

ReenigneArcher force-pushed the feature/global-do-undo-commands branch from 61dc8eb to 249592aCompare March 27, 2023 13:32

ReenigneArcher reviewed Mar 27, 2023
View reviewed changes

Comment threadsrc/config.cpp Outdated

pgrunzjrand others added 2 commits March 27, 2023 09:47

remove boost json include
34885da

Merge branch 'nightly' into feature/global-do-undo-commands
35c8f90

ReenigneArcher approved these changes Mar 27, 2023
View reviewed changes

ReenigneArcher merged commit 8c86baf into LizardByte:nightlyMar 27, 2023

pgrunzjr deleted the feature/global-do-undo-commands branch March 27, 2023 16:58

ReenigneArcher mentioned this pull request Mar 27, 2023
commands: fix prep commands when empty #1083
Merged
11 tasks

pgrunzjr mentioned this pull request Mar 27, 2023
Add missing setup for default global prep command exclusion dropdown #1085
Merged
11 tasks