Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/common/include/displaydevice/types.h
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,14 @@
#pragma once

namespace display_device {
/**
* @brief The device's HDR state in the operating system.
*/
enum class HdrState {
Disabled,
Enabled
};

/**
* @brief Display's resolution.
*/
Expand Down
4 changes: 4 additions & 0 deletions src/windows/include/displaydevice/windows/types.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -91,4 +91,8 @@ namespace display_device {
*/
using DeviceDisplayModeMap = std::map<std::string, DisplayMode>;

/**
* @brief Ordered map of [DEVICE_ID -> std::optional<HdrState>].
*/
using HdrStateMap = std::map<std::string, std::optional<HdrState>>;
} // namespace display_device
8 changes: 8 additions & 0 deletions src/windows/include/displaydevice/windows/winapilayer.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,5 +36,13 @@ namespace display_device {
/** For details @see WinApiLayerInterface::setDisplayConfig */
[[nodiscard]] LONG
setDisplayConfig(std::vector<DISPLAYCONFIG_PATH_INFO> paths, std::vector<DISPLAYCONFIG_MODE_INFO> modes, UINT32 flags) override;

/** For details @see WinApiLayerInterface::getHdrState */
[[nodiscard]] std::optional<HdrState>
getHdrState(const DISPLAYCONFIG_PATH_INFO &path) const override;

/** For details @see WinApiLayerInterface::setHdrState */
[[nodiscard]] bool
setHdrState(const DISPLAYCONFIG_PATH_INFO &path, HdrState state) override;
};
} // namespace display_device
31 changes: 31 additions & 0 deletions src/windows/include/displaydevice/windows/winapilayerinterface.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -166,5 +166,36 @@ namespace display_device {
*/
[[nodiscard]] virtual LONG
setDisplayConfig(std::vector<DISPLAYCONFIG_PATH_INFO> paths, std::vector<DISPLAYCONFIG_MODE_INFO> modes, UINT32 flags) = 0;

/**
* @brief Get the HDR state the path.
* @param path Path to get HDR state for.
* @returns std::nullopt if the state could not be retrieved, or other enum values describing the state otherwise.
*
* EXAMPLES:
* ```cpp
* DISPLAYCONFIG_PATH_INFO path;
* const WinApiLayerInterface* iface = getIface(...);
* const auto hdr_state = iface->getHdrState(path);
* ```
*/
[[nodiscard]] virtual std::optional<HdrState>
getHdrState(const DISPLAYCONFIG_PATH_INFO &path) const = 0;

/**
* @brief Set the HDR state for the path.
* @param path Path to set HDR state for.
* @param state Specify new HDR state.
* @returns True if the device is in the new state, false otherwise.
*
* EXAMPLES:
* ```cpp
* DISPLAYCONFIG_PATH_INFO path;
* const WinApiLayerInterface* iface = getIface(...);
* const bool success = iface->setHdrState(path, HdrState::Enabled);
* ```
*/
[[nodiscard]] virtual bool
setHdrState(const DISPLAYCONFIG_PATH_INFO &path, HdrState state) = 0;
};
} // namespace display_device
8 changes: 8 additions & 0 deletions src/windows/include/displaydevice/windows/windisplaydevice.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,14 @@ namespace display_device {
[[nodiscard]] bool
setAsPrimary(const std::string &device_id) override;

/** For details @see WinDisplayDeviceInterface::getCurrentHdrStates */
[[nodiscard]] HdrStateMap
getCurrentHdrStates(const std::set<std::string> &device_ids) const override;

/** For details @see WinDisplayDeviceInterface::setHdrStates */
[[nodiscard]] bool
setHdrStates(const HdrStateMap &states) override;

private:
std::shared_ptr<WinApiLayerInterface> m_w_api;
};
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,5 +150,40 @@ namespace display_device {
*/
[[nodiscard]] virtual bool
setAsPrimary(const std::string &device_id) = 0;

/**
* @brief Get HDR state for the devices.
* @param device_ids A list of devices to get the HDR states for.
* @returns A map of HDR states per a device or an empty map if an error has occurred.
* @note On Windows the state cannot be retrieved until the device is active even if it supports it.
*
* EXAMPLES:
* ```cpp
* const WinDisplayDeviceInterface* iface = getIface(...);
* const std::unordered_set<std::string> device_ids { "DEVICE_ID_1", "DEVICE_ID_2" };
* const auto current_hdr_states = iface->getCurrentHdrStates(device_ids);
* ```
*/
[[nodiscard]] virtual HdrStateMap
getCurrentHdrStates(const std::set<std::string> &device_ids) const = 0;

/**
* @brief Set HDR states for the devices.
* @param modes A map of HDR states to set.
* @returns True if HDR states were set, false otherwise.
* @note If `unknown` states are provided, they will be silently ignored
* and current state will not be changed.
*
* EXAMPLES:
* ```cpp
* const WinDisplayDeviceInterface* iface = getIface(...);
* const std::string display_a { "MY_ID_1" };
* const std::string display_b { "MY_ID_2" };
* const auto success = iface->setHdrStates({ { display_a, HdrState::Enabled },
* { display_b, HdrState::Disabled } });
* ```
*/
[[nodiscard]] virtual bool
setHdrStates(const HdrStateMap &states) = 0;
};
} // namespace display_device
37 changes: 36 additions & 1 deletion src/windows/winapilayer.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -522,7 +522,7 @@ namespace display_device {

LONG result { DisplayConfigGetDeviceInfo(&source_name.header) };
if (result != ERROR_SUCCESS) {
DD_LOG(error) << getErrorString(result) << " failed to get display name!";
DD_LOG(error) << getErrorString(result) << " failed to get display name!";
return {};
}

Expand All@@ -539,4 +539,39 @@ namespace display_device {
modes.empty() ? nullptr : modes.data(),
flags);
}

std::optional<HdrState>
WinApiLayer::getHdrState(const DISPLAYCONFIG_PATH_INFO &path) const {
DISPLAYCONFIG_GET_ADVANCED_COLOR_INFO color_info = {};
color_info.header.adapterId = path.targetInfo.adapterId;
color_info.header.id = path.targetInfo.id;
color_info.header.type = DISPLAYCONFIG_DEVICE_INFO_GET_ADVANCED_COLOR_INFO;
color_info.header.size = sizeof(color_info);

LONG result { DisplayConfigGetDeviceInfo(&color_info.header) };
if (result != ERROR_SUCCESS) {
DD_LOG(error) << getErrorString(result) << " failed to get advanced color info!";
return std::nullopt;
}

return color_info.advancedColorSupported ? std::make_optional(color_info.advancedColorEnabled ? HdrState::Enabled : HdrState::Disabled) : std::nullopt;
}

bool
WinApiLayer::setHdrState(const DISPLAYCONFIG_PATH_INFO &path, HdrState state) {
DISPLAYCONFIG_SET_ADVANCED_COLOR_STATE color_state = {};
color_state.header.adapterId = path.targetInfo.adapterId;
color_state.header.id = path.targetInfo.id;
color_state.header.type = DISPLAYCONFIG_DEVICE_INFO_SET_ADVANCED_COLOR_STATE;
color_state.header.size = sizeof(color_state);
color_state.enableAdvancedColor = state == HdrState::Enabled ? 1 : 0;

LONG result { DisplayConfigSetDeviceInfo(&color_state.header) };
if (result != ERROR_SUCCESS) {
DD_LOG(error) << getErrorString(result) << " failed to set advanced color info!";
return false;
}

return true;
}
} // namespace display_device
127 changes: 127 additions & 0 deletions src/windows/windisplaydevicehdr.cpp
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,127 @@
// class header include
#include "displaydevice/windows/windisplaydevice.h"

// system includes
#include <ranges>

// local includes
#include "displaydevice/logging.h"
#include "displaydevice/windows/winapiutils.h"

namespace display_device {
namespace {
/** @brief HDR state map without optional values. */
using HdrStateMapNoOpt = std::map<std::string, HdrState>;

/**
* @see setHdrStates for a description as this was split off to reduce cognitive complexity.
*/
bool
doSetHdrStates(WinApiLayerInterface &w_api, const PathAndModeData &display_data, const HdrStateMapNoOpt &states, HdrStateMapNoOpt *changed_states) {
const auto try_set_state {
[&w_api, &display_data](const auto &device_id, const auto &state, auto &current_state) {
const auto path { win_utils::getActivePath(w_api, device_id, display_data.m_paths) };
if (!path) {
DD_LOG(error) << "Failed to find device for " << device_id << "!";
return false;
}

const auto current_state_int { w_api.getHdrState(*path) };
if (!current_state_int) {
DD_LOG(error) << "HDR state cannot be changed for " << device_id << "!";
return false;
}

if (state != *current_state_int) {
if (!w_api.setHdrState(*path, state)) {
// Error already logged
return false;
}

current_state = current_state_int;
}

return true;
}
};

for (const auto &[device_id, state] : states) {
std::optional<HdrState> current_state;
if (try_set_state(device_id, state, current_state)) {
if (current_state && changed_states != nullptr) {
(*changed_states)[device_id] = *current_state;
}
}
// If we are undoing changes we don't want to return early and continue regardless of what error we get.
else if (changed_states != nullptr) {
return false;
}
}

return true;
}

} // namespace

HdrStateMap
WinDisplayDevice::getCurrentHdrStates(const std::set<std::string> &device_ids) const {
if (device_ids.empty()) {
DD_LOG(error) << "Device id set is empty!";
return {};
}

const auto display_data { m_w_api->queryDisplayConfig(QueryType::Active) };
if (!display_data) {
// Error already logged
return {};
}

HdrStateMap states;
for (const auto &device_id : device_ids) {
const auto path { win_utils::getActivePath(*m_w_api, device_id, display_data->m_paths) };
if (!path) {
DD_LOG(error) << "Failed to find device for " << device_id << "!";
return {};
}

states[device_id] = m_w_api->getHdrState(*path);
}

return states;
}

bool
WinDisplayDevice::setHdrStates(const HdrStateMap &states) {
if (states.empty()) {
DD_LOG(error) << "States map is empty!";
return false;
}

HdrStateMapNoOpt states_without_opt;
std::ranges::copy(states |
std::ranges::views::filter([](const auto &entry) { return static_cast<bool>(entry.second); }) |
std::views::transform([](const auto &entry) { return std::make_pair(entry.first, *entry.second); }),
std::inserter(states_without_opt, std::begin(states_without_opt)));

if (states_without_opt.empty()) {
// Return early as there is nothing to do...
return true;
}

const auto display_data { m_w_api->queryDisplayConfig(QueryType::Active) };
if (!display_data) {
// Error already logged
return {};
}

HdrStateMapNoOpt changed_states;
if (!doSetHdrStates(*m_w_api, *display_data, states_without_opt, &changed_states)) {
if (!changed_states.empty()) {
doSetHdrStates(*m_w_api, *display_data, changed_states, nullptr); // return value does not matter
}
return false;
}

return true;
}
} // namespace display_device
8 changes: 8 additions & 0 deletions tests/unit/windows/test_winapilayer.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -204,3 +204,11 @@ TEST_F_S(GetDisplayName) {
TEST_F_S(GetDisplayName, InvalidPath) {
EXPECT_EQ(m_layer.getDisplayName(INVALID_PATH), std::string {});
}

TEST_F_S(GetHdrState, InvalidPath) {
EXPECT_EQ(m_layer.getHdrState(INVALID_PATH), std::nullopt);
}

TEST_F_S(SetHdrState, InvalidPath) {
EXPECT_FALSE(m_layer.setHdrState(INVALID_PATH, display_device::HdrState::Enabled));
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/common/include/displaydevice/types.h
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,14 @@
#pragma once

namespace display_device {
/**
* @brief The device's HDR state in the operating system.
*/
enum class HdrState {
Disabled,
Enabled
};

/**
* @brief Display's resolution.
*/
Expand Down
4 changes: 4 additions & 0 deletions src/windows/include/displaydevice/windows/types.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -91,4 +91,8 @@ namespace display_device {
*/
using DeviceDisplayModeMap = std::map<std::string, DisplayMode>;

/**
* @brief Ordered map of [DEVICE_ID -> std::optional<HdrState>].
*/
using HdrStateMap = std::map<std::string, std::optional<HdrState>>;
} // namespace display_device
8 changes: 8 additions & 0 deletions src/windows/include/displaydevice/windows/winapilayer.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,5 +36,13 @@ namespace display_device {
/** For details @see WinApiLayerInterface::setDisplayConfig */
[[nodiscard]] LONG
setDisplayConfig(std::vector<DISPLAYCONFIG_PATH_INFO> paths, std::vector<DISPLAYCONFIG_MODE_INFO> modes, UINT32 flags) override;

/** For details @see WinApiLayerInterface::getHdrState */
[[nodiscard]] std::optional<HdrState>
getHdrState(const DISPLAYCONFIG_PATH_INFO &path) const override;

/** For details @see WinApiLayerInterface::setHdrState */
[[nodiscard]] bool
setHdrState(const DISPLAYCONFIG_PATH_INFO &path, HdrState state) override;
};
} // namespace display_device
31 changes: 31 additions & 0 deletions src/windows/include/displaydevice/windows/winapilayerinterface.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -166,5 +166,36 @@ namespace display_device {
*/
[[nodiscard]] virtual LONG
setDisplayConfig(std::vector<DISPLAYCONFIG_PATH_INFO> paths, std::vector<DISPLAYCONFIG_MODE_INFO> modes, UINT32 flags) = 0;

/**
* @brief Get the HDR state the path.
* @param path Path to get HDR state for.
* @returns std::nullopt if the state could not be retrieved, or other enum values describing the state otherwise.
*
* EXAMPLES:
* ```cpp
* DISPLAYCONFIG_PATH_INFO path;
* const WinApiLayerInterface* iface = getIface(...);
* const auto hdr_state = iface->getHdrState(path);
* ```
*/
[[nodiscard]] virtual std::optional<HdrState>
getHdrState(const DISPLAYCONFIG_PATH_INFO &path) const = 0;

/**
* @brief Set the HDR state for the path.
* @param path Path to set HDR state for.
* @param state Specify new HDR state.
* @returns True if the device is in the new state, false otherwise.
*
* EXAMPLES:
* ```cpp
* DISPLAYCONFIG_PATH_INFO path;
* const WinApiLayerInterface* iface = getIface(...);
* const bool success = iface->setHdrState(path, HdrState::Enabled);
* ```
*/
[[nodiscard]] virtual bool
setHdrState(const DISPLAYCONFIG_PATH_INFO &path, HdrState state) = 0;
};
} // namespace display_device
8 changes: 8 additions & 0 deletions src/windows/include/displaydevice/windows/windisplaydevice.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,14 @@ namespace display_device {
[[nodiscard]] bool
setAsPrimary(const std::string &device_id) override;

/** For details @see WinDisplayDeviceInterface::getCurrentHdrStates */
[[nodiscard]] HdrStateMap
getCurrentHdrStates(const std::set<std::string> &device_ids) const override;

/** For details @see WinDisplayDeviceInterface::setHdrStates */
[[nodiscard]] bool
setHdrStates(const HdrStateMap &states) override;

private:
std::shared_ptr<WinApiLayerInterface> m_w_api;
};
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,5 +150,40 @@ namespace display_device {
*/
[[nodiscard]] virtual bool
setAsPrimary(const std::string &device_id) = 0;

/**
* @brief Get HDR state for the devices.
* @param device_ids A list of devices to get the HDR states for.
* @returns A map of HDR states per a device or an empty map if an error has occurred.
* @note On Windows the state cannot be retrieved until the device is active even if it supports it.
*
* EXAMPLES:
* ```cpp
* const WinDisplayDeviceInterface* iface = getIface(...);
* const std::unordered_set<std::string> device_ids { "DEVICE_ID_1", "DEVICE_ID_2" };
* const auto current_hdr_states = iface->getCurrentHdrStates(device_ids);
* ```
*/
[[nodiscard]] virtual HdrStateMap
getCurrentHdrStates(const std::set<std::string> &device_ids) const = 0;

/**
* @brief Set HDR states for the devices.
* @param modes A map of HDR states to set.
* @returns True if HDR states were set, false otherwise.
* @note If `unknown` states are provided, they will be silently ignored
* and current state will not be changed.
*
* EXAMPLES:
* ```cpp
* const WinDisplayDeviceInterface* iface = getIface(...);
* const std::string display_a { "MY_ID_1" };
* const std::string display_b { "MY_ID_2" };
* const auto success = iface->setHdrStates({ { display_a, HdrState::Enabled },
* { display_b, HdrState::Disabled } });
* ```
*/
[[nodiscard]] virtual bool
setHdrStates(const HdrStateMap &states) = 0;
};
} // namespace display_device
37 changes: 36 additions & 1 deletion src/windows/winapilayer.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -522,7 +522,7 @@ namespace display_device {

LONG result { DisplayConfigGetDeviceInfo(&source_name.header) };
if (result != ERROR_SUCCESS) {
DD_LOG(error) << getErrorString(result) << " failed to get display name!";
DD_LOG(error) << getErrorString(result) << " failed to get display name!";
return {};
}

Expand All@@ -539,4 +539,39 @@ namespace display_device {
modes.empty() ? nullptr : modes.data(),
flags);
}

std::optional<HdrState>
WinApiLayer::getHdrState(const DISPLAYCONFIG_PATH_INFO &path) const {
DISPLAYCONFIG_GET_ADVANCED_COLOR_INFO color_info = {};
color_info.header.adapterId = path.targetInfo.adapterId;
color_info.header.id = path.targetInfo.id;
color_info.header.type = DISPLAYCONFIG_DEVICE_INFO_GET_ADVANCED_COLOR_INFO;
color_info.header.size = sizeof(color_info);

LONG result { DisplayConfigGetDeviceInfo(&color_info.header) };
if (result != ERROR_SUCCESS) {
DD_LOG(error) << getErrorString(result) << " failed to get advanced color info!";
return std::nullopt;
}

return color_info.advancedColorSupported ? std::make_optional(color_info.advancedColorEnabled ? HdrState::Enabled : HdrState::Disabled) : std::nullopt;
}

bool
WinApiLayer::setHdrState(const DISPLAYCONFIG_PATH_INFO &path, HdrState state) {
DISPLAYCONFIG_SET_ADVANCED_COLOR_STATE color_state = {};
color_state.header.adapterId = path.targetInfo.adapterId;
color_state.header.id = path.targetInfo.id;
color_state.header.type = DISPLAYCONFIG_DEVICE_INFO_SET_ADVANCED_COLOR_STATE;
color_state.header.size = sizeof(color_state);
color_state.enableAdvancedColor = state == HdrState::Enabled ? 1 : 0;

LONG result { DisplayConfigSetDeviceInfo(&color_state.header) };
if (result != ERROR_SUCCESS) {
DD_LOG(error) << getErrorString(result) << " failed to set advanced color info!";
return false;
}

return true;
}
} // namespace display_device
127 changes: 127 additions & 0 deletions src/windows/windisplaydevicehdr.cpp
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,127 @@
// class header include
#include "displaydevice/windows/windisplaydevice.h"

// system includes
#include <ranges>

// local includes
#include "displaydevice/logging.h"
#include "displaydevice/windows/winapiutils.h"

namespace display_device {
namespace {
/** @brief HDR state map without optional values. */
using HdrStateMapNoOpt = std::map<std::string, HdrState>;

/**
* @see setHdrStates for a description as this was split off to reduce cognitive complexity.
*/
bool
doSetHdrStates(WinApiLayerInterface &w_api, const PathAndModeData &display_data, const HdrStateMapNoOpt &states, HdrStateMapNoOpt *changed_states) {
const auto try_set_state {
[&w_api, &display_data](const auto &device_id, const auto &state, auto &current_state) {
const auto path { win_utils::getActivePath(w_api, device_id, display_data.m_paths) };
if (!path) {
DD_LOG(error) << "Failed to find device for " << device_id << "!";
return false;
}

const auto current_state_int { w_api.getHdrState(*path) };
if (!current_state_int) {
DD_LOG(error) << "HDR state cannot be changed for " << device_id << "!";
return false;
}

if (state != *current_state_int) {
if (!w_api.setHdrState(*path, state)) {
// Error already logged
return false;
}

current_state = current_state_int;
}

return true;
}
};

for (const auto &[device_id, state] : states) {
std::optional<HdrState> current_state;
if (try_set_state(device_id, state, current_state)) {
if (current_state && changed_states != nullptr) {
(*changed_states)[device_id] = *current_state;
}
}
// If we are undoing changes we don't want to return early and continue regardless of what error we get.
else if (changed_states != nullptr) {
return false;
}
}

return true;
}

} // namespace

HdrStateMap
WinDisplayDevice::getCurrentHdrStates(const std::set<std::string> &device_ids) const {
if (device_ids.empty()) {
DD_LOG(error) << "Device id set is empty!";
return {};
}

const auto display_data { m_w_api->queryDisplayConfig(QueryType::Active) };
if (!display_data) {
// Error already logged
return {};
}

HdrStateMap states;
for (const auto &device_id : device_ids) {
const auto path { win_utils::getActivePath(*m_w_api, device_id, display_data->m_paths) };
if (!path) {
DD_LOG(error) << "Failed to find device for " << device_id << "!";
return {};
}

states[device_id] = m_w_api->getHdrState(*path);
}

return states;
}

bool
WinDisplayDevice::setHdrStates(const HdrStateMap &states) {
if (states.empty()) {
DD_LOG(error) << "States map is empty!";
return false;
}

HdrStateMapNoOpt states_without_opt;
std::ranges::copy(states |
std::ranges::views::filter([](const auto &entry) { return static_cast<bool>(entry.second); }) |
std::views::transform([](const auto &entry) { return std::make_pair(entry.first, *entry.second); }),
std::inserter(states_without_opt, std::begin(states_without_opt)));

if (states_without_opt.empty()) {
// Return early as there is nothing to do...
return true;
}

const auto display_data { m_w_api->queryDisplayConfig(QueryType::Active) };
if (!display_data) {
// Error already logged
return {};
}

HdrStateMapNoOpt changed_states;
if (!doSetHdrStates(*m_w_api, *display_data, states_without_opt, &changed_states)) {
if (!changed_states.empty()) {
doSetHdrStates(*m_w_api, *display_data, changed_states, nullptr); // return value does not matter
}
return false;
}

return true;
}
} // namespace display_device
8 changes: 8 additions & 0 deletions tests/unit/windows/test_winapilayer.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -204,3 +204,11 @@ TEST_F_S(GetDisplayName) {
TEST_F_S(GetDisplayName, InvalidPath) {
EXPECT_EQ(m_layer.getDisplayName(INVALID_PATH), std::string {});
}

TEST_F_S(GetHdrState, InvalidPath) {
EXPECT_EQ(m_layer.getHdrState(INVALID_PATH), std::nullopt);
}

TEST_F_S(SetHdrState, InvalidPath) {
EXPECT_FALSE(m_layer.setHdrState(INVALID_PATH, display_device::HdrState::Enabled));
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/common/include/displaydevice/types.h
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,14 @@
#pragma once

namespace display_device {
/**
* @brief The device's HDR state in the operating system.
*/
enum class HdrState {
Disabled,
Enabled
};

/**
* @brief Display's resolution.
*/
Expand Down
4 changes: 4 additions & 0 deletions src/windows/include/displaydevice/windows/types.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -91,4 +91,8 @@ namespace display_device {
*/
using DeviceDisplayModeMap = std::map<std::string, DisplayMode>;

/**
* @brief Ordered map of [DEVICE_ID -> std::optional<HdrState>].
*/
using HdrStateMap = std::map<std::string, std::optional<HdrState>>;
} // namespace display_device
8 changes: 8 additions & 0 deletions src/windows/include/displaydevice/windows/winapilayer.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,5 +36,13 @@ namespace display_device {
/** For details @see WinApiLayerInterface::setDisplayConfig */
[[nodiscard]] LONG
setDisplayConfig(std::vector<DISPLAYCONFIG_PATH_INFO> paths, std::vector<DISPLAYCONFIG_MODE_INFO> modes, UINT32 flags) override;

/** For details @see WinApiLayerInterface::getHdrState */
[[nodiscard]] std::optional<HdrState>
getHdrState(const DISPLAYCONFIG_PATH_INFO &path) const override;

/** For details @see WinApiLayerInterface::setHdrState */
[[nodiscard]] bool
setHdrState(const DISPLAYCONFIG_PATH_INFO &path, HdrState state) override;
};
} // namespace display_device
31 changes: 31 additions & 0 deletions src/windows/include/displaydevice/windows/winapilayerinterface.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -166,5 +166,36 @@ namespace display_device {
*/
[[nodiscard]] virtual LONG
setDisplayConfig(std::vector<DISPLAYCONFIG_PATH_INFO> paths, std::vector<DISPLAYCONFIG_MODE_INFO> modes, UINT32 flags) = 0;

/**
* @brief Get the HDR state the path.
* @param path Path to get HDR state for.
* @returns std::nullopt if the state could not be retrieved, or other enum values describing the state otherwise.
*
* EXAMPLES:
* ```cpp
* DISPLAYCONFIG_PATH_INFO path;
* const WinApiLayerInterface* iface = getIface(...);
* const auto hdr_state = iface->getHdrState(path);
* ```
*/
[[nodiscard]] virtual std::optional<HdrState>
getHdrState(const DISPLAYCONFIG_PATH_INFO &path) const = 0;

/**
* @brief Set the HDR state for the path.
* @param path Path to set HDR state for.
* @param state Specify new HDR state.
* @returns True if the device is in the new state, false otherwise.
*
* EXAMPLES:
* ```cpp
* DISPLAYCONFIG_PATH_INFO path;
* const WinApiLayerInterface* iface = getIface(...);
* const bool success = iface->setHdrState(path, HdrState::Enabled);
* ```
*/
[[nodiscard]] virtual bool
setHdrState(const DISPLAYCONFIG_PATH_INFO &path, HdrState state) = 0;
};
} // namespace display_device
8 changes: 8 additions & 0 deletions src/windows/include/displaydevice/windows/windisplaydevice.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,14 @@ namespace display_device {
[[nodiscard]] bool
setAsPrimary(const std::string &device_id) override;

/** For details @see WinDisplayDeviceInterface::getCurrentHdrStates */
[[nodiscard]] HdrStateMap
getCurrentHdrStates(const std::set<std::string> &device_ids) const override;

/** For details @see WinDisplayDeviceInterface::setHdrStates */
[[nodiscard]] bool
setHdrStates(const HdrStateMap &states) override;

private:
std::shared_ptr<WinApiLayerInterface> m_w_api;
};
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,5 +150,40 @@ namespace display_device {
*/
[[nodiscard]] virtual bool
setAsPrimary(const std::string &device_id) = 0;

/**
* @brief Get HDR state for the devices.
* @param device_ids A list of devices to get the HDR states for.
* @returns A map of HDR states per a device or an empty map if an error has occurred.
* @note On Windows the state cannot be retrieved until the device is active even if it supports it.
*
* EXAMPLES:
* ```cpp
* const WinDisplayDeviceInterface* iface = getIface(...);
* const std::unordered_set<std::string> device_ids { "DEVICE_ID_1", "DEVICE_ID_2" };
* const auto current_hdr_states = iface->getCurrentHdrStates(device_ids);
* ```
*/
[[nodiscard]] virtual HdrStateMap
getCurrentHdrStates(const std::set<std::string> &device_ids) const = 0;

/**
* @brief Set HDR states for the devices.
* @param modes A map of HDR states to set.
* @returns True if HDR states were set, false otherwise.
* @note If `unknown` states are provided, they will be silently ignored
* and current state will not be changed.
*
* EXAMPLES:
* ```cpp
* const WinDisplayDeviceInterface* iface = getIface(...);
* const std::string display_a { "MY_ID_1" };
* const std::string display_b { "MY_ID_2" };
* const auto success = iface->setHdrStates({ { display_a, HdrState::Enabled },
* { display_b, HdrState::Disabled } });
* ```
*/
[[nodiscard]] virtual bool
setHdrStates(const HdrStateMap &states) = 0;
};
} // namespace display_device
37 changes: 36 additions & 1 deletion src/windows/winapilayer.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -522,7 +522,7 @@ namespace display_device {

LONG result { DisplayConfigGetDeviceInfo(&source_name.header) };
if (result != ERROR_SUCCESS) {
DD_LOG(error) << getErrorString(result) << " failed to get display name!";
DD_LOG(error) << getErrorString(result) << " failed to get display name!";
return {};
}

Expand All@@ -539,4 +539,39 @@ namespace display_device {
modes.empty() ? nullptr : modes.data(),
flags);
}

std::optional<HdrState>
WinApiLayer::getHdrState(const DISPLAYCONFIG_PATH_INFO &path) const {
DISPLAYCONFIG_GET_ADVANCED_COLOR_INFO color_info = {};
color_info.header.adapterId = path.targetInfo.adapterId;
color_info.header.id = path.targetInfo.id;
color_info.header.type = DISPLAYCONFIG_DEVICE_INFO_GET_ADVANCED_COLOR_INFO;
color_info.header.size = sizeof(color_info);

LONG result { DisplayConfigGetDeviceInfo(&color_info.header) };
if (result != ERROR_SUCCESS) {
DD_LOG(error) << getErrorString(result) << " failed to get advanced color info!";
return std::nullopt;
}

return color_info.advancedColorSupported ? std::make_optional(color_info.advancedColorEnabled ? HdrState::Enabled : HdrState::Disabled) : std::nullopt;
}

bool
WinApiLayer::setHdrState(const DISPLAYCONFIG_PATH_INFO &path, HdrState state) {
DISPLAYCONFIG_SET_ADVANCED_COLOR_STATE color_state = {};
color_state.header.adapterId = path.targetInfo.adapterId;
color_state.header.id = path.targetInfo.id;
color_state.header.type = DISPLAYCONFIG_DEVICE_INFO_SET_ADVANCED_COLOR_STATE;
color_state.header.size = sizeof(color_state);
color_state.enableAdvancedColor = state == HdrState::Enabled ? 1 : 0;

LONG result { DisplayConfigSetDeviceInfo(&color_state.header) };
if (result != ERROR_SUCCESS) {
DD_LOG(error) << getErrorString(result) << " failed to set advanced color info!";
return false;
}

return true;
}
} // namespace display_device
127 changes: 127 additions & 0 deletions src/windows/windisplaydevicehdr.cpp
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,127 @@
// class header include
#include "displaydevice/windows/windisplaydevice.h"

// system includes
#include <ranges>

// local includes
#include "displaydevice/logging.h"
#include "displaydevice/windows/winapiutils.h"

namespace display_device {
namespace {
/** @brief HDR state map without optional values. */
using HdrStateMapNoOpt = std::map<std::string, HdrState>;

/**
* @see setHdrStates for a description as this was split off to reduce cognitive complexity.
*/
bool
doSetHdrStates(WinApiLayerInterface &w_api, const PathAndModeData &display_data, const HdrStateMapNoOpt &states, HdrStateMapNoOpt *changed_states) {
const auto try_set_state {
[&w_api, &display_data](const auto &device_id, const auto &state, auto &current_state) {
const auto path { win_utils::getActivePath(w_api, device_id, display_data.m_paths) };
if (!path) {
DD_LOG(error) << "Failed to find device for " << device_id << "!";
return false;
}

const auto current_state_int { w_api.getHdrState(*path) };
if (!current_state_int) {
DD_LOG(error) << "HDR state cannot be changed for " << device_id << "!";
return false;
}

if (state != *current_state_int) {
if (!w_api.setHdrState(*path, state)) {
// Error already logged
return false;
}

current_state = current_state_int;
}

return true;
}
};

for (const auto &[device_id, state] : states) {
std::optional<HdrState> current_state;
if (try_set_state(device_id, state, current_state)) {
if (current_state && changed_states != nullptr) {
(*changed_states)[device_id] = *current_state;
}
}
// If we are undoing changes we don't want to return early and continue regardless of what error we get.
else if (changed_states != nullptr) {
return false;
}
}

return true;
}

} // namespace

HdrStateMap
WinDisplayDevice::getCurrentHdrStates(const std::set<std::string> &device_ids) const {
if (device_ids.empty()) {
DD_LOG(error) << "Device id set is empty!";
return {};
}

const auto display_data { m_w_api->queryDisplayConfig(QueryType::Active) };
if (!display_data) {
// Error already logged
return {};
}

HdrStateMap states;
for (const auto &device_id : device_ids) {
const auto path { win_utils::getActivePath(*m_w_api, device_id, display_data->m_paths) };
if (!path) {
DD_LOG(error) << "Failed to find device for " << device_id << "!";
return {};
}

states[device_id] = m_w_api->getHdrState(*path);
}

return states;
}

bool
WinDisplayDevice::setHdrStates(const HdrStateMap &states) {
if (states.empty()) {
DD_LOG(error) << "States map is empty!";
return false;
}

HdrStateMapNoOpt states_without_opt;
std::ranges::copy(states |
std::ranges::views::filter([](const auto &entry) { return static_cast<bool>(entry.second); }) |
std::views::transform([](const auto &entry) { return std::make_pair(entry.first, *entry.second); }),
std::inserter(states_without_opt, std::begin(states_without_opt)));

if (states_without_opt.empty()) {
// Return early as there is nothing to do...
return true;
}

const auto display_data { m_w_api->queryDisplayConfig(QueryType::Active) };
if (!display_data) {
// Error already logged
return {};
}

HdrStateMapNoOpt changed_states;
if (!doSetHdrStates(*m_w_api, *display_data, states_without_opt, &changed_states)) {
if (!changed_states.empty()) {
doSetHdrStates(*m_w_api, *display_data, changed_states, nullptr); // return value does not matter
}
return false;
}

return true;
}
} // namespace display_device
8 changes: 8 additions & 0 deletions tests/unit/windows/test_winapilayer.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -204,3 +204,11 @@ TEST_F_S(GetDisplayName) {
TEST_F_S(GetDisplayName, InvalidPath) {
EXPECT_EQ(m_layer.getDisplayName(INVALID_PATH), std::string {});
}

TEST_F_S(GetHdrState, InvalidPath) {
EXPECT_EQ(m_layer.getHdrState(INVALID_PATH), std::nullopt);
}

TEST_F_S(SetHdrState, InvalidPath) {
EXPECT_FALSE(m_layer.setHdrState(INVALID_PATH, display_device::HdrState::Enabled));
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/common/include/displaydevice/types.h
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,14 @@
#pragma once

namespace display_device {
/**
* @brief The device's HDR state in the operating system.
*/
enum class HdrState {
Disabled,
Enabled
};

/**
* @brief Display's resolution.
*/
Expand Down
4 changes: 4 additions & 0 deletions src/windows/include/displaydevice/windows/types.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -91,4 +91,8 @@ namespace display_device {
*/
using DeviceDisplayModeMap = std::map<std::string, DisplayMode>;

/**
* @brief Ordered map of [DEVICE_ID -> std::optional<HdrState>].
*/
using HdrStateMap = std::map<std::string, std::optional<HdrState>>;
} // namespace display_device
8 changes: 8 additions & 0 deletions src/windows/include/displaydevice/windows/winapilayer.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,5 +36,13 @@ namespace display_device {
/** For details @see WinApiLayerInterface::setDisplayConfig */
[[nodiscard]] LONG
setDisplayConfig(std::vector<DISPLAYCONFIG_PATH_INFO> paths, std::vector<DISPLAYCONFIG_MODE_INFO> modes, UINT32 flags) override;

/** For details @see WinApiLayerInterface::getHdrState */
[[nodiscard]] std::optional<HdrState>
getHdrState(const DISPLAYCONFIG_PATH_INFO &path) const override;

/** For details @see WinApiLayerInterface::setHdrState */
[[nodiscard]] bool
setHdrState(const DISPLAYCONFIG_PATH_INFO &path, HdrState state) override;
};
} // namespace display_device
31 changes: 31 additions & 0 deletions src/windows/include/displaydevice/windows/winapilayerinterface.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -166,5 +166,36 @@ namespace display_device {
*/
[[nodiscard]] virtual LONG
setDisplayConfig(std::vector<DISPLAYCONFIG_PATH_INFO> paths, std::vector<DISPLAYCONFIG_MODE_INFO> modes, UINT32 flags) = 0;

/**
* @brief Get the HDR state the path.
* @param path Path to get HDR state for.
* @returns std::nullopt if the state could not be retrieved, or other enum values describing the state otherwise.
*
* EXAMPLES:
* ```cpp
* DISPLAYCONFIG_PATH_INFO path;
* const WinApiLayerInterface* iface = getIface(...);
* const auto hdr_state = iface->getHdrState(path);
* ```
*/
[[nodiscard]] virtual std::optional<HdrState>
getHdrState(const DISPLAYCONFIG_PATH_INFO &path) const = 0;

/**
* @brief Set the HDR state for the path.
* @param path Path to set HDR state for.
* @param state Specify new HDR state.
* @returns True if the device is in the new state, false otherwise.
*
* EXAMPLES:
* ```cpp
* DISPLAYCONFIG_PATH_INFO path;
* const WinApiLayerInterface* iface = getIface(...);
* const bool success = iface->setHdrState(path, HdrState::Enabled);
* ```
*/
[[nodiscard]] virtual bool
setHdrState(const DISPLAYCONFIG_PATH_INFO &path, HdrState state) = 0;
};
} // namespace display_device
8 changes: 8 additions & 0 deletions src/windows/include/displaydevice/windows/windisplaydevice.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,14 @@ namespace display_device {
[[nodiscard]] bool
setAsPrimary(const std::string &device_id) override;

/** For details @see WinDisplayDeviceInterface::getCurrentHdrStates */
[[nodiscard]] HdrStateMap
getCurrentHdrStates(const std::set<std::string> &device_ids) const override;

/** For details @see WinDisplayDeviceInterface::setHdrStates */
[[nodiscard]] bool
setHdrStates(const HdrStateMap &states) override;

private:
std::shared_ptr<WinApiLayerInterface> m_w_api;
};
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,5 +150,40 @@ namespace display_device {
*/
[[nodiscard]] virtual bool
setAsPrimary(const std::string &device_id) = 0;

/**
* @brief Get HDR state for the devices.
* @param device_ids A list of devices to get the HDR states for.
* @returns A map of HDR states per a device or an empty map if an error has occurred.
* @note On Windows the state cannot be retrieved until the device is active even if it supports it.
*
* EXAMPLES:
* ```cpp
* const WinDisplayDeviceInterface* iface = getIface(...);
* const std::unordered_set<std::string> device_ids { "DEVICE_ID_1", "DEVICE_ID_2" };
* const auto current_hdr_states = iface->getCurrentHdrStates(device_ids);
* ```
*/
[[nodiscard]] virtual HdrStateMap
getCurrentHdrStates(const std::set<std::string> &device_ids) const = 0;

/**
* @brief Set HDR states for the devices.
* @param modes A map of HDR states to set.
* @returns True if HDR states were set, false otherwise.
* @note If `unknown` states are provided, they will be silently ignored
* and current state will not be changed.
*
* EXAMPLES:
* ```cpp
* const WinDisplayDeviceInterface* iface = getIface(...);
* const std::string display_a { "MY_ID_1" };
* const std::string display_b { "MY_ID_2" };
* const auto success = iface->setHdrStates({ { display_a, HdrState::Enabled },
* { display_b, HdrState::Disabled } });
* ```
*/
[[nodiscard]] virtual bool
setHdrStates(const HdrStateMap &states) = 0;
};
} // namespace display_device
37 changes: 36 additions & 1 deletion src/windows/winapilayer.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -522,7 +522,7 @@ namespace display_device {

LONG result { DisplayConfigGetDeviceInfo(&source_name.header) };
if (result != ERROR_SUCCESS) {
DD_LOG(error) << getErrorString(result) << " failed to get display name!";
DD_LOG(error) << getErrorString(result) << " failed to get display name!";
return {};
}

Expand All@@ -539,4 +539,39 @@ namespace display_device {
modes.empty() ? nullptr : modes.data(),
flags);
}

std::optional<HdrState>
WinApiLayer::getHdrState(const DISPLAYCONFIG_PATH_INFO &path) const {
DISPLAYCONFIG_GET_ADVANCED_COLOR_INFO color_info = {};
color_info.header.adapterId = path.targetInfo.adapterId;
color_info.header.id = path.targetInfo.id;
color_info.header.type = DISPLAYCONFIG_DEVICE_INFO_GET_ADVANCED_COLOR_INFO;
color_info.header.size = sizeof(color_info);

LONG result { DisplayConfigGetDeviceInfo(&color_info.header) };
if (result != ERROR_SUCCESS) {
DD_LOG(error) << getErrorString(result) << " failed to get advanced color info!";
return std::nullopt;
}

return color_info.advancedColorSupported ? std::make_optional(color_info.advancedColorEnabled ? HdrState::Enabled : HdrState::Disabled) : std::nullopt;
}

bool
WinApiLayer::setHdrState(const DISPLAYCONFIG_PATH_INFO &path, HdrState state) {
DISPLAYCONFIG_SET_ADVANCED_COLOR_STATE color_state = {};
color_state.header.adapterId = path.targetInfo.adapterId;
color_state.header.id = path.targetInfo.id;
color_state.header.type = DISPLAYCONFIG_DEVICE_INFO_SET_ADVANCED_COLOR_STATE;
color_state.header.size = sizeof(color_state);
color_state.enableAdvancedColor = state == HdrState::Enabled ? 1 : 0;

LONG result { DisplayConfigSetDeviceInfo(&color_state.header) };
if (result != ERROR_SUCCESS) {
DD_LOG(error) << getErrorString(result) << " failed to set advanced color info!";
return false;
}

return true;
}
} // namespace display_device
127 changes: 127 additions & 0 deletions src/windows/windisplaydevicehdr.cpp
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,127 @@
// class header include
#include "displaydevice/windows/windisplaydevice.h"

// system includes
#include <ranges>

// local includes
#include "displaydevice/logging.h"
#include "displaydevice/windows/winapiutils.h"

namespace display_device {
namespace {
/** @brief HDR state map without optional values. */
using HdrStateMapNoOpt = std::map<std::string, HdrState>;

/**
* @see setHdrStates for a description as this was split off to reduce cognitive complexity.
*/
bool
doSetHdrStates(WinApiLayerInterface &w_api, const PathAndModeData &display_data, const HdrStateMapNoOpt &states, HdrStateMapNoOpt *changed_states) {
const auto try_set_state {
[&w_api, &display_data](const auto &device_id, const auto &state, auto &current_state) {
const auto path { win_utils::getActivePath(w_api, device_id, display_data.m_paths) };
if (!path) {
DD_LOG(error) << "Failed to find device for " << device_id << "!";
return false;
}

const auto current_state_int { w_api.getHdrState(*path) };
if (!current_state_int) {
DD_LOG(error) << "HDR state cannot be changed for " << device_id << "!";
return false;
}

if (state != *current_state_int) {
if (!w_api.setHdrState(*path, state)) {
// Error already logged
return false;
}

current_state = current_state_int;
}

return true;
}
};

for (const auto &[device_id, state] : states) {
std::optional<HdrState> current_state;
if (try_set_state(device_id, state, current_state)) {
if (current_state && changed_states != nullptr) {
(*changed_states)[device_id] = *current_state;
}
}
// If we are undoing changes we don't want to return early and continue regardless of what error we get.
else if (changed_states != nullptr) {
return false;
}
}

return true;
}

} // namespace

HdrStateMap
WinDisplayDevice::getCurrentHdrStates(const std::set<std::string> &device_ids) const {
if (device_ids.empty()) {
DD_LOG(error) << "Device id set is empty!";
return {};
}

const auto display_data { m_w_api->queryDisplayConfig(QueryType::Active) };
if (!display_data) {
// Error already logged
return {};
}

HdrStateMap states;
for (const auto &device_id : device_ids) {
const auto path { win_utils::getActivePath(*m_w_api, device_id, display_data->m_paths) };
if (!path) {
DD_LOG(error) << "Failed to find device for " << device_id << "!";
return {};
}

states[device_id] = m_w_api->getHdrState(*path);
}

return states;
}

bool
WinDisplayDevice::setHdrStates(const HdrStateMap &states) {
if (states.empty()) {
DD_LOG(error) << "States map is empty!";
return false;
}

HdrStateMapNoOpt states_without_opt;
std::ranges::copy(states |
std::ranges::views::filter([](const auto &entry) { return static_cast<bool>(entry.second); }) |
std::views::transform([](const auto &entry) { return std::make_pair(entry.first, *entry.second); }),
std::inserter(states_without_opt, std::begin(states_without_opt)));

if (states_without_opt.empty()) {
// Return early as there is nothing to do...
return true;
}

const auto display_data { m_w_api->queryDisplayConfig(QueryType::Active) };
if (!display_data) {
// Error already logged
return {};
}

HdrStateMapNoOpt changed_states;
if (!doSetHdrStates(*m_w_api, *display_data, states_without_opt, &changed_states)) {
if (!changed_states.empty()) {
doSetHdrStates(*m_w_api, *display_data, changed_states, nullptr); // return value does not matter
}
return false;
}

return true;
}
} // namespace display_device
8 changes: 8 additions & 0 deletions tests/unit/windows/test_winapilayer.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -204,3 +204,11 @@ TEST_F_S(GetDisplayName) {
TEST_F_S(GetDisplayName, InvalidPath) {
EXPECT_EQ(m_layer.getDisplayName(INVALID_PATH), std::string {});
}

TEST_F_S(GetHdrState, InvalidPath) {
EXPECT_EQ(m_layer.getHdrState(INVALID_PATH), std::nullopt);
}

TEST_F_S(SetHdrState, InvalidPath) {
EXPECT_FALSE(m_layer.setHdrState(INVALID_PATH, display_device::HdrState::Enabled));
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/common/include/displaydevice/types.h
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,14 @@
#pragma once

namespace display_device {
/**
* @brief The device's HDR state in the operating system.
*/
enum class HdrState {
Disabled,
Enabled
};

/**
* @brief Display's resolution.
*/
Expand Down
4 changes: 4 additions & 0 deletions src/windows/include/displaydevice/windows/types.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -91,4 +91,8 @@ namespace display_device {
*/
using DeviceDisplayModeMap = std::map<std::string, DisplayMode>;

/**
* @brief Ordered map of [DEVICE_ID -> std::optional<HdrState>].
*/
using HdrStateMap = std::map<std::string, std::optional<HdrState>>;
} // namespace display_device
8 changes: 8 additions & 0 deletions src/windows/include/displaydevice/windows/winapilayer.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,5 +36,13 @@ namespace display_device {
/** For details @see WinApiLayerInterface::setDisplayConfig */
[[nodiscard]] LONG
setDisplayConfig(std::vector<DISPLAYCONFIG_PATH_INFO> paths, std::vector<DISPLAYCONFIG_MODE_INFO> modes, UINT32 flags) override;

/** For details @see WinApiLayerInterface::getHdrState */
[[nodiscard]] std::optional<HdrState>
getHdrState(const DISPLAYCONFIG_PATH_INFO &path) const override;

/** For details @see WinApiLayerInterface::setHdrState */
[[nodiscard]] bool
setHdrState(const DISPLAYCONFIG_PATH_INFO &path, HdrState state) override;
};
} // namespace display_device
31 changes: 31 additions & 0 deletions src/windows/include/displaydevice/windows/winapilayerinterface.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -166,5 +166,36 @@ namespace display_device {
*/
[[nodiscard]] virtual LONG
setDisplayConfig(std::vector<DISPLAYCONFIG_PATH_INFO> paths, std::vector<DISPLAYCONFIG_MODE_INFO> modes, UINT32 flags) = 0;

/**
* @brief Get the HDR state the path.
* @param path Path to get HDR state for.
* @returns std::nullopt if the state could not be retrieved, or other enum values describing the state otherwise.
*
* EXAMPLES:
* ```cpp
* DISPLAYCONFIG_PATH_INFO path;
* const WinApiLayerInterface* iface = getIface(...);
* const auto hdr_state = iface->getHdrState(path);
* ```
*/
[[nodiscard]] virtual std::optional<HdrState>
getHdrState(const DISPLAYCONFIG_PATH_INFO &path) const = 0;

/**
* @brief Set the HDR state for the path.
* @param path Path to set HDR state for.
* @param state Specify new HDR state.
* @returns True if the device is in the new state, false otherwise.
*
* EXAMPLES:
* ```cpp
* DISPLAYCONFIG_PATH_INFO path;
* const WinApiLayerInterface* iface = getIface(...);
* const bool success = iface->setHdrState(path, HdrState::Enabled);
* ```
*/
[[nodiscard]] virtual bool
setHdrState(const DISPLAYCONFIG_PATH_INFO &path, HdrState state) = 0;
};
} // namespace display_device
8 changes: 8 additions & 0 deletions src/windows/include/displaydevice/windows/windisplaydevice.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,14 @@ namespace display_device {
[[nodiscard]] bool
setAsPrimary(const std::string &device_id) override;

/** For details @see WinDisplayDeviceInterface::getCurrentHdrStates */
[[nodiscard]] HdrStateMap
getCurrentHdrStates(const std::set<std::string> &device_ids) const override;

/** For details @see WinDisplayDeviceInterface::setHdrStates */
[[nodiscard]] bool
setHdrStates(const HdrStateMap &states) override;

private:
std::shared_ptr<WinApiLayerInterface> m_w_api;
};
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,5 +150,40 @@ namespace display_device {
*/
[[nodiscard]] virtual bool
setAsPrimary(const std::string &device_id) = 0;

/**
* @brief Get HDR state for the devices.
* @param device_ids A list of devices to get the HDR states for.
* @returns A map of HDR states per a device or an empty map if an error has occurred.
* @note On Windows the state cannot be retrieved until the device is active even if it supports it.
*
* EXAMPLES:
* ```cpp
* const WinDisplayDeviceInterface* iface = getIface(...);
* const std::unordered_set<std::string> device_ids { "DEVICE_ID_1", "DEVICE_ID_2" };
* const auto current_hdr_states = iface->getCurrentHdrStates(device_ids);
* ```
*/
[[nodiscard]] virtual HdrStateMap
getCurrentHdrStates(const std::set<std::string> &device_ids) const = 0;

/**
* @brief Set HDR states for the devices.
* @param modes A map of HDR states to set.
* @returns True if HDR states were set, false otherwise.
* @note If `unknown` states are provided, they will be silently ignored
* and current state will not be changed.
*
* EXAMPLES:
* ```cpp
* const WinDisplayDeviceInterface* iface = getIface(...);
* const std::string display_a { "MY_ID_1" };
* const std::string display_b { "MY_ID_2" };
* const auto success = iface->setHdrStates({ { display_a, HdrState::Enabled },
* { display_b, HdrState::Disabled } });
* ```
*/
[[nodiscard]] virtual bool
setHdrStates(const HdrStateMap &states) = 0;
};
} // namespace display_device
37 changes: 36 additions & 1 deletion src/windows/winapilayer.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -522,7 +522,7 @@ namespace display_device {

LONG result { DisplayConfigGetDeviceInfo(&source_name.header) };
if (result != ERROR_SUCCESS) {
DD_LOG(error) << getErrorString(result) << " failed to get display name!";
DD_LOG(error) << getErrorString(result) << " failed to get display name!";
return {};
}

Expand All@@ -539,4 +539,39 @@ namespace display_device {
modes.empty() ? nullptr : modes.data(),
flags);
}

std::optional<HdrState>
WinApiLayer::getHdrState(const DISPLAYCONFIG_PATH_INFO &path) const {
DISPLAYCONFIG_GET_ADVANCED_COLOR_INFO color_info = {};
color_info.header.adapterId = path.targetInfo.adapterId;
color_info.header.id = path.targetInfo.id;
color_info.header.type = DISPLAYCONFIG_DEVICE_INFO_GET_ADVANCED_COLOR_INFO;
color_info.header.size = sizeof(color_info);

LONG result { DisplayConfigGetDeviceInfo(&color_info.header) };
if (result != ERROR_SUCCESS) {
DD_LOG(error) << getErrorString(result) << " failed to get advanced color info!";
return std::nullopt;
}

return color_info.advancedColorSupported ? std::make_optional(color_info.advancedColorEnabled ? HdrState::Enabled : HdrState::Disabled) : std::nullopt;
}

bool
WinApiLayer::setHdrState(const DISPLAYCONFIG_PATH_INFO &path, HdrState state) {
DISPLAYCONFIG_SET_ADVANCED_COLOR_STATE color_state = {};
color_state.header.adapterId = path.targetInfo.adapterId;
color_state.header.id = path.targetInfo.id;
color_state.header.type = DISPLAYCONFIG_DEVICE_INFO_SET_ADVANCED_COLOR_STATE;
color_state.header.size = sizeof(color_state);
color_state.enableAdvancedColor = state == HdrState::Enabled ? 1 : 0;

LONG result { DisplayConfigSetDeviceInfo(&color_state.header) };
if (result != ERROR_SUCCESS) {
DD_LOG(error) << getErrorString(result) << " failed to set advanced color info!";
return false;
}

return true;
}
} // namespace display_device
127 changes: 127 additions & 0 deletions src/windows/windisplaydevicehdr.cpp
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,127 @@
// class header include
#include "displaydevice/windows/windisplaydevice.h"

// system includes
#include <ranges>

// local includes
#include "displaydevice/logging.h"
#include "displaydevice/windows/winapiutils.h"

namespace display_device {
namespace {
/** @brief HDR state map without optional values. */
using HdrStateMapNoOpt = std::map<std::string, HdrState>;

/**
* @see setHdrStates for a description as this was split off to reduce cognitive complexity.
*/
bool
doSetHdrStates(WinApiLayerInterface &w_api, const PathAndModeData &display_data, const HdrStateMapNoOpt &states, HdrStateMapNoOpt *changed_states) {
const auto try_set_state {
[&w_api, &display_data](const auto &device_id, const auto &state, auto &current_state) {
const auto path { win_utils::getActivePath(w_api, device_id, display_data.m_paths) };
if (!path) {
DD_LOG(error) << "Failed to find device for " << device_id << "!";
return false;
}

const auto current_state_int { w_api.getHdrState(*path) };
if (!current_state_int) {
DD_LOG(error) << "HDR state cannot be changed for " << device_id << "!";
return false;
}

if (state != *current_state_int) {
if (!w_api.setHdrState(*path, state)) {
// Error already logged
return false;
}

current_state = current_state_int;
}

return true;
}
};

for (const auto &[device_id, state] : states) {
std::optional<HdrState> current_state;
if (try_set_state(device_id, state, current_state)) {
if (current_state && changed_states != nullptr) {
(*changed_states)[device_id] = *current_state;
}
}
// If we are undoing changes we don't want to return early and continue regardless of what error we get.
else if (changed_states != nullptr) {
return false;
}
}

return true;
}

} // namespace

HdrStateMap
WinDisplayDevice::getCurrentHdrStates(const std::set<std::string> &device_ids) const {
if (device_ids.empty()) {
DD_LOG(error) << "Device id set is empty!";
return {};
}

const auto display_data { m_w_api->queryDisplayConfig(QueryType::Active) };
if (!display_data) {
// Error already logged
return {};
}

HdrStateMap states;
for (const auto &device_id : device_ids) {
const auto path { win_utils::getActivePath(*m_w_api, device_id, display_data->m_paths) };
if (!path) {
DD_LOG(error) << "Failed to find device for " << device_id << "!";
return {};
}

states[device_id] = m_w_api->getHdrState(*path);
}

return states;
}

bool
WinDisplayDevice::setHdrStates(const HdrStateMap &states) {
if (states.empty()) {
DD_LOG(error) << "States map is empty!";
return false;
}

HdrStateMapNoOpt states_without_opt;
std::ranges::copy(states |
std::ranges::views::filter([](const auto &entry) { return static_cast<bool>(entry.second); }) |
std::views::transform([](const auto &entry) { return std::make_pair(entry.first, *entry.second); }),
std::inserter(states_without_opt, std::begin(states_without_opt)));

if (states_without_opt.empty()) {
// Return early as there is nothing to do...
return true;
}

const auto display_data { m_w_api->queryDisplayConfig(QueryType::Active) };
if (!display_data) {
// Error already logged
return {};
}

HdrStateMapNoOpt changed_states;
if (!doSetHdrStates(*m_w_api, *display_data, states_without_opt, &changed_states)) {
if (!changed_states.empty()) {
doSetHdrStates(*m_w_api, *display_data, changed_states, nullptr); // return value does not matter
}
return false;
}

return true;
}
} // namespace display_device
8 changes: 8 additions & 0 deletions tests/unit/windows/test_winapilayer.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -204,3 +204,11 @@ TEST_F_S(GetDisplayName) {
TEST_F_S(GetDisplayName, InvalidPath) {
EXPECT_EQ(m_layer.getDisplayName(INVALID_PATH), std::string {});
}

TEST_F_S(GetHdrState, InvalidPath) {
EXPECT_EQ(m_layer.getHdrState(INVALID_PATH), std::nullopt);
}

TEST_F_S(SetHdrState, InvalidPath) {
EXPECT_FALSE(m_layer.setHdrState(INVALID_PATH, display_device::HdrState::Enabled));
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/common/include/displaydevice/types.h
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,14 @@
#pragma once

namespace display_device {
/**
* @brief The device's HDR state in the operating system.
*/
enum class HdrState {
Disabled,
Enabled
};

/**
* @brief Display's resolution.
*/
Expand Down
4 changes: 4 additions & 0 deletions src/windows/include/displaydevice/windows/types.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -91,4 +91,8 @@ namespace display_device {
*/
using DeviceDisplayModeMap = std::map<std::string, DisplayMode>;

/**
* @brief Ordered map of [DEVICE_ID -> std::optional<HdrState>].
*/
using HdrStateMap = std::map<std::string, std::optional<HdrState>>;
} // namespace display_device
8 changes: 8 additions & 0 deletions src/windows/include/displaydevice/windows/winapilayer.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,5 +36,13 @@ namespace display_device {
/** For details @see WinApiLayerInterface::setDisplayConfig */
[[nodiscard]] LONG
setDisplayConfig(std::vector<DISPLAYCONFIG_PATH_INFO> paths, std::vector<DISPLAYCONFIG_MODE_INFO> modes, UINT32 flags) override;

/** For details @see WinApiLayerInterface::getHdrState */
[[nodiscard]] std::optional<HdrState>
getHdrState(const DISPLAYCONFIG_PATH_INFO &path) const override;

/** For details @see WinApiLayerInterface::setHdrState */
[[nodiscard]] bool
setHdrState(const DISPLAYCONFIG_PATH_INFO &path, HdrState state) override;
};
} // namespace display_device
31 changes: 31 additions & 0 deletions src/windows/include/displaydevice/windows/winapilayerinterface.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -166,5 +166,36 @@ namespace display_device {
*/
[[nodiscard]] virtual LONG
setDisplayConfig(std::vector<DISPLAYCONFIG_PATH_INFO> paths, std::vector<DISPLAYCONFIG_MODE_INFO> modes, UINT32 flags) = 0;

/**
* @brief Get the HDR state the path.
* @param path Path to get HDR state for.
* @returns std::nullopt if the state could not be retrieved, or other enum values describing the state otherwise.
*
* EXAMPLES:
* ```cpp
* DISPLAYCONFIG_PATH_INFO path;
* const WinApiLayerInterface* iface = getIface(...);
* const auto hdr_state = iface->getHdrState(path);
* ```
*/
[[nodiscard]] virtual std::optional<HdrState>
getHdrState(const DISPLAYCONFIG_PATH_INFO &path) const = 0;

/**
* @brief Set the HDR state for the path.
* @param path Path to set HDR state for.
* @param state Specify new HDR state.
* @returns True if the device is in the new state, false otherwise.
*
* EXAMPLES:
* ```cpp
* DISPLAYCONFIG_PATH_INFO path;
* const WinApiLayerInterface* iface = getIface(...);
* const bool success = iface->setHdrState(path, HdrState::Enabled);
* ```
*/
[[nodiscard]] virtual bool
setHdrState(const DISPLAYCONFIG_PATH_INFO &path, HdrState state) = 0;
};
} // namespace display_device
8 changes: 8 additions & 0 deletions src/windows/include/displaydevice/windows/windisplaydevice.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,14 @@ namespace display_device {
[[nodiscard]] bool
setAsPrimary(const std::string &device_id) override;

/** For details @see WinDisplayDeviceInterface::getCurrentHdrStates */
[[nodiscard]] HdrStateMap
getCurrentHdrStates(const std::set<std::string> &device_ids) const override;

/** For details @see WinDisplayDeviceInterface::setHdrStates */
[[nodiscard]] bool
setHdrStates(const HdrStateMap &states) override;

private:
std::shared_ptr<WinApiLayerInterface> m_w_api;
};
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,5 +150,40 @@ namespace display_device {
*/
[[nodiscard]] virtual bool
setAsPrimary(const std::string &device_id) = 0;

/**
* @brief Get HDR state for the devices.
* @param device_ids A list of devices to get the HDR states for.
* @returns A map of HDR states per a device or an empty map if an error has occurred.
* @note On Windows the state cannot be retrieved until the device is active even if it supports it.
*
* EXAMPLES:
* ```cpp
* const WinDisplayDeviceInterface* iface = getIface(...);
* const std::unordered_set<std::string> device_ids { "DEVICE_ID_1", "DEVICE_ID_2" };
* const auto current_hdr_states = iface->getCurrentHdrStates(device_ids);
* ```
*/
[[nodiscard]] virtual HdrStateMap
getCurrentHdrStates(const std::set<std::string> &device_ids) const = 0;

/**
* @brief Set HDR states for the devices.
* @param modes A map of HDR states to set.
* @returns True if HDR states were set, false otherwise.
* @note If `unknown` states are provided, they will be silently ignored
* and current state will not be changed.
*
* EXAMPLES:
* ```cpp
* const WinDisplayDeviceInterface* iface = getIface(...);
* const std::string display_a { "MY_ID_1" };
* const std::string display_b { "MY_ID_2" };
* const auto success = iface->setHdrStates({ { display_a, HdrState::Enabled },
* { display_b, HdrState::Disabled } });
* ```
*/
[[nodiscard]] virtual bool
setHdrStates(const HdrStateMap &states) = 0;
};
} // namespace display_device
37 changes: 36 additions & 1 deletion src/windows/winapilayer.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -522,7 +522,7 @@ namespace display_device {

LONG result { DisplayConfigGetDeviceInfo(&source_name.header) };
if (result != ERROR_SUCCESS) {
DD_LOG(error) << getErrorString(result) << " failed to get display name!";
DD_LOG(error) << getErrorString(result) << " failed to get display name!";
return {};
}

Expand All@@ -539,4 +539,39 @@ namespace display_device {
modes.empty() ? nullptr : modes.data(),
flags);
}

std::optional<HdrState>
WinApiLayer::getHdrState(const DISPLAYCONFIG_PATH_INFO &path) const {
DISPLAYCONFIG_GET_ADVANCED_COLOR_INFO color_info = {};
color_info.header.adapterId = path.targetInfo.adapterId;
color_info.header.id = path.targetInfo.id;
color_info.header.type = DISPLAYCONFIG_DEVICE_INFO_GET_ADVANCED_COLOR_INFO;
color_info.header.size = sizeof(color_info);

LONG result { DisplayConfigGetDeviceInfo(&color_info.header) };
if (result != ERROR_SUCCESS) {
DD_LOG(error) << getErrorString(result) << " failed to get advanced color info!";
return std::nullopt;
}

return color_info.advancedColorSupported ? std::make_optional(color_info.advancedColorEnabled ? HdrState::Enabled : HdrState::Disabled) : std::nullopt;
}

bool
WinApiLayer::setHdrState(const DISPLAYCONFIG_PATH_INFO &path, HdrState state) {
DISPLAYCONFIG_SET_ADVANCED_COLOR_STATE color_state = {};
color_state.header.adapterId = path.targetInfo.adapterId;
color_state.header.id = path.targetInfo.id;
color_state.header.type = DISPLAYCONFIG_DEVICE_INFO_SET_ADVANCED_COLOR_STATE;
color_state.header.size = sizeof(color_state);
color_state.enableAdvancedColor = state == HdrState::Enabled ? 1 : 0;

LONG result { DisplayConfigSetDeviceInfo(&color_state.header) };
if (result != ERROR_SUCCESS) {
DD_LOG(error) << getErrorString(result) << " failed to set advanced color info!";
return false;
}

return true;
}
} // namespace display_device
127 changes: 127 additions & 0 deletions src/windows/windisplaydevicehdr.cpp
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,127 @@
// class header include
#include "displaydevice/windows/windisplaydevice.h"

// system includes
#include <ranges>

// local includes
#include "displaydevice/logging.h"
#include "displaydevice/windows/winapiutils.h"

namespace display_device {
namespace {
/** @brief HDR state map without optional values. */
using HdrStateMapNoOpt = std::map<std::string, HdrState>;

/**
* @see setHdrStates for a description as this was split off to reduce cognitive complexity.
*/
bool
doSetHdrStates(WinApiLayerInterface &w_api, const PathAndModeData &display_data, const HdrStateMapNoOpt &states, HdrStateMapNoOpt *changed_states) {
const auto try_set_state {
[&w_api, &display_data](const auto &device_id, const auto &state, auto &current_state) {
const auto path { win_utils::getActivePath(w_api, device_id, display_data.m_paths) };
if (!path) {
DD_LOG(error) << "Failed to find device for " << device_id << "!";
return false;
}

const auto current_state_int { w_api.getHdrState(*path) };
if (!current_state_int) {
DD_LOG(error) << "HDR state cannot be changed for " << device_id << "!";
return false;
}

if (state != *current_state_int) {
if (!w_api.setHdrState(*path, state)) {
// Error already logged
return false;
}

current_state = current_state_int;
}

return true;
}
};

for (const auto &[device_id, state] : states) {
std::optional<HdrState> current_state;
if (try_set_state(device_id, state, current_state)) {
if (current_state && changed_states != nullptr) {
(*changed_states)[device_id] = *current_state;
}
}
// If we are undoing changes we don't want to return early and continue regardless of what error we get.
else if (changed_states != nullptr) {
return false;
}
}

return true;
}

} // namespace

HdrStateMap
WinDisplayDevice::getCurrentHdrStates(const std::set<std::string> &device_ids) const {
if (device_ids.empty()) {
DD_LOG(error) << "Device id set is empty!";
return {};
}

const auto display_data { m_w_api->queryDisplayConfig(QueryType::Active) };
if (!display_data) {
// Error already logged
return {};
}

HdrStateMap states;
for (const auto &device_id : device_ids) {
const auto path { win_utils::getActivePath(*m_w_api, device_id, display_data->m_paths) };
if (!path) {
DD_LOG(error) << "Failed to find device for " << device_id << "!";
return {};
}

states[device_id] = m_w_api->getHdrState(*path);
}

return states;
}

bool
WinDisplayDevice::setHdrStates(const HdrStateMap &states) {
if (states.empty()) {
DD_LOG(error) << "States map is empty!";
return false;
}

HdrStateMapNoOpt states_without_opt;
std::ranges::copy(states |
std::ranges::views::filter([](const auto &entry) { return static_cast<bool>(entry.second); }) |
std::views::transform([](const auto &entry) { return std::make_pair(entry.first, *entry.second); }),
std::inserter(states_without_opt, std::begin(states_without_opt)));

if (states_without_opt.empty()) {
// Return early as there is nothing to do...
return true;
}

const auto display_data { m_w_api->queryDisplayConfig(QueryType::Active) };
if (!display_data) {
// Error already logged
return {};
}

HdrStateMapNoOpt changed_states;
if (!doSetHdrStates(*m_w_api, *display_data, states_without_opt, &changed_states)) {
if (!changed_states.empty()) {
doSetHdrStates(*m_w_api, *display_data, changed_states, nullptr); // return value does not matter
}
return false;
}

return true;
}
} // namespace display_device
8 changes: 8 additions & 0 deletions tests/unit/windows/test_winapilayer.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -204,3 +204,11 @@ TEST_F_S(GetDisplayName) {
TEST_F_S(GetDisplayName, InvalidPath) {
EXPECT_EQ(m_layer.getDisplayName(INVALID_PATH), std::string {});
}

TEST_F_S(GetHdrState, InvalidPath) {
EXPECT_EQ(m_layer.getHdrState(INVALID_PATH), std::nullopt);
}

TEST_F_S(SetHdrState, InvalidPath) {
EXPECT_FALSE(m_layer.setHdrState(INVALID_PATH, display_device::HdrState::Enabled));
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/common/include/displaydevice/types.h
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,14 @@
#pragma once

namespace display_device {
/**
* @brief The device's HDR state in the operating system.
*/
enum class HdrState {
Disabled,
Enabled
};

/**
* @brief Display's resolution.
*/
Expand Down
4 changes: 4 additions & 0 deletions src/windows/include/displaydevice/windows/types.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -91,4 +91,8 @@ namespace display_device {
*/
using DeviceDisplayModeMap = std::map<std::string, DisplayMode>;

/**
* @brief Ordered map of [DEVICE_ID -> std::optional<HdrState>].
*/
using HdrStateMap = std::map<std::string, std::optional<HdrState>>;
} // namespace display_device
8 changes: 8 additions & 0 deletions src/windows/include/displaydevice/windows/winapilayer.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,5 +36,13 @@ namespace display_device {
/** For details @see WinApiLayerInterface::setDisplayConfig */
[[nodiscard]] LONG
setDisplayConfig(std::vector<DISPLAYCONFIG_PATH_INFO> paths, std::vector<DISPLAYCONFIG_MODE_INFO> modes, UINT32 flags) override;

/** For details @see WinApiLayerInterface::getHdrState */
[[nodiscard]] std::optional<HdrState>
getHdrState(const DISPLAYCONFIG_PATH_INFO &path) const override;

/** For details @see WinApiLayerInterface::setHdrState */
[[nodiscard]] bool
setHdrState(const DISPLAYCONFIG_PATH_INFO &path, HdrState state) override;
};
} // namespace display_device
31 changes: 31 additions & 0 deletions src/windows/include/displaydevice/windows/winapilayerinterface.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -166,5 +166,36 @@ namespace display_device {
*/
[[nodiscard]] virtual LONG
setDisplayConfig(std::vector<DISPLAYCONFIG_PATH_INFO> paths, std::vector<DISPLAYCONFIG_MODE_INFO> modes, UINT32 flags) = 0;

/**
* @brief Get the HDR state the path.
* @param path Path to get HDR state for.
* @returns std::nullopt if the state could not be retrieved, or other enum values describing the state otherwise.
*
* EXAMPLES:
* ```cpp
* DISPLAYCONFIG_PATH_INFO path;
* const WinApiLayerInterface* iface = getIface(...);
* const auto hdr_state = iface->getHdrState(path);
* ```
*/
[[nodiscard]] virtual std::optional<HdrState>
getHdrState(const DISPLAYCONFIG_PATH_INFO &path) const = 0;

/**
* @brief Set the HDR state for the path.
* @param path Path to set HDR state for.
* @param state Specify new HDR state.
* @returns True if the device is in the new state, false otherwise.
*
* EXAMPLES:
* ```cpp
* DISPLAYCONFIG_PATH_INFO path;
* const WinApiLayerInterface* iface = getIface(...);
* const bool success = iface->setHdrState(path, HdrState::Enabled);
* ```
*/
[[nodiscard]] virtual bool
setHdrState(const DISPLAYCONFIG_PATH_INFO &path, HdrState state) = 0;
};
} // namespace display_device
8 changes: 8 additions & 0 deletions src/windows/include/displaydevice/windows/windisplaydevice.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,14 @@ namespace display_device {
[[nodiscard]] bool
setAsPrimary(const std::string &device_id) override;

/** For details @see WinDisplayDeviceInterface::getCurrentHdrStates */
[[nodiscard]] HdrStateMap
getCurrentHdrStates(const std::set<std::string> &device_ids) const override;

/** For details @see WinDisplayDeviceInterface::setHdrStates */
[[nodiscard]] bool
setHdrStates(const HdrStateMap &states) override;

private:
std::shared_ptr<WinApiLayerInterface> m_w_api;
};
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,5 +150,40 @@ namespace display_device {
*/
[[nodiscard]] virtual bool
setAsPrimary(const std::string &device_id) = 0;

/**
* @brief Get HDR state for the devices.
* @param device_ids A list of devices to get the HDR states for.
* @returns A map of HDR states per a device or an empty map if an error has occurred.
* @note On Windows the state cannot be retrieved until the device is active even if it supports it.
*
* EXAMPLES:
* ```cpp
* const WinDisplayDeviceInterface* iface = getIface(...);
* const std::unordered_set<std::string> device_ids { "DEVICE_ID_1", "DEVICE_ID_2" };
* const auto current_hdr_states = iface->getCurrentHdrStates(device_ids);
* ```
*/
[[nodiscard]] virtual HdrStateMap
getCurrentHdrStates(const std::set<std::string> &device_ids) const = 0;

/**
* @brief Set HDR states for the devices.
* @param modes A map of HDR states to set.
* @returns True if HDR states were set, false otherwise.
* @note If `unknown` states are provided, they will be silently ignored
* and current state will not be changed.
*
* EXAMPLES:
* ```cpp
* const WinDisplayDeviceInterface* iface = getIface(...);
* const std::string display_a { "MY_ID_1" };
* const std::string display_b { "MY_ID_2" };
* const auto success = iface->setHdrStates({ { display_a, HdrState::Enabled },
* { display_b, HdrState::Disabled } });
* ```
*/
[[nodiscard]] virtual bool
setHdrStates(const HdrStateMap &states) = 0;
};
} // namespace display_device
37 changes: 36 additions & 1 deletion src/windows/winapilayer.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -522,7 +522,7 @@ namespace display_device {

LONG result { DisplayConfigGetDeviceInfo(&source_name.header) };
if (result != ERROR_SUCCESS) {
DD_LOG(error) << getErrorString(result) << " failed to get display name!";
DD_LOG(error) << getErrorString(result) << " failed to get display name!";
return {};
}

Expand All@@ -539,4 +539,39 @@ namespace display_device {
modes.empty() ? nullptr : modes.data(),
flags);
}

std::optional<HdrState>
WinApiLayer::getHdrState(const DISPLAYCONFIG_PATH_INFO &path) const {
DISPLAYCONFIG_GET_ADVANCED_COLOR_INFO color_info = {};
color_info.header.adapterId = path.targetInfo.adapterId;
color_info.header.id = path.targetInfo.id;
color_info.header.type = DISPLAYCONFIG_DEVICE_INFO_GET_ADVANCED_COLOR_INFO;
color_info.header.size = sizeof(color_info);

LONG result { DisplayConfigGetDeviceInfo(&color_info.header) };
if (result != ERROR_SUCCESS) {
DD_LOG(error) << getErrorString(result) << " failed to get advanced color info!";
return std::nullopt;
}

return color_info.advancedColorSupported ? std::make_optional(color_info.advancedColorEnabled ? HdrState::Enabled : HdrState::Disabled) : std::nullopt;
}

bool
WinApiLayer::setHdrState(const DISPLAYCONFIG_PATH_INFO &path, HdrState state) {
DISPLAYCONFIG_SET_ADVANCED_COLOR_STATE color_state = {};
color_state.header.adapterId = path.targetInfo.adapterId;
color_state.header.id = path.targetInfo.id;
color_state.header.type = DISPLAYCONFIG_DEVICE_INFO_SET_ADVANCED_COLOR_STATE;
color_state.header.size = sizeof(color_state);
color_state.enableAdvancedColor = state == HdrState::Enabled ? 1 : 0;

LONG result { DisplayConfigSetDeviceInfo(&color_state.header) };
if (result != ERROR_SUCCESS) {
DD_LOG(error) << getErrorString(result) << " failed to set advanced color info!";
return false;
}

return true;
}
} // namespace display_device
127 changes: 127 additions & 0 deletions src/windows/windisplaydevicehdr.cpp
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,127 @@
// class header include
#include "displaydevice/windows/windisplaydevice.h"

// system includes
#include <ranges>

// local includes
#include "displaydevice/logging.h"
#include "displaydevice/windows/winapiutils.h"

namespace display_device {
namespace {
/** @brief HDR state map without optional values. */
using HdrStateMapNoOpt = std::map<std::string, HdrState>;

/**
* @see setHdrStates for a description as this was split off to reduce cognitive complexity.
*/
bool
doSetHdrStates(WinApiLayerInterface &w_api, const PathAndModeData &display_data, const HdrStateMapNoOpt &states, HdrStateMapNoOpt *changed_states) {
const auto try_set_state {
[&w_api, &display_data](const auto &device_id, const auto &state, auto &current_state) {
const auto path { win_utils::getActivePath(w_api, device_id, display_data.m_paths) };
if (!path) {
DD_LOG(error) << "Failed to find device for " << device_id << "!";
return false;
}

const auto current_state_int { w_api.getHdrState(*path) };
if (!current_state_int) {
DD_LOG(error) << "HDR state cannot be changed for " << device_id << "!";
return false;
}

if (state != *current_state_int) {
if (!w_api.setHdrState(*path, state)) {
// Error already logged
return false;
}

current_state = current_state_int;
}

return true;
}
};

for (const auto &[device_id, state] : states) {
std::optional<HdrState> current_state;
if (try_set_state(device_id, state, current_state)) {
if (current_state && changed_states != nullptr) {
(*changed_states)[device_id] = *current_state;
}
}
// If we are undoing changes we don't want to return early and continue regardless of what error we get.
else if (changed_states != nullptr) {
return false;
}
}

return true;
}

} // namespace

HdrStateMap
WinDisplayDevice::getCurrentHdrStates(const std::set<std::string> &device_ids) const {
if (device_ids.empty()) {
DD_LOG(error) << "Device id set is empty!";
return {};
}

const auto display_data { m_w_api->queryDisplayConfig(QueryType::Active) };
if (!display_data) {
// Error already logged
return {};
}

HdrStateMap states;
for (const auto &device_id : device_ids) {
const auto path { win_utils::getActivePath(*m_w_api, device_id, display_data->m_paths) };
if (!path) {
DD_LOG(error) << "Failed to find device for " << device_id << "!";
return {};
}

states[device_id] = m_w_api->getHdrState(*path);
}

return states;
}

bool
WinDisplayDevice::setHdrStates(const HdrStateMap &states) {
if (states.empty()) {
DD_LOG(error) << "States map is empty!";
return false;
}

HdrStateMapNoOpt states_without_opt;
std::ranges::copy(states |
std::ranges::views::filter([](const auto &entry) { return static_cast<bool>(entry.second); }) |
std::views::transform([](const auto &entry) { return std::make_pair(entry.first, *entry.second); }),
std::inserter(states_without_opt, std::begin(states_without_opt)));

if (states_without_opt.empty()) {
// Return early as there is nothing to do...
return true;
}

const auto display_data { m_w_api->queryDisplayConfig(QueryType::Active) };
if (!display_data) {
// Error already logged
return {};
}

HdrStateMapNoOpt changed_states;
if (!doSetHdrStates(*m_w_api, *display_data, states_without_opt, &changed_states)) {
if (!changed_states.empty()) {
doSetHdrStates(*m_w_api, *display_data, changed_states, nullptr); // return value does not matter
}
return false;
}

return true;
}
} // namespace display_device
8 changes: 8 additions & 0 deletions tests/unit/windows/test_winapilayer.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -204,3 +204,11 @@ TEST_F_S(GetDisplayName) {
TEST_F_S(GetDisplayName, InvalidPath) {
EXPECT_EQ(m_layer.getDisplayName(INVALID_PATH), std::string {});
}

TEST_F_S(GetHdrState, InvalidPath) {
EXPECT_EQ(m_layer.getHdrState(INVALID_PATH), std::nullopt);
}

TEST_F_S(SetHdrState, InvalidPath) {
EXPECT_FALSE(m_layer.setHdrState(INVALID_PATH, display_device::HdrState::Enabled));
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/common/include/displaydevice/types.h
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,14 @@
#pragma once

namespace display_device {
/**
* @brief The device's HDR state in the operating system.
*/
enum class HdrState {
Disabled,
Enabled
};

/**
* @brief Display's resolution.
*/
Expand Down
4 changes: 4 additions & 0 deletions src/windows/include/displaydevice/windows/types.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -91,4 +91,8 @@ namespace display_device {
*/
using DeviceDisplayModeMap = std::map<std::string, DisplayMode>;

/**
* @brief Ordered map of [DEVICE_ID -> std::optional<HdrState>].
*/
using HdrStateMap = std::map<std::string, std::optional<HdrState>>;
} // namespace display_device
8 changes: 8 additions & 0 deletions src/windows/include/displaydevice/windows/winapilayer.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,5 +36,13 @@ namespace display_device {
/** For details @see WinApiLayerInterface::setDisplayConfig */
[[nodiscard]] LONG
setDisplayConfig(std::vector<DISPLAYCONFIG_PATH_INFO> paths, std::vector<DISPLAYCONFIG_MODE_INFO> modes, UINT32 flags) override;

/** For details @see WinApiLayerInterface::getHdrState */
[[nodiscard]] std::optional<HdrState>
getHdrState(const DISPLAYCONFIG_PATH_INFO &path) const override;

/** For details @see WinApiLayerInterface::setHdrState */
[[nodiscard]] bool
setHdrState(const DISPLAYCONFIG_PATH_INFO &path, HdrState state) override;
};
} // namespace display_device
31 changes: 31 additions & 0 deletions src/windows/include/displaydevice/windows/winapilayerinterface.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -166,5 +166,36 @@ namespace display_device {
*/
[[nodiscard]] virtual LONG
setDisplayConfig(std::vector<DISPLAYCONFIG_PATH_INFO> paths, std::vector<DISPLAYCONFIG_MODE_INFO> modes, UINT32 flags) = 0;

/**
* @brief Get the HDR state the path.
* @param path Path to get HDR state for.
* @returns std::nullopt if the state could not be retrieved, or other enum values describing the state otherwise.
*
* EXAMPLES:
* ```cpp
* DISPLAYCONFIG_PATH_INFO path;
* const WinApiLayerInterface* iface = getIface(...);
* const auto hdr_state = iface->getHdrState(path);
* ```
*/
[[nodiscard]] virtual std::optional<HdrState>
getHdrState(const DISPLAYCONFIG_PATH_INFO &path) const = 0;

/**
* @brief Set the HDR state for the path.
* @param path Path to set HDR state for.
* @param state Specify new HDR state.
* @returns True if the device is in the new state, false otherwise.
*
* EXAMPLES:
* ```cpp
* DISPLAYCONFIG_PATH_INFO path;
* const WinApiLayerInterface* iface = getIface(...);
* const bool success = iface->setHdrState(path, HdrState::Enabled);
* ```
*/
[[nodiscard]] virtual bool
setHdrState(const DISPLAYCONFIG_PATH_INFO &path, HdrState state) = 0;
};
} // namespace display_device
8 changes: 8 additions & 0 deletions src/windows/include/displaydevice/windows/windisplaydevice.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,14 @@ namespace display_device {
[[nodiscard]] bool
setAsPrimary(const std::string &device_id) override;

/** For details @see WinDisplayDeviceInterface::getCurrentHdrStates */
[[nodiscard]] HdrStateMap
getCurrentHdrStates(const std::set<std::string> &device_ids) const override;

/** For details @see WinDisplayDeviceInterface::setHdrStates */
[[nodiscard]] bool
setHdrStates(const HdrStateMap &states) override;

private:
std::shared_ptr<WinApiLayerInterface> m_w_api;
};
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,5 +150,40 @@ namespace display_device {
*/
[[nodiscard]] virtual bool
setAsPrimary(const std::string &device_id) = 0;

/**
* @brief Get HDR state for the devices.
* @param device_ids A list of devices to get the HDR states for.
* @returns A map of HDR states per a device or an empty map if an error has occurred.
* @note On Windows the state cannot be retrieved until the device is active even if it supports it.
*
* EXAMPLES:
* ```cpp
* const WinDisplayDeviceInterface* iface = getIface(...);
* const std::unordered_set<std::string> device_ids { "DEVICE_ID_1", "DEVICE_ID_2" };
* const auto current_hdr_states = iface->getCurrentHdrStates(device_ids);
* ```
*/
[[nodiscard]] virtual HdrStateMap
getCurrentHdrStates(const std::set<std::string> &device_ids) const = 0;

/**
* @brief Set HDR states for the devices.
* @param modes A map of HDR states to set.
* @returns True if HDR states were set, false otherwise.
* @note If `unknown` states are provided, they will be silently ignored
* and current state will not be changed.
*
* EXAMPLES:
* ```cpp
* const WinDisplayDeviceInterface* iface = getIface(...);
* const std::string display_a { "MY_ID_1" };
* const std::string display_b { "MY_ID_2" };
* const auto success = iface->setHdrStates({ { display_a, HdrState::Enabled },
* { display_b, HdrState::Disabled } });
* ```
*/
[[nodiscard]] virtual bool
setHdrStates(const HdrStateMap &states) = 0;
};
} // namespace display_device
37 changes: 36 additions & 1 deletion src/windows/winapilayer.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -522,7 +522,7 @@ namespace display_device {

LONG result { DisplayConfigGetDeviceInfo(&source_name.header) };
if (result != ERROR_SUCCESS) {
DD_LOG(error) << getErrorString(result) << " failed to get display name!";
DD_LOG(error) << getErrorString(result) << " failed to get display name!";
return {};
}

Expand All@@ -539,4 +539,39 @@ namespace display_device {
modes.empty() ? nullptr : modes.data(),
flags);
}

std::optional<HdrState>
WinApiLayer::getHdrState(const DISPLAYCONFIG_PATH_INFO &path) const {
DISPLAYCONFIG_GET_ADVANCED_COLOR_INFO color_info = {};
color_info.header.adapterId = path.targetInfo.adapterId;
color_info.header.id = path.targetInfo.id;
color_info.header.type = DISPLAYCONFIG_DEVICE_INFO_GET_ADVANCED_COLOR_INFO;
color_info.header.size = sizeof(color_info);

LONG result { DisplayConfigGetDeviceInfo(&color_info.header) };
if (result != ERROR_SUCCESS) {
DD_LOG(error) << getErrorString(result) << " failed to get advanced color info!";
return std::nullopt;
}

return color_info.advancedColorSupported ? std::make_optional(color_info.advancedColorEnabled ? HdrState::Enabled : HdrState::Disabled) : std::nullopt;
}

bool
WinApiLayer::setHdrState(const DISPLAYCONFIG_PATH_INFO &path, HdrState state) {
DISPLAYCONFIG_SET_ADVANCED_COLOR_STATE color_state = {};
color_state.header.adapterId = path.targetInfo.adapterId;
color_state.header.id = path.targetInfo.id;
color_state.header.type = DISPLAYCONFIG_DEVICE_INFO_SET_ADVANCED_COLOR_STATE;
color_state.header.size = sizeof(color_state);
color_state.enableAdvancedColor = state == HdrState::Enabled ? 1 : 0;

LONG result { DisplayConfigSetDeviceInfo(&color_state.header) };
if (result != ERROR_SUCCESS) {
DD_LOG(error) << getErrorString(result) << " failed to set advanced color info!";
return false;
}

return true;
}
} // namespace display_device
127 changes: 127 additions & 0 deletions src/windows/windisplaydevicehdr.cpp
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,127 @@
// class header include
#include "displaydevice/windows/windisplaydevice.h"

// system includes
#include <ranges>

// local includes
#include "displaydevice/logging.h"
#include "displaydevice/windows/winapiutils.h"

namespace display_device {
namespace {
/** @brief HDR state map without optional values. */
using HdrStateMapNoOpt = std::map<std::string, HdrState>;

/**
* @see setHdrStates for a description as this was split off to reduce cognitive complexity.
*/
bool
doSetHdrStates(WinApiLayerInterface &w_api, const PathAndModeData &display_data, const HdrStateMapNoOpt &states, HdrStateMapNoOpt *changed_states) {
const auto try_set_state {
[&w_api, &display_data](const auto &device_id, const auto &state, auto &current_state) {
const auto path { win_utils::getActivePath(w_api, device_id, display_data.m_paths) };
if (!path) {
DD_LOG(error) << "Failed to find device for " << device_id << "!";
return false;
}

const auto current_state_int { w_api.getHdrState(*path) };
if (!current_state_int) {
DD_LOG(error) << "HDR state cannot be changed for " << device_id << "!";
return false;
}

if (state != *current_state_int) {
if (!w_api.setHdrState(*path, state)) {
// Error already logged
return false;
}

current_state = current_state_int;
}

return true;
}
};

for (const auto &[device_id, state] : states) {
std::optional<HdrState> current_state;
if (try_set_state(device_id, state, current_state)) {
if (current_state && changed_states != nullptr) {
(*changed_states)[device_id] = *current_state;
}
}
// If we are undoing changes we don't want to return early and continue regardless of what error we get.
else if (changed_states != nullptr) {
return false;
}
}

return true;
}

} // namespace

HdrStateMap
WinDisplayDevice::getCurrentHdrStates(const std::set<std::string> &device_ids) const {
if (device_ids.empty()) {
DD_LOG(error) << "Device id set is empty!";
return {};
}

const auto display_data { m_w_api->queryDisplayConfig(QueryType::Active) };
if (!display_data) {
// Error already logged
return {};
}

HdrStateMap states;
for (const auto &device_id : device_ids) {
const auto path { win_utils::getActivePath(*m_w_api, device_id, display_data->m_paths) };
if (!path) {
DD_LOG(error) << "Failed to find device for " << device_id << "!";
return {};
}

states[device_id] = m_w_api->getHdrState(*path);
}

return states;
}

bool
WinDisplayDevice::setHdrStates(const HdrStateMap &states) {
if (states.empty()) {
DD_LOG(error) << "States map is empty!";
return false;
}

HdrStateMapNoOpt states_without_opt;
std::ranges::copy(states |
std::ranges::views::filter([](const auto &entry) { return static_cast<bool>(entry.second); }) |
std::views::transform([](const auto &entry) { return std::make_pair(entry.first, *entry.second); }),
std::inserter(states_without_opt, std::begin(states_without_opt)));

if (states_without_opt.empty()) {
// Return early as there is nothing to do...
return true;
}

const auto display_data { m_w_api->queryDisplayConfig(QueryType::Active) };
if (!display_data) {
// Error already logged
return {};
}

HdrStateMapNoOpt changed_states;
if (!doSetHdrStates(*m_w_api, *display_data, states_without_opt, &changed_states)) {
if (!changed_states.empty()) {
doSetHdrStates(*m_w_api, *display_data, changed_states, nullptr); // return value does not matter
}
return false;
}

return true;
}
} // namespace display_device
8 changes: 8 additions & 0 deletions tests/unit/windows/test_winapilayer.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -204,3 +204,11 @@ TEST_F_S(GetDisplayName) {
TEST_F_S(GetDisplayName, InvalidPath) {
EXPECT_EQ(m_layer.getDisplayName(INVALID_PATH), std::string {});
}

TEST_F_S(GetHdrState, InvalidPath) {
EXPECT_EQ(m_layer.getHdrState(INVALID_PATH), std::nullopt);
}

TEST_F_S(SetHdrState, InvalidPath) {
EXPECT_FALSE(m_layer.setHdrState(INVALID_PATH, display_device::HdrState::Enabled));
}
Loading