Skip to content

feat:(Windows): add HID keyboard support - #104

Merged
ReenigneArcher merged 1 commit into
masterfrom
feat/windows/back-virtual-keyboard-by-HID-device
Aug 26, 2026
Merged

feat:(Windows): add HID keyboard support#104
ReenigneArcher merged 1 commit into
masterfrom
feat/windows/back-virtual-keyboard-by-HID-device

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Add a licensed driver-backed keyboard path on Windows, including protocol/version updates, HID report framing, broker validation, and Win32 fallback behavior when the licensed path is unavailable. Update tests and documentation to cover the new keyboard device type and control-protocol semantics.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Add a licensed driver-backed keyboard path on Windows, including protocol/version updates, HID report framing, broker validation, and Win32 fallback behavior when the licensed path is unavailable. Update tests and documentation to cover the new keyboard device type and control-protocol semantics.
@ReenigneArcher
ReenigneArcherforce-pushed the feat/windows/back-virtual-keyboard-by-HID-device branch from 6e854f9 to 8b8e192CompareAugust 26, 2026 20:05
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecovBot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.53659% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.81%. Comparing base (27526d0) to head (8b8e192).
✅ All tests successful. No failed tests found.

Files with missing linesPatch %Lines
src/platform/windows/windows_backend.cpp77.88%43 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@## master #104 +/- ##
==========================================
+ Coverage 72.75% 72.81% +0.06% 
==========================================
Files 34 34 Lines 8780 8969 +189 Branches 3273 3329 +56 ==========================================
+ Hits 6388 6531 +143 - Misses 1747 1819 +72 + Partials 645 619 -26 
FlagCoverage Δ
FreeBSD52.33% <100.00%> (+0.03%)⬆️
Linux-Clang54.45% <100.00%> (+0.02%)⬆️
Linux-GCC64.98% <100.00%> (-0.02%)⬇️
Windows-MSVC88.04% <82.95%> (-0.28%)⬇️
Windows-MinGW-UCRT6462.27% <65.49%> (+0.03%)⬆️
macOS48.13% <100.00%> (+0.03%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing linesCoverage Δ
src/platform/windows/control_protocol.hpp97.23% <100.00%> (-1.62%)⬇️
...platform/windows/shared/vhf_input_report_queue.hpp96.98% <ø> (ø)
...latform/windows/shared/windows_device_identity.hpp100.00% <ø> (ø)
src/platform/windows/windows_backend.cpp82.45% <77.88%> (-1.22%)⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27526d0...8b8e192. Read the comment docs.

@ReenigneArcher
ReenigneArcher merged commit 6089eed into masterAug 26, 2026
32 checks passed
@ReenigneArcher
ReenigneArcher deleted the feat/windows/back-virtual-keyboard-by-HID-device branch August 26, 2026 20:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keyboard is detected as a virtual device instead of physical

1 participant

@ReenigneArcher