Skip to content

refactor(sonar): remove duplication - #18

Merged
ReenigneArcher merged 1 commit into
masterfrom
refactor/sonar/duplication
Jun 20, 2026
Merged

refactor(sonar): remove duplication#18
ReenigneArcher merged 1 commit into
masterfrom
refactor/sonar/duplication

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Fix sonar duplication.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@read-the-docs-community

read-the-docs-communityBot commented Jun 20, 2026

Copy link
Copy Markdown

@codecov

codecovBot commented Jun 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.68421% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.05%. Comparing base (ccad17c) to head (a325b23).
✅ All tests successful. No failed tests found.

Files with missing linesPatch %Lines
src/core/runtime.cpp97.87%0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@## master #18 +/- ##
==========================================
+ Coverage 87.03% 87.05% +0.01% 
==========================================
Files 10 10 Lines 3194 3152 -42 Branches 1161 1109 -52 ==========================================
- Hits 2780 2744 -36 + Misses 302 278 -24 - Partials 112 130 +18 
FlagCoverage Δ
Linux-Clang69.46% <82.53%> (+0.84%)⬆️
Linux-GCC81.43% <100.00%> (+0.27%)⬆️
Windows-MSVC85.32% <97.29%> (+0.37%)⬆️
Windows-MinGW-UCRT6475.58% <91.42%> (+1.10%)⬆️
macOS67.73% <86.11%> (+0.86%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing linesCoverage Δ
src/platform/linux/uhid_backend.cpp87.57% <100.00%> (-0.38%)⬇️
src/core/runtime.cpp84.52% <97.87%> (+0.77%)⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccad17c...a325b23. Read the comment docs.

@ReenigneArcher
ReenigneArcherforce-pushed the refactor/sonar/duplication branch from 4e94dfb to a325b23CompareJune 20, 2026 18:13
@ReenigneArcher
ReenigneArcher merged commit 798ad90 into masterJun 20, 2026
24 checks passed
@ReenigneArcher
ReenigneArcher deleted the refactor/sonar/duplication branch June 20, 2026 18:18
@sonarqubecloud

Copy link
Copy Markdown

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@ReenigneArcher