Skip to content

feat(driver): add rotating UMDF trace log support - #65

Merged
ReenigneArcher merged 2 commits into
masterfrom
fix/release-prep-01
Aug 12, 2026
Merged

feat(driver): add rotating UMDF trace log support#65
ReenigneArcher merged 2 commits into
masterfrom
fix/release-prep-01

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Introduce a bounded rotating trace log for the Windows UMDF driver, with 5 MiB active log size and 5 retained generations, and wire it into the driver build. Update UMDF tracing to use the new logger and reduce hot-path noise by only logging failed report submissions/feature requests. Add Windows unit tests for rotation behavior and update driver documentation with log location and retention details.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecovBot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.04%. Comparing base (88db84c) to head (cf3a3c1).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@## master #65 +/- ##
==========================================
+ Coverage 73.73% 74.04% +0.31% 
==========================================
Files 30 33 +3 Lines 7701 7793 +92 Branches 2892 2922 +30 ==========================================
+ Hits 5678 5770 +92 + Misses 1757 1496 -261 - Partials 266 527 +261 
FlagCoverage Δ
Linux-Clang56.55% <ø> (ø)
Linux-GCC67.39% <ø> (ø)
Windows-MSVC87.42% <100.00%> (+0.25%)⬆️
Windows-MinGW-UCRT6463.57% <100.00%> (+0.55%)⬆️
macOS50.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing linesCoverage Δ
src/platform/windows/driver/rotating_trace_log.cpp100.00% <100.00%> (ø)
src/platform/windows/driver/rotating_trace_log.hpp100.00% <100.00%> (ø)
...rc/platform/windows/driver/unique_win32_handle.hpp100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88db84c...cf3a3c1. Read the comment docs.

@ReenigneArcher
ReenigneArcherforce-pushed the fix/release-prep-01 branch 2 times, most recently from 20f4000 to ed31b4fCompareAugust 12, 2026 12:39
@ReenigneArcherReenigneArcher changed the title feat(logging): add rotating UMDF trace log supportfeat(driver): add rotating UMDF trace log supportAug 12, 2026
@ReenigneArcher
ReenigneArcherforce-pushed the fix/release-prep-01 branch 4 times, most recently from 854292c to 41662acCompareAugust 12, 2026 13:25
Comment threadsrc/platform/windows/driver/rotating_trace_log.cpp Fixed
Comment threadsrc/platform/windows/driver/rotating_trace_log.cpp Fixed
Introduce a bounded rotating trace log for the Windows UMDF driver, with 5 MiB active log size and 5 retained generations, and wire it into the driver build. Update UMDF tracing to use the new logger and reduce hot-path noise by only logging failed report submissions/feature requests. Add Windows unit tests for rotation behavior and update driver documentation with log location and retention details.
@sonarqubecloud

Copy link
Copy Markdown

@ReenigneArcher
ReenigneArcher merged commit 8e076f3 into masterAug 12, 2026
29 checks passed
@ReenigneArcher
ReenigneArcher deleted the fix/release-prep-01 branch August 12, 2026 16:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ReenigneArcher@github-advanced-security