Skip to content
This repository was archived by the owner on Aug 9, 2024. It is now read-only.

ci(plexhints)!: drop python3 support - #252

Merged
ReenigneArcher merged 1 commit into
masterfrom
ci(plexhints)!-drop-python3-support
May 16, 2024
Merged

ci(plexhints)!: drop python3 support#252
ReenigneArcher merged 1 commit into
masterfrom
ci(plexhints)!-drop-python3-support

Conversation

@ReenigneArcher

@ReenigneArcherReenigneArcher commented May 15, 2024

Copy link
Copy Markdown
Member

Description

Drop Python 3.x support, as plexhints is meant to run in Plex, which is python 2.7. This does not affect the github action, which still uses python 3.11.

This should significantly lighten the load on dependabot PRs.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher
ReenigneArcherforce-pushed the ci(plexhints)!-drop-python3-support branch from 722b393 to 061f866CompareMay 16, 2024 01:11
@codecov

codecovBot commented May 16, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.77%. Comparing base (3815503) to head (4a3a3a7).

Additional details and impacted files
@@ Coverage Diff @@## master #252 +/- ##
==========================================
- Coverage 80.49% 78.77% -1.73% 
==========================================
Files 24 24 Lines 2907 2869 -38 ==========================================
- Hits 2340 2260 -80 - Misses 567 609 +42 
FlagCoverage Δ
Python-2.7-Linux78.77% <ø> (ø)
Python-2.7-Windows?
Python-2.7-macOS78.77% <ø> (ø)
Python-3.10-Linux?
Python-3.10-Windows?
Python-3.10-macOS?
Python-3.11-Linux?
Python-3.11-Windows?
Python-3.11-macOS?
Python-3.8-Linux?
Python-3.8-Windows?
Python-3.8-macOS?
Python-3.9-Linux?
Python-3.9-Windows?
Python-3.9-macOS?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

@ReenigneArcher
ReenigneArcherforce-pushed the ci(plexhints)!-drop-python3-support branch from 061f866 to 4a3a3a7CompareMay 16, 2024 01:20
@ReenigneArcher
ReenigneArcher merged commit 03f3978 into masterMay 16, 2024
@ReenigneArcher
ReenigneArcher deleted the ci(plexhints)!-drop-python3-support branch May 16, 2024 01:28
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop Python 3 support for Plexhints python module

1 participant

@ReenigneArcher
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
ci(plexhints)!: drop python3 support by ReenigneArcher · Pull Request #252 · LizardByte/plexhints · GitHub
Skip to content
This repository was archived by the owner on Aug 9, 2024. It is now read-only.

ci(plexhints)!: drop python3 support - #252

Merged
ReenigneArcher merged 1 commit into
masterfrom
ci(plexhints)!-drop-python3-support
May 16, 2024
Merged

ci(plexhints)!: drop python3 support#252
ReenigneArcher merged 1 commit into
masterfrom
ci(plexhints)!-drop-python3-support

Conversation

@ReenigneArcher

@ReenigneArcherReenigneArcher commented May 15, 2024

Copy link
Copy Markdown
Member

Description

Drop Python 3.x support, as plexhints is meant to run in Plex, which is python 2.7. This does not affect the github action, which still uses python 3.11.

This should significantly lighten the load on dependabot PRs.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher
ReenigneArcherforce-pushed the ci(plexhints)!-drop-python3-support branch from 722b393 to 061f866CompareMay 16, 2024 01:11
@codecov

codecovBot commented May 16, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.77%. Comparing base (3815503) to head (4a3a3a7).

Additional details and impacted files
@@ Coverage Diff @@## master #252 +/- ##
==========================================
- Coverage 80.49% 78.77% -1.73% 
==========================================
Files 24 24 Lines 2907 2869 -38 ==========================================
- Hits 2340 2260 -80 - Misses 567 609 +42 
FlagCoverage Δ
Python-2.7-Linux78.77% <ø> (ø)
Python-2.7-Windows?
Python-2.7-macOS78.77% <ø> (ø)
Python-3.10-Linux?
Python-3.10-Windows?
Python-3.10-macOS?
Python-3.11-Linux?
Python-3.11-Windows?
Python-3.11-macOS?
Python-3.8-Linux?
Python-3.8-Windows?
Python-3.8-macOS?
Python-3.9-Linux?
Python-3.9-Windows?
Python-3.9-macOS?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

@ReenigneArcher
ReenigneArcherforce-pushed the ci(plexhints)!-drop-python3-support branch from 061f866 to 4a3a3a7CompareMay 16, 2024 01:20
@ReenigneArcher
ReenigneArcher merged commit 03f3978 into masterMay 16, 2024
@ReenigneArcher
ReenigneArcher deleted the ci(plexhints)!-drop-python3-support branch May 16, 2024 01:28
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop Python 3 support for Plexhints python module

1 participant

@ReenigneArcher
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' ci(plexhints)!: drop python3 support by ReenigneArcher · Pull Request #252 · LizardByte/plexhints · GitHub
Skip to content
This repository was archived by the owner on Aug 9, 2024. It is now read-only.

ci(plexhints)!: drop python3 support - #252

Merged
ReenigneArcher merged 1 commit into
masterfrom
ci(plexhints)!-drop-python3-support
May 16, 2024
Merged

ci(plexhints)!: drop python3 support#252
ReenigneArcher merged 1 commit into
masterfrom
ci(plexhints)!-drop-python3-support

Conversation

@ReenigneArcher

@ReenigneArcherReenigneArcher commented May 15, 2024

Copy link
Copy Markdown
Member

Description

Drop Python 3.x support, as plexhints is meant to run in Plex, which is python 2.7. This does not affect the github action, which still uses python 3.11.

This should significantly lighten the load on dependabot PRs.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher
ReenigneArcherforce-pushed the ci(plexhints)!-drop-python3-support branch from 722b393 to 061f866CompareMay 16, 2024 01:11
@codecov

codecovBot commented May 16, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.77%. Comparing base (3815503) to head (4a3a3a7).

Additional details and impacted files
@@ Coverage Diff @@## master #252 +/- ##
==========================================
- Coverage 80.49% 78.77% -1.73% 
==========================================
Files 24 24 Lines 2907 2869 -38 ==========================================
- Hits 2340 2260 -80 - Misses 567 609 +42 
FlagCoverage Δ
Python-2.7-Linux78.77% <ø> (ø)
Python-2.7-Windows?
Python-2.7-macOS78.77% <ø> (ø)
Python-3.10-Linux?
Python-3.10-Windows?
Python-3.10-macOS?
Python-3.11-Linux?
Python-3.11-Windows?
Python-3.11-macOS?
Python-3.8-Linux?
Python-3.8-Windows?
Python-3.8-macOS?
Python-3.9-Linux?
Python-3.9-Windows?
Python-3.9-macOS?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

@ReenigneArcher
ReenigneArcherforce-pushed the ci(plexhints)!-drop-python3-support branch from 061f866 to 4a3a3a7CompareMay 16, 2024 01:20
@ReenigneArcher
ReenigneArcher merged commit 03f3978 into masterMay 16, 2024
@ReenigneArcher
ReenigneArcher deleted the ci(plexhints)!-drop-python3-support branch May 16, 2024 01:28
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop Python 3 support for Plexhints python module

1 participant

@ReenigneArcher
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' ci(plexhints)!: drop python3 support by ReenigneArcher · Pull Request #252 · LizardByte/plexhints · GitHub
Skip to content
This repository was archived by the owner on Aug 9, 2024. It is now read-only.

ci(plexhints)!: drop python3 support - #252

Merged
ReenigneArcher merged 1 commit into
masterfrom
ci(plexhints)!-drop-python3-support
May 16, 2024
Merged

ci(plexhints)!: drop python3 support#252
ReenigneArcher merged 1 commit into
masterfrom
ci(plexhints)!-drop-python3-support

Conversation

@ReenigneArcher

@ReenigneArcherReenigneArcher commented May 15, 2024

Copy link
Copy Markdown
Member

Description

Drop Python 3.x support, as plexhints is meant to run in Plex, which is python 2.7. This does not affect the github action, which still uses python 3.11.

This should significantly lighten the load on dependabot PRs.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher
ReenigneArcherforce-pushed the ci(plexhints)!-drop-python3-support branch from 722b393 to 061f866CompareMay 16, 2024 01:11
@codecov

codecovBot commented May 16, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.77%. Comparing base (3815503) to head (4a3a3a7).

Additional details and impacted files
@@ Coverage Diff @@## master #252 +/- ##
==========================================
- Coverage 80.49% 78.77% -1.73% 
==========================================
Files 24 24 Lines 2907 2869 -38 ==========================================
- Hits 2340 2260 -80 - Misses 567 609 +42 
FlagCoverage Δ
Python-2.7-Linux78.77% <ø> (ø)
Python-2.7-Windows?
Python-2.7-macOS78.77% <ø> (ø)
Python-3.10-Linux?
Python-3.10-Windows?
Python-3.10-macOS?
Python-3.11-Linux?
Python-3.11-Windows?
Python-3.11-macOS?
Python-3.8-Linux?
Python-3.8-Windows?
Python-3.8-macOS?
Python-3.9-Linux?
Python-3.9-Windows?
Python-3.9-macOS?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

@ReenigneArcher
ReenigneArcherforce-pushed the ci(plexhints)!-drop-python3-support branch from 061f866 to 4a3a3a7CompareMay 16, 2024 01:20
@ReenigneArcher
ReenigneArcher merged commit 03f3978 into masterMay 16, 2024
@ReenigneArcher
ReenigneArcher deleted the ci(plexhints)!-drop-python3-support branch May 16, 2024 01:28
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop Python 3 support for Plexhints python module

1 participant

@ReenigneArcher
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' ci(plexhints)!: drop python3 support by ReenigneArcher · Pull Request #252 · LizardByte/plexhints · GitHub
Skip to content
This repository was archived by the owner on Aug 9, 2024. It is now read-only.

ci(plexhints)!: drop python3 support - #252

Merged
ReenigneArcher merged 1 commit into
masterfrom
ci(plexhints)!-drop-python3-support
May 16, 2024
Merged

ci(plexhints)!: drop python3 support#252
ReenigneArcher merged 1 commit into
masterfrom
ci(plexhints)!-drop-python3-support

Conversation

@ReenigneArcher

@ReenigneArcherReenigneArcher commented May 15, 2024

Copy link
Copy Markdown
Member

Description

Drop Python 3.x support, as plexhints is meant to run in Plex, which is python 2.7. This does not affect the github action, which still uses python 3.11.

This should significantly lighten the load on dependabot PRs.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher
ReenigneArcherforce-pushed the ci(plexhints)!-drop-python3-support branch from 722b393 to 061f866CompareMay 16, 2024 01:11
@codecov

codecovBot commented May 16, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.77%. Comparing base (3815503) to head (4a3a3a7).

Additional details and impacted files
@@ Coverage Diff @@## master #252 +/- ##
==========================================
- Coverage 80.49% 78.77% -1.73% 
==========================================
Files 24 24 Lines 2907 2869 -38 ==========================================
- Hits 2340 2260 -80 - Misses 567 609 +42 
FlagCoverage Δ
Python-2.7-Linux78.77% <ø> (ø)
Python-2.7-Windows?
Python-2.7-macOS78.77% <ø> (ø)
Python-3.10-Linux?
Python-3.10-Windows?
Python-3.10-macOS?
Python-3.11-Linux?
Python-3.11-Windows?
Python-3.11-macOS?
Python-3.8-Linux?
Python-3.8-Windows?
Python-3.8-macOS?
Python-3.9-Linux?
Python-3.9-Windows?
Python-3.9-macOS?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

@ReenigneArcher
ReenigneArcherforce-pushed the ci(plexhints)!-drop-python3-support branch from 061f866 to 4a3a3a7CompareMay 16, 2024 01:20
@ReenigneArcher
ReenigneArcher merged commit 03f3978 into masterMay 16, 2024
@ReenigneArcher
ReenigneArcher deleted the ci(plexhints)!-drop-python3-support branch May 16, 2024 01:28
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop Python 3 support for Plexhints python module

1 participant

@ReenigneArcher
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' ci(plexhints)!: drop python3 support by ReenigneArcher · Pull Request #252 · LizardByte/plexhints · GitHub
Skip to content
This repository was archived by the owner on Aug 9, 2024. It is now read-only.

ci(plexhints)!: drop python3 support - #252

Merged
ReenigneArcher merged 1 commit into
masterfrom
ci(plexhints)!-drop-python3-support
May 16, 2024
Merged

ci(plexhints)!: drop python3 support#252
ReenigneArcher merged 1 commit into
masterfrom
ci(plexhints)!-drop-python3-support

Conversation

@ReenigneArcher

@ReenigneArcherReenigneArcher commented May 15, 2024

Copy link
Copy Markdown
Member

Description

Drop Python 3.x support, as plexhints is meant to run in Plex, which is python 2.7. This does not affect the github action, which still uses python 3.11.

This should significantly lighten the load on dependabot PRs.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher
ReenigneArcherforce-pushed the ci(plexhints)!-drop-python3-support branch from 722b393 to 061f866CompareMay 16, 2024 01:11
@codecov

codecovBot commented May 16, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.77%. Comparing base (3815503) to head (4a3a3a7).

Additional details and impacted files
@@ Coverage Diff @@## master #252 +/- ##
==========================================
- Coverage 80.49% 78.77% -1.73% 
==========================================
Files 24 24 Lines 2907 2869 -38 ==========================================
- Hits 2340 2260 -80 - Misses 567 609 +42 
FlagCoverage Δ
Python-2.7-Linux78.77% <ø> (ø)
Python-2.7-Windows?
Python-2.7-macOS78.77% <ø> (ø)
Python-3.10-Linux?
Python-3.10-Windows?
Python-3.10-macOS?
Python-3.11-Linux?
Python-3.11-Windows?
Python-3.11-macOS?
Python-3.8-Linux?
Python-3.8-Windows?
Python-3.8-macOS?
Python-3.9-Linux?
Python-3.9-Windows?
Python-3.9-macOS?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

@ReenigneArcher
ReenigneArcherforce-pushed the ci(plexhints)!-drop-python3-support branch from 061f866 to 4a3a3a7CompareMay 16, 2024 01:20
@ReenigneArcher
ReenigneArcher merged commit 03f3978 into masterMay 16, 2024
@ReenigneArcher
ReenigneArcher deleted the ci(plexhints)!-drop-python3-support branch May 16, 2024 01:28
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop Python 3 support for Plexhints python module

1 participant

@ReenigneArcher
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' ci(plexhints)!: drop python3 support by ReenigneArcher · Pull Request #252 · LizardByte/plexhints · GitHub
Skip to content
This repository was archived by the owner on Aug 9, 2024. It is now read-only.

ci(plexhints)!: drop python3 support - #252

Merged
ReenigneArcher merged 1 commit into
masterfrom
ci(plexhints)!-drop-python3-support
May 16, 2024
Merged

ci(plexhints)!: drop python3 support#252
ReenigneArcher merged 1 commit into
masterfrom
ci(plexhints)!-drop-python3-support

Conversation

@ReenigneArcher

@ReenigneArcherReenigneArcher commented May 15, 2024

Copy link
Copy Markdown
Member

Description

Drop Python 3.x support, as plexhints is meant to run in Plex, which is python 2.7. This does not affect the github action, which still uses python 3.11.

This should significantly lighten the load on dependabot PRs.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher
ReenigneArcherforce-pushed the ci(plexhints)!-drop-python3-support branch from 722b393 to 061f866CompareMay 16, 2024 01:11
@codecov

codecovBot commented May 16, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.77%. Comparing base (3815503) to head (4a3a3a7).

Additional details and impacted files
@@ Coverage Diff @@## master #252 +/- ##
==========================================
- Coverage 80.49% 78.77% -1.73% 
==========================================
Files 24 24 Lines 2907 2869 -38 ==========================================
- Hits 2340 2260 -80 - Misses 567 609 +42 
FlagCoverage Δ
Python-2.7-Linux78.77% <ø> (ø)
Python-2.7-Windows?
Python-2.7-macOS78.77% <ø> (ø)
Python-3.10-Linux?
Python-3.10-Windows?
Python-3.10-macOS?
Python-3.11-Linux?
Python-3.11-Windows?
Python-3.11-macOS?
Python-3.8-Linux?
Python-3.8-Windows?
Python-3.8-macOS?
Python-3.9-Linux?
Python-3.9-Windows?
Python-3.9-macOS?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

@ReenigneArcher
ReenigneArcherforce-pushed the ci(plexhints)!-drop-python3-support branch from 061f866 to 4a3a3a7CompareMay 16, 2024 01:20
@ReenigneArcher
ReenigneArcher merged commit 03f3978 into masterMay 16, 2024
@ReenigneArcher
ReenigneArcher deleted the ci(plexhints)!-drop-python3-support branch May 16, 2024 01:28
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop Python 3 support for Plexhints python module

1 participant

@ReenigneArcher
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); ci(plexhints)!: drop python3 support by ReenigneArcher · Pull Request #252 · LizardByte/plexhints · GitHub
Skip to content
This repository was archived by the owner on Aug 9, 2024. It is now read-only.

ci(plexhints)!: drop python3 support - #252

Merged
ReenigneArcher merged 1 commit into
masterfrom
ci(plexhints)!-drop-python3-support
May 16, 2024
Merged

ci(plexhints)!: drop python3 support#252
ReenigneArcher merged 1 commit into
masterfrom
ci(plexhints)!-drop-python3-support

Conversation

@ReenigneArcher

@ReenigneArcherReenigneArcher commented May 15, 2024

Copy link
Copy Markdown
Member

Description

Drop Python 3.x support, as plexhints is meant to run in Plex, which is python 2.7. This does not affect the github action, which still uses python 3.11.

This should significantly lighten the load on dependabot PRs.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher
ReenigneArcherforce-pushed the ci(plexhints)!-drop-python3-support branch from 722b393 to 061f866CompareMay 16, 2024 01:11
@codecov

codecovBot commented May 16, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.77%. Comparing base (3815503) to head (4a3a3a7).

Additional details and impacted files
@@ Coverage Diff @@## master #252 +/- ##
==========================================
- Coverage 80.49% 78.77% -1.73% 
==========================================
Files 24 24 Lines 2907 2869 -38 ==========================================
- Hits 2340 2260 -80 - Misses 567 609 +42 
FlagCoverage Δ
Python-2.7-Linux78.77% <ø> (ø)
Python-2.7-Windows?
Python-2.7-macOS78.77% <ø> (ø)
Python-3.10-Linux?
Python-3.10-Windows?
Python-3.10-macOS?
Python-3.11-Linux?
Python-3.11-Windows?
Python-3.11-macOS?
Python-3.8-Linux?
Python-3.8-Windows?
Python-3.8-macOS?
Python-3.9-Linux?
Python-3.9-Windows?
Python-3.9-macOS?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

@ReenigneArcher
ReenigneArcherforce-pushed the ci(plexhints)!-drop-python3-support branch from 061f866 to 4a3a3a7CompareMay 16, 2024 01:20
@ReenigneArcher
ReenigneArcher merged commit 03f3978 into masterMay 16, 2024
@ReenigneArcher
ReenigneArcher deleted the ci(plexhints)!-drop-python3-support branch May 16, 2024 01:28
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop Python 3 support for Plexhints python module

1 participant

@ReenigneArcher