feat: Cleanup Qt-based tray implementation - #121

Merged
ReenigneArcher merged 28 commits into
LizardByte:masterfrom
Kishi85:simplify-qt-tray
May 23, 2026
Merged

feat: Cleanup Qt-based tray implementation#121
ReenigneArcher merged 28 commits into
LizardByte:masterfrom
Kishi85:simplify-qt-tray

Conversation

@Kishi85

@Kishi85Kishi85 commented May 8, 2026•
edited
Loading

Copy link
Copy Markdown

Description

This reworks the Qt-based tray with an adapted version of QtTrayMenu.h/cpp from upstream as suggested in LizardByte/Sunshine#4907.

This version restores libnotify for notifications due to potential problems caused by DBus interface limitations when running with elevated privileges (e.g. as used by Sunshine). The new libnotify integration also tries to separate the used codepaths as best as possible to keep the implementation clean and easily understandable (with a fallback to basic notifications using QtTrayMenu::showMessage).

There is still an issue with left clicking the tray icon on Wayland (also present in the current AI based implementation) which caused by https://qt-project.atlassian.net/browse/QTBUG-139921 that can unfortunately not be worked around.

This version is platform-neutral for QtTrayMenu.h/cpp code with Linux platform-specific parts (and libnotify integration) restricted to tray_linux.cpp. Qt-provided features are used as much as possible to keep this platform-independent.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@Kishi85Kishi85 changed the title Simplify QT-based tray implementaionfix: Simplify QT-based tray implementaionMay 8, 2026
@Kishi85Kishi85 changed the title fix: Simplify QT-based tray implementaionfeat: Simplify QT-based tray implementaionMay 8, 2026
@codecov

codecovBot commented May 9, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 61.26984% with 122 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.38%. Comparing base (dc4be3a) to head (5f5e43d).
⚠️ Report is 39 commits behind head on master.

Files with missing linesPatch %Lines
src/QtTrayMenu.cpp54.00%59 Missing and 33 partials ⚠️
src/tray_linux.cpp73.91%11 Missing and 19 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@## master #121 +/- ##
==========================================
+ Coverage 63.75% 64.38% +0.63% 
==========================================
Files 4 5 +1 Lines 858 643 -215 Branches 313 209 -104 ==========================================
- Hits 547 414 -133 + Misses 205 153 -52 + Partials 106 76 -30
FlagCoverage Δ
Linux-qt555.16% <61.26%> (-1.96%)⬇️
Linux-qt655.16% <61.26%> (-1.96%)⬇️
Windows70.67% <ø> (ø)
macOS56.63% <ø> (-2.66%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing linesCoverage Δ
src/tray_linux.cpp65.51% <73.91%> (+6.05%)⬆️
src/QtTrayMenu.cpp54.00% <54.00%> (ø)

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc4be3a...5f5e43d. Read the comment docs.

@Kishi85
Kishi85force-pushed the simplify-qt-tray branch 11 times, most recently from 275be0f to c552bdaCompareMay 11, 2026 11:31
@Kishi85

Kishi85 commented May 11, 2026

Copy link
Copy Markdown
Author

I've fixed most of the issues I've found so far (added all the necessary pointer valid checks/etc. and moved the exit() order around so everything gets cleaned up in reverse order (clearing references as necessary on the go). But no matter what I do the CI pipeline segfaults at this one specific test:

[ RUN ] TrayTest.TestCheckboxStates
/home/runner/work/_temp/d5b937f4-9556-4df2-8f27-571e2cb10ca8.sh: line 1: 8581 Segmentation fault (core dumped) ./test_tray --gtest_color=yes --gtest_output=xml:test_results.xml
Error: Process completed with exit code 139.

I can run all the tests fine locally after I've added support for spectacle screenshots due to using KDE, tests running both with clang and gcc compiled project. It just wont complete when run on the CI-container with ubuntu-latest. I'm a bit out of ideas here and it looks like I have to test this on a native Ubuntu-latest install at some point to continue this further.

@ReenigneArcher

ReenigneArcher commented May 12, 2026

Copy link
Copy Markdown
Member

@Kishi85 have a look at #123

ReenigneArcher
ReenigneArcher reviewed May 12, 2026
View reviewed changes
Comment threadsrc/QtTrayMenu.cpp Outdated
Comment threadsrc/tray_linux.cpp
@Kishi85

Kishi85 commented May 12, 2026

Copy link
Copy Markdown
Author

@Kishi85 have a look at #123

I'll pick that test change if you dont mind as it IMHO makes more sense logically

@Kishi85

Kishi85 commented May 12, 2026•
edited
Loading

Copy link
Copy Markdown
Author

Also the change you did for showing the menu on wayland in #123 does not work. Same issue as with show() due to that bug in Qt:
qt.qpa.wayland: Failed to create grabbing popup. Ensure popup QWidgetWindow(0x55c3cc28b8c0, name="QMenuClassWindow") has a transientParent set and that parent window has received input.

Looks like the only way to get left-click to work on Linux/Wayland is for Qt to fix the bug, every other workaround either fails silently or yields above message unfortunately.

@Kishi85

Kishi85 commented May 12, 2026•
edited
Loading

Copy link
Copy Markdown
Author

One main deficit of the QSystemTray::showMessage notification is that it does not hide immediately when you click it even if it triggers the callback. Neither can you programmatically close the message via the trayIcon object hence the screenshots showing multiple balloons due to tests firing in rapid succession.

After looking around for a bit the best thing (in terms of interoperability and functionality) seems to be using libnotify just for the notifications (as the XDG desktop notification path is not really viable due to the process privilege constraints).

Good thing here is that now that most of the Qt Tray Menu stuff is now isolated, it should be easy to do something similar for notifications and have a clean implementation.

@Kishi85Kishi85 changed the title feat: Simplify QT-based tray implementaionfeat: Simplify QT-based tray implementationMay 12, 2026
@Kishi85
Kishi85force-pushed the simplify-qt-tray branch 5 times, most recently from b747b99 to 26d15e6CompareMay 15, 2026 09:40
@ReenigneArcher

This comment was marked as resolved.

Sign in to view
Kishi85and others added 21 commits May 23, 2026 08:52
@Kishi85@ReenigneArcher
WIP - process events during exit
5598361
@ReenigneArcher
Update test_tray.cpp
844df0c
@ReenigneArcher
Provide default argv, hide menu, use popup
800c0e4
Add a persistent default argv (anonymous namespace) and include QCursor, then construct QApplication with the default argv when original argc/argv are missing to avoid using a short-lived stack array. Hide trayTopMenu before clearing tray references to prevent lingering UI. Replace menu->show() with menu->popup(QCursor::pos()) to work around QTBUG-139921 on Linux/Wayland. NOSONAR comments for QApplication allocation are preserved.
@Kishi85@ReenigneArcher
QApplication::quit() only for apps that we created.
7736f4c
@Kishi85@ReenigneArcher
Cleanup QtTrayMenu constructor
3806cf4
@Kishi85@ReenigneArcher
Add option to fire notification using QSystemTray::showMessage on ini…
71aeba1
…t/update
@Kishi85@ReenigneArcher
(Re-)Implement tray notifications using libnotify with fallback to ba…
e0df938
…sic QtTrayIcon::showMessage()
@Kishi85@ReenigneArcher
Refactor tray_linux.cpp notifications and add separate namespace for …
2d4d90a
…tray_linux
@Kishi85@ReenigneArcher
fix: Properly cleanup notificationCurrent and notificationCurrentCall…
d6bb4b3
…back where necessary
@Kishi85@ReenigneArcher
refactor - Use acknowledge_notification to also clear previous notifi…
dfaac3f
…cation in notify()
@Kishi85@ReenigneArcher
fix: Allow using themed icons for tray icon
0426265
@Kishi85@ReenigneArcher
fix: Always use absolute paths for filesystem-based notification icons
d98dc67
@Kishi85@ReenigneArcher
fix: Add missing/fix docstrings and unify variable style for namespac…
1834002
…e tray_linux
@Kishi85@ReenigneArcher
fix: Remove Qt::DBus dependency
35b5fab
@Kishi85@ReenigneArcher
fix: Fix potential issues with QtTrayMenu
925a2cb
@Kishi85@ReenigneArcher
fix: Re-init notify upon setting app_name
96cf063
@Kishi85@ReenigneArcher
fix: Process UI modifications using Qt event system
e24c656
Unless the operation is done during init, loop or already emitting a signal to do the modification.
@Kishi85@ReenigneArcher
fix: Improve error handling on tray_init
ed616c5
@Kishi85@ReenigneArcher
fix: Only fail tray init on libnotify failure if Qt does not support …
71f8760
…messages on system tray
@Kishi85@ReenigneArcher
fix: Requested changes from review
4d6b137
@Kishi85@ReenigneArcher
feat: run libnotify actions that use DBus asynchronously with timeout…
5f5e43d
… to avoid deadlocking
@sonarqubecloud

sonarqubecloudBot commented May 23, 2026

Copy link
Copy Markdown

Quality Gate PassedQuality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ReenigneArcher

ReenigneArcher commented May 23, 2026

Copy link
Copy Markdown
Member

Unless you want me to wait, I think I'm good with merging this as is. I don't think anyone is going to test it out on Sunshine until it's merged into the pre-releases.

@Kishi85

Kishi85 commented May 23, 2026

Copy link
Copy Markdown
Author

Unless you want me to wait, I think I'm good with merging this as is. I don't think anyone is going to test it out on Sunshine until it's merged into the pre-releases.

Go for it. If there's anything to add I'll do a follow up PR.

@ReenigneArcher
ReenigneArcher merged commit 35a6c4e into LizardByte:masterMay 23, 2026
18 of 19 checks passed
@Kishi85

Kishi85 commented May 23, 2026

Copy link
Copy Markdown
Author

@ReenigneArcher
5f5e43d seems to cause issues now (just realized this while trying a game on my TV).
I'll put up a PR to revert that specific commit in a second as without that change everything is running smoothly here.

@Kishi85Kishi85 mentioned this pull request May 23, 2026
Merged
21 tasks
@ReenigneArcher

ReenigneArcher commented May 23, 2026

Copy link
Copy Markdown
Member

@Kishi85 so with these changes, do you think it could pave the way to use QT on Windows and macOS as well?

@Kishi85

Kishi85 commented May 23, 2026

Copy link
Copy Markdown
Author

@Kishi85 so with these changes, do you think it could pave the way to use QT on Windows and macOS as well?

The QtTrayMenu class should work on any QT supported platform. The only thing that likely needs attention per platform is notifications due to already noted restrictions of QSystemTrayIcon::showMessage.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ReenigneArcherReenigneArcherReenigneArcher left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kishi85@ReenigneArcher
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat: Cleanup Qt-based tray implementation - #121
Merged
ReenigneArcher merged 28 commits into
LizardByte:masterfrom 
Kishi85:simplify-qt-tray
May 23, 2026
Merged
feat: Cleanup Qt-based tray implementation#121
ReenigneArcher merged 28 commits into
LizardByte:masterfrom 
Kishi85:simplify-qt-tray
Conversation
@Kishi85
@Kishi85Kishi85
commented
May 8, 2026•

edited

Loading

Copy link


Copy Markdown

Description
This reworks the Qt-based tray with an adapted version of QtTrayMenu.h/cpp from upstream as suggested in LizardByte/Sunshine#4907.
This version restores libnotify for notifications due to potential problems caused by DBus interface limitations when running with elevated privileges (e.g. as used by Sunshine). The new libnotify integration also tries to separate the used codepaths as best as possible to keep the implementation clean and easily understandable (with a fallback to basic notifications using QtTrayMenu::showMessage).
There is still an issue with left clicking the tray icon on Wayland (also present in the current AI based implementation) which caused by https://qt-project.atlassian.net/browse/QTBUG-139921 that can unfortunately not be worked around.
This version is platform-neutral for QtTrayMenu.h/cpp code with Linux platform-specific parts (and libnotify integration) restricted to tray_linux.cpp. Qt-provided features are used as much as possible to keep this platform-independent.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)
Checklist
  •  Code follows the style guidelines of this project
  •  Code has been self-reviewed
  •  Code has been commented, particularly in hard-to-understand areas
  •  Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  •  Unit tests have been added or updated for any new or modified functionality
AI Usage
  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes
@Kishi85Kishi85
changed the title
Simplify QT-based tray implementaionfix: Simplify QT-based tray implementaionMay 8, 2026
@Kishi85Kishi85
changed the title
fix: Simplify QT-based tray implementaionfeat: Simplify QT-based tray implementaionMay 8, 2026
@codecov
codecovBot
commented
May 9, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 61.26984% with 122 lines in your changes missing coverage. Please review.

✅ Project coverage is 64.38%. Comparing base (dc4be3a) to head (5f5e43d).
⚠️ Report is 39 commits behind head on master.
Files with missing linesPatch %Lines
src/QtTrayMenu.cpp54.00%59 Missing and 33 partials ⚠️
src/tray_linux.cpp73.91%11 Missing and 19 partials ⚠️
Additional details and impacted files
Impacted file tree graph
@@ Coverage Diff @@## master #121 +/- ##
==========================================
+ Coverage 63.75% 64.38% +0.63% 
==========================================
Files 4 5 +1 Lines 858 643 -215 Branches 313 209 -104 ==========================================
- Hits 547 414 -133 + Misses 205 153 -52 + Partials 106 76 -30 
FlagCoverage Δ
Linux-qt555.16% <61.26%> (-1.96%)⬇️
Linux-qt655.16% <61.26%> (-1.96%)⬇️
Windows70.67% <ø> (ø)
macOS56.63% <ø> (-2.66%)⬇️
Flags with carried forward coverage won't be shown. Click here to find out more.
Files with missing linesCoverage Δ
src/tray_linux.cpp65.51% <73.91%> (+6.05%)⬆️
src/QtTrayMenu.cpp54.00% <54.00%> (ø)
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Harness.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update dc4be3a...5f5e43d. Read the comment docs.
@Kishi85
Kishi85force-pushed
the
simplify-qt-tray
branch
11 times, most recently
from
275be0f to
c552bdaCompareMay 11, 2026 11:31
@Kishi85
Kishi85
commented
May 11, 2026

Copy link


Copy Markdown

Author
I've fixed most of the issues I've found so far (added all the necessary pointer valid checks/etc. and moved the exit() order around so everything gets cleaned up in reverse order (clearing references as necessary on the go). But no matter what I do the CI pipeline segfaults at this one specific test:
[ RUN ] TrayTest.TestCheckboxStates
/home/runner/work/_temp/d5b937f4-9556-4df2-8f27-571e2cb10ca8.sh: line 1: 8581 Segmentation fault (core dumped) ./test_tray --gtest_color=yes --gtest_output=xml:test_results.xml
Error: Process completed with exit code 139.

I can run all the tests fine locally after I've added support for spectacle screenshots due to using KDE, tests running both with clang and gcc compiled project. It just wont complete when run on the CI-container with ubuntu-latest. I'm a bit out of ideas here and it looks like I have to test this on a native Ubuntu-latest install at some point to continue this further.
@ReenigneArcher
ReenigneArcher
commented
May 12, 2026

Copy link


Copy Markdown

Member
@Kishi85 have a look at #123
ReenigneArcher
ReenigneArcher
reviewed
May 12, 2026
View reviewed changes
Comment threadsrc/QtTrayMenu.cpp
Outdated

Comment threadsrc/tray_linux.cpp
@Kishi85
Kishi85
commented
May 12, 2026

Copy link


Copy Markdown

Author
@Kishi85 have a look at #123
I'll pick that test change if you dont mind as it IMHO makes more sense logically
@Kishi85
Kishi85
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Author
Also the change you did for showing the menu on wayland in #123 does not work. Same issue as with show() due to that bug in Qt:
qt.qpa.wayland: Failed to create grabbing popup. Ensure popup QWidgetWindow(0x55c3cc28b8c0, name="QMenuClassWindow") has a transientParent set and that parent window has received input.
Looks like the only way to get left-click to work on Linux/Wayland is for Qt to fix the bug, every other workaround either fails silently or yields above message unfortunately.
@Kishi85
Kishi85
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Author
One main deficit of the QSystemTray::showMessage notification is that it does not hide immediately when you click it even if it triggers the callback. Neither can you programmatically close the message via the trayIcon object hence the screenshots showing multiple balloons due to tests firing in rapid succession.
After looking around for a bit the best thing (in terms of interoperability and functionality) seems to be using libnotify just for the notifications (as the XDG desktop notification path is not really viable due to the process privilege constraints).
Good thing here is that now that most of the Qt Tray Menu stuff is now isolated, it should be easy to do something similar for notifications and have a clean implementation.
@Kishi85Kishi85
changed the title
feat: Simplify QT-based tray implementaionfeat: Simplify QT-based tray implementationMay 12, 2026
@Kishi85
Kishi85force-pushed
the
simplify-qt-tray
branch
5 times, most recently
from
b747b99 to
26d15e6CompareMay 15, 2026 09:40
@ReenigneArcher

This comment was marked as resolved.

Sign in to view
Kishi85and others
added 21 commits
May 23, 2026 08:52
@Kishi85@ReenigneArcher
WIP - process events during exit
5598361
@ReenigneArcher
Update test_tray.cpp
844df0c
@ReenigneArcher
Provide default argv, hide menu, use popup
800c0e4
Add a persistent default argv (anonymous namespace) and include QCursor, then construct QApplication with the default argv when original argc/argv are missing to avoid using a short-lived stack array. Hide trayTopMenu before clearing tray references to prevent lingering UI. Replace menu->show() with menu->popup(QCursor::pos()) to work around QTBUG-139921 on Linux/Wayland. NOSONAR comments for QApplication allocation are preserved.
@Kishi85@ReenigneArcher
QApplication::quit() only for apps that we created.
7736f4c
@Kishi85@ReenigneArcher
Cleanup QtTrayMenu constructor
3806cf4
@Kishi85@ReenigneArcher
Add option to fire notification using QSystemTray::showMessage on ini…
71aeba1
…t/update
@Kishi85@ReenigneArcher
(Re-)Implement tray notifications using libnotify with fallback to ba…
e0df938
…sic QtTrayIcon::showMessage()
@Kishi85@ReenigneArcher
Refactor tray_linux.cpp notifications and add separate namespace for …
2d4d90a
…tray_linux
@Kishi85@ReenigneArcher
fix: Properly cleanup notificationCurrent and notificationCurrentCall…
d6bb4b3
…back where necessary
@Kishi85@ReenigneArcher
refactor - Use acknowledge_notification to also clear previous notifi…
dfaac3f
…cation in notify()
@Kishi85@ReenigneArcher
fix: Allow using themed icons for tray icon
0426265
@Kishi85@ReenigneArcher
fix: Always use absolute paths for filesystem-based notification icons
d98dc67
@Kishi85@ReenigneArcher
fix: Add missing/fix docstrings and unify variable style for namespac…
1834002
…e tray_linux
@Kishi85@ReenigneArcher
fix: Remove Qt::DBus dependency
35b5fab
@Kishi85@ReenigneArcher
fix: Fix potential issues with QtTrayMenu
925a2cb
@Kishi85@ReenigneArcher
fix: Re-init notify upon setting app_name
96cf063
@Kishi85@ReenigneArcher
fix: Process UI modifications using Qt event system
e24c656
Unless the operation is done during init, loop or already emitting a signal to do the modification.
@Kishi85@ReenigneArcher
fix: Improve error handling on tray_init
ed616c5
@Kishi85@ReenigneArcher
fix: Only fail tray init on libnotify failure if Qt does not support …
71f8760
…messages on system tray
@Kishi85@ReenigneArcher
fix: Requested changes from review
4d6b137
@Kishi85@ReenigneArcher
feat: run libnotify actions that use DBus asynchronously with timeout…
5f5e43d
… to avoid deadlocking
@sonarqubecloud
sonarqubecloudBot
commented
May 23, 2026

Copy link


Copy Markdown

Quality Gate PassedQuality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
@ReenigneArcher
ReenigneArcher
commented
May 23, 2026

Copy link


Copy Markdown

Member
Unless you want me to wait, I think I'm good with merging this as is. I don't think anyone is going to test it out on Sunshine until it's merged into the pre-releases.
@Kishi85
Kishi85
commented
May 23, 2026

Copy link


Copy Markdown

Author
Unless you want me to wait, I think I'm good with merging this as is. I don't think anyone is going to test it out on Sunshine until it's merged into the pre-releases.
Go for it. If there's anything to add I'll do a follow up PR.
@ReenigneArcher
ReenigneArcher
merged commit 35a6c4e
into
LizardByte:masterMay 23, 2026

18 of 19 checks passed

@Kishi85
Kishi85
commented
May 23, 2026

Copy link


Copy Markdown

Author
@ReenigneArcher
5f5e43d seems to cause issues now (just realized this while trying a game on my TV).

I'll put up a PR to revert that specific commit in a second as without that change everything is running smoothly here.
@Kishi85Kishi85
mentioned this pull request
May 23, 2026
 Merged

21 tasks
@ReenigneArcher
ReenigneArcher
commented
May 23, 2026

Copy link


Copy Markdown

Member
@Kishi85 so with these changes, do you think it could pave the way to use QT on Windows and macOS as well?
@Kishi85
Kishi85
commented
May 23, 2026

Copy link


Copy Markdown

Author
@Kishi85 so with these changes, do you think it could pave the way to use QT on Windows and macOS as well?
The QtTrayMenu class should work on any QT supported platform. The only thing that likely needs attention per platform is notifications due to already noted restrictions of QSystemTrayIcon::showMessage.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ReenigneArcherReenigneArcherReenigneArcher left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Kishi85@ReenigneArcher

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: Cleanup Qt-based tray implementation - #121
Merged
ReenigneArcher merged 28 commits into
LizardByte:masterfrom 
Kishi85:simplify-qt-tray
May 23, 2026
Merged
feat: Cleanup Qt-based tray implementation#121
ReenigneArcher merged 28 commits into
LizardByte:masterfrom 
Kishi85:simplify-qt-tray
Conversation
@Kishi85
@Kishi85Kishi85
commented
May 8, 2026•

edited

Loading

Copy link


Copy Markdown

Description
This reworks the Qt-based tray with an adapted version of QtTrayMenu.h/cpp from upstream as suggested in LizardByte/Sunshine#4907.
This version restores libnotify for notifications due to potential problems caused by DBus interface limitations when running with elevated privileges (e.g. as used by Sunshine). The new libnotify integration also tries to separate the used codepaths as best as possible to keep the implementation clean and easily understandable (with a fallback to basic notifications using QtTrayMenu::showMessage).
There is still an issue with left clicking the tray icon on Wayland (also present in the current AI based implementation) which caused by https://qt-project.atlassian.net/browse/QTBUG-139921 that can unfortunately not be worked around.
This version is platform-neutral for QtTrayMenu.h/cpp code with Linux platform-specific parts (and libnotify integration) restricted to tray_linux.cpp. Qt-provided features are used as much as possible to keep this platform-independent.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)
Checklist
  •  Code follows the style guidelines of this project
  •  Code has been self-reviewed
  •  Code has been commented, particularly in hard-to-understand areas
  •  Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  •  Unit tests have been added or updated for any new or modified functionality
AI Usage
  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes
@Kishi85Kishi85
changed the title
Simplify QT-based tray implementaionfix: Simplify QT-based tray implementaionMay 8, 2026
@Kishi85Kishi85
changed the title
fix: Simplify QT-based tray implementaionfeat: Simplify QT-based tray implementaionMay 8, 2026
@codecov
codecovBot
commented
May 9, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 61.26984% with 122 lines in your changes missing coverage. Please review.

✅ Project coverage is 64.38%. Comparing base (dc4be3a) to head (5f5e43d).
⚠️ Report is 39 commits behind head on master.
Files with missing linesPatch %Lines
src/QtTrayMenu.cpp54.00%59 Missing and 33 partials ⚠️
src/tray_linux.cpp73.91%11 Missing and 19 partials ⚠️
Additional details and impacted files
Impacted file tree graph
@@ Coverage Diff @@## master #121 +/- ##
==========================================
+ Coverage 63.75% 64.38% +0.63% 
==========================================
Files 4 5 +1 Lines 858 643 -215 Branches 313 209 -104 ==========================================
- Hits 547 414 -133 + Misses 205 153 -52 + Partials 106 76 -30 
FlagCoverage Δ
Linux-qt555.16% <61.26%> (-1.96%)⬇️
Linux-qt655.16% <61.26%> (-1.96%)⬇️
Windows70.67% <ø> (ø)
macOS56.63% <ø> (-2.66%)⬇️
Flags with carried forward coverage won't be shown. Click here to find out more.
Files with missing linesCoverage Δ
src/tray_linux.cpp65.51% <73.91%> (+6.05%)⬆️
src/QtTrayMenu.cpp54.00% <54.00%> (ø)
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Harness.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update dc4be3a...5f5e43d. Read the comment docs.
@Kishi85
Kishi85force-pushed
the
simplify-qt-tray
branch
11 times, most recently
from
275be0f to
c552bdaCompareMay 11, 2026 11:31
@Kishi85
Kishi85
commented
May 11, 2026

Copy link


Copy Markdown

Author
I've fixed most of the issues I've found so far (added all the necessary pointer valid checks/etc. and moved the exit() order around so everything gets cleaned up in reverse order (clearing references as necessary on the go). But no matter what I do the CI pipeline segfaults at this one specific test:
[ RUN ] TrayTest.TestCheckboxStates
/home/runner/work/_temp/d5b937f4-9556-4df2-8f27-571e2cb10ca8.sh: line 1: 8581 Segmentation fault (core dumped) ./test_tray --gtest_color=yes --gtest_output=xml:test_results.xml
Error: Process completed with exit code 139.

I can run all the tests fine locally after I've added support for spectacle screenshots due to using KDE, tests running both with clang and gcc compiled project. It just wont complete when run on the CI-container with ubuntu-latest. I'm a bit out of ideas here and it looks like I have to test this on a native Ubuntu-latest install at some point to continue this further.
@ReenigneArcher
ReenigneArcher
commented
May 12, 2026

Copy link


Copy Markdown

Member
@Kishi85 have a look at #123
ReenigneArcher
ReenigneArcher
reviewed
May 12, 2026
View reviewed changes
Comment threadsrc/QtTrayMenu.cpp
Outdated

Comment threadsrc/tray_linux.cpp
@Kishi85
Kishi85
commented
May 12, 2026

Copy link


Copy Markdown

Author
@Kishi85 have a look at #123
I'll pick that test change if you dont mind as it IMHO makes more sense logically
@Kishi85
Kishi85
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Author
Also the change you did for showing the menu on wayland in #123 does not work. Same issue as with show() due to that bug in Qt:
qt.qpa.wayland: Failed to create grabbing popup. Ensure popup QWidgetWindow(0x55c3cc28b8c0, name="QMenuClassWindow") has a transientParent set and that parent window has received input.
Looks like the only way to get left-click to work on Linux/Wayland is for Qt to fix the bug, every other workaround either fails silently or yields above message unfortunately.
@Kishi85
Kishi85
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Author
One main deficit of the QSystemTray::showMessage notification is that it does not hide immediately when you click it even if it triggers the callback. Neither can you programmatically close the message via the trayIcon object hence the screenshots showing multiple balloons due to tests firing in rapid succession.
After looking around for a bit the best thing (in terms of interoperability and functionality) seems to be using libnotify just for the notifications (as the XDG desktop notification path is not really viable due to the process privilege constraints).
Good thing here is that now that most of the Qt Tray Menu stuff is now isolated, it should be easy to do something similar for notifications and have a clean implementation.
@Kishi85Kishi85
changed the title
feat: Simplify QT-based tray implementaionfeat: Simplify QT-based tray implementationMay 12, 2026
@Kishi85
Kishi85force-pushed
the
simplify-qt-tray
branch
5 times, most recently
from
b747b99 to
26d15e6CompareMay 15, 2026 09:40
@ReenigneArcher

This comment was marked as resolved.

Sign in to view
Kishi85and others
added 21 commits
May 23, 2026 08:52
@Kishi85@ReenigneArcher
WIP - process events during exit
5598361
@ReenigneArcher
Update test_tray.cpp
844df0c
@ReenigneArcher
Provide default argv, hide menu, use popup
800c0e4
Add a persistent default argv (anonymous namespace) and include QCursor, then construct QApplication with the default argv when original argc/argv are missing to avoid using a short-lived stack array. Hide trayTopMenu before clearing tray references to prevent lingering UI. Replace menu->show() with menu->popup(QCursor::pos()) to work around QTBUG-139921 on Linux/Wayland. NOSONAR comments for QApplication allocation are preserved.
@Kishi85@ReenigneArcher
QApplication::quit() only for apps that we created.
7736f4c
@Kishi85@ReenigneArcher
Cleanup QtTrayMenu constructor
3806cf4
@Kishi85@ReenigneArcher
Add option to fire notification using QSystemTray::showMessage on ini…
71aeba1
…t/update
@Kishi85@ReenigneArcher
(Re-)Implement tray notifications using libnotify with fallback to ba…
e0df938
…sic QtTrayIcon::showMessage()
@Kishi85@ReenigneArcher
Refactor tray_linux.cpp notifications and add separate namespace for …
2d4d90a
…tray_linux
@Kishi85@ReenigneArcher
fix: Properly cleanup notificationCurrent and notificationCurrentCall…
d6bb4b3
…back where necessary
@Kishi85@ReenigneArcher
refactor - Use acknowledge_notification to also clear previous notifi…
dfaac3f
…cation in notify()
@Kishi85@ReenigneArcher
fix: Allow using themed icons for tray icon
0426265
@Kishi85@ReenigneArcher
fix: Always use absolute paths for filesystem-based notification icons
d98dc67
@Kishi85@ReenigneArcher
fix: Add missing/fix docstrings and unify variable style for namespac…
1834002
…e tray_linux
@Kishi85@ReenigneArcher
fix: Remove Qt::DBus dependency
35b5fab
@Kishi85@ReenigneArcher
fix: Fix potential issues with QtTrayMenu
925a2cb
@Kishi85@ReenigneArcher
fix: Re-init notify upon setting app_name
96cf063
@Kishi85@ReenigneArcher
fix: Process UI modifications using Qt event system
e24c656
Unless the operation is done during init, loop or already emitting a signal to do the modification.
@Kishi85@ReenigneArcher
fix: Improve error handling on tray_init
ed616c5
@Kishi85@ReenigneArcher
fix: Only fail tray init on libnotify failure if Qt does not support …
71f8760
…messages on system tray
@Kishi85@ReenigneArcher
fix: Requested changes from review
4d6b137
@Kishi85@ReenigneArcher
feat: run libnotify actions that use DBus asynchronously with timeout…
5f5e43d
… to avoid deadlocking
@sonarqubecloud
sonarqubecloudBot
commented
May 23, 2026

Copy link


Copy Markdown

Quality Gate PassedQuality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
@ReenigneArcher
ReenigneArcher
commented
May 23, 2026

Copy link


Copy Markdown

Member
Unless you want me to wait, I think I'm good with merging this as is. I don't think anyone is going to test it out on Sunshine until it's merged into the pre-releases.
@Kishi85
Kishi85
commented
May 23, 2026

Copy link


Copy Markdown

Author
Unless you want me to wait, I think I'm good with merging this as is. I don't think anyone is going to test it out on Sunshine until it's merged into the pre-releases.
Go for it. If there's anything to add I'll do a follow up PR.
@ReenigneArcher
ReenigneArcher
merged commit 35a6c4e
into
LizardByte:masterMay 23, 2026

18 of 19 checks passed

@Kishi85
Kishi85
commented
May 23, 2026

Copy link


Copy Markdown

Author
@ReenigneArcher
5f5e43d seems to cause issues now (just realized this while trying a game on my TV).

I'll put up a PR to revert that specific commit in a second as without that change everything is running smoothly here.
@Kishi85Kishi85
mentioned this pull request
May 23, 2026
 Merged

21 tasks
@ReenigneArcher
ReenigneArcher
commented
May 23, 2026

Copy link


Copy Markdown

Member
@Kishi85 so with these changes, do you think it could pave the way to use QT on Windows and macOS as well?
@Kishi85
Kishi85
commented
May 23, 2026

Copy link


Copy Markdown

Author
@Kishi85 so with these changes, do you think it could pave the way to use QT on Windows and macOS as well?
The QtTrayMenu class should work on any QT supported platform. The only thing that likely needs attention per platform is notifications due to already noted restrictions of QSystemTrayIcon::showMessage.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ReenigneArcherReenigneArcherReenigneArcher left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Kishi85@ReenigneArcher

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: Cleanup Qt-based tray implementation - #121
Merged
ReenigneArcher merged 28 commits into
LizardByte:masterfrom 
Kishi85:simplify-qt-tray
May 23, 2026
Merged
feat: Cleanup Qt-based tray implementation#121
ReenigneArcher merged 28 commits into
LizardByte:masterfrom 
Kishi85:simplify-qt-tray
Conversation
@Kishi85
@Kishi85Kishi85
commented
May 8, 2026•

edited

Loading

Copy link


Copy Markdown

Description
This reworks the Qt-based tray with an adapted version of QtTrayMenu.h/cpp from upstream as suggested in LizardByte/Sunshine#4907.
This version restores libnotify for notifications due to potential problems caused by DBus interface limitations when running with elevated privileges (e.g. as used by Sunshine). The new libnotify integration also tries to separate the used codepaths as best as possible to keep the implementation clean and easily understandable (with a fallback to basic notifications using QtTrayMenu::showMessage).
There is still an issue with left clicking the tray icon on Wayland (also present in the current AI based implementation) which caused by https://qt-project.atlassian.net/browse/QTBUG-139921 that can unfortunately not be worked around.
This version is platform-neutral for QtTrayMenu.h/cpp code with Linux platform-specific parts (and libnotify integration) restricted to tray_linux.cpp. Qt-provided features are used as much as possible to keep this platform-independent.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)
Checklist
  •  Code follows the style guidelines of this project
  •  Code has been self-reviewed
  •  Code has been commented, particularly in hard-to-understand areas
  •  Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  •  Unit tests have been added or updated for any new or modified functionality
AI Usage
  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes
@Kishi85Kishi85
changed the title
Simplify QT-based tray implementaionfix: Simplify QT-based tray implementaionMay 8, 2026
@Kishi85Kishi85
changed the title
fix: Simplify QT-based tray implementaionfeat: Simplify QT-based tray implementaionMay 8, 2026
@codecov
codecovBot
commented
May 9, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 61.26984% with 122 lines in your changes missing coverage. Please review.

✅ Project coverage is 64.38%. Comparing base (dc4be3a) to head (5f5e43d).
⚠️ Report is 39 commits behind head on master.
Files with missing linesPatch %Lines
src/QtTrayMenu.cpp54.00%59 Missing and 33 partials ⚠️
src/tray_linux.cpp73.91%11 Missing and 19 partials ⚠️
Additional details and impacted files
Impacted file tree graph
@@ Coverage Diff @@## master #121 +/- ##
==========================================
+ Coverage 63.75% 64.38% +0.63% 
==========================================
Files 4 5 +1 Lines 858 643 -215 Branches 313 209 -104 ==========================================
- Hits 547 414 -133 + Misses 205 153 -52 + Partials 106 76 -30 
FlagCoverage Δ
Linux-qt555.16% <61.26%> (-1.96%)⬇️
Linux-qt655.16% <61.26%> (-1.96%)⬇️
Windows70.67% <ø> (ø)
macOS56.63% <ø> (-2.66%)⬇️
Flags with carried forward coverage won't be shown. Click here to find out more.
Files with missing linesCoverage Δ
src/tray_linux.cpp65.51% <73.91%> (+6.05%)⬆️
src/QtTrayMenu.cpp54.00% <54.00%> (ø)
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Harness.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update dc4be3a...5f5e43d. Read the comment docs.
@Kishi85
Kishi85force-pushed
the
simplify-qt-tray
branch
11 times, most recently
from
275be0f to
c552bdaCompareMay 11, 2026 11:31
@Kishi85
Kishi85
commented
May 11, 2026

Copy link


Copy Markdown

Author
I've fixed most of the issues I've found so far (added all the necessary pointer valid checks/etc. and moved the exit() order around so everything gets cleaned up in reverse order (clearing references as necessary on the go). But no matter what I do the CI pipeline segfaults at this one specific test:
[ RUN ] TrayTest.TestCheckboxStates
/home/runner/work/_temp/d5b937f4-9556-4df2-8f27-571e2cb10ca8.sh: line 1: 8581 Segmentation fault (core dumped) ./test_tray --gtest_color=yes --gtest_output=xml:test_results.xml
Error: Process completed with exit code 139.

I can run all the tests fine locally after I've added support for spectacle screenshots due to using KDE, tests running both with clang and gcc compiled project. It just wont complete when run on the CI-container with ubuntu-latest. I'm a bit out of ideas here and it looks like I have to test this on a native Ubuntu-latest install at some point to continue this further.
@ReenigneArcher
ReenigneArcher
commented
May 12, 2026

Copy link


Copy Markdown

Member
@Kishi85 have a look at #123
ReenigneArcher
ReenigneArcher
reviewed
May 12, 2026
View reviewed changes
Comment threadsrc/QtTrayMenu.cpp
Outdated

Comment threadsrc/tray_linux.cpp
@Kishi85
Kishi85
commented
May 12, 2026

Copy link


Copy Markdown

Author
@Kishi85 have a look at #123
I'll pick that test change if you dont mind as it IMHO makes more sense logically
@Kishi85
Kishi85
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Author
Also the change you did for showing the menu on wayland in #123 does not work. Same issue as with show() due to that bug in Qt:
qt.qpa.wayland: Failed to create grabbing popup. Ensure popup QWidgetWindow(0x55c3cc28b8c0, name="QMenuClassWindow") has a transientParent set and that parent window has received input.
Looks like the only way to get left-click to work on Linux/Wayland is for Qt to fix the bug, every other workaround either fails silently or yields above message unfortunately.
@Kishi85
Kishi85
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Author
One main deficit of the QSystemTray::showMessage notification is that it does not hide immediately when you click it even if it triggers the callback. Neither can you programmatically close the message via the trayIcon object hence the screenshots showing multiple balloons due to tests firing in rapid succession.
After looking around for a bit the best thing (in terms of interoperability and functionality) seems to be using libnotify just for the notifications (as the XDG desktop notification path is not really viable due to the process privilege constraints).
Good thing here is that now that most of the Qt Tray Menu stuff is now isolated, it should be easy to do something similar for notifications and have a clean implementation.
@Kishi85Kishi85
changed the title
feat: Simplify QT-based tray implementaionfeat: Simplify QT-based tray implementationMay 12, 2026
@Kishi85
Kishi85force-pushed
the
simplify-qt-tray
branch
5 times, most recently
from
b747b99 to
26d15e6CompareMay 15, 2026 09:40
@ReenigneArcher

This comment was marked as resolved.

Sign in to view
Kishi85and others
added 21 commits
May 23, 2026 08:52
@Kishi85@ReenigneArcher
WIP - process events during exit
5598361
@ReenigneArcher
Update test_tray.cpp
844df0c
@ReenigneArcher
Provide default argv, hide menu, use popup
800c0e4
Add a persistent default argv (anonymous namespace) and include QCursor, then construct QApplication with the default argv when original argc/argv are missing to avoid using a short-lived stack array. Hide trayTopMenu before clearing tray references to prevent lingering UI. Replace menu->show() with menu->popup(QCursor::pos()) to work around QTBUG-139921 on Linux/Wayland. NOSONAR comments for QApplication allocation are preserved.
@Kishi85@ReenigneArcher
QApplication::quit() only for apps that we created.
7736f4c
@Kishi85@ReenigneArcher
Cleanup QtTrayMenu constructor
3806cf4
@Kishi85@ReenigneArcher
Add option to fire notification using QSystemTray::showMessage on ini…
71aeba1
…t/update
@Kishi85@ReenigneArcher
(Re-)Implement tray notifications using libnotify with fallback to ba…
e0df938
…sic QtTrayIcon::showMessage()
@Kishi85@ReenigneArcher
Refactor tray_linux.cpp notifications and add separate namespace for …
2d4d90a
…tray_linux
@Kishi85@ReenigneArcher
fix: Properly cleanup notificationCurrent and notificationCurrentCall…
d6bb4b3
…back where necessary
@Kishi85@ReenigneArcher
refactor - Use acknowledge_notification to also clear previous notifi…
dfaac3f
…cation in notify()
@Kishi85@ReenigneArcher
fix: Allow using themed icons for tray icon
0426265
@Kishi85@ReenigneArcher
fix: Always use absolute paths for filesystem-based notification icons
d98dc67
@Kishi85@ReenigneArcher
fix: Add missing/fix docstrings and unify variable style for namespac…
1834002
…e tray_linux
@Kishi85@ReenigneArcher
fix: Remove Qt::DBus dependency
35b5fab
@Kishi85@ReenigneArcher
fix: Fix potential issues with QtTrayMenu
925a2cb
@Kishi85@ReenigneArcher
fix: Re-init notify upon setting app_name
96cf063
@Kishi85@ReenigneArcher
fix: Process UI modifications using Qt event system
e24c656
Unless the operation is done during init, loop or already emitting a signal to do the modification.
@Kishi85@ReenigneArcher
fix: Improve error handling on tray_init
ed616c5
@Kishi85@ReenigneArcher
fix: Only fail tray init on libnotify failure if Qt does not support …
71f8760
…messages on system tray
@Kishi85@ReenigneArcher
fix: Requested changes from review
4d6b137
@Kishi85@ReenigneArcher
feat: run libnotify actions that use DBus asynchronously with timeout…
5f5e43d
… to avoid deadlocking
@sonarqubecloud
sonarqubecloudBot
commented
May 23, 2026

Copy link


Copy Markdown

Quality Gate PassedQuality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
@ReenigneArcher
ReenigneArcher
commented
May 23, 2026

Copy link


Copy Markdown

Member
Unless you want me to wait, I think I'm good with merging this as is. I don't think anyone is going to test it out on Sunshine until it's merged into the pre-releases.
@Kishi85
Kishi85
commented
May 23, 2026

Copy link


Copy Markdown

Author
Unless you want me to wait, I think I'm good with merging this as is. I don't think anyone is going to test it out on Sunshine until it's merged into the pre-releases.
Go for it. If there's anything to add I'll do a follow up PR.
@ReenigneArcher
ReenigneArcher
merged commit 35a6c4e
into
LizardByte:masterMay 23, 2026

18 of 19 checks passed

@Kishi85
Kishi85
commented
May 23, 2026

Copy link


Copy Markdown

Author
@ReenigneArcher
5f5e43d seems to cause issues now (just realized this while trying a game on my TV).

I'll put up a PR to revert that specific commit in a second as without that change everything is running smoothly here.
@Kishi85Kishi85
mentioned this pull request
May 23, 2026
 Merged

21 tasks
@ReenigneArcher
ReenigneArcher
commented
May 23, 2026

Copy link


Copy Markdown

Member
@Kishi85 so with these changes, do you think it could pave the way to use QT on Windows and macOS as well?
@Kishi85
Kishi85
commented
May 23, 2026

Copy link


Copy Markdown

Author
@Kishi85 so with these changes, do you think it could pave the way to use QT on Windows and macOS as well?
The QtTrayMenu class should work on any QT supported platform. The only thing that likely needs attention per platform is notifications due to already noted restrictions of QSystemTrayIcon::showMessage.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ReenigneArcherReenigneArcherReenigneArcher left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Kishi85@ReenigneArcher

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat: Cleanup Qt-based tray implementation - #121
Merged
ReenigneArcher merged 28 commits into
LizardByte:masterfrom 
Kishi85:simplify-qt-tray
May 23, 2026
Merged
feat: Cleanup Qt-based tray implementation#121
ReenigneArcher merged 28 commits into
LizardByte:masterfrom 
Kishi85:simplify-qt-tray
Conversation
@Kishi85
@Kishi85Kishi85
commented
May 8, 2026•

edited

Loading

Copy link


Copy Markdown

Description
This reworks the Qt-based tray with an adapted version of QtTrayMenu.h/cpp from upstream as suggested in LizardByte/Sunshine#4907.
This version restores libnotify for notifications due to potential problems caused by DBus interface limitations when running with elevated privileges (e.g. as used by Sunshine). The new libnotify integration also tries to separate the used codepaths as best as possible to keep the implementation clean and easily understandable (with a fallback to basic notifications using QtTrayMenu::showMessage).
There is still an issue with left clicking the tray icon on Wayland (also present in the current AI based implementation) which caused by https://qt-project.atlassian.net/browse/QTBUG-139921 that can unfortunately not be worked around.
This version is platform-neutral for QtTrayMenu.h/cpp code with Linux platform-specific parts (and libnotify integration) restricted to tray_linux.cpp. Qt-provided features are used as much as possible to keep this platform-independent.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)
Checklist
  •  Code follows the style guidelines of this project
  •  Code has been self-reviewed
  •  Code has been commented, particularly in hard-to-understand areas
  •  Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  •  Unit tests have been added or updated for any new or modified functionality
AI Usage
  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes
@Kishi85Kishi85
changed the title
Simplify QT-based tray implementaionfix: Simplify QT-based tray implementaionMay 8, 2026
@Kishi85Kishi85
changed the title
fix: Simplify QT-based tray implementaionfeat: Simplify QT-based tray implementaionMay 8, 2026
@codecov
codecovBot
commented
May 9, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 61.26984% with 122 lines in your changes missing coverage. Please review.

✅ Project coverage is 64.38%. Comparing base (dc4be3a) to head (5f5e43d).
⚠️ Report is 39 commits behind head on master.
Files with missing linesPatch %Lines
src/QtTrayMenu.cpp54.00%59 Missing and 33 partials ⚠️
src/tray_linux.cpp73.91%11 Missing and 19 partials ⚠️
Additional details and impacted files
Impacted file tree graph
@@ Coverage Diff @@## master #121 +/- ##
==========================================
+ Coverage 63.75% 64.38% +0.63% 
==========================================
Files 4 5 +1 Lines 858 643 -215 Branches 313 209 -104 ==========================================
- Hits 547 414 -133 + Misses 205 153 -52 + Partials 106 76 -30 
FlagCoverage Δ
Linux-qt555.16% <61.26%> (-1.96%)⬇️
Linux-qt655.16% <61.26%> (-1.96%)⬇️
Windows70.67% <ø> (ø)
macOS56.63% <ø> (-2.66%)⬇️
Flags with carried forward coverage won't be shown. Click here to find out more.
Files with missing linesCoverage Δ
src/tray_linux.cpp65.51% <73.91%> (+6.05%)⬆️
src/QtTrayMenu.cpp54.00% <54.00%> (ø)
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Harness.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update dc4be3a...5f5e43d. Read the comment docs.
@Kishi85
Kishi85force-pushed
the
simplify-qt-tray
branch
11 times, most recently
from
275be0f to
c552bdaCompareMay 11, 2026 11:31
@Kishi85
Kishi85
commented
May 11, 2026

Copy link


Copy Markdown

Author
I've fixed most of the issues I've found so far (added all the necessary pointer valid checks/etc. and moved the exit() order around so everything gets cleaned up in reverse order (clearing references as necessary on the go). But no matter what I do the CI pipeline segfaults at this one specific test:
[ RUN ] TrayTest.TestCheckboxStates
/home/runner/work/_temp/d5b937f4-9556-4df2-8f27-571e2cb10ca8.sh: line 1: 8581 Segmentation fault (core dumped) ./test_tray --gtest_color=yes --gtest_output=xml:test_results.xml
Error: Process completed with exit code 139.

I can run all the tests fine locally after I've added support for spectacle screenshots due to using KDE, tests running both with clang and gcc compiled project. It just wont complete when run on the CI-container with ubuntu-latest. I'm a bit out of ideas here and it looks like I have to test this on a native Ubuntu-latest install at some point to continue this further.
@ReenigneArcher
ReenigneArcher
commented
May 12, 2026

Copy link


Copy Markdown

Member
@Kishi85 have a look at #123
ReenigneArcher
ReenigneArcher
reviewed
May 12, 2026
View reviewed changes
Comment threadsrc/QtTrayMenu.cpp
Outdated

Comment threadsrc/tray_linux.cpp
@Kishi85
Kishi85
commented
May 12, 2026

Copy link


Copy Markdown

Author
@Kishi85 have a look at #123
I'll pick that test change if you dont mind as it IMHO makes more sense logically
@Kishi85
Kishi85
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Author
Also the change you did for showing the menu on wayland in #123 does not work. Same issue as with show() due to that bug in Qt:
qt.qpa.wayland: Failed to create grabbing popup. Ensure popup QWidgetWindow(0x55c3cc28b8c0, name="QMenuClassWindow") has a transientParent set and that parent window has received input.
Looks like the only way to get left-click to work on Linux/Wayland is for Qt to fix the bug, every other workaround either fails silently or yields above message unfortunately.
@Kishi85
Kishi85
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Author
One main deficit of the QSystemTray::showMessage notification is that it does not hide immediately when you click it even if it triggers the callback. Neither can you programmatically close the message via the trayIcon object hence the screenshots showing multiple balloons due to tests firing in rapid succession.
After looking around for a bit the best thing (in terms of interoperability and functionality) seems to be using libnotify just for the notifications (as the XDG desktop notification path is not really viable due to the process privilege constraints).
Good thing here is that now that most of the Qt Tray Menu stuff is now isolated, it should be easy to do something similar for notifications and have a clean implementation.
@Kishi85Kishi85
changed the title
feat: Simplify QT-based tray implementaionfeat: Simplify QT-based tray implementationMay 12, 2026
@Kishi85
Kishi85force-pushed
the
simplify-qt-tray
branch
5 times, most recently
from
b747b99 to
26d15e6CompareMay 15, 2026 09:40
@ReenigneArcher

This comment was marked as resolved.

Sign in to view
Kishi85and others
added 21 commits
May 23, 2026 08:52
@Kishi85@ReenigneArcher
WIP - process events during exit
5598361
@ReenigneArcher
Update test_tray.cpp
844df0c
@ReenigneArcher
Provide default argv, hide menu, use popup
800c0e4
Add a persistent default argv (anonymous namespace) and include QCursor, then construct QApplication with the default argv when original argc/argv are missing to avoid using a short-lived stack array. Hide trayTopMenu before clearing tray references to prevent lingering UI. Replace menu->show() with menu->popup(QCursor::pos()) to work around QTBUG-139921 on Linux/Wayland. NOSONAR comments for QApplication allocation are preserved.
@Kishi85@ReenigneArcher
QApplication::quit() only for apps that we created.
7736f4c
@Kishi85@ReenigneArcher
Cleanup QtTrayMenu constructor
3806cf4
@Kishi85@ReenigneArcher
Add option to fire notification using QSystemTray::showMessage on ini…
71aeba1
…t/update
@Kishi85@ReenigneArcher
(Re-)Implement tray notifications using libnotify with fallback to ba…
e0df938
…sic QtTrayIcon::showMessage()
@Kishi85@ReenigneArcher
Refactor tray_linux.cpp notifications and add separate namespace for …
2d4d90a
…tray_linux
@Kishi85@ReenigneArcher
fix: Properly cleanup notificationCurrent and notificationCurrentCall…
d6bb4b3
…back where necessary
@Kishi85@ReenigneArcher
refactor - Use acknowledge_notification to also clear previous notifi…
dfaac3f
…cation in notify()
@Kishi85@ReenigneArcher
fix: Allow using themed icons for tray icon
0426265
@Kishi85@ReenigneArcher
fix: Always use absolute paths for filesystem-based notification icons
d98dc67
@Kishi85@ReenigneArcher
fix: Add missing/fix docstrings and unify variable style for namespac…
1834002
…e tray_linux
@Kishi85@ReenigneArcher
fix: Remove Qt::DBus dependency
35b5fab
@Kishi85@ReenigneArcher
fix: Fix potential issues with QtTrayMenu
925a2cb
@Kishi85@ReenigneArcher
fix: Re-init notify upon setting app_name
96cf063
@Kishi85@ReenigneArcher
fix: Process UI modifications using Qt event system
e24c656
Unless the operation is done during init, loop or already emitting a signal to do the modification.
@Kishi85@ReenigneArcher
fix: Improve error handling on tray_init
ed616c5
@Kishi85@ReenigneArcher
fix: Only fail tray init on libnotify failure if Qt does not support …
71f8760
…messages on system tray
@Kishi85@ReenigneArcher
fix: Requested changes from review
4d6b137
@Kishi85@ReenigneArcher
feat: run libnotify actions that use DBus asynchronously with timeout…
5f5e43d
… to avoid deadlocking
@sonarqubecloud
sonarqubecloudBot
commented
May 23, 2026

Copy link


Copy Markdown

Quality Gate PassedQuality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
@ReenigneArcher
ReenigneArcher
commented
May 23, 2026

Copy link


Copy Markdown

Member
Unless you want me to wait, I think I'm good with merging this as is. I don't think anyone is going to test it out on Sunshine until it's merged into the pre-releases.
@Kishi85
Kishi85
commented
May 23, 2026

Copy link


Copy Markdown

Author
Unless you want me to wait, I think I'm good with merging this as is. I don't think anyone is going to test it out on Sunshine until it's merged into the pre-releases.
Go for it. If there's anything to add I'll do a follow up PR.
@ReenigneArcher
ReenigneArcher
merged commit 35a6c4e
into
LizardByte:masterMay 23, 2026

18 of 19 checks passed

@Kishi85
Kishi85
commented
May 23, 2026

Copy link


Copy Markdown

Author
@ReenigneArcher
5f5e43d seems to cause issues now (just realized this while trying a game on my TV).

I'll put up a PR to revert that specific commit in a second as without that change everything is running smoothly here.
@Kishi85Kishi85
mentioned this pull request
May 23, 2026
 Merged

21 tasks
@ReenigneArcher
ReenigneArcher
commented
May 23, 2026

Copy link


Copy Markdown

Member
@Kishi85 so with these changes, do you think it could pave the way to use QT on Windows and macOS as well?
@Kishi85
Kishi85
commented
May 23, 2026

Copy link


Copy Markdown

Author
@Kishi85 so with these changes, do you think it could pave the way to use QT on Windows and macOS as well?
The QtTrayMenu class should work on any QT supported platform. The only thing that likely needs attention per platform is notifications due to already noted restrictions of QSystemTrayIcon::showMessage.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ReenigneArcherReenigneArcherReenigneArcher left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Kishi85@ReenigneArcher

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: Cleanup Qt-based tray implementation - #121
Merged
ReenigneArcher merged 28 commits into
LizardByte:masterfrom 
Kishi85:simplify-qt-tray
May 23, 2026
Merged
feat: Cleanup Qt-based tray implementation#121
ReenigneArcher merged 28 commits into
LizardByte:masterfrom 
Kishi85:simplify-qt-tray
Conversation
@Kishi85
@Kishi85Kishi85
commented
May 8, 2026•

edited

Loading

Copy link


Copy Markdown

Description
This reworks the Qt-based tray with an adapted version of QtTrayMenu.h/cpp from upstream as suggested in LizardByte/Sunshine#4907.
This version restores libnotify for notifications due to potential problems caused by DBus interface limitations when running with elevated privileges (e.g. as used by Sunshine). The new libnotify integration also tries to separate the used codepaths as best as possible to keep the implementation clean and easily understandable (with a fallback to basic notifications using QtTrayMenu::showMessage).
There is still an issue with left clicking the tray icon on Wayland (also present in the current AI based implementation) which caused by https://qt-project.atlassian.net/browse/QTBUG-139921 that can unfortunately not be worked around.
This version is platform-neutral for QtTrayMenu.h/cpp code with Linux platform-specific parts (and libnotify integration) restricted to tray_linux.cpp. Qt-provided features are used as much as possible to keep this platform-independent.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)
Checklist
  •  Code follows the style guidelines of this project
  •  Code has been self-reviewed
  •  Code has been commented, particularly in hard-to-understand areas
  •  Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  •  Unit tests have been added or updated for any new or modified functionality
AI Usage
  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes
@Kishi85Kishi85
changed the title
Simplify QT-based tray implementaionfix: Simplify QT-based tray implementaionMay 8, 2026
@Kishi85Kishi85
changed the title
fix: Simplify QT-based tray implementaionfeat: Simplify QT-based tray implementaionMay 8, 2026
@codecov
codecovBot
commented
May 9, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 61.26984% with 122 lines in your changes missing coverage. Please review.

✅ Project coverage is 64.38%. Comparing base (dc4be3a) to head (5f5e43d).
⚠️ Report is 39 commits behind head on master.
Files with missing linesPatch %Lines
src/QtTrayMenu.cpp54.00%59 Missing and 33 partials ⚠️
src/tray_linux.cpp73.91%11 Missing and 19 partials ⚠️
Additional details and impacted files
Impacted file tree graph
@@ Coverage Diff @@## master #121 +/- ##
==========================================
+ Coverage 63.75% 64.38% +0.63% 
==========================================
Files 4 5 +1 Lines 858 643 -215 Branches 313 209 -104 ==========================================
- Hits 547 414 -133 + Misses 205 153 -52 + Partials 106 76 -30 
FlagCoverage Δ
Linux-qt555.16% <61.26%> (-1.96%)⬇️
Linux-qt655.16% <61.26%> (-1.96%)⬇️
Windows70.67% <ø> (ø)
macOS56.63% <ø> (-2.66%)⬇️
Flags with carried forward coverage won't be shown. Click here to find out more.
Files with missing linesCoverage Δ
src/tray_linux.cpp65.51% <73.91%> (+6.05%)⬆️
src/QtTrayMenu.cpp54.00% <54.00%> (ø)
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Harness.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update dc4be3a...5f5e43d. Read the comment docs.
@Kishi85
Kishi85force-pushed
the
simplify-qt-tray
branch
11 times, most recently
from
275be0f to
c552bdaCompareMay 11, 2026 11:31
@Kishi85
Kishi85
commented
May 11, 2026

Copy link


Copy Markdown

Author
I've fixed most of the issues I've found so far (added all the necessary pointer valid checks/etc. and moved the exit() order around so everything gets cleaned up in reverse order (clearing references as necessary on the go). But no matter what I do the CI pipeline segfaults at this one specific test:
[ RUN ] TrayTest.TestCheckboxStates
/home/runner/work/_temp/d5b937f4-9556-4df2-8f27-571e2cb10ca8.sh: line 1: 8581 Segmentation fault (core dumped) ./test_tray --gtest_color=yes --gtest_output=xml:test_results.xml
Error: Process completed with exit code 139.

I can run all the tests fine locally after I've added support for spectacle screenshots due to using KDE, tests running both with clang and gcc compiled project. It just wont complete when run on the CI-container with ubuntu-latest. I'm a bit out of ideas here and it looks like I have to test this on a native Ubuntu-latest install at some point to continue this further.
@ReenigneArcher
ReenigneArcher
commented
May 12, 2026

Copy link


Copy Markdown

Member
@Kishi85 have a look at #123
ReenigneArcher
ReenigneArcher
reviewed
May 12, 2026
View reviewed changes
Comment threadsrc/QtTrayMenu.cpp
Outdated

Comment threadsrc/tray_linux.cpp
@Kishi85
Kishi85
commented
May 12, 2026

Copy link


Copy Markdown

Author
@Kishi85 have a look at #123
I'll pick that test change if you dont mind as it IMHO makes more sense logically
@Kishi85
Kishi85
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Author
Also the change you did for showing the menu on wayland in #123 does not work. Same issue as with show() due to that bug in Qt:
qt.qpa.wayland: Failed to create grabbing popup. Ensure popup QWidgetWindow(0x55c3cc28b8c0, name="QMenuClassWindow") has a transientParent set and that parent window has received input.
Looks like the only way to get left-click to work on Linux/Wayland is for Qt to fix the bug, every other workaround either fails silently or yields above message unfortunately.
@Kishi85
Kishi85
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Author
One main deficit of the QSystemTray::showMessage notification is that it does not hide immediately when you click it even if it triggers the callback. Neither can you programmatically close the message via the trayIcon object hence the screenshots showing multiple balloons due to tests firing in rapid succession.
After looking around for a bit the best thing (in terms of interoperability and functionality) seems to be using libnotify just for the notifications (as the XDG desktop notification path is not really viable due to the process privilege constraints).
Good thing here is that now that most of the Qt Tray Menu stuff is now isolated, it should be easy to do something similar for notifications and have a clean implementation.
@Kishi85Kishi85
changed the title
feat: Simplify QT-based tray implementaionfeat: Simplify QT-based tray implementationMay 12, 2026
@Kishi85
Kishi85force-pushed
the
simplify-qt-tray
branch
5 times, most recently
from
b747b99 to
26d15e6CompareMay 15, 2026 09:40
@ReenigneArcher

This comment was marked as resolved.

Sign in to view
Kishi85and others
added 21 commits
May 23, 2026 08:52
@Kishi85@ReenigneArcher
WIP - process events during exit
5598361
@ReenigneArcher
Update test_tray.cpp
844df0c
@ReenigneArcher
Provide default argv, hide menu, use popup
800c0e4
Add a persistent default argv (anonymous namespace) and include QCursor, then construct QApplication with the default argv when original argc/argv are missing to avoid using a short-lived stack array. Hide trayTopMenu before clearing tray references to prevent lingering UI. Replace menu->show() with menu->popup(QCursor::pos()) to work around QTBUG-139921 on Linux/Wayland. NOSONAR comments for QApplication allocation are preserved.
@Kishi85@ReenigneArcher
QApplication::quit() only for apps that we created.
7736f4c
@Kishi85@ReenigneArcher
Cleanup QtTrayMenu constructor
3806cf4
@Kishi85@ReenigneArcher
Add option to fire notification using QSystemTray::showMessage on ini…
71aeba1
…t/update
@Kishi85@ReenigneArcher
(Re-)Implement tray notifications using libnotify with fallback to ba…
e0df938
…sic QtTrayIcon::showMessage()
@Kishi85@ReenigneArcher
Refactor tray_linux.cpp notifications and add separate namespace for …
2d4d90a
…tray_linux
@Kishi85@ReenigneArcher
fix: Properly cleanup notificationCurrent and notificationCurrentCall…
d6bb4b3
…back where necessary
@Kishi85@ReenigneArcher
refactor - Use acknowledge_notification to also clear previous notifi…
dfaac3f
…cation in notify()
@Kishi85@ReenigneArcher
fix: Allow using themed icons for tray icon
0426265
@Kishi85@ReenigneArcher
fix: Always use absolute paths for filesystem-based notification icons
d98dc67
@Kishi85@ReenigneArcher
fix: Add missing/fix docstrings and unify variable style for namespac…
1834002
…e tray_linux
@Kishi85@ReenigneArcher
fix: Remove Qt::DBus dependency
35b5fab
@Kishi85@ReenigneArcher
fix: Fix potential issues with QtTrayMenu
925a2cb
@Kishi85@ReenigneArcher
fix: Re-init notify upon setting app_name
96cf063
@Kishi85@ReenigneArcher
fix: Process UI modifications using Qt event system
e24c656
Unless the operation is done during init, loop or already emitting a signal to do the modification.
@Kishi85@ReenigneArcher
fix: Improve error handling on tray_init
ed616c5
@Kishi85@ReenigneArcher
fix: Only fail tray init on libnotify failure if Qt does not support …
71f8760
…messages on system tray
@Kishi85@ReenigneArcher
fix: Requested changes from review
4d6b137
@Kishi85@ReenigneArcher
feat: run libnotify actions that use DBus asynchronously with timeout…
5f5e43d
… to avoid deadlocking
@sonarqubecloud
sonarqubecloudBot
commented
May 23, 2026

Copy link


Copy Markdown

Quality Gate PassedQuality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
@ReenigneArcher
ReenigneArcher
commented
May 23, 2026

Copy link


Copy Markdown

Member
Unless you want me to wait, I think I'm good with merging this as is. I don't think anyone is going to test it out on Sunshine until it's merged into the pre-releases.
@Kishi85
Kishi85
commented
May 23, 2026

Copy link


Copy Markdown

Author
Unless you want me to wait, I think I'm good with merging this as is. I don't think anyone is going to test it out on Sunshine until it's merged into the pre-releases.
Go for it. If there's anything to add I'll do a follow up PR.
@ReenigneArcher
ReenigneArcher
merged commit 35a6c4e
into
LizardByte:masterMay 23, 2026

18 of 19 checks passed

@Kishi85
Kishi85
commented
May 23, 2026

Copy link


Copy Markdown

Author
@ReenigneArcher
5f5e43d seems to cause issues now (just realized this while trying a game on my TV).

I'll put up a PR to revert that specific commit in a second as without that change everything is running smoothly here.
@Kishi85Kishi85
mentioned this pull request
May 23, 2026
 Merged

21 tasks
@ReenigneArcher
ReenigneArcher
commented
May 23, 2026

Copy link


Copy Markdown

Member
@Kishi85 so with these changes, do you think it could pave the way to use QT on Windows and macOS as well?
@Kishi85
Kishi85
commented
May 23, 2026

Copy link


Copy Markdown

Author
@Kishi85 so with these changes, do you think it could pave the way to use QT on Windows and macOS as well?
The QtTrayMenu class should work on any QT supported platform. The only thing that likely needs attention per platform is notifications due to already noted restrictions of QSystemTrayIcon::showMessage.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ReenigneArcherReenigneArcherReenigneArcher left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Kishi85@ReenigneArcher

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: Cleanup Qt-based tray implementation - #121
Merged
ReenigneArcher merged 28 commits into
LizardByte:masterfrom 
Kishi85:simplify-qt-tray
May 23, 2026
Merged
feat: Cleanup Qt-based tray implementation#121
ReenigneArcher merged 28 commits into
LizardByte:masterfrom 
Kishi85:simplify-qt-tray
Conversation
@Kishi85
@Kishi85Kishi85
commented
May 8, 2026•

edited

Loading

Copy link


Copy Markdown

Description
This reworks the Qt-based tray with an adapted version of QtTrayMenu.h/cpp from upstream as suggested in LizardByte/Sunshine#4907.
This version restores libnotify for notifications due to potential problems caused by DBus interface limitations when running with elevated privileges (e.g. as used by Sunshine). The new libnotify integration also tries to separate the used codepaths as best as possible to keep the implementation clean and easily understandable (with a fallback to basic notifications using QtTrayMenu::showMessage).
There is still an issue with left clicking the tray icon on Wayland (also present in the current AI based implementation) which caused by https://qt-project.atlassian.net/browse/QTBUG-139921 that can unfortunately not be worked around.
This version is platform-neutral for QtTrayMenu.h/cpp code with Linux platform-specific parts (and libnotify integration) restricted to tray_linux.cpp. Qt-provided features are used as much as possible to keep this platform-independent.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)
Checklist
  •  Code follows the style guidelines of this project
  •  Code has been self-reviewed
  •  Code has been commented, particularly in hard-to-understand areas
  •  Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  •  Unit tests have been added or updated for any new or modified functionality
AI Usage
  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes
@Kishi85Kishi85
changed the title
Simplify QT-based tray implementaionfix: Simplify QT-based tray implementaionMay 8, 2026
@Kishi85Kishi85
changed the title
fix: Simplify QT-based tray implementaionfeat: Simplify QT-based tray implementaionMay 8, 2026
@codecov
codecovBot
commented
May 9, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 61.26984% with 122 lines in your changes missing coverage. Please review.

✅ Project coverage is 64.38%. Comparing base (dc4be3a) to head (5f5e43d).
⚠️ Report is 39 commits behind head on master.
Files with missing linesPatch %Lines
src/QtTrayMenu.cpp54.00%59 Missing and 33 partials ⚠️
src/tray_linux.cpp73.91%11 Missing and 19 partials ⚠️
Additional details and impacted files
Impacted file tree graph
@@ Coverage Diff @@## master #121 +/- ##
==========================================
+ Coverage 63.75% 64.38% +0.63% 
==========================================
Files 4 5 +1 Lines 858 643 -215 Branches 313 209 -104 ==========================================
- Hits 547 414 -133 + Misses 205 153 -52 + Partials 106 76 -30 
FlagCoverage Δ
Linux-qt555.16% <61.26%> (-1.96%)⬇️
Linux-qt655.16% <61.26%> (-1.96%)⬇️
Windows70.67% <ø> (ø)
macOS56.63% <ø> (-2.66%)⬇️
Flags with carried forward coverage won't be shown. Click here to find out more.
Files with missing linesCoverage Δ
src/tray_linux.cpp65.51% <73.91%> (+6.05%)⬆️
src/QtTrayMenu.cpp54.00% <54.00%> (ø)
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Harness.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update dc4be3a...5f5e43d. Read the comment docs.
@Kishi85
Kishi85force-pushed
the
simplify-qt-tray
branch
11 times, most recently
from
275be0f to
c552bdaCompareMay 11, 2026 11:31
@Kishi85
Kishi85
commented
May 11, 2026

Copy link


Copy Markdown

Author
I've fixed most of the issues I've found so far (added all the necessary pointer valid checks/etc. and moved the exit() order around so everything gets cleaned up in reverse order (clearing references as necessary on the go). But no matter what I do the CI pipeline segfaults at this one specific test:
[ RUN ] TrayTest.TestCheckboxStates
/home/runner/work/_temp/d5b937f4-9556-4df2-8f27-571e2cb10ca8.sh: line 1: 8581 Segmentation fault (core dumped) ./test_tray --gtest_color=yes --gtest_output=xml:test_results.xml
Error: Process completed with exit code 139.

I can run all the tests fine locally after I've added support for spectacle screenshots due to using KDE, tests running both with clang and gcc compiled project. It just wont complete when run on the CI-container with ubuntu-latest. I'm a bit out of ideas here and it looks like I have to test this on a native Ubuntu-latest install at some point to continue this further.
@ReenigneArcher
ReenigneArcher
commented
May 12, 2026

Copy link


Copy Markdown

Member
@Kishi85 have a look at #123
ReenigneArcher
ReenigneArcher
reviewed
May 12, 2026
View reviewed changes
Comment threadsrc/QtTrayMenu.cpp
Outdated

Comment threadsrc/tray_linux.cpp
@Kishi85
Kishi85
commented
May 12, 2026

Copy link


Copy Markdown

Author
@Kishi85 have a look at #123
I'll pick that test change if you dont mind as it IMHO makes more sense logically
@Kishi85
Kishi85
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Author
Also the change you did for showing the menu on wayland in #123 does not work. Same issue as with show() due to that bug in Qt:
qt.qpa.wayland: Failed to create grabbing popup. Ensure popup QWidgetWindow(0x55c3cc28b8c0, name="QMenuClassWindow") has a transientParent set and that parent window has received input.
Looks like the only way to get left-click to work on Linux/Wayland is for Qt to fix the bug, every other workaround either fails silently or yields above message unfortunately.
@Kishi85
Kishi85
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Author
One main deficit of the QSystemTray::showMessage notification is that it does not hide immediately when you click it even if it triggers the callback. Neither can you programmatically close the message via the trayIcon object hence the screenshots showing multiple balloons due to tests firing in rapid succession.
After looking around for a bit the best thing (in terms of interoperability and functionality) seems to be using libnotify just for the notifications (as the XDG desktop notification path is not really viable due to the process privilege constraints).
Good thing here is that now that most of the Qt Tray Menu stuff is now isolated, it should be easy to do something similar for notifications and have a clean implementation.
@Kishi85Kishi85
changed the title
feat: Simplify QT-based tray implementaionfeat: Simplify QT-based tray implementationMay 12, 2026
@Kishi85
Kishi85force-pushed
the
simplify-qt-tray
branch
5 times, most recently
from
b747b99 to
26d15e6CompareMay 15, 2026 09:40
@ReenigneArcher

This comment was marked as resolved.

Sign in to view
Kishi85and others
added 21 commits
May 23, 2026 08:52
@Kishi85@ReenigneArcher
WIP - process events during exit
5598361
@ReenigneArcher
Update test_tray.cpp
844df0c
@ReenigneArcher
Provide default argv, hide menu, use popup
800c0e4
Add a persistent default argv (anonymous namespace) and include QCursor, then construct QApplication with the default argv when original argc/argv are missing to avoid using a short-lived stack array. Hide trayTopMenu before clearing tray references to prevent lingering UI. Replace menu->show() with menu->popup(QCursor::pos()) to work around QTBUG-139921 on Linux/Wayland. NOSONAR comments for QApplication allocation are preserved.
@Kishi85@ReenigneArcher
QApplication::quit() only for apps that we created.
7736f4c
@Kishi85@ReenigneArcher
Cleanup QtTrayMenu constructor
3806cf4
@Kishi85@ReenigneArcher
Add option to fire notification using QSystemTray::showMessage on ini…
71aeba1
…t/update
@Kishi85@ReenigneArcher
(Re-)Implement tray notifications using libnotify with fallback to ba…
e0df938
…sic QtTrayIcon::showMessage()
@Kishi85@ReenigneArcher
Refactor tray_linux.cpp notifications and add separate namespace for …
2d4d90a
…tray_linux
@Kishi85@ReenigneArcher
fix: Properly cleanup notificationCurrent and notificationCurrentCall…
d6bb4b3
…back where necessary
@Kishi85@ReenigneArcher
refactor - Use acknowledge_notification to also clear previous notifi…
dfaac3f
…cation in notify()
@Kishi85@ReenigneArcher
fix: Allow using themed icons for tray icon
0426265
@Kishi85@ReenigneArcher
fix: Always use absolute paths for filesystem-based notification icons
d98dc67
@Kishi85@ReenigneArcher
fix: Add missing/fix docstrings and unify variable style for namespac…
1834002
…e tray_linux
@Kishi85@ReenigneArcher
fix: Remove Qt::DBus dependency
35b5fab
@Kishi85@ReenigneArcher
fix: Fix potential issues with QtTrayMenu
925a2cb
@Kishi85@ReenigneArcher
fix: Re-init notify upon setting app_name
96cf063
@Kishi85@ReenigneArcher
fix: Process UI modifications using Qt event system
e24c656
Unless the operation is done during init, loop or already emitting a signal to do the modification.
@Kishi85@ReenigneArcher
fix: Improve error handling on tray_init
ed616c5
@Kishi85@ReenigneArcher
fix: Only fail tray init on libnotify failure if Qt does not support …
71f8760
…messages on system tray
@Kishi85@ReenigneArcher
fix: Requested changes from review
4d6b137
@Kishi85@ReenigneArcher
feat: run libnotify actions that use DBus asynchronously with timeout…
5f5e43d
… to avoid deadlocking
@sonarqubecloud
sonarqubecloudBot
commented
May 23, 2026

Copy link


Copy Markdown

Quality Gate PassedQuality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
@ReenigneArcher
ReenigneArcher
commented
May 23, 2026

Copy link


Copy Markdown

Member
Unless you want me to wait, I think I'm good with merging this as is. I don't think anyone is going to test it out on Sunshine until it's merged into the pre-releases.
@Kishi85
Kishi85
commented
May 23, 2026

Copy link


Copy Markdown

Author
Unless you want me to wait, I think I'm good with merging this as is. I don't think anyone is going to test it out on Sunshine until it's merged into the pre-releases.
Go for it. If there's anything to add I'll do a follow up PR.
@ReenigneArcher
ReenigneArcher
merged commit 35a6c4e
into
LizardByte:masterMay 23, 2026

18 of 19 checks passed

@Kishi85
Kishi85
commented
May 23, 2026

Copy link


Copy Markdown

Author
@ReenigneArcher
5f5e43d seems to cause issues now (just realized this while trying a game on my TV).

I'll put up a PR to revert that specific commit in a second as without that change everything is running smoothly here.
@Kishi85Kishi85
mentioned this pull request
May 23, 2026
 Merged

21 tasks
@ReenigneArcher
ReenigneArcher
commented
May 23, 2026

Copy link


Copy Markdown

Member
@Kishi85 so with these changes, do you think it could pave the way to use QT on Windows and macOS as well?
@Kishi85
Kishi85
commented
May 23, 2026

Copy link


Copy Markdown

Author
@Kishi85 so with these changes, do you think it could pave the way to use QT on Windows and macOS as well?
The QtTrayMenu class should work on any QT supported platform. The only thing that likely needs attention per platform is notifications due to already noted restrictions of QSystemTrayIcon::showMessage.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ReenigneArcherReenigneArcherReenigneArcher left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Kishi85@ReenigneArcher

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat: Cleanup Qt-based tray implementation - #121
Merged
ReenigneArcher merged 28 commits into
LizardByte:masterfrom 
Kishi85:simplify-qt-tray
May 23, 2026
Merged
feat: Cleanup Qt-based tray implementation#121
ReenigneArcher merged 28 commits into
LizardByte:masterfrom 
Kishi85:simplify-qt-tray
Conversation
@Kishi85
@Kishi85Kishi85
commented
May 8, 2026•

edited

Loading

Copy link


Copy Markdown

Description
This reworks the Qt-based tray with an adapted version of QtTrayMenu.h/cpp from upstream as suggested in LizardByte/Sunshine#4907.
This version restores libnotify for notifications due to potential problems caused by DBus interface limitations when running with elevated privileges (e.g. as used by Sunshine). The new libnotify integration also tries to separate the used codepaths as best as possible to keep the implementation clean and easily understandable (with a fallback to basic notifications using QtTrayMenu::showMessage).
There is still an issue with left clicking the tray icon on Wayland (also present in the current AI based implementation) which caused by https://qt-project.atlassian.net/browse/QTBUG-139921 that can unfortunately not be worked around.
This version is platform-neutral for QtTrayMenu.h/cpp code with Linux platform-specific parts (and libnotify integration) restricted to tray_linux.cpp. Qt-provided features are used as much as possible to keep this platform-independent.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)
Checklist
  •  Code follows the style guidelines of this project
  •  Code has been self-reviewed
  •  Code has been commented, particularly in hard-to-understand areas
  •  Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  •  Unit tests have been added or updated for any new or modified functionality
AI Usage
  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes
@Kishi85Kishi85
changed the title
Simplify QT-based tray implementaionfix: Simplify QT-based tray implementaionMay 8, 2026
@Kishi85Kishi85
changed the title
fix: Simplify QT-based tray implementaionfeat: Simplify QT-based tray implementaionMay 8, 2026
@codecov
codecovBot
commented
May 9, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 61.26984% with 122 lines in your changes missing coverage. Please review.

✅ Project coverage is 64.38%. Comparing base (dc4be3a) to head (5f5e43d).
⚠️ Report is 39 commits behind head on master.
Files with missing linesPatch %Lines
src/QtTrayMenu.cpp54.00%59 Missing and 33 partials ⚠️
src/tray_linux.cpp73.91%11 Missing and 19 partials ⚠️
Additional details and impacted files
Impacted file tree graph
@@ Coverage Diff @@## master #121 +/- ##
==========================================
+ Coverage 63.75% 64.38% +0.63% 
==========================================
Files 4 5 +1 Lines 858 643 -215 Branches 313 209 -104 ==========================================
- Hits 547 414 -133 + Misses 205 153 -52 + Partials 106 76 -30 
FlagCoverage Δ
Linux-qt555.16% <61.26%> (-1.96%)⬇️
Linux-qt655.16% <61.26%> (-1.96%)⬇️
Windows70.67% <ø> (ø)
macOS56.63% <ø> (-2.66%)⬇️
Flags with carried forward coverage won't be shown. Click here to find out more.
Files with missing linesCoverage Δ
src/tray_linux.cpp65.51% <73.91%> (+6.05%)⬆️
src/QtTrayMenu.cpp54.00% <54.00%> (ø)
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Harness.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update dc4be3a...5f5e43d. Read the comment docs.
@Kishi85
Kishi85force-pushed
the
simplify-qt-tray
branch
11 times, most recently
from
275be0f to
c552bdaCompareMay 11, 2026 11:31
@Kishi85
Kishi85
commented
May 11, 2026

Copy link


Copy Markdown

Author
I've fixed most of the issues I've found so far (added all the necessary pointer valid checks/etc. and moved the exit() order around so everything gets cleaned up in reverse order (clearing references as necessary on the go). But no matter what I do the CI pipeline segfaults at this one specific test:
[ RUN ] TrayTest.TestCheckboxStates
/home/runner/work/_temp/d5b937f4-9556-4df2-8f27-571e2cb10ca8.sh: line 1: 8581 Segmentation fault (core dumped) ./test_tray --gtest_color=yes --gtest_output=xml:test_results.xml
Error: Process completed with exit code 139.

I can run all the tests fine locally after I've added support for spectacle screenshots due to using KDE, tests running both with clang and gcc compiled project. It just wont complete when run on the CI-container with ubuntu-latest. I'm a bit out of ideas here and it looks like I have to test this on a native Ubuntu-latest install at some point to continue this further.
@ReenigneArcher
ReenigneArcher
commented
May 12, 2026

Copy link


Copy Markdown

Member
@Kishi85 have a look at #123
ReenigneArcher
ReenigneArcher
reviewed
May 12, 2026
View reviewed changes
Comment threadsrc/QtTrayMenu.cpp
Outdated

Comment threadsrc/tray_linux.cpp
@Kishi85
Kishi85
commented
May 12, 2026

Copy link


Copy Markdown

Author
@Kishi85 have a look at #123
I'll pick that test change if you dont mind as it IMHO makes more sense logically
@Kishi85
Kishi85
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Author
Also the change you did for showing the menu on wayland in #123 does not work. Same issue as with show() due to that bug in Qt:
qt.qpa.wayland: Failed to create grabbing popup. Ensure popup QWidgetWindow(0x55c3cc28b8c0, name="QMenuClassWindow") has a transientParent set and that parent window has received input.
Looks like the only way to get left-click to work on Linux/Wayland is for Qt to fix the bug, every other workaround either fails silently or yields above message unfortunately.
@Kishi85
Kishi85
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Author
One main deficit of the QSystemTray::showMessage notification is that it does not hide immediately when you click it even if it triggers the callback. Neither can you programmatically close the message via the trayIcon object hence the screenshots showing multiple balloons due to tests firing in rapid succession.
After looking around for a bit the best thing (in terms of interoperability and functionality) seems to be using libnotify just for the notifications (as the XDG desktop notification path is not really viable due to the process privilege constraints).
Good thing here is that now that most of the Qt Tray Menu stuff is now isolated, it should be easy to do something similar for notifications and have a clean implementation.
@Kishi85Kishi85
changed the title
feat: Simplify QT-based tray implementaionfeat: Simplify QT-based tray implementationMay 12, 2026
@Kishi85
Kishi85force-pushed
the
simplify-qt-tray
branch
5 times, most recently
from
b747b99 to
26d15e6CompareMay 15, 2026 09:40
@ReenigneArcher

This comment was marked as resolved.

Sign in to view
Kishi85and others
added 21 commits
May 23, 2026 08:52
@Kishi85@ReenigneArcher
WIP - process events during exit
5598361
@ReenigneArcher
Update test_tray.cpp
844df0c
@ReenigneArcher
Provide default argv, hide menu, use popup
800c0e4
Add a persistent default argv (anonymous namespace) and include QCursor, then construct QApplication with the default argv when original argc/argv are missing to avoid using a short-lived stack array. Hide trayTopMenu before clearing tray references to prevent lingering UI. Replace menu->show() with menu->popup(QCursor::pos()) to work around QTBUG-139921 on Linux/Wayland. NOSONAR comments for QApplication allocation are preserved.
@Kishi85@ReenigneArcher
QApplication::quit() only for apps that we created.
7736f4c
@Kishi85@ReenigneArcher
Cleanup QtTrayMenu constructor
3806cf4
@Kishi85@ReenigneArcher
Add option to fire notification using QSystemTray::showMessage on ini…
71aeba1
…t/update
@Kishi85@ReenigneArcher
(Re-)Implement tray notifications using libnotify with fallback to ba…
e0df938
…sic QtTrayIcon::showMessage()
@Kishi85@ReenigneArcher
Refactor tray_linux.cpp notifications and add separate namespace for …
2d4d90a
…tray_linux
@Kishi85@ReenigneArcher
fix: Properly cleanup notificationCurrent and notificationCurrentCall…
d6bb4b3
…back where necessary
@Kishi85@ReenigneArcher
refactor - Use acknowledge_notification to also clear previous notifi…
dfaac3f
…cation in notify()
@Kishi85@ReenigneArcher
fix: Allow using themed icons for tray icon
0426265
@Kishi85@ReenigneArcher
fix: Always use absolute paths for filesystem-based notification icons
d98dc67
@Kishi85@ReenigneArcher
fix: Add missing/fix docstrings and unify variable style for namespac…
1834002
…e tray_linux
@Kishi85@ReenigneArcher
fix: Remove Qt::DBus dependency
35b5fab
@Kishi85@ReenigneArcher
fix: Fix potential issues with QtTrayMenu
925a2cb
@Kishi85@ReenigneArcher
fix: Re-init notify upon setting app_name
96cf063
@Kishi85@ReenigneArcher
fix: Process UI modifications using Qt event system
e24c656
Unless the operation is done during init, loop or already emitting a signal to do the modification.
@Kishi85@ReenigneArcher
fix: Improve error handling on tray_init
ed616c5
@Kishi85@ReenigneArcher
fix: Only fail tray init on libnotify failure if Qt does not support …
71f8760
…messages on system tray
@Kishi85@ReenigneArcher
fix: Requested changes from review
4d6b137
@Kishi85@ReenigneArcher
feat: run libnotify actions that use DBus asynchronously with timeout…
5f5e43d
… to avoid deadlocking
@sonarqubecloud
sonarqubecloudBot
commented
May 23, 2026

Copy link


Copy Markdown

Quality Gate PassedQuality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
@ReenigneArcher
ReenigneArcher
commented
May 23, 2026

Copy link


Copy Markdown

Member
Unless you want me to wait, I think I'm good with merging this as is. I don't think anyone is going to test it out on Sunshine until it's merged into the pre-releases.
@Kishi85
Kishi85
commented
May 23, 2026

Copy link


Copy Markdown

Author
Unless you want me to wait, I think I'm good with merging this as is. I don't think anyone is going to test it out on Sunshine until it's merged into the pre-releases.
Go for it. If there's anything to add I'll do a follow up PR.
@ReenigneArcher
ReenigneArcher
merged commit 35a6c4e
into
LizardByte:masterMay 23, 2026

18 of 19 checks passed

@Kishi85
Kishi85
commented
May 23, 2026

Copy link


Copy Markdown

Author
@ReenigneArcher
5f5e43d seems to cause issues now (just realized this while trying a game on my TV).

I'll put up a PR to revert that specific commit in a second as without that change everything is running smoothly here.
@Kishi85Kishi85
mentioned this pull request
May 23, 2026
 Merged

21 tasks
@ReenigneArcher
ReenigneArcher
commented
May 23, 2026

Copy link


Copy Markdown

Member
@Kishi85 so with these changes, do you think it could pave the way to use QT on Windows and macOS as well?
@Kishi85
Kishi85
commented
May 23, 2026

Copy link


Copy Markdown

Author
@Kishi85 so with these changes, do you think it could pave the way to use QT on Windows and macOS as well?
The QtTrayMenu class should work on any QT supported platform. The only thing that likely needs attention per platform is notifications due to already noted restrictions of QSystemTrayIcon::showMessage.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ReenigneArcherReenigneArcherReenigneArcher left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Kishi85@ReenigneArcher