fix: resolve legacy code-page encodings without opening Preferences f…

src/LogExpert.Core/Classes/JsonConverters/EncodingJsonConverter.cs

@@ -1,6 +1,8 @@
 using System;
 using System.Text;
 
+using LogExpert.Core.Helpers;
+
 using Newtonsoft.Json;
 
 namespace LogExpert.Core.Classes.JsonConverters;
@@ -53,19 +55,6 @@ public override void WriteJson (JsonWriter writer, object? value, JsonSerializer
  return null;
  }
 
- var encodingName = reader.Value?.ToString();
- if (string.IsNullOrEmpty(encodingName))
- {
- return Encoding.Default;
- }
-
- try
- {
- return Encoding.GetEncoding(encodingName);
- }
- catch (ArgumentException)
- {
- return Encoding.Default;
- }
+ return EncodingRegistry.GetEncoding(reader.Value?.ToString(), Encoding.Default);
  }
 }

src/LogExpert.Core/Classes/Log/LogfileReader.cs

@@ -37,8 +37,6 @@ public partial class LogfileReader : ILogfileReader, IMultiFileNavigation, ILogf
 
  private readonly ILoadProgressReporter _progressReporter;
 
- private readonly MemoryMappedFileReader _mmfReader;
-
  private const int WAIT_TIME = 1000;
 
  private bool _contentDeleted;
@@ -186,18 +184,6 @@ private LogfileReader (
 
  _watchedILogFileInfo = fileInfo;
 
- if (!IsMultiFile && _watchedILogFileInfo.Uri?.Scheme is null or "file")
- {
- try
- {
- _mmfReader = new MemoryMappedFileReader(_watchedILogFileInfo.FullName, EncodingOptions.Encoding ?? Encoding.Default);
- }
- catch (IOException)
- {
- _mmfReader = null; // fallback to buffer path
- }
- }
-
  StartGCThread();
  }
 
@@ -959,12 +945,6 @@ private ValueTask<ILogLineMemory> GetLogLineMemoryInternal (int lineNum)
  return default;
  }
 
- if (_mmfReader != null && lineNum < _mmfReader.LineCount)
- {
- var line = _mmfReader.GetLine(lineNum);
- return new ValueTask<ILogLineMemory>(line);
- }
-
  using var readLock = BufferIndex.AcquireReadLock();
  {
  var logBufferEntry = BufferIndex.GetBufferForLineWithIndex(lineNum);
@@ -1568,8 +1548,6 @@ private void FileChanged ()
  _logger.Info(CultureInfo.InvariantCulture, "file size changed. new size={0}, file: {1}", newSize, _fileName);
  FireChangeEvent();
  }
-
- _mmfReader?.ExtendIndex();
  }
 
  /// <summary>
@@ -1874,8 +1852,6 @@ protected virtual void Dispose (bool disposing)
  _cts.Dispose();
  BufferIndex.Dispose();
  _progressReporter.Dispose();
- _mmfReader?.Dispose();
-
  }
 
  _disposed = true;

src/LogExpert.Core/Classes/Persister/PersisterXML.cs

@@ -6,6 +6,7 @@
 
 using LogExpert.Core.Classes.Filter;
 using LogExpert.Core.Entities;
+using LogExpert.Core.Helpers;
 
 using NLog;
 
@@ -266,26 +267,24 @@ private static PersistenceData ReadPersistenceDataFromNode (XmlNode node)
  private static Encoding ReadEncoding (XmlElement fileElement)
  {
  XmlNode encodingNode = fileElement.SelectSingleNode("encoding");
- if (encodingNode != null)
+ if (encodingNode == null)
  {
- XmlAttribute encAttr = encodingNode.Attributes["name"];
- try
- {
- return encAttr == null ? null : Encoding.GetEncoding(encAttr.Value);
- }
- catch (ArgumentException e)
- {
- _logger.Error(e);
- return Encoding.Default;
- }
- catch (NotSupportedException e)
- {
- _logger.Error(e);
- return Encoding.Default;
- }
+ return null;
+ }
+
+ XmlAttribute encAttr = encodingNode.Attributes["name"];
+ if (encAttr == null)
+ {
+ return null;
+ }
+
+ if (EncodingRegistry.TryGetEncoding(encAttr.Value, out var encoding))
+ {
+ return encoding;
  }
 
- return null;
+ _logger.Error($"Persisted encoding '{encAttr.Value}' is not supported, falling back to the default encoding");
+ return Encoding.Default;
  }
 
  /// <summary>