Skip to content

add geometry validation to Sampler#238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
noellehmcheng wants to merge 1 commit into
base:noelle/thickness_calculator
Choose a base branch
from
Draft

add geometry validation to Sampler #238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions map2loop/sampler.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -90,6 +90,15 @@ def sample(
Returns:
pandas.DataFrame: the sampled data points
"""
valid_geometry = (
shapely.geometry.point.Point,
shapely.geometry.multipoint.MultiPoint
)

all_valid_geometries = all(isinstance(geom, valid_geometry) for geom in spatial_data.geometry)
if not all_valid_geometries:
raise ValueError("Invalid geometry types found in spatial_data")

data = spatial_data.copy()
data["X"] = data.geometry.x
data["Y"] = data.geometry.y
Expand DownExpand Up@@ -149,6 +158,16 @@ def sample(
Returns:
pandas.DataFrame: the sampled data points
"""
valid_geometry = (
shapely.geometry.multipolygon.MultiPolygon,
shapely.geometry.polygon.Polygon,
shapely.geometry.multilinestring.MultiLineString,
shapely.geometry.linestring.LineString
)
all_valid_geometries = all(isinstance(geom, valid_geometry) for geom in spatial_data.geometry)
if not all_valid_geometries:
raise ValueError("Invalid geometry types found in spatial_data")

schema = {"ID": str, "X": float, "Y": float, "featureId": str}
df = pandas.DataFrame(columns=schema.keys()).astype(schema)
for _, row in spatial_data.iterrows():
Expand Down