Fault feature panel upgrade by lachlangrose · Pull Request #63 · Loop3D/plugin_loopstructural

lachlangrose · 2026-01-14T23:03:49Z

No description provided.

Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

Copilot

Pull request overview

This PR introduces a comprehensive upgrade to the fault feature panel and debugging capabilities for the LoopStructural QGIS plugin. The changes add debug directory management, parameter logging for map2loop tools, and UI improvements to enable interactive fault parameter editing with live model updates.

Changes:

Added debug manager infrastructure with configurable debug directory and automatic logging/export of tool parameters and layers
Implemented Observable pattern for model updates and added debounced rebuilds for interactive fault parameter editing
Enhanced map2loop tool dialogs to accept and use debug_manager for parameter logging and layer export

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 63 comments.

Show a summary per file

File	Description
loopstructural/debug_manager.py	New debug manager with session directories, parameter logging, and layer export
loopstructural/toolbelt/preferences.py	Added debug_directory setting and logging configuration
loopstructural/main/model_manager.py	Converted to Observable, added notification suspension and feature update methods
loopstructural/gui/dlg_settings.py	Added debug directory UI controls
loopstructural/plugin_main.py	Integrated debug_manager and added fault topology action
loopstructural/main/m2l_api.py	Added debug_manager parameter to map2loop API functions
loopstructural/gui/modelling/geological_model_tab/feature_details_panel.py	Implemented debounced rebuilds and fault parameter controls
loopstructural/gui/visualisation/feature_list_widget.py	Added model update observers and surface re-rendering
loopstructural/gui/map2loop_tools/*.py	Added debug manager integration to all map2loop tool widgets
loopstructural/main/debug/export.py	New debug package export utility
tests/qgis/test_plg_preferences.py	Added tests for debug_directory setting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-14T23:11:46Z

+from loopstructural.main.debug import export



Unused import. The 'export' module is imported but never used. Remove this import or use the export functionality.
Suggested change
from loopstructural.main.debug import export

Copilot · 2026-01-14T23:11:47Z

- if unit_name_field and unit_name_field != 'UNITNAME' and unit_name_field in geology_gdf.columns:
+ if (
+ unit_name_field
+ and unit_name_field != unit_name_field


The condition 'unit_name_field != unit_name_field' is always False. This appears to be a copy-paste error and will cause the code block to never execute. This condition should likely compare unit_name_field against 'UNITNAME' or another constant.
Suggested change
and unit_name_field != unit_name_field

Copilot · 2026-01-14T23:12:02Z

+ payload = params if params is not None else self.get_parameters()
+ payload = self._serialize_params_for_logging(payload, context_label)
+ self._debug.log_params(context_label=context_label, params=payload)
+ except Exception:


'except' clause does nothing but pass and there is no explanatory comment.

Copilot · 2026-01-14T23:12:02Z

+ if getattr(self, "_debug", None):
+ try:
+ self._debug.log_params(context_label=context_label, params=params)
+ except Exception:


'except' clause does nothing but pass and there is no explanatory comment.

Copilot · 2026-01-14T23:12:02Z

+ logger.debug(f"Removed existing mesh: {mesh_name}")
+ except Exception:
+ logger.debug(f"Failed to remove existing mesh: {mesh_name}")
+ pass


Unnecessary 'pass' statement.

Copilot · 2026-01-14T23:12:02Z

+ except Exception as e:
+ print("Failed to save sampler debug info")
+ print(e)
+ pass


Unnecessary 'pass' statement.

lachlangrose · 2026-01-14T23:03:49Z

No description provided.

Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

Copilot

Pull request overview

This PR introduces a comprehensive upgrade to the fault feature panel and debugging capabilities for the LoopStructural QGIS plugin. The changes add debug directory management, parameter logging for map2loop tools, and UI improvements to enable interactive fault parameter editing with live model updates.

Changes:

Added debug manager infrastructure with configurable debug directory and automatic logging/export of tool parameters and layers
Implemented Observable pattern for model updates and added debounced rebuilds for interactive fault parameter editing
Enhanced map2loop tool dialogs to accept and use debug_manager for parameter logging and layer export

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 63 comments.

Show a summary per file

File	Description
loopstructural/debug_manager.py	New debug manager with session directories, parameter logging, and layer export
loopstructural/toolbelt/preferences.py	Added debug_directory setting and logging configuration
loopstructural/main/model_manager.py	Converted to Observable, added notification suspension and feature update methods
loopstructural/gui/dlg_settings.py	Added debug directory UI controls
loopstructural/plugin_main.py	Integrated debug_manager and added fault topology action
loopstructural/main/m2l_api.py	Added debug_manager parameter to map2loop API functions
loopstructural/gui/modelling/geological_model_tab/feature_details_panel.py	Implemented debounced rebuilds and fault parameter controls
loopstructural/gui/visualisation/feature_list_widget.py	Added model update observers and surface re-rendering
loopstructural/gui/map2loop_tools/*.py	Added debug manager integration to all map2loop tool widgets
loopstructural/main/debug/export.py	New debug package export utility
tests/qgis/test_plg_preferences.py	Added tests for debug_directory setting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-14T23:11:46Z

+from loopstructural.main.debug import export



Unused import. The 'export' module is imported but never used. Remove this import or use the export functionality.
Suggested change
from loopstructural.main.debug import export

Copilot · 2026-01-14T23:11:47Z

- if unit_name_field and unit_name_field != 'UNITNAME' and unit_name_field in geology_gdf.columns:
+ if (
+ unit_name_field
+ and unit_name_field != unit_name_field


The condition 'unit_name_field != unit_name_field' is always False. This appears to be a copy-paste error and will cause the code block to never execute. This condition should likely compare unit_name_field against 'UNITNAME' or another constant.
Suggested change
and unit_name_field != unit_name_field

Copilot · 2026-01-14T23:12:02Z

+ payload = params if params is not None else self.get_parameters()
+ payload = self._serialize_params_for_logging(payload, context_label)
+ self._debug.log_params(context_label=context_label, params=payload)
+ except Exception:


'except' clause does nothing but pass and there is no explanatory comment.

Copilot · 2026-01-14T23:12:02Z

+ if getattr(self, "_debug", None):
+ try:
+ self._debug.log_params(context_label=context_label, params=params)
+ except Exception:


'except' clause does nothing but pass and there is no explanatory comment.

Copilot · 2026-01-14T23:12:02Z

+ logger.debug(f"Removed existing mesh: {mesh_name}")
+ except Exception:
+ logger.debug(f"Failed to remove existing mesh: {mesh_name}")
+ pass


Unnecessary 'pass' statement.

Copilot · 2026-01-14T23:12:02Z

+ except Exception as e:
+ print("Failed to save sampler debug info")
+ print(e)
+ pass


Unnecessary 'pass' statement.

lachlangrose · 2026-01-14T23:03:49Z

No description provided.

Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

Copilot

Pull request overview

This PR introduces a comprehensive upgrade to the fault feature panel and debugging capabilities for the LoopStructural QGIS plugin. The changes add debug directory management, parameter logging for map2loop tools, and UI improvements to enable interactive fault parameter editing with live model updates.

Changes:

Added debug manager infrastructure with configurable debug directory and automatic logging/export of tool parameters and layers
Implemented Observable pattern for model updates and added debounced rebuilds for interactive fault parameter editing
Enhanced map2loop tool dialogs to accept and use debug_manager for parameter logging and layer export

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 63 comments.

Show a summary per file

File	Description
loopstructural/debug_manager.py	New debug manager with session directories, parameter logging, and layer export
loopstructural/toolbelt/preferences.py	Added debug_directory setting and logging configuration
loopstructural/main/model_manager.py	Converted to Observable, added notification suspension and feature update methods
loopstructural/gui/dlg_settings.py	Added debug directory UI controls
loopstructural/plugin_main.py	Integrated debug_manager and added fault topology action
loopstructural/main/m2l_api.py	Added debug_manager parameter to map2loop API functions
loopstructural/gui/modelling/geological_model_tab/feature_details_panel.py	Implemented debounced rebuilds and fault parameter controls
loopstructural/gui/visualisation/feature_list_widget.py	Added model update observers and surface re-rendering
loopstructural/gui/map2loop_tools/*.py	Added debug manager integration to all map2loop tool widgets
loopstructural/main/debug/export.py	New debug package export utility
tests/qgis/test_plg_preferences.py	Added tests for debug_directory setting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-14T23:11:46Z

+from loopstructural.main.debug import export



Unused import. The 'export' module is imported but never used. Remove this import or use the export functionality.
Suggested change
from loopstructural.main.debug import export

Copilot · 2026-01-14T23:11:47Z

- if unit_name_field and unit_name_field != 'UNITNAME' and unit_name_field in geology_gdf.columns:
+ if (
+ unit_name_field
+ and unit_name_field != unit_name_field


The condition 'unit_name_field != unit_name_field' is always False. This appears to be a copy-paste error and will cause the code block to never execute. This condition should likely compare unit_name_field against 'UNITNAME' or another constant.
Suggested change
and unit_name_field != unit_name_field

Copilot · 2026-01-14T23:12:02Z

+ payload = params if params is not None else self.get_parameters()
+ payload = self._serialize_params_for_logging(payload, context_label)
+ self._debug.log_params(context_label=context_label, params=payload)
+ except Exception:


'except' clause does nothing but pass and there is no explanatory comment.

Copilot · 2026-01-14T23:12:02Z

+ if getattr(self, "_debug", None):
+ try:
+ self._debug.log_params(context_label=context_label, params=params)
+ except Exception:


'except' clause does nothing but pass and there is no explanatory comment.

Copilot · 2026-01-14T23:12:02Z

+ logger.debug(f"Removed existing mesh: {mesh_name}")
+ except Exception:
+ logger.debug(f"Failed to remove existing mesh: {mesh_name}")
+ pass


Unnecessary 'pass' statement.

Copilot · 2026-01-14T23:12:02Z

+ except Exception as e:
+ print("Failed to save sampler debug info")
+ print(e)
+ pass


Unnecessary 'pass' statement.

lachlangrose · 2026-01-14T23:03:49Z

No description provided.

Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

Copilot

Pull request overview

This PR introduces a comprehensive upgrade to the fault feature panel and debugging capabilities for the LoopStructural QGIS plugin. The changes add debug directory management, parameter logging for map2loop tools, and UI improvements to enable interactive fault parameter editing with live model updates.

Changes:

Added debug manager infrastructure with configurable debug directory and automatic logging/export of tool parameters and layers
Implemented Observable pattern for model updates and added debounced rebuilds for interactive fault parameter editing
Enhanced map2loop tool dialogs to accept and use debug_manager for parameter logging and layer export

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 63 comments.

Show a summary per file

File	Description
loopstructural/debug_manager.py	New debug manager with session directories, parameter logging, and layer export
loopstructural/toolbelt/preferences.py	Added debug_directory setting and logging configuration
loopstructural/main/model_manager.py	Converted to Observable, added notification suspension and feature update methods
loopstructural/gui/dlg_settings.py	Added debug directory UI controls
loopstructural/plugin_main.py	Integrated debug_manager and added fault topology action
loopstructural/main/m2l_api.py	Added debug_manager parameter to map2loop API functions
loopstructural/gui/modelling/geological_model_tab/feature_details_panel.py	Implemented debounced rebuilds and fault parameter controls
loopstructural/gui/visualisation/feature_list_widget.py	Added model update observers and surface re-rendering
loopstructural/gui/map2loop_tools/*.py	Added debug manager integration to all map2loop tool widgets
loopstructural/main/debug/export.py	New debug package export utility
tests/qgis/test_plg_preferences.py	Added tests for debug_directory setting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-14T23:11:46Z

+from loopstructural.main.debug import export



Unused import. The 'export' module is imported but never used. Remove this import or use the export functionality.
Suggested change
from loopstructural.main.debug import export

Copilot · 2026-01-14T23:11:47Z

- if unit_name_field and unit_name_field != 'UNITNAME' and unit_name_field in geology_gdf.columns:
+ if (
+ unit_name_field
+ and unit_name_field != unit_name_field


The condition 'unit_name_field != unit_name_field' is always False. This appears to be a copy-paste error and will cause the code block to never execute. This condition should likely compare unit_name_field against 'UNITNAME' or another constant.
Suggested change
and unit_name_field != unit_name_field

Copilot · 2026-01-14T23:12:02Z

+ payload = params if params is not None else self.get_parameters()
+ payload = self._serialize_params_for_logging(payload, context_label)
+ self._debug.log_params(context_label=context_label, params=payload)
+ except Exception:


'except' clause does nothing but pass and there is no explanatory comment.

Copilot · 2026-01-14T23:12:02Z

+ if getattr(self, "_debug", None):
+ try:
+ self._debug.log_params(context_label=context_label, params=params)
+ except Exception:


'except' clause does nothing but pass and there is no explanatory comment.

Copilot · 2026-01-14T23:12:02Z

+ logger.debug(f"Removed existing mesh: {mesh_name}")
+ except Exception:
+ logger.debug(f"Failed to remove existing mesh: {mesh_name}")
+ pass


Unnecessary 'pass' statement.

Copilot · 2026-01-14T23:12:02Z

+ except Exception as e:
+ print("Failed to save sampler debug info")
+ print(e)
+ pass


Unnecessary 'pass' statement.

lachlangrose · 2026-01-14T23:03:49Z

No description provided.

Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

Copilot

Pull request overview

This PR introduces a comprehensive upgrade to the fault feature panel and debugging capabilities for the LoopStructural QGIS plugin. The changes add debug directory management, parameter logging for map2loop tools, and UI improvements to enable interactive fault parameter editing with live model updates.

Changes:

Added debug manager infrastructure with configurable debug directory and automatic logging/export of tool parameters and layers
Implemented Observable pattern for model updates and added debounced rebuilds for interactive fault parameter editing
Enhanced map2loop tool dialogs to accept and use debug_manager for parameter logging and layer export

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 63 comments.

Show a summary per file

File	Description
loopstructural/debug_manager.py	New debug manager with session directories, parameter logging, and layer export
loopstructural/toolbelt/preferences.py	Added debug_directory setting and logging configuration
loopstructural/main/model_manager.py	Converted to Observable, added notification suspension and feature update methods
loopstructural/gui/dlg_settings.py	Added debug directory UI controls
loopstructural/plugin_main.py	Integrated debug_manager and added fault topology action
loopstructural/main/m2l_api.py	Added debug_manager parameter to map2loop API functions
loopstructural/gui/modelling/geological_model_tab/feature_details_panel.py	Implemented debounced rebuilds and fault parameter controls
loopstructural/gui/visualisation/feature_list_widget.py	Added model update observers and surface re-rendering
loopstructural/gui/map2loop_tools/*.py	Added debug manager integration to all map2loop tool widgets
loopstructural/main/debug/export.py	New debug package export utility
tests/qgis/test_plg_preferences.py	Added tests for debug_directory setting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-14T23:11:46Z

+from loopstructural.main.debug import export



Unused import. The 'export' module is imported but never used. Remove this import or use the export functionality.
Suggested change
from loopstructural.main.debug import export

Copilot · 2026-01-14T23:11:47Z

- if unit_name_field and unit_name_field != 'UNITNAME' and unit_name_field in geology_gdf.columns:
+ if (
+ unit_name_field
+ and unit_name_field != unit_name_field


The condition 'unit_name_field != unit_name_field' is always False. This appears to be a copy-paste error and will cause the code block to never execute. This condition should likely compare unit_name_field against 'UNITNAME' or another constant.
Suggested change
and unit_name_field != unit_name_field

Copilot · 2026-01-14T23:12:02Z

+ payload = params if params is not None else self.get_parameters()
+ payload = self._serialize_params_for_logging(payload, context_label)
+ self._debug.log_params(context_label=context_label, params=payload)
+ except Exception:


'except' clause does nothing but pass and there is no explanatory comment.

Copilot · 2026-01-14T23:12:02Z

+ if getattr(self, "_debug", None):
+ try:
+ self._debug.log_params(context_label=context_label, params=params)
+ except Exception:


'except' clause does nothing but pass and there is no explanatory comment.

Copilot · 2026-01-14T23:12:02Z

+ logger.debug(f"Removed existing mesh: {mesh_name}")
+ except Exception:
+ logger.debug(f"Failed to remove existing mesh: {mesh_name}")
+ pass


Unnecessary 'pass' statement.

Copilot · 2026-01-14T23:12:02Z

+ except Exception as e:
+ print("Failed to save sampler debug info")
+ print(e)
+ pass


Unnecessary 'pass' statement.

lachlangrose · 2026-01-14T23:03:49Z

No description provided.

Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

Copilot

Pull request overview

This PR introduces a comprehensive upgrade to the fault feature panel and debugging capabilities for the LoopStructural QGIS plugin. The changes add debug directory management, parameter logging for map2loop tools, and UI improvements to enable interactive fault parameter editing with live model updates.

Changes:

Added debug manager infrastructure with configurable debug directory and automatic logging/export of tool parameters and layers
Implemented Observable pattern for model updates and added debounced rebuilds for interactive fault parameter editing
Enhanced map2loop tool dialogs to accept and use debug_manager for parameter logging and layer export

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 63 comments.

Show a summary per file

File	Description
loopstructural/debug_manager.py	New debug manager with session directories, parameter logging, and layer export
loopstructural/toolbelt/preferences.py	Added debug_directory setting and logging configuration
loopstructural/main/model_manager.py	Converted to Observable, added notification suspension and feature update methods
loopstructural/gui/dlg_settings.py	Added debug directory UI controls
loopstructural/plugin_main.py	Integrated debug_manager and added fault topology action
loopstructural/main/m2l_api.py	Added debug_manager parameter to map2loop API functions
loopstructural/gui/modelling/geological_model_tab/feature_details_panel.py	Implemented debounced rebuilds and fault parameter controls
loopstructural/gui/visualisation/feature_list_widget.py	Added model update observers and surface re-rendering
loopstructural/gui/map2loop_tools/*.py	Added debug manager integration to all map2loop tool widgets
loopstructural/main/debug/export.py	New debug package export utility
tests/qgis/test_plg_preferences.py	Added tests for debug_directory setting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-14T23:11:46Z

+from loopstructural.main.debug import export



Unused import. The 'export' module is imported but never used. Remove this import or use the export functionality.
Suggested change
from loopstructural.main.debug import export

Copilot · 2026-01-14T23:11:47Z

- if unit_name_field and unit_name_field != 'UNITNAME' and unit_name_field in geology_gdf.columns:
+ if (
+ unit_name_field
+ and unit_name_field != unit_name_field


The condition 'unit_name_field != unit_name_field' is always False. This appears to be a copy-paste error and will cause the code block to never execute. This condition should likely compare unit_name_field against 'UNITNAME' or another constant.
Suggested change
and unit_name_field != unit_name_field

Copilot · 2026-01-14T23:12:02Z

+ payload = params if params is not None else self.get_parameters()
+ payload = self._serialize_params_for_logging(payload, context_label)
+ self._debug.log_params(context_label=context_label, params=payload)
+ except Exception:


'except' clause does nothing but pass and there is no explanatory comment.

Copilot · 2026-01-14T23:12:02Z

+ if getattr(self, "_debug", None):
+ try:
+ self._debug.log_params(context_label=context_label, params=params)
+ except Exception:


'except' clause does nothing but pass and there is no explanatory comment.

Copilot · 2026-01-14T23:12:02Z

+ logger.debug(f"Removed existing mesh: {mesh_name}")
+ except Exception:
+ logger.debug(f"Failed to remove existing mesh: {mesh_name}")
+ pass


Unnecessary 'pass' statement.

Copilot · 2026-01-14T23:12:02Z

+ except Exception as e:
+ print("Failed to save sampler debug info")
+ print(e)
+ pass


Unnecessary 'pass' statement.

lachlangrose · 2026-01-14T23:03:49Z

No description provided.

Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

Copilot

Pull request overview

This PR introduces a comprehensive upgrade to the fault feature panel and debugging capabilities for the LoopStructural QGIS plugin. The changes add debug directory management, parameter logging for map2loop tools, and UI improvements to enable interactive fault parameter editing with live model updates.

Changes:

Added debug manager infrastructure with configurable debug directory and automatic logging/export of tool parameters and layers
Implemented Observable pattern for model updates and added debounced rebuilds for interactive fault parameter editing
Enhanced map2loop tool dialogs to accept and use debug_manager for parameter logging and layer export

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 63 comments.

Show a summary per file

File	Description
loopstructural/debug_manager.py	New debug manager with session directories, parameter logging, and layer export
loopstructural/toolbelt/preferences.py	Added debug_directory setting and logging configuration
loopstructural/main/model_manager.py	Converted to Observable, added notification suspension and feature update methods
loopstructural/gui/dlg_settings.py	Added debug directory UI controls
loopstructural/plugin_main.py	Integrated debug_manager and added fault topology action
loopstructural/main/m2l_api.py	Added debug_manager parameter to map2loop API functions
loopstructural/gui/modelling/geological_model_tab/feature_details_panel.py	Implemented debounced rebuilds and fault parameter controls
loopstructural/gui/visualisation/feature_list_widget.py	Added model update observers and surface re-rendering
loopstructural/gui/map2loop_tools/*.py	Added debug manager integration to all map2loop tool widgets
loopstructural/main/debug/export.py	New debug package export utility
tests/qgis/test_plg_preferences.py	Added tests for debug_directory setting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-14T23:11:46Z

+from loopstructural.main.debug import export



Unused import. The 'export' module is imported but never used. Remove this import or use the export functionality.
Suggested change
from loopstructural.main.debug import export

Copilot · 2026-01-14T23:11:47Z

- if unit_name_field and unit_name_field != 'UNITNAME' and unit_name_field in geology_gdf.columns:
+ if (
+ unit_name_field
+ and unit_name_field != unit_name_field


The condition 'unit_name_field != unit_name_field' is always False. This appears to be a copy-paste error and will cause the code block to never execute. This condition should likely compare unit_name_field against 'UNITNAME' or another constant.
Suggested change
and unit_name_field != unit_name_field

Copilot · 2026-01-14T23:12:02Z

+ payload = params if params is not None else self.get_parameters()
+ payload = self._serialize_params_for_logging(payload, context_label)
+ self._debug.log_params(context_label=context_label, params=payload)
+ except Exception:


'except' clause does nothing but pass and there is no explanatory comment.

Copilot · 2026-01-14T23:12:02Z

+ if getattr(self, "_debug", None):
+ try:
+ self._debug.log_params(context_label=context_label, params=params)
+ except Exception:


'except' clause does nothing but pass and there is no explanatory comment.

Copilot · 2026-01-14T23:12:02Z

+ logger.debug(f"Removed existing mesh: {mesh_name}")
+ except Exception:
+ logger.debug(f"Failed to remove existing mesh: {mesh_name}")
+ pass


Unnecessary 'pass' statement.

Copilot · 2026-01-14T23:12:02Z

+ except Exception as e:
+ print("Failed to save sampler debug info")
+ print(e)
+ pass


Unnecessary 'pass' statement.

lachlangrose · 2026-01-14T23:03:49Z

No description provided.

Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

Copilot

Pull request overview

This PR introduces a comprehensive upgrade to the fault feature panel and debugging capabilities for the LoopStructural QGIS plugin. The changes add debug directory management, parameter logging for map2loop tools, and UI improvements to enable interactive fault parameter editing with live model updates.

Changes:

Added debug manager infrastructure with configurable debug directory and automatic logging/export of tool parameters and layers
Implemented Observable pattern for model updates and added debounced rebuilds for interactive fault parameter editing
Enhanced map2loop tool dialogs to accept and use debug_manager for parameter logging and layer export

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 63 comments.

Show a summary per file

File	Description
loopstructural/debug_manager.py	New debug manager with session directories, parameter logging, and layer export
loopstructural/toolbelt/preferences.py	Added debug_directory setting and logging configuration
loopstructural/main/model_manager.py	Converted to Observable, added notification suspension and feature update methods
loopstructural/gui/dlg_settings.py	Added debug directory UI controls
loopstructural/plugin_main.py	Integrated debug_manager and added fault topology action
loopstructural/main/m2l_api.py	Added debug_manager parameter to map2loop API functions
loopstructural/gui/modelling/geological_model_tab/feature_details_panel.py	Implemented debounced rebuilds and fault parameter controls
loopstructural/gui/visualisation/feature_list_widget.py	Added model update observers and surface re-rendering
loopstructural/gui/map2loop_tools/*.py	Added debug manager integration to all map2loop tool widgets
loopstructural/main/debug/export.py	New debug package export utility
tests/qgis/test_plg_preferences.py	Added tests for debug_directory setting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-14T23:11:46Z

+from loopstructural.main.debug import export



Unused import. The 'export' module is imported but never used. Remove this import or use the export functionality.
Suggested change
from loopstructural.main.debug import export

Copilot · 2026-01-14T23:11:47Z

- if unit_name_field and unit_name_field != 'UNITNAME' and unit_name_field in geology_gdf.columns:
+ if (
+ unit_name_field
+ and unit_name_field != unit_name_field


The condition 'unit_name_field != unit_name_field' is always False. This appears to be a copy-paste error and will cause the code block to never execute. This condition should likely compare unit_name_field against 'UNITNAME' or another constant.
Suggested change
and unit_name_field != unit_name_field

Copilot · 2026-01-14T23:12:02Z

+ payload = params if params is not None else self.get_parameters()
+ payload = self._serialize_params_for_logging(payload, context_label)
+ self._debug.log_params(context_label=context_label, params=payload)
+ except Exception:


'except' clause does nothing but pass and there is no explanatory comment.

Copilot · 2026-01-14T23:12:02Z

+ if getattr(self, "_debug", None):
+ try:
+ self._debug.log_params(context_label=context_label, params=params)
+ except Exception:


'except' clause does nothing but pass and there is no explanatory comment.

Copilot · 2026-01-14T23:12:02Z

+ logger.debug(f"Removed existing mesh: {mesh_name}")
+ except Exception:
+ logger.debug(f"Failed to remove existing mesh: {mesh_name}")
+ pass


Unnecessary 'pass' statement.

Copilot · 2026-01-14T23:12:02Z

+ except Exception as e:
+ print("Failed to save sampler debug info")
+ print(e)
+ pass


Unnecessary 'pass' statement.

CopilotAIand others added 23 commits December 16, 2025 22:46

Initial plan
ae425a0

feat: add debug manager and directory setting
fc7b8eb
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

chore: refine debug handling and options
dd79214
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

chore: address review follow ups
ff55f3f
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

fix: convert unit_name_field to 'UNITNAME'
351a96a

fix: updating unload to prevent error when missing dock widgets
2ec3fcd

fix: rename unit_name_column to unit_name_field
24cc539

fix: update stratigraphic column with calculated thicknesses
56ceb77

fix: update stratigraphic unit to prevent missing widget error
5fba7c8

style: formatting
4a0ba19

Merge branch 'dev-0.1.12' into copilot/add-structured-logging-feature
752f217

chore: log layer sources in debug params
9148640
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

feat: export layers and add offline runner script
91d94e6
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

fix: give debug manager the logger
e590b19

fix: add generic exporter for m2l objects
c487dec

fix: pass debug manager to api for exporting packages
c74aedc

move export to debug manager
118aecc

adding rebuild with debounce when geometry properties are changed
e74bcc7

call update feature when rebuild is required
75ff03e

adding progress bar when model update is required
7208085

keep track of source feature for meshes
440fd2e

update feature in viewer when it changes
3a22d1a

fix: debug mode changes logging
52cccd1

lachlangrose added enhancement New feature or request UI quality labels Jan 14, 2026

lachlangrose requested a review from Copilot January 14, 2026 23:04

Copilotstarted reviewing on behalf of lachlangrose January 14, 2026 23:05 View session

CopilotAI reviewed Jan 14, 2026
View reviewed changes

adding copilot fixes
37e0319

Merge branch 'dev-0.1.12' into fault-feature-panel-upgrade
cc9a0de

lachlangrose merged commit 1fb1539 into dev-0.1.12Jan 14, 2026
1 check passed

lachlangrose deleted the fault-feature-panel-upgrade branch January 14, 2026 23:59

CopilotAIand others added 23 commits December 16, 2025 22:46

Initial plan
ae425a0

feat: add debug manager and directory setting
fc7b8eb
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

chore: refine debug handling and options
dd79214
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

chore: address review follow ups
ff55f3f
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

fix: convert unit_name_field to 'UNITNAME'
351a96a

fix: updating unload to prevent error when missing dock widgets
2ec3fcd

fix: rename unit_name_column to unit_name_field
24cc539

fix: update stratigraphic column with calculated thicknesses
56ceb77

fix: update stratigraphic unit to prevent missing widget error
5fba7c8

style: formatting
4a0ba19

Merge branch 'dev-0.1.12' into copilot/add-structured-logging-feature
752f217

chore: log layer sources in debug params
9148640
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

feat: export layers and add offline runner script
91d94e6
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

fix: give debug manager the logger
e590b19

fix: add generic exporter for m2l objects
c487dec

fix: pass debug manager to api for exporting packages
c74aedc

move export to debug manager
118aecc

adding rebuild with debounce when geometry properties are changed
e74bcc7

call update feature when rebuild is required
75ff03e

adding progress bar when model update is required
7208085

keep track of source feature for meshes
440fd2e

update feature in viewer when it changes
3a22d1a

fix: debug mode changes logging
52cccd1

lachlangrose added enhancement New feature or request UI quality labels Jan 14, 2026

lachlangrose requested a review from Copilot January 14, 2026 23:04

Copilotstarted reviewing on behalf of lachlangrose January 14, 2026 23:05 View session

CopilotAI reviewed Jan 14, 2026
View reviewed changes

adding copilot fixes
37e0319

Merge branch 'dev-0.1.12' into fault-feature-panel-upgrade
cc9a0de

lachlangrose merged commit 1fb1539 into dev-0.1.12Jan 14, 2026
1 check passed

lachlangrose deleted the fault-feature-panel-upgrade branch January 14, 2026 23:59

CopilotAIand others added 23 commits December 16, 2025 22:46

Initial plan
ae425a0

feat: add debug manager and directory setting
fc7b8eb
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

chore: refine debug handling and options
dd79214
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

chore: address review follow ups
ff55f3f
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

fix: convert unit_name_field to 'UNITNAME'
351a96a

fix: updating unload to prevent error when missing dock widgets
2ec3fcd

fix: rename unit_name_column to unit_name_field
24cc539

fix: update stratigraphic column with calculated thicknesses
56ceb77

fix: update stratigraphic unit to prevent missing widget error
5fba7c8

style: formatting
4a0ba19

Merge branch 'dev-0.1.12' into copilot/add-structured-logging-feature
752f217

chore: log layer sources in debug params
9148640
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

feat: export layers and add offline runner script
91d94e6
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

fix: give debug manager the logger
e590b19

fix: add generic exporter for m2l objects
c487dec

fix: pass debug manager to api for exporting packages
c74aedc

move export to debug manager
118aecc

adding rebuild with debounce when geometry properties are changed
e74bcc7

call update feature when rebuild is required
75ff03e

adding progress bar when model update is required
7208085

keep track of source feature for meshes
440fd2e

update feature in viewer when it changes
3a22d1a

fix: debug mode changes logging
52cccd1

lachlangrose added enhancement New feature or request UI quality labels Jan 14, 2026

lachlangrose requested a review from Copilot January 14, 2026 23:04

Copilotstarted reviewing on behalf of lachlangrose January 14, 2026 23:05 View session

CopilotAI reviewed Jan 14, 2026
View reviewed changes

adding copilot fixes
37e0319

Merge branch 'dev-0.1.12' into fault-feature-panel-upgrade
cc9a0de

lachlangrose merged commit 1fb1539 into dev-0.1.12Jan 14, 2026
1 check passed

lachlangrose deleted the fault-feature-panel-upgrade branch January 14, 2026 23:59

CopilotAIand others added 23 commits December 16, 2025 22:46

Initial plan
ae425a0

feat: add debug manager and directory setting
fc7b8eb
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

chore: refine debug handling and options
dd79214
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

chore: address review follow ups
ff55f3f
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

fix: convert unit_name_field to 'UNITNAME'
351a96a

fix: updating unload to prevent error when missing dock widgets
2ec3fcd

fix: rename unit_name_column to unit_name_field
24cc539

fix: update stratigraphic column with calculated thicknesses
56ceb77

fix: update stratigraphic unit to prevent missing widget error
5fba7c8

style: formatting
4a0ba19

Merge branch 'dev-0.1.12' into copilot/add-structured-logging-feature
752f217

chore: log layer sources in debug params
9148640
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

feat: export layers and add offline runner script
91d94e6
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

fix: give debug manager the logger
e590b19

fix: add generic exporter for m2l objects
c487dec

fix: pass debug manager to api for exporting packages
c74aedc

move export to debug manager
118aecc

adding rebuild with debounce when geometry properties are changed
e74bcc7

call update feature when rebuild is required
75ff03e

adding progress bar when model update is required
7208085

keep track of source feature for meshes
440fd2e

update feature in viewer when it changes
3a22d1a

fix: debug mode changes logging
52cccd1

lachlangrose added enhancement New feature or request UI quality labels Jan 14, 2026

lachlangrose requested a review from Copilot January 14, 2026 23:04

Copilotstarted reviewing on behalf of lachlangrose January 14, 2026 23:05 View session

CopilotAI reviewed Jan 14, 2026
View reviewed changes

adding copilot fixes
37e0319

Merge branch 'dev-0.1.12' into fault-feature-panel-upgrade
cc9a0de

lachlangrose merged commit 1fb1539 into dev-0.1.12Jan 14, 2026
1 check passed

lachlangrose deleted the fault-feature-panel-upgrade branch January 14, 2026 23:59

CopilotAIand others added 23 commits December 16, 2025 22:46

Initial plan
ae425a0

feat: add debug manager and directory setting
fc7b8eb
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

chore: refine debug handling and options
dd79214
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

chore: address review follow ups
ff55f3f
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

fix: convert unit_name_field to 'UNITNAME'
351a96a

fix: updating unload to prevent error when missing dock widgets
2ec3fcd

fix: rename unit_name_column to unit_name_field
24cc539

fix: update stratigraphic column with calculated thicknesses
56ceb77

fix: update stratigraphic unit to prevent missing widget error
5fba7c8

style: formatting
4a0ba19

Merge branch 'dev-0.1.12' into copilot/add-structured-logging-feature
752f217

chore: log layer sources in debug params
9148640
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

feat: export layers and add offline runner script
91d94e6
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

fix: give debug manager the logger
e590b19

fix: add generic exporter for m2l objects
c487dec

fix: pass debug manager to api for exporting packages
c74aedc

move export to debug manager
118aecc

adding rebuild with debounce when geometry properties are changed
e74bcc7

call update feature when rebuild is required
75ff03e

adding progress bar when model update is required
7208085

keep track of source feature for meshes
440fd2e

update feature in viewer when it changes
3a22d1a

fix: debug mode changes logging
52cccd1

lachlangrose added enhancement New feature or request UI quality labels Jan 14, 2026

lachlangrose requested a review from Copilot January 14, 2026 23:04

Copilotstarted reviewing on behalf of lachlangrose January 14, 2026 23:05 View session

CopilotAI reviewed Jan 14, 2026
View reviewed changes

adding copilot fixes
37e0319

Merge branch 'dev-0.1.12' into fault-feature-panel-upgrade
cc9a0de

lachlangrose merged commit 1fb1539 into dev-0.1.12Jan 14, 2026
1 check passed

lachlangrose deleted the fault-feature-panel-upgrade branch January 14, 2026 23:59

CopilotAIand others added 23 commits December 16, 2025 22:46

Initial plan
ae425a0

feat: add debug manager and directory setting
fc7b8eb
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

chore: refine debug handling and options
dd79214
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

chore: address review follow ups
ff55f3f
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

fix: convert unit_name_field to 'UNITNAME'
351a96a

fix: updating unload to prevent error when missing dock widgets
2ec3fcd

fix: rename unit_name_column to unit_name_field
24cc539

fix: update stratigraphic column with calculated thicknesses
56ceb77

fix: update stratigraphic unit to prevent missing widget error
5fba7c8

style: formatting
4a0ba19

Merge branch 'dev-0.1.12' into copilot/add-structured-logging-feature
752f217

chore: log layer sources in debug params
9148640
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

feat: export layers and add offline runner script
91d94e6
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

fix: give debug manager the logger
e590b19

fix: add generic exporter for m2l objects
c487dec

fix: pass debug manager to api for exporting packages
c74aedc

move export to debug manager
118aecc

adding rebuild with debounce when geometry properties are changed
e74bcc7

call update feature when rebuild is required
75ff03e

adding progress bar when model update is required
7208085

keep track of source feature for meshes
440fd2e

update feature in viewer when it changes
3a22d1a

fix: debug mode changes logging
52cccd1

lachlangrose added enhancement New feature or request UI quality labels Jan 14, 2026

lachlangrose requested a review from Copilot January 14, 2026 23:04

Copilotstarted reviewing on behalf of lachlangrose January 14, 2026 23:05 View session

CopilotAI reviewed Jan 14, 2026
View reviewed changes

adding copilot fixes
37e0319

Merge branch 'dev-0.1.12' into fault-feature-panel-upgrade
cc9a0de

lachlangrose merged commit 1fb1539 into dev-0.1.12Jan 14, 2026
1 check passed

lachlangrose deleted the fault-feature-panel-upgrade branch January 14, 2026 23:59

CopilotAIand others added 23 commits December 16, 2025 22:46

Initial plan
ae425a0

feat: add debug manager and directory setting
fc7b8eb
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

chore: refine debug handling and options
dd79214
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

chore: address review follow ups
ff55f3f
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

fix: convert unit_name_field to 'UNITNAME'
351a96a

fix: updating unload to prevent error when missing dock widgets
2ec3fcd

fix: rename unit_name_column to unit_name_field
24cc539

fix: update stratigraphic column with calculated thicknesses
56ceb77

fix: update stratigraphic unit to prevent missing widget error
5fba7c8

style: formatting
4a0ba19

Merge branch 'dev-0.1.12' into copilot/add-structured-logging-feature
752f217

chore: log layer sources in debug params
9148640
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

feat: export layers and add offline runner script
91d94e6
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

fix: give debug manager the logger
e590b19

fix: add generic exporter for m2l objects
c487dec

fix: pass debug manager to api for exporting packages
c74aedc

move export to debug manager
118aecc

adding rebuild with debounce when geometry properties are changed
e74bcc7

call update feature when rebuild is required
75ff03e

adding progress bar when model update is required
7208085

keep track of source feature for meshes
440fd2e

update feature in viewer when it changes
3a22d1a

fix: debug mode changes logging
52cccd1

lachlangrose added enhancement New feature or request UI quality labels Jan 14, 2026

lachlangrose requested a review from Copilot January 14, 2026 23:04

Copilotstarted reviewing on behalf of lachlangrose January 14, 2026 23:05 View session

CopilotAI reviewed Jan 14, 2026
View reviewed changes

adding copilot fixes
37e0319

Merge branch 'dev-0.1.12' into fault-feature-panel-upgrade
cc9a0de

lachlangrose merged commit 1fb1539 into dev-0.1.12Jan 14, 2026
1 check passed

lachlangrose deleted the fault-feature-panel-upgrade branch January 14, 2026 23:59

CopilotAIand others added 23 commits December 16, 2025 22:46

Initial plan
ae425a0

feat: add debug manager and directory setting
fc7b8eb
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

chore: refine debug handling and options
dd79214
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

chore: address review follow ups
ff55f3f
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

fix: convert unit_name_field to 'UNITNAME'
351a96a

fix: updating unload to prevent error when missing dock widgets
2ec3fcd

fix: rename unit_name_column to unit_name_field
24cc539

fix: update stratigraphic column with calculated thicknesses
56ceb77

fix: update stratigraphic unit to prevent missing widget error
5fba7c8

style: formatting
4a0ba19

Merge branch 'dev-0.1.12' into copilot/add-structured-logging-feature
752f217

chore: log layer sources in debug params
9148640
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

feat: export layers and add offline runner script
91d94e6
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>

fix: give debug manager the logger
e590b19

fix: add generic exporter for m2l objects
c487dec

fix: pass debug manager to api for exporting packages
c74aedc

move export to debug manager
118aecc

adding rebuild with debounce when geometry properties are changed
e74bcc7

call update feature when rebuild is required
75ff03e

adding progress bar when model update is required
7208085

keep track of source feature for meshes
440fd2e

update feature in viewer when it changes
3a22d1a

fix: debug mode changes logging
52cccd1

lachlangrose added enhancement New feature or request UI quality labels Jan 14, 2026

lachlangrose requested a review from Copilot January 14, 2026 23:04

Copilotstarted reviewing on behalf of lachlangrose January 14, 2026 23:05 View session

CopilotAI reviewed Jan 14, 2026
View reviewed changes

adding copilot fixes
37e0319

Merge branch 'dev-0.1.12' into fault-feature-panel-upgrade
cc9a0de

lachlangrose merged commit 1fb1539 into dev-0.1.12Jan 14, 2026
1 check passed

lachlangrose deleted the fault-feature-panel-upgrade branch January 14, 2026 23:59

Uh oh!

Conversation

lachlangrose commented Jan 14, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

CopilotAIJan 14, 2026

Choose a reason for hiding this comment

Uh oh!

CopilotAIJan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CopilotAIJan 14, 2026

Choose a reason for hiding this comment

Uh oh!

CopilotAIJan 14, 2026

Choose a reason for hiding this comment

Uh oh!

CopilotAIJan 14, 2026

Choose a reason for hiding this comment

Uh oh!

CopilotAIJan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

lachlangrose commented Jan 14, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

CopilotAIJan 14, 2026

Choose a reason for hiding this comment

Uh oh!

CopilotAIJan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CopilotAIJan 14, 2026

Choose a reason for hiding this comment

Uh oh!

CopilotAIJan 14, 2026

Choose a reason for hiding this comment

Uh oh!

CopilotAIJan 14, 2026

Choose a reason for hiding this comment

Uh oh!

CopilotAIJan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants