Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,6 +150,26 @@ def initialize_model(self):
"Please set the bounding box before initializing the model.",
)
return

# Validate model CRS
if not self.data_manager.is_model_crs_valid():
crs = self.data_manager.get_model_crs()
if crs is None or not crs.isValid():
msg = "Model CRS is not set or invalid. Please select a valid projected CRS in the Model Definition tab."
else:
# Safely get CRS description
try:
crs_desc = crs.description() or crs.authid() or "Unknown"
except Exception:
crs_desc = crs.authid() if hasattr(crs, 'authid') else "Unknown"
msg = f"Model CRS must be projected (in meters), not geographic.\nSelected CRS: {crs_desc}\n\nPlease select a valid projected CRS in the Model Definition tab."

QMessageBox.critical(
self,
"Invalid Model CRS",
msg,
)
return

# create progress dialog (indeterminate)
progress = QProgressDialog("Updating geological model...", "Cancel", 0, 0, self)
Expand Down
142 changes: 142 additions & 0 deletions loopstructural/gui/modelling/model_definition/bounding_box.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@

import numpy as np
from PyQt5.QtWidgets import QWidget
from qgis.core import QgsProject
from qgis.PyQt import uic

from loopstructural.main.data_manager import default_bounding_box
Expand All@@ -13,6 +14,8 @@ def __init__(self, parent=None, data_manager=None):
super().__init__(parent)
ui_path = os.path.join(os.path.dirname(__file__), "bounding_box.ui")
uic.loadUi(ui_path, self)

# Connect bounding box spinbox signals
self.originXSpinBox.valueChanged.connect(lambda x: self.onChangeExtent({'xmin': x}))
self.maxXSpinBox.valueChanged.connect(lambda x: self.onChangeExtent({'xmax': x}))
self.originYSpinBox.valueChanged.connect(lambda y: self.onChangeExtent({'ymin': y}))
Expand All@@ -21,9 +24,148 @@ def __init__(self, parent=None, data_manager=None):
self.maxZSpinBox.valueChanged.connect(lambda z: self.onChangeExtent({'zmax': z}))
self.useCurrentViewExtentButton.clicked.connect(self.useCurrentViewExtent)
self.selectFromCurrentLayerButton.clicked.connect(self.selectFromCurrentLayer)

# Connect CRS control signals
self.useProjectCrsRadioButton.toggled.connect(self.onCrsSourceChanged)
self.useCustomCrsRadioButton.toggled.connect(self.onCrsSourceChanged)
self.crsSelector.crsChanged.connect(self.onCrsChanged)

# Set up callbacks
self.data_manager.set_bounding_box_update_callback(self.set_bounding_box)
self.data_manager.set_model_crs_callback(self.update_crs_ui)

# Initialize CRS UI
self.initialize_crs_ui()
self._update_bounding_box_styles()

# Connect to project CRS changes so the widget updates when the project's CRS changes
try:
project = getattr(self.data_manager, 'project', None) or QgsProject.instance()
project.crsChanged.connect(self._onProjectCrsChanged)
except Exception:
# If the signal isn't available or connection fails, ignore to keep widget functional
pass

def initialize_crs_ui(self):
"""Initialize CRS controls with current settings."""
# Set initial CRS selector value
crs = self.data_manager.get_model_crs()
if crs is not None and crs.isValid():
self.crsSelector.setCrs(crs)
else:
# Default to project CRS
self.crsSelector.setCrs(self.data_manager.project.crs())

# Set radio button based on use_project_crs setting
if self.data_manager._use_project_crs:
self.useProjectCrsRadioButton.setChecked(True)
else:
self.useCustomCrsRadioButton.setChecked(True)

self.validate_crs()

def onCrsSourceChanged(self):
"""Handle change in CRS source (project vs custom)."""
use_project_crs = self.useProjectCrsRadioButton.isChecked()
self.crsSelector.setEnabled(not use_project_crs)

if use_project_crs:
# Use project CRS
success, msg = self.data_manager.set_model_crs(None, use_project_crs=True)
else:
# Use custom CRS
crs = self.crsSelector.crs()
success, msg = self.data_manager.set_model_crs(crs, use_project_crs=False)

self.validate_crs()

def onCrsChanged(self):
"""Handle change in custom CRS selection."""
if self.useCustomCrsRadioButton.isChecked():
crs = self.crsSelector.crs()
success, msg = self.data_manager.set_model_crs(crs, use_project_crs=False)
self.validate_crs()

def update_crs_ui(self, crs, use_project_crs):
"""Update UI when model CRS changes externally.

Parameters
----------
crs : QgsCoordinateReferenceSystem or None
The new model CRS
use_project_crs : bool
Whether to use project CRS
"""
# Block signals to avoid recursive updates
self.useProjectCrsRadioButton.blockSignals(True)
self.useCustomCrsRadioButton.blockSignals(True)
self.crsSelector.blockSignals(True)

try:
if use_project_crs:
self.useProjectCrsRadioButton.setChecked(True)
self.crsSelector.setEnabled(False)
self.crsSelector.setCrs(crs)

else:
self.useCustomCrsRadioButton.setChecked(True)
self.crsSelector.setEnabled(True)
if crs is not None and crs.isValid():
self.crsSelector.setCrs(crs)

self.validate_crs()
finally:
# Unblock signals
self.useProjectCrsRadioButton.blockSignals(False)
self.useCustomCrsRadioButton.blockSignals(False)
self.crsSelector.blockSignals(False)

def _onProjectCrsChanged(self, crs=None):
"""Handle project CRS changes and update UI when the widget is using the project CRS.

Accept an optional `crs` argument because different QGIS versions may emit the
new CRS or emit no arguments when the project's CRS changes.
"""
# If the signal didn't provide a CRS, try to obtain it from the project's current CRS
if crs is None:
try:
project = getattr(self.data_manager, 'project', None) or QgsProject.instance()
crs = project.crs()
except Exception:
crs = None

# Only update the UI if the model is configured to use the project CRS
try:
if getattr(self.data_manager, '_use_project_crs', False):
# Update the UI to reflect the new project CRS
self.update_crs_ui(crs, use_project_crs=True)
except Exception:
pass

def validate_crs(self):
"""Validate the selected CRS and update warning label."""
crs = self.data_manager.get_model_crs()

if crs is None or not crs.isValid():
self.crsWarningLabel.setText("⚠ Invalid CRS selected. Model cannot be initialized.")
return False

if crs.isGeographic():
# Safely get CRS description
try:
crs_desc = crs.description() or crs.authid() or "Unknown"
except Exception:
crs_desc = crs.authid() if hasattr(crs, 'authid') else "Unknown"

self.crsWarningLabel.setText(
f"⚠ CRS must be projected (in meters), not geographic.\n" f"Selected: {crs_desc}"
)
return False

# CRS is valid and projected
self.crsWarningLabel.setText("")
return True

def set_bounding_box(self, bounding_box):
"""Populate UI controls with values from a BoundingBox object.

Expand Down
53 changes: 53 additions & 0 deletions loopstructural/gui/modelling/model_definition/bounding_box.ui
Original file line numberDiff line numberDiff line change
Expand Up@@ -162,6 +162,52 @@
</item>
</layout>
</item>
<item>
<widget class="QGroupBox" name="crsGroupBox">
<property name="title">
<string>Coordinate Reference System (CRS)</string>
</property>
<layout class="QVBoxLayout" name="crsVerticalLayout">
<item>
<widget class="QRadioButton" name="useProjectCrsRadioButton">
<property name="text">
<string>Use Project CRS</string>
</property>
<property name="checked">
<bool>true</bool>
</property>
</widget>
</item>
<item>
<widget class="QRadioButton" name="useCustomCrsRadioButton">
<property name="text">
<string>Use Custom CRS</string>
</property>
</widget>
</item>
<item>
<widget class="QgsProjectionSelectionWidget" name="crsSelector">
<property name="enabled">
<bool>false</bool>
</property>
</widget>
</item>
<item>
<widget class="QLabel" name="crsWarningLabel">
<property name="text">
<string/>
</property>
<property name="wordWrap">
<bool>true</bool>
</property>
<property name="styleSheet">
<string>color: red; font-weight: bold;</string>
</property>
</widget>
</item>
</layout>
</widget>
</item>
<item>
<widget class="QPushButton" name="selectFromCurrentLayerButton">
<property name="text">
Expand All@@ -185,6 +231,13 @@
</item>
</layout>
</widget>
<customwidgets>
<customwidget>
<class>QgsProjectionSelectionWidget</class>
<extends>QWidget</extends>
<header>qgis.gui</header>
</customwidget>
</customwidgets>
<resources/>
<connections/>
</ui>
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,6 +150,26 @@ def initialize_model(self):
"Please set the bounding box before initializing the model.",
)
return

# Validate model CRS
if not self.data_manager.is_model_crs_valid():
crs = self.data_manager.get_model_crs()
if crs is None or not crs.isValid():
msg = "Model CRS is not set or invalid. Please select a valid projected CRS in the Model Definition tab."
else:
# Safely get CRS description
try:
crs_desc = crs.description() or crs.authid() or "Unknown"
except Exception:
crs_desc = crs.authid() if hasattr(crs, 'authid') else "Unknown"
msg = f"Model CRS must be projected (in meters), not geographic.\nSelected CRS: {crs_desc}\n\nPlease select a valid projected CRS in the Model Definition tab."

QMessageBox.critical(
self,
"Invalid Model CRS",
msg,
)
return

# create progress dialog (indeterminate)
progress = QProgressDialog("Updating geological model...", "Cancel", 0, 0, self)
Expand Down
142 changes: 142 additions & 0 deletions loopstructural/gui/modelling/model_definition/bounding_box.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@

import numpy as np
from PyQt5.QtWidgets import QWidget
from qgis.core import QgsProject
from qgis.PyQt import uic

from loopstructural.main.data_manager import default_bounding_box
Expand All@@ -13,6 +14,8 @@ def __init__(self, parent=None, data_manager=None):
super().__init__(parent)
ui_path = os.path.join(os.path.dirname(__file__), "bounding_box.ui")
uic.loadUi(ui_path, self)

# Connect bounding box spinbox signals
self.originXSpinBox.valueChanged.connect(lambda x: self.onChangeExtent({'xmin': x}))
self.maxXSpinBox.valueChanged.connect(lambda x: self.onChangeExtent({'xmax': x}))
self.originYSpinBox.valueChanged.connect(lambda y: self.onChangeExtent({'ymin': y}))
Expand All@@ -21,9 +24,148 @@ def __init__(self, parent=None, data_manager=None):
self.maxZSpinBox.valueChanged.connect(lambda z: self.onChangeExtent({'zmax': z}))
self.useCurrentViewExtentButton.clicked.connect(self.useCurrentViewExtent)
self.selectFromCurrentLayerButton.clicked.connect(self.selectFromCurrentLayer)

# Connect CRS control signals
self.useProjectCrsRadioButton.toggled.connect(self.onCrsSourceChanged)
self.useCustomCrsRadioButton.toggled.connect(self.onCrsSourceChanged)
self.crsSelector.crsChanged.connect(self.onCrsChanged)

# Set up callbacks
self.data_manager.set_bounding_box_update_callback(self.set_bounding_box)
self.data_manager.set_model_crs_callback(self.update_crs_ui)

# Initialize CRS UI
self.initialize_crs_ui()
self._update_bounding_box_styles()

# Connect to project CRS changes so the widget updates when the project's CRS changes
try:
project = getattr(self.data_manager, 'project', None) or QgsProject.instance()
project.crsChanged.connect(self._onProjectCrsChanged)
except Exception:
# If the signal isn't available or connection fails, ignore to keep widget functional
pass

def initialize_crs_ui(self):
"""Initialize CRS controls with current settings."""
# Set initial CRS selector value
crs = self.data_manager.get_model_crs()
if crs is not None and crs.isValid():
self.crsSelector.setCrs(crs)
else:
# Default to project CRS
self.crsSelector.setCrs(self.data_manager.project.crs())

# Set radio button based on use_project_crs setting
if self.data_manager._use_project_crs:
self.useProjectCrsRadioButton.setChecked(True)
else:
self.useCustomCrsRadioButton.setChecked(True)

self.validate_crs()

def onCrsSourceChanged(self):
"""Handle change in CRS source (project vs custom)."""
use_project_crs = self.useProjectCrsRadioButton.isChecked()
self.crsSelector.setEnabled(not use_project_crs)

if use_project_crs:
# Use project CRS
success, msg = self.data_manager.set_model_crs(None, use_project_crs=True)
else:
# Use custom CRS
crs = self.crsSelector.crs()
success, msg = self.data_manager.set_model_crs(crs, use_project_crs=False)

self.validate_crs()

def onCrsChanged(self):
"""Handle change in custom CRS selection."""
if self.useCustomCrsRadioButton.isChecked():
crs = self.crsSelector.crs()
success, msg = self.data_manager.set_model_crs(crs, use_project_crs=False)
self.validate_crs()

def update_crs_ui(self, crs, use_project_crs):
"""Update UI when model CRS changes externally.

Parameters
----------
crs : QgsCoordinateReferenceSystem or None
The new model CRS
use_project_crs : bool
Whether to use project CRS
"""
# Block signals to avoid recursive updates
self.useProjectCrsRadioButton.blockSignals(True)
self.useCustomCrsRadioButton.blockSignals(True)
self.crsSelector.blockSignals(True)

try:
if use_project_crs:
self.useProjectCrsRadioButton.setChecked(True)
self.crsSelector.setEnabled(False)
self.crsSelector.setCrs(crs)

else:
self.useCustomCrsRadioButton.setChecked(True)
self.crsSelector.setEnabled(True)
if crs is not None and crs.isValid():
self.crsSelector.setCrs(crs)

self.validate_crs()
finally:
# Unblock signals
self.useProjectCrsRadioButton.blockSignals(False)
self.useCustomCrsRadioButton.blockSignals(False)
self.crsSelector.blockSignals(False)

def _onProjectCrsChanged(self, crs=None):
"""Handle project CRS changes and update UI when the widget is using the project CRS.

Accept an optional `crs` argument because different QGIS versions may emit the
new CRS or emit no arguments when the project's CRS changes.
"""
# If the signal didn't provide a CRS, try to obtain it from the project's current CRS
if crs is None:
try:
project = getattr(self.data_manager, 'project', None) or QgsProject.instance()
crs = project.crs()
except Exception:
crs = None

# Only update the UI if the model is configured to use the project CRS
try:
if getattr(self.data_manager, '_use_project_crs', False):
# Update the UI to reflect the new project CRS
self.update_crs_ui(crs, use_project_crs=True)
except Exception:
pass

def validate_crs(self):
"""Validate the selected CRS and update warning label."""
crs = self.data_manager.get_model_crs()

if crs is None or not crs.isValid():
self.crsWarningLabel.setText("⚠ Invalid CRS selected. Model cannot be initialized.")
return False

if crs.isGeographic():
# Safely get CRS description
try:
crs_desc = crs.description() or crs.authid() or "Unknown"
except Exception:
crs_desc = crs.authid() if hasattr(crs, 'authid') else "Unknown"

self.crsWarningLabel.setText(
f"⚠ CRS must be projected (in meters), not geographic.\n" f"Selected: {crs_desc}"
)
return False

# CRS is valid and projected
self.crsWarningLabel.setText("")
return True

def set_bounding_box(self, bounding_box):
"""Populate UI controls with values from a BoundingBox object.

Expand Down
53 changes: 53 additions & 0 deletions loopstructural/gui/modelling/model_definition/bounding_box.ui
Original file line numberDiff line numberDiff line change
Expand Up@@ -162,6 +162,52 @@
</item>
</layout>
</item>
<item>
<widget class="QGroupBox" name="crsGroupBox">
<property name="title">
<string>Coordinate Reference System (CRS)</string>
</property>
<layout class="QVBoxLayout" name="crsVerticalLayout">
<item>
<widget class="QRadioButton" name="useProjectCrsRadioButton">
<property name="text">
<string>Use Project CRS</string>
</property>
<property name="checked">
<bool>true</bool>
</property>
</widget>
</item>
<item>
<widget class="QRadioButton" name="useCustomCrsRadioButton">
<property name="text">
<string>Use Custom CRS</string>
</property>
</widget>
</item>
<item>
<widget class="QgsProjectionSelectionWidget" name="crsSelector">
<property name="enabled">
<bool>false</bool>
</property>
</widget>
</item>
<item>
<widget class="QLabel" name="crsWarningLabel">
<property name="text">
<string/>
</property>
<property name="wordWrap">
<bool>true</bool>
</property>
<property name="styleSheet">
<string>color: red; font-weight: bold;</string>
</property>
</widget>
</item>
</layout>
</widget>
</item>
<item>
<widget class="QPushButton" name="selectFromCurrentLayerButton">
<property name="text">
Expand All@@ -185,6 +231,13 @@
</item>
</layout>
</widget>
<customwidgets>
<customwidget>
<class>QgsProjectionSelectionWidget</class>
<extends>QWidget</extends>
<header>qgis.gui</header>
</customwidget>
</customwidgets>
<resources/>
<connections/>
</ui>
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,6 +150,26 @@ def initialize_model(self):
"Please set the bounding box before initializing the model.",
)
return

# Validate model CRS
if not self.data_manager.is_model_crs_valid():
crs = self.data_manager.get_model_crs()
if crs is None or not crs.isValid():
msg = "Model CRS is not set or invalid. Please select a valid projected CRS in the Model Definition tab."
else:
# Safely get CRS description
try:
crs_desc = crs.description() or crs.authid() or "Unknown"
except Exception:
crs_desc = crs.authid() if hasattr(crs, 'authid') else "Unknown"
msg = f"Model CRS must be projected (in meters), not geographic.\nSelected CRS: {crs_desc}\n\nPlease select a valid projected CRS in the Model Definition tab."

QMessageBox.critical(
self,
"Invalid Model CRS",
msg,
)
return

# create progress dialog (indeterminate)
progress = QProgressDialog("Updating geological model...", "Cancel", 0, 0, self)
Expand Down
142 changes: 142 additions & 0 deletions loopstructural/gui/modelling/model_definition/bounding_box.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@

import numpy as np
from PyQt5.QtWidgets import QWidget
from qgis.core import QgsProject
from qgis.PyQt import uic

from loopstructural.main.data_manager import default_bounding_box
Expand All@@ -13,6 +14,8 @@ def __init__(self, parent=None, data_manager=None):
super().__init__(parent)
ui_path = os.path.join(os.path.dirname(__file__), "bounding_box.ui")
uic.loadUi(ui_path, self)

# Connect bounding box spinbox signals
self.originXSpinBox.valueChanged.connect(lambda x: self.onChangeExtent({'xmin': x}))
self.maxXSpinBox.valueChanged.connect(lambda x: self.onChangeExtent({'xmax': x}))
self.originYSpinBox.valueChanged.connect(lambda y: self.onChangeExtent({'ymin': y}))
Expand All@@ -21,9 +24,148 @@ def __init__(self, parent=None, data_manager=None):
self.maxZSpinBox.valueChanged.connect(lambda z: self.onChangeExtent({'zmax': z}))
self.useCurrentViewExtentButton.clicked.connect(self.useCurrentViewExtent)
self.selectFromCurrentLayerButton.clicked.connect(self.selectFromCurrentLayer)

# Connect CRS control signals
self.useProjectCrsRadioButton.toggled.connect(self.onCrsSourceChanged)
self.useCustomCrsRadioButton.toggled.connect(self.onCrsSourceChanged)
self.crsSelector.crsChanged.connect(self.onCrsChanged)

# Set up callbacks
self.data_manager.set_bounding_box_update_callback(self.set_bounding_box)
self.data_manager.set_model_crs_callback(self.update_crs_ui)

# Initialize CRS UI
self.initialize_crs_ui()
self._update_bounding_box_styles()

# Connect to project CRS changes so the widget updates when the project's CRS changes
try:
project = getattr(self.data_manager, 'project', None) or QgsProject.instance()
project.crsChanged.connect(self._onProjectCrsChanged)
except Exception:
# If the signal isn't available or connection fails, ignore to keep widget functional
pass

def initialize_crs_ui(self):
"""Initialize CRS controls with current settings."""
# Set initial CRS selector value
crs = self.data_manager.get_model_crs()
if crs is not None and crs.isValid():
self.crsSelector.setCrs(crs)
else:
# Default to project CRS
self.crsSelector.setCrs(self.data_manager.project.crs())

# Set radio button based on use_project_crs setting
if self.data_manager._use_project_crs:
self.useProjectCrsRadioButton.setChecked(True)
else:
self.useCustomCrsRadioButton.setChecked(True)

self.validate_crs()

def onCrsSourceChanged(self):
"""Handle change in CRS source (project vs custom)."""
use_project_crs = self.useProjectCrsRadioButton.isChecked()
self.crsSelector.setEnabled(not use_project_crs)

if use_project_crs:
# Use project CRS
success, msg = self.data_manager.set_model_crs(None, use_project_crs=True)
else:
# Use custom CRS
crs = self.crsSelector.crs()
success, msg = self.data_manager.set_model_crs(crs, use_project_crs=False)

self.validate_crs()

def onCrsChanged(self):
"""Handle change in custom CRS selection."""
if self.useCustomCrsRadioButton.isChecked():
crs = self.crsSelector.crs()
success, msg = self.data_manager.set_model_crs(crs, use_project_crs=False)
self.validate_crs()

def update_crs_ui(self, crs, use_project_crs):
"""Update UI when model CRS changes externally.

Parameters
----------
crs : QgsCoordinateReferenceSystem or None
The new model CRS
use_project_crs : bool
Whether to use project CRS
"""
# Block signals to avoid recursive updates
self.useProjectCrsRadioButton.blockSignals(True)
self.useCustomCrsRadioButton.blockSignals(True)
self.crsSelector.blockSignals(True)

try:
if use_project_crs:
self.useProjectCrsRadioButton.setChecked(True)
self.crsSelector.setEnabled(False)
self.crsSelector.setCrs(crs)

else:
self.useCustomCrsRadioButton.setChecked(True)
self.crsSelector.setEnabled(True)
if crs is not None and crs.isValid():
self.crsSelector.setCrs(crs)

self.validate_crs()
finally:
# Unblock signals
self.useProjectCrsRadioButton.blockSignals(False)
self.useCustomCrsRadioButton.blockSignals(False)
self.crsSelector.blockSignals(False)

def _onProjectCrsChanged(self, crs=None):
"""Handle project CRS changes and update UI when the widget is using the project CRS.

Accept an optional `crs` argument because different QGIS versions may emit the
new CRS or emit no arguments when the project's CRS changes.
"""
# If the signal didn't provide a CRS, try to obtain it from the project's current CRS
if crs is None:
try:
project = getattr(self.data_manager, 'project', None) or QgsProject.instance()
crs = project.crs()
except Exception:
crs = None

# Only update the UI if the model is configured to use the project CRS
try:
if getattr(self.data_manager, '_use_project_crs', False):
# Update the UI to reflect the new project CRS
self.update_crs_ui(crs, use_project_crs=True)
except Exception:
pass

def validate_crs(self):
"""Validate the selected CRS and update warning label."""
crs = self.data_manager.get_model_crs()

if crs is None or not crs.isValid():
self.crsWarningLabel.setText("⚠ Invalid CRS selected. Model cannot be initialized.")
return False

if crs.isGeographic():
# Safely get CRS description
try:
crs_desc = crs.description() or crs.authid() or "Unknown"
except Exception:
crs_desc = crs.authid() if hasattr(crs, 'authid') else "Unknown"

self.crsWarningLabel.setText(
f"⚠ CRS must be projected (in meters), not geographic.\n" f"Selected: {crs_desc}"
)
return False

# CRS is valid and projected
self.crsWarningLabel.setText("")
return True

def set_bounding_box(self, bounding_box):
"""Populate UI controls with values from a BoundingBox object.

Expand Down
53 changes: 53 additions & 0 deletions loopstructural/gui/modelling/model_definition/bounding_box.ui
Original file line numberDiff line numberDiff line change
Expand Up@@ -162,6 +162,52 @@
</item>
</layout>
</item>
<item>
<widget class="QGroupBox" name="crsGroupBox">
<property name="title">
<string>Coordinate Reference System (CRS)</string>
</property>
<layout class="QVBoxLayout" name="crsVerticalLayout">
<item>
<widget class="QRadioButton" name="useProjectCrsRadioButton">
<property name="text">
<string>Use Project CRS</string>
</property>
<property name="checked">
<bool>true</bool>
</property>
</widget>
</item>
<item>
<widget class="QRadioButton" name="useCustomCrsRadioButton">
<property name="text">
<string>Use Custom CRS</string>
</property>
</widget>
</item>
<item>
<widget class="QgsProjectionSelectionWidget" name="crsSelector">
<property name="enabled">
<bool>false</bool>
</property>
</widget>
</item>
<item>
<widget class="QLabel" name="crsWarningLabel">
<property name="text">
<string/>
</property>
<property name="wordWrap">
<bool>true</bool>
</property>
<property name="styleSheet">
<string>color: red; font-weight: bold;</string>
</property>
</widget>
</item>
</layout>
</widget>
</item>
<item>
<widget class="QPushButton" name="selectFromCurrentLayerButton">
<property name="text">
Expand All@@ -185,6 +231,13 @@
</item>
</layout>
</widget>
<customwidgets>
<customwidget>
<class>QgsProjectionSelectionWidget</class>
<extends>QWidget</extends>
<header>qgis.gui</header>
</customwidget>
</customwidgets>
<resources/>
<connections/>
</ui>
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,6 +150,26 @@ def initialize_model(self):
"Please set the bounding box before initializing the model.",
)
return

# Validate model CRS
if not self.data_manager.is_model_crs_valid():
crs = self.data_manager.get_model_crs()
if crs is None or not crs.isValid():
msg = "Model CRS is not set or invalid. Please select a valid projected CRS in the Model Definition tab."
else:
# Safely get CRS description
try:
crs_desc = crs.description() or crs.authid() or "Unknown"
except Exception:
crs_desc = crs.authid() if hasattr(crs, 'authid') else "Unknown"
msg = f"Model CRS must be projected (in meters), not geographic.\nSelected CRS: {crs_desc}\n\nPlease select a valid projected CRS in the Model Definition tab."

QMessageBox.critical(
self,
"Invalid Model CRS",
msg,
)
return

# create progress dialog (indeterminate)
progress = QProgressDialog("Updating geological model...", "Cancel", 0, 0, self)
Expand Down
142 changes: 142 additions & 0 deletions loopstructural/gui/modelling/model_definition/bounding_box.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@

import numpy as np
from PyQt5.QtWidgets import QWidget
from qgis.core import QgsProject
from qgis.PyQt import uic

from loopstructural.main.data_manager import default_bounding_box
Expand All@@ -13,6 +14,8 @@ def __init__(self, parent=None, data_manager=None):
super().__init__(parent)
ui_path = os.path.join(os.path.dirname(__file__), "bounding_box.ui")
uic.loadUi(ui_path, self)

# Connect bounding box spinbox signals
self.originXSpinBox.valueChanged.connect(lambda x: self.onChangeExtent({'xmin': x}))
self.maxXSpinBox.valueChanged.connect(lambda x: self.onChangeExtent({'xmax': x}))
self.originYSpinBox.valueChanged.connect(lambda y: self.onChangeExtent({'ymin': y}))
Expand All@@ -21,9 +24,148 @@ def __init__(self, parent=None, data_manager=None):
self.maxZSpinBox.valueChanged.connect(lambda z: self.onChangeExtent({'zmax': z}))
self.useCurrentViewExtentButton.clicked.connect(self.useCurrentViewExtent)
self.selectFromCurrentLayerButton.clicked.connect(self.selectFromCurrentLayer)

# Connect CRS control signals
self.useProjectCrsRadioButton.toggled.connect(self.onCrsSourceChanged)
self.useCustomCrsRadioButton.toggled.connect(self.onCrsSourceChanged)
self.crsSelector.crsChanged.connect(self.onCrsChanged)

# Set up callbacks
self.data_manager.set_bounding_box_update_callback(self.set_bounding_box)
self.data_manager.set_model_crs_callback(self.update_crs_ui)

# Initialize CRS UI
self.initialize_crs_ui()
self._update_bounding_box_styles()

# Connect to project CRS changes so the widget updates when the project's CRS changes
try:
project = getattr(self.data_manager, 'project', None) or QgsProject.instance()
project.crsChanged.connect(self._onProjectCrsChanged)
except Exception:
# If the signal isn't available or connection fails, ignore to keep widget functional
pass

def initialize_crs_ui(self):
"""Initialize CRS controls with current settings."""
# Set initial CRS selector value
crs = self.data_manager.get_model_crs()
if crs is not None and crs.isValid():
self.crsSelector.setCrs(crs)
else:
# Default to project CRS
self.crsSelector.setCrs(self.data_manager.project.crs())

# Set radio button based on use_project_crs setting
if self.data_manager._use_project_crs:
self.useProjectCrsRadioButton.setChecked(True)
else:
self.useCustomCrsRadioButton.setChecked(True)

self.validate_crs()

def onCrsSourceChanged(self):
"""Handle change in CRS source (project vs custom)."""
use_project_crs = self.useProjectCrsRadioButton.isChecked()
self.crsSelector.setEnabled(not use_project_crs)

if use_project_crs:
# Use project CRS
success, msg = self.data_manager.set_model_crs(None, use_project_crs=True)
else:
# Use custom CRS
crs = self.crsSelector.crs()
success, msg = self.data_manager.set_model_crs(crs, use_project_crs=False)

self.validate_crs()

def onCrsChanged(self):
"""Handle change in custom CRS selection."""
if self.useCustomCrsRadioButton.isChecked():
crs = self.crsSelector.crs()
success, msg = self.data_manager.set_model_crs(crs, use_project_crs=False)
self.validate_crs()

def update_crs_ui(self, crs, use_project_crs):
"""Update UI when model CRS changes externally.

Parameters
----------
crs : QgsCoordinateReferenceSystem or None
The new model CRS
use_project_crs : bool
Whether to use project CRS
"""
# Block signals to avoid recursive updates
self.useProjectCrsRadioButton.blockSignals(True)
self.useCustomCrsRadioButton.blockSignals(True)
self.crsSelector.blockSignals(True)

try:
if use_project_crs:
self.useProjectCrsRadioButton.setChecked(True)
self.crsSelector.setEnabled(False)
self.crsSelector.setCrs(crs)

else:
self.useCustomCrsRadioButton.setChecked(True)
self.crsSelector.setEnabled(True)
if crs is not None and crs.isValid():
self.crsSelector.setCrs(crs)

self.validate_crs()
finally:
# Unblock signals
self.useProjectCrsRadioButton.blockSignals(False)
self.useCustomCrsRadioButton.blockSignals(False)
self.crsSelector.blockSignals(False)

def _onProjectCrsChanged(self, crs=None):
"""Handle project CRS changes and update UI when the widget is using the project CRS.

Accept an optional `crs` argument because different QGIS versions may emit the
new CRS or emit no arguments when the project's CRS changes.
"""
# If the signal didn't provide a CRS, try to obtain it from the project's current CRS
if crs is None:
try:
project = getattr(self.data_manager, 'project', None) or QgsProject.instance()
crs = project.crs()
except Exception:
crs = None

# Only update the UI if the model is configured to use the project CRS
try:
if getattr(self.data_manager, '_use_project_crs', False):
# Update the UI to reflect the new project CRS
self.update_crs_ui(crs, use_project_crs=True)
except Exception:
pass

def validate_crs(self):
"""Validate the selected CRS and update warning label."""
crs = self.data_manager.get_model_crs()

if crs is None or not crs.isValid():
self.crsWarningLabel.setText("⚠ Invalid CRS selected. Model cannot be initialized.")
return False

if crs.isGeographic():
# Safely get CRS description
try:
crs_desc = crs.description() or crs.authid() or "Unknown"
except Exception:
crs_desc = crs.authid() if hasattr(crs, 'authid') else "Unknown"

self.crsWarningLabel.setText(
f"⚠ CRS must be projected (in meters), not geographic.\n" f"Selected: {crs_desc}"
)
return False

# CRS is valid and projected
self.crsWarningLabel.setText("")
return True

def set_bounding_box(self, bounding_box):
"""Populate UI controls with values from a BoundingBox object.

Expand Down
53 changes: 53 additions & 0 deletions loopstructural/gui/modelling/model_definition/bounding_box.ui
Original file line numberDiff line numberDiff line change
Expand Up@@ -162,6 +162,52 @@
</item>
</layout>
</item>
<item>
<widget class="QGroupBox" name="crsGroupBox">
<property name="title">
<string>Coordinate Reference System (CRS)</string>
</property>
<layout class="QVBoxLayout" name="crsVerticalLayout">
<item>
<widget class="QRadioButton" name="useProjectCrsRadioButton">
<property name="text">
<string>Use Project CRS</string>
</property>
<property name="checked">
<bool>true</bool>
</property>
</widget>
</item>
<item>
<widget class="QRadioButton" name="useCustomCrsRadioButton">
<property name="text">
<string>Use Custom CRS</string>
</property>
</widget>
</item>
<item>
<widget class="QgsProjectionSelectionWidget" name="crsSelector">
<property name="enabled">
<bool>false</bool>
</property>
</widget>
</item>
<item>
<widget class="QLabel" name="crsWarningLabel">
<property name="text">
<string/>
</property>
<property name="wordWrap">
<bool>true</bool>
</property>
<property name="styleSheet">
<string>color: red; font-weight: bold;</string>
</property>
</widget>
</item>
</layout>
</widget>
</item>
<item>
<widget class="QPushButton" name="selectFromCurrentLayerButton">
<property name="text">
Expand All@@ -185,6 +231,13 @@
</item>
</layout>
</widget>
<customwidgets>
<customwidget>
<class>QgsProjectionSelectionWidget</class>
<extends>QWidget</extends>
<header>qgis.gui</header>
</customwidget>
</customwidgets>
<resources/>
<connections/>
</ui>
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,6 +150,26 @@ def initialize_model(self):
"Please set the bounding box before initializing the model.",
)
return

# Validate model CRS
if not self.data_manager.is_model_crs_valid():
crs = self.data_manager.get_model_crs()
if crs is None or not crs.isValid():
msg = "Model CRS is not set or invalid. Please select a valid projected CRS in the Model Definition tab."
else:
# Safely get CRS description
try:
crs_desc = crs.description() or crs.authid() or "Unknown"
except Exception:
crs_desc = crs.authid() if hasattr(crs, 'authid') else "Unknown"
msg = f"Model CRS must be projected (in meters), not geographic.\nSelected CRS: {crs_desc}\n\nPlease select a valid projected CRS in the Model Definition tab."

QMessageBox.critical(
self,
"Invalid Model CRS",
msg,
)
return

# create progress dialog (indeterminate)
progress = QProgressDialog("Updating geological model...", "Cancel", 0, 0, self)
Expand Down
142 changes: 142 additions & 0 deletions loopstructural/gui/modelling/model_definition/bounding_box.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@

import numpy as np
from PyQt5.QtWidgets import QWidget
from qgis.core import QgsProject
from qgis.PyQt import uic

from loopstructural.main.data_manager import default_bounding_box
Expand All@@ -13,6 +14,8 @@ def __init__(self, parent=None, data_manager=None):
super().__init__(parent)
ui_path = os.path.join(os.path.dirname(__file__), "bounding_box.ui")
uic.loadUi(ui_path, self)

# Connect bounding box spinbox signals
self.originXSpinBox.valueChanged.connect(lambda x: self.onChangeExtent({'xmin': x}))
self.maxXSpinBox.valueChanged.connect(lambda x: self.onChangeExtent({'xmax': x}))
self.originYSpinBox.valueChanged.connect(lambda y: self.onChangeExtent({'ymin': y}))
Expand All@@ -21,9 +24,148 @@ def __init__(self, parent=None, data_manager=None):
self.maxZSpinBox.valueChanged.connect(lambda z: self.onChangeExtent({'zmax': z}))
self.useCurrentViewExtentButton.clicked.connect(self.useCurrentViewExtent)
self.selectFromCurrentLayerButton.clicked.connect(self.selectFromCurrentLayer)

# Connect CRS control signals
self.useProjectCrsRadioButton.toggled.connect(self.onCrsSourceChanged)
self.useCustomCrsRadioButton.toggled.connect(self.onCrsSourceChanged)
self.crsSelector.crsChanged.connect(self.onCrsChanged)

# Set up callbacks
self.data_manager.set_bounding_box_update_callback(self.set_bounding_box)
self.data_manager.set_model_crs_callback(self.update_crs_ui)

# Initialize CRS UI
self.initialize_crs_ui()
self._update_bounding_box_styles()

# Connect to project CRS changes so the widget updates when the project's CRS changes
try:
project = getattr(self.data_manager, 'project', None) or QgsProject.instance()
project.crsChanged.connect(self._onProjectCrsChanged)
except Exception:
# If the signal isn't available or connection fails, ignore to keep widget functional
pass

def initialize_crs_ui(self):
"""Initialize CRS controls with current settings."""
# Set initial CRS selector value
crs = self.data_manager.get_model_crs()
if crs is not None and crs.isValid():
self.crsSelector.setCrs(crs)
else:
# Default to project CRS
self.crsSelector.setCrs(self.data_manager.project.crs())

# Set radio button based on use_project_crs setting
if self.data_manager._use_project_crs:
self.useProjectCrsRadioButton.setChecked(True)
else:
self.useCustomCrsRadioButton.setChecked(True)

self.validate_crs()

def onCrsSourceChanged(self):
"""Handle change in CRS source (project vs custom)."""
use_project_crs = self.useProjectCrsRadioButton.isChecked()
self.crsSelector.setEnabled(not use_project_crs)

if use_project_crs:
# Use project CRS
success, msg = self.data_manager.set_model_crs(None, use_project_crs=True)
else:
# Use custom CRS
crs = self.crsSelector.crs()
success, msg = self.data_manager.set_model_crs(crs, use_project_crs=False)

self.validate_crs()

def onCrsChanged(self):
"""Handle change in custom CRS selection."""
if self.useCustomCrsRadioButton.isChecked():
crs = self.crsSelector.crs()
success, msg = self.data_manager.set_model_crs(crs, use_project_crs=False)
self.validate_crs()

def update_crs_ui(self, crs, use_project_crs):
"""Update UI when model CRS changes externally.

Parameters
----------
crs : QgsCoordinateReferenceSystem or None
The new model CRS
use_project_crs : bool
Whether to use project CRS
"""
# Block signals to avoid recursive updates
self.useProjectCrsRadioButton.blockSignals(True)
self.useCustomCrsRadioButton.blockSignals(True)
self.crsSelector.blockSignals(True)

try:
if use_project_crs:
self.useProjectCrsRadioButton.setChecked(True)
self.crsSelector.setEnabled(False)
self.crsSelector.setCrs(crs)

else:
self.useCustomCrsRadioButton.setChecked(True)
self.crsSelector.setEnabled(True)
if crs is not None and crs.isValid():
self.crsSelector.setCrs(crs)

self.validate_crs()
finally:
# Unblock signals
self.useProjectCrsRadioButton.blockSignals(False)
self.useCustomCrsRadioButton.blockSignals(False)
self.crsSelector.blockSignals(False)

def _onProjectCrsChanged(self, crs=None):
"""Handle project CRS changes and update UI when the widget is using the project CRS.

Accept an optional `crs` argument because different QGIS versions may emit the
new CRS or emit no arguments when the project's CRS changes.
"""
# If the signal didn't provide a CRS, try to obtain it from the project's current CRS
if crs is None:
try:
project = getattr(self.data_manager, 'project', None) or QgsProject.instance()
crs = project.crs()
except Exception:
crs = None

# Only update the UI if the model is configured to use the project CRS
try:
if getattr(self.data_manager, '_use_project_crs', False):
# Update the UI to reflect the new project CRS
self.update_crs_ui(crs, use_project_crs=True)
except Exception:
pass

def validate_crs(self):
"""Validate the selected CRS and update warning label."""
crs = self.data_manager.get_model_crs()

if crs is None or not crs.isValid():
self.crsWarningLabel.setText("⚠ Invalid CRS selected. Model cannot be initialized.")
return False

if crs.isGeographic():
# Safely get CRS description
try:
crs_desc = crs.description() or crs.authid() or "Unknown"
except Exception:
crs_desc = crs.authid() if hasattr(crs, 'authid') else "Unknown"

self.crsWarningLabel.setText(
f"⚠ CRS must be projected (in meters), not geographic.\n" f"Selected: {crs_desc}"
)
return False

# CRS is valid and projected
self.crsWarningLabel.setText("")
return True

def set_bounding_box(self, bounding_box):
"""Populate UI controls with values from a BoundingBox object.

Expand Down
53 changes: 53 additions & 0 deletions loopstructural/gui/modelling/model_definition/bounding_box.ui
Original file line numberDiff line numberDiff line change
Expand Up@@ -162,6 +162,52 @@
</item>
</layout>
</item>
<item>
<widget class="QGroupBox" name="crsGroupBox">
<property name="title">
<string>Coordinate Reference System (CRS)</string>
</property>
<layout class="QVBoxLayout" name="crsVerticalLayout">
<item>
<widget class="QRadioButton" name="useProjectCrsRadioButton">
<property name="text">
<string>Use Project CRS</string>
</property>
<property name="checked">
<bool>true</bool>
</property>
</widget>
</item>
<item>
<widget class="QRadioButton" name="useCustomCrsRadioButton">
<property name="text">
<string>Use Custom CRS</string>
</property>
</widget>
</item>
<item>
<widget class="QgsProjectionSelectionWidget" name="crsSelector">
<property name="enabled">
<bool>false</bool>
</property>
</widget>
</item>
<item>
<widget class="QLabel" name="crsWarningLabel">
<property name="text">
<string/>
</property>
<property name="wordWrap">
<bool>true</bool>
</property>
<property name="styleSheet">
<string>color: red; font-weight: bold;</string>
</property>
</widget>
</item>
</layout>
</widget>
</item>
<item>
<widget class="QPushButton" name="selectFromCurrentLayerButton">
<property name="text">
Expand All@@ -185,6 +231,13 @@
</item>
</layout>
</widget>
<customwidgets>
<customwidget>
<class>QgsProjectionSelectionWidget</class>
<extends>QWidget</extends>
<header>qgis.gui</header>
</customwidget>
</customwidgets>
<resources/>
<connections/>
</ui>
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,6 +150,26 @@ def initialize_model(self):
"Please set the bounding box before initializing the model.",
)
return

# Validate model CRS
if not self.data_manager.is_model_crs_valid():
crs = self.data_manager.get_model_crs()
if crs is None or not crs.isValid():
msg = "Model CRS is not set or invalid. Please select a valid projected CRS in the Model Definition tab."
else:
# Safely get CRS description
try:
crs_desc = crs.description() or crs.authid() or "Unknown"
except Exception:
crs_desc = crs.authid() if hasattr(crs, 'authid') else "Unknown"
msg = f"Model CRS must be projected (in meters), not geographic.\nSelected CRS: {crs_desc}\n\nPlease select a valid projected CRS in the Model Definition tab."

QMessageBox.critical(
self,
"Invalid Model CRS",
msg,
)
return

# create progress dialog (indeterminate)
progress = QProgressDialog("Updating geological model...", "Cancel", 0, 0, self)
Expand Down
142 changes: 142 additions & 0 deletions loopstructural/gui/modelling/model_definition/bounding_box.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@

import numpy as np
from PyQt5.QtWidgets import QWidget
from qgis.core import QgsProject
from qgis.PyQt import uic

from loopstructural.main.data_manager import default_bounding_box
Expand All@@ -13,6 +14,8 @@ def __init__(self, parent=None, data_manager=None):
super().__init__(parent)
ui_path = os.path.join(os.path.dirname(__file__), "bounding_box.ui")
uic.loadUi(ui_path, self)

# Connect bounding box spinbox signals
self.originXSpinBox.valueChanged.connect(lambda x: self.onChangeExtent({'xmin': x}))
self.maxXSpinBox.valueChanged.connect(lambda x: self.onChangeExtent({'xmax': x}))
self.originYSpinBox.valueChanged.connect(lambda y: self.onChangeExtent({'ymin': y}))
Expand All@@ -21,9 +24,148 @@ def __init__(self, parent=None, data_manager=None):
self.maxZSpinBox.valueChanged.connect(lambda z: self.onChangeExtent({'zmax': z}))
self.useCurrentViewExtentButton.clicked.connect(self.useCurrentViewExtent)
self.selectFromCurrentLayerButton.clicked.connect(self.selectFromCurrentLayer)

# Connect CRS control signals
self.useProjectCrsRadioButton.toggled.connect(self.onCrsSourceChanged)
self.useCustomCrsRadioButton.toggled.connect(self.onCrsSourceChanged)
self.crsSelector.crsChanged.connect(self.onCrsChanged)

# Set up callbacks
self.data_manager.set_bounding_box_update_callback(self.set_bounding_box)
self.data_manager.set_model_crs_callback(self.update_crs_ui)

# Initialize CRS UI
self.initialize_crs_ui()
self._update_bounding_box_styles()

# Connect to project CRS changes so the widget updates when the project's CRS changes
try:
project = getattr(self.data_manager, 'project', None) or QgsProject.instance()
project.crsChanged.connect(self._onProjectCrsChanged)
except Exception:
# If the signal isn't available or connection fails, ignore to keep widget functional
pass

def initialize_crs_ui(self):
"""Initialize CRS controls with current settings."""
# Set initial CRS selector value
crs = self.data_manager.get_model_crs()
if crs is not None and crs.isValid():
self.crsSelector.setCrs(crs)
else:
# Default to project CRS
self.crsSelector.setCrs(self.data_manager.project.crs())

# Set radio button based on use_project_crs setting
if self.data_manager._use_project_crs:
self.useProjectCrsRadioButton.setChecked(True)
else:
self.useCustomCrsRadioButton.setChecked(True)

self.validate_crs()

def onCrsSourceChanged(self):
"""Handle change in CRS source (project vs custom)."""
use_project_crs = self.useProjectCrsRadioButton.isChecked()
self.crsSelector.setEnabled(not use_project_crs)

if use_project_crs:
# Use project CRS
success, msg = self.data_manager.set_model_crs(None, use_project_crs=True)
else:
# Use custom CRS
crs = self.crsSelector.crs()
success, msg = self.data_manager.set_model_crs(crs, use_project_crs=False)

self.validate_crs()

def onCrsChanged(self):
"""Handle change in custom CRS selection."""
if self.useCustomCrsRadioButton.isChecked():
crs = self.crsSelector.crs()
success, msg = self.data_manager.set_model_crs(crs, use_project_crs=False)
self.validate_crs()

def update_crs_ui(self, crs, use_project_crs):
"""Update UI when model CRS changes externally.

Parameters
----------
crs : QgsCoordinateReferenceSystem or None
The new model CRS
use_project_crs : bool
Whether to use project CRS
"""
# Block signals to avoid recursive updates
self.useProjectCrsRadioButton.blockSignals(True)
self.useCustomCrsRadioButton.blockSignals(True)
self.crsSelector.blockSignals(True)

try:
if use_project_crs:
self.useProjectCrsRadioButton.setChecked(True)
self.crsSelector.setEnabled(False)
self.crsSelector.setCrs(crs)

else:
self.useCustomCrsRadioButton.setChecked(True)
self.crsSelector.setEnabled(True)
if crs is not None and crs.isValid():
self.crsSelector.setCrs(crs)

self.validate_crs()
finally:
# Unblock signals
self.useProjectCrsRadioButton.blockSignals(False)
self.useCustomCrsRadioButton.blockSignals(False)
self.crsSelector.blockSignals(False)

def _onProjectCrsChanged(self, crs=None):
"""Handle project CRS changes and update UI when the widget is using the project CRS.

Accept an optional `crs` argument because different QGIS versions may emit the
new CRS or emit no arguments when the project's CRS changes.
"""
# If the signal didn't provide a CRS, try to obtain it from the project's current CRS
if crs is None:
try:
project = getattr(self.data_manager, 'project', None) or QgsProject.instance()
crs = project.crs()
except Exception:
crs = None

# Only update the UI if the model is configured to use the project CRS
try:
if getattr(self.data_manager, '_use_project_crs', False):
# Update the UI to reflect the new project CRS
self.update_crs_ui(crs, use_project_crs=True)
except Exception:
pass

def validate_crs(self):
"""Validate the selected CRS and update warning label."""
crs = self.data_manager.get_model_crs()

if crs is None or not crs.isValid():
self.crsWarningLabel.setText("⚠ Invalid CRS selected. Model cannot be initialized.")
return False

if crs.isGeographic():
# Safely get CRS description
try:
crs_desc = crs.description() or crs.authid() or "Unknown"
except Exception:
crs_desc = crs.authid() if hasattr(crs, 'authid') else "Unknown"

self.crsWarningLabel.setText(
f"⚠ CRS must be projected (in meters), not geographic.\n" f"Selected: {crs_desc}"
)
return False

# CRS is valid and projected
self.crsWarningLabel.setText("")
return True

def set_bounding_box(self, bounding_box):
"""Populate UI controls with values from a BoundingBox object.

Expand Down
53 changes: 53 additions & 0 deletions loopstructural/gui/modelling/model_definition/bounding_box.ui
Original file line numberDiff line numberDiff line change
Expand Up@@ -162,6 +162,52 @@
</item>
</layout>
</item>
<item>
<widget class="QGroupBox" name="crsGroupBox">
<property name="title">
<string>Coordinate Reference System (CRS)</string>
</property>
<layout class="QVBoxLayout" name="crsVerticalLayout">
<item>
<widget class="QRadioButton" name="useProjectCrsRadioButton">
<property name="text">
<string>Use Project CRS</string>
</property>
<property name="checked">
<bool>true</bool>
</property>
</widget>
</item>
<item>
<widget class="QRadioButton" name="useCustomCrsRadioButton">
<property name="text">
<string>Use Custom CRS</string>
</property>
</widget>
</item>
<item>
<widget class="QgsProjectionSelectionWidget" name="crsSelector">
<property name="enabled">
<bool>false</bool>
</property>
</widget>
</item>
<item>
<widget class="QLabel" name="crsWarningLabel">
<property name="text">
<string/>
</property>
<property name="wordWrap">
<bool>true</bool>
</property>
<property name="styleSheet">
<string>color: red; font-weight: bold;</string>
</property>
</widget>
</item>
</layout>
</widget>
</item>
<item>
<widget class="QPushButton" name="selectFromCurrentLayerButton">
<property name="text">
Expand All@@ -185,6 +231,13 @@
</item>
</layout>
</widget>
<customwidgets>
<customwidget>
<class>QgsProjectionSelectionWidget</class>
<extends>QWidget</extends>
<header>qgis.gui</header>
</customwidget>
</customwidgets>
<resources/>
<connections/>
</ui>
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,6 +150,26 @@ def initialize_model(self):
"Please set the bounding box before initializing the model.",
)
return

# Validate model CRS
if not self.data_manager.is_model_crs_valid():
crs = self.data_manager.get_model_crs()
if crs is None or not crs.isValid():
msg = "Model CRS is not set or invalid. Please select a valid projected CRS in the Model Definition tab."
else:
# Safely get CRS description
try:
crs_desc = crs.description() or crs.authid() or "Unknown"
except Exception:
crs_desc = crs.authid() if hasattr(crs, 'authid') else "Unknown"
msg = f"Model CRS must be projected (in meters), not geographic.\nSelected CRS: {crs_desc}\n\nPlease select a valid projected CRS in the Model Definition tab."

QMessageBox.critical(
self,
"Invalid Model CRS",
msg,
)
return

# create progress dialog (indeterminate)
progress = QProgressDialog("Updating geological model...", "Cancel", 0, 0, self)
Expand Down
142 changes: 142 additions & 0 deletions loopstructural/gui/modelling/model_definition/bounding_box.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@

import numpy as np
from PyQt5.QtWidgets import QWidget
from qgis.core import QgsProject
from qgis.PyQt import uic

from loopstructural.main.data_manager import default_bounding_box
Expand All@@ -13,6 +14,8 @@ def __init__(self, parent=None, data_manager=None):
super().__init__(parent)
ui_path = os.path.join(os.path.dirname(__file__), "bounding_box.ui")
uic.loadUi(ui_path, self)

# Connect bounding box spinbox signals
self.originXSpinBox.valueChanged.connect(lambda x: self.onChangeExtent({'xmin': x}))
self.maxXSpinBox.valueChanged.connect(lambda x: self.onChangeExtent({'xmax': x}))
self.originYSpinBox.valueChanged.connect(lambda y: self.onChangeExtent({'ymin': y}))
Expand All@@ -21,9 +24,148 @@ def __init__(self, parent=None, data_manager=None):
self.maxZSpinBox.valueChanged.connect(lambda z: self.onChangeExtent({'zmax': z}))
self.useCurrentViewExtentButton.clicked.connect(self.useCurrentViewExtent)
self.selectFromCurrentLayerButton.clicked.connect(self.selectFromCurrentLayer)

# Connect CRS control signals
self.useProjectCrsRadioButton.toggled.connect(self.onCrsSourceChanged)
self.useCustomCrsRadioButton.toggled.connect(self.onCrsSourceChanged)
self.crsSelector.crsChanged.connect(self.onCrsChanged)

# Set up callbacks
self.data_manager.set_bounding_box_update_callback(self.set_bounding_box)
self.data_manager.set_model_crs_callback(self.update_crs_ui)

# Initialize CRS UI
self.initialize_crs_ui()
self._update_bounding_box_styles()

# Connect to project CRS changes so the widget updates when the project's CRS changes
try:
project = getattr(self.data_manager, 'project', None) or QgsProject.instance()
project.crsChanged.connect(self._onProjectCrsChanged)
except Exception:
# If the signal isn't available or connection fails, ignore to keep widget functional
pass

def initialize_crs_ui(self):
"""Initialize CRS controls with current settings."""
# Set initial CRS selector value
crs = self.data_manager.get_model_crs()
if crs is not None and crs.isValid():
self.crsSelector.setCrs(crs)
else:
# Default to project CRS
self.crsSelector.setCrs(self.data_manager.project.crs())

# Set radio button based on use_project_crs setting
if self.data_manager._use_project_crs:
self.useProjectCrsRadioButton.setChecked(True)
else:
self.useCustomCrsRadioButton.setChecked(True)

self.validate_crs()

def onCrsSourceChanged(self):
"""Handle change in CRS source (project vs custom)."""
use_project_crs = self.useProjectCrsRadioButton.isChecked()
self.crsSelector.setEnabled(not use_project_crs)

if use_project_crs:
# Use project CRS
success, msg = self.data_manager.set_model_crs(None, use_project_crs=True)
else:
# Use custom CRS
crs = self.crsSelector.crs()
success, msg = self.data_manager.set_model_crs(crs, use_project_crs=False)

self.validate_crs()

def onCrsChanged(self):
"""Handle change in custom CRS selection."""
if self.useCustomCrsRadioButton.isChecked():
crs = self.crsSelector.crs()
success, msg = self.data_manager.set_model_crs(crs, use_project_crs=False)
self.validate_crs()

def update_crs_ui(self, crs, use_project_crs):
"""Update UI when model CRS changes externally.

Parameters
----------
crs : QgsCoordinateReferenceSystem or None
The new model CRS
use_project_crs : bool
Whether to use project CRS
"""
# Block signals to avoid recursive updates
self.useProjectCrsRadioButton.blockSignals(True)
self.useCustomCrsRadioButton.blockSignals(True)
self.crsSelector.blockSignals(True)

try:
if use_project_crs:
self.useProjectCrsRadioButton.setChecked(True)
self.crsSelector.setEnabled(False)
self.crsSelector.setCrs(crs)

else:
self.useCustomCrsRadioButton.setChecked(True)
self.crsSelector.setEnabled(True)
if crs is not None and crs.isValid():
self.crsSelector.setCrs(crs)

self.validate_crs()
finally:
# Unblock signals
self.useProjectCrsRadioButton.blockSignals(False)
self.useCustomCrsRadioButton.blockSignals(False)
self.crsSelector.blockSignals(False)

def _onProjectCrsChanged(self, crs=None):
"""Handle project CRS changes and update UI when the widget is using the project CRS.

Accept an optional `crs` argument because different QGIS versions may emit the
new CRS or emit no arguments when the project's CRS changes.
"""
# If the signal didn't provide a CRS, try to obtain it from the project's current CRS
if crs is None:
try:
project = getattr(self.data_manager, 'project', None) or QgsProject.instance()
crs = project.crs()
except Exception:
crs = None

# Only update the UI if the model is configured to use the project CRS
try:
if getattr(self.data_manager, '_use_project_crs', False):
# Update the UI to reflect the new project CRS
self.update_crs_ui(crs, use_project_crs=True)
except Exception:
pass

def validate_crs(self):
"""Validate the selected CRS and update warning label."""
crs = self.data_manager.get_model_crs()

if crs is None or not crs.isValid():
self.crsWarningLabel.setText("⚠ Invalid CRS selected. Model cannot be initialized.")
return False

if crs.isGeographic():
# Safely get CRS description
try:
crs_desc = crs.description() or crs.authid() or "Unknown"
except Exception:
crs_desc = crs.authid() if hasattr(crs, 'authid') else "Unknown"

self.crsWarningLabel.setText(
f"⚠ CRS must be projected (in meters), not geographic.\n" f"Selected: {crs_desc}"
)
return False

# CRS is valid and projected
self.crsWarningLabel.setText("")
return True

def set_bounding_box(self, bounding_box):
"""Populate UI controls with values from a BoundingBox object.

Expand Down
53 changes: 53 additions & 0 deletions loopstructural/gui/modelling/model_definition/bounding_box.ui
Original file line numberDiff line numberDiff line change
Expand Up@@ -162,6 +162,52 @@
</item>
</layout>
</item>
<item>
<widget class="QGroupBox" name="crsGroupBox">
<property name="title">
<string>Coordinate Reference System (CRS)</string>
</property>
<layout class="QVBoxLayout" name="crsVerticalLayout">
<item>
<widget class="QRadioButton" name="useProjectCrsRadioButton">
<property name="text">
<string>Use Project CRS</string>
</property>
<property name="checked">
<bool>true</bool>
</property>
</widget>
</item>
<item>
<widget class="QRadioButton" name="useCustomCrsRadioButton">
<property name="text">
<string>Use Custom CRS</string>
</property>
</widget>
</item>
<item>
<widget class="QgsProjectionSelectionWidget" name="crsSelector">
<property name="enabled">
<bool>false</bool>
</property>
</widget>
</item>
<item>
<widget class="QLabel" name="crsWarningLabel">
<property name="text">
<string/>
</property>
<property name="wordWrap">
<bool>true</bool>
</property>
<property name="styleSheet">
<string>color: red; font-weight: bold;</string>
</property>
</widget>
</item>
</layout>
</widget>
</item>
<item>
<widget class="QPushButton" name="selectFromCurrentLayerButton">
<property name="text">
Expand All@@ -185,6 +231,13 @@
</item>
</layout>
</widget>
<customwidgets>
<customwidget>
<class>QgsProjectionSelectionWidget</class>
<extends>QWidget</extends>
<header>qgis.gui</header>
</customwidget>
</customwidgets>
<resources/>
<connections/>
</ui>
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,6 +150,26 @@ def initialize_model(self):
"Please set the bounding box before initializing the model.",
)
return

# Validate model CRS
if not self.data_manager.is_model_crs_valid():
crs = self.data_manager.get_model_crs()
if crs is None or not crs.isValid():
msg = "Model CRS is not set or invalid. Please select a valid projected CRS in the Model Definition tab."
else:
# Safely get CRS description
try:
crs_desc = crs.description() or crs.authid() or "Unknown"
except Exception:
crs_desc = crs.authid() if hasattr(crs, 'authid') else "Unknown"
msg = f"Model CRS must be projected (in meters), not geographic.\nSelected CRS: {crs_desc}\n\nPlease select a valid projected CRS in the Model Definition tab."

QMessageBox.critical(
self,
"Invalid Model CRS",
msg,
)
return

# create progress dialog (indeterminate)
progress = QProgressDialog("Updating geological model...", "Cancel", 0, 0, self)
Expand Down
142 changes: 142 additions & 0 deletions loopstructural/gui/modelling/model_definition/bounding_box.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@

import numpy as np
from PyQt5.QtWidgets import QWidget
from qgis.core import QgsProject
from qgis.PyQt import uic

from loopstructural.main.data_manager import default_bounding_box
Expand All@@ -13,6 +14,8 @@ def __init__(self, parent=None, data_manager=None):
super().__init__(parent)
ui_path = os.path.join(os.path.dirname(__file__), "bounding_box.ui")
uic.loadUi(ui_path, self)

# Connect bounding box spinbox signals
self.originXSpinBox.valueChanged.connect(lambda x: self.onChangeExtent({'xmin': x}))
self.maxXSpinBox.valueChanged.connect(lambda x: self.onChangeExtent({'xmax': x}))
self.originYSpinBox.valueChanged.connect(lambda y: self.onChangeExtent({'ymin': y}))
Expand All@@ -21,9 +24,148 @@ def __init__(self, parent=None, data_manager=None):
self.maxZSpinBox.valueChanged.connect(lambda z: self.onChangeExtent({'zmax': z}))
self.useCurrentViewExtentButton.clicked.connect(self.useCurrentViewExtent)
self.selectFromCurrentLayerButton.clicked.connect(self.selectFromCurrentLayer)

# Connect CRS control signals
self.useProjectCrsRadioButton.toggled.connect(self.onCrsSourceChanged)
self.useCustomCrsRadioButton.toggled.connect(self.onCrsSourceChanged)
self.crsSelector.crsChanged.connect(self.onCrsChanged)

# Set up callbacks
self.data_manager.set_bounding_box_update_callback(self.set_bounding_box)
self.data_manager.set_model_crs_callback(self.update_crs_ui)

# Initialize CRS UI
self.initialize_crs_ui()
self._update_bounding_box_styles()

# Connect to project CRS changes so the widget updates when the project's CRS changes
try:
project = getattr(self.data_manager, 'project', None) or QgsProject.instance()
project.crsChanged.connect(self._onProjectCrsChanged)
except Exception:
# If the signal isn't available or connection fails, ignore to keep widget functional
pass

def initialize_crs_ui(self):
"""Initialize CRS controls with current settings."""
# Set initial CRS selector value
crs = self.data_manager.get_model_crs()
if crs is not None and crs.isValid():
self.crsSelector.setCrs(crs)
else:
# Default to project CRS
self.crsSelector.setCrs(self.data_manager.project.crs())

# Set radio button based on use_project_crs setting
if self.data_manager._use_project_crs:
self.useProjectCrsRadioButton.setChecked(True)
else:
self.useCustomCrsRadioButton.setChecked(True)

self.validate_crs()

def onCrsSourceChanged(self):
"""Handle change in CRS source (project vs custom)."""
use_project_crs = self.useProjectCrsRadioButton.isChecked()
self.crsSelector.setEnabled(not use_project_crs)

if use_project_crs:
# Use project CRS
success, msg = self.data_manager.set_model_crs(None, use_project_crs=True)
else:
# Use custom CRS
crs = self.crsSelector.crs()
success, msg = self.data_manager.set_model_crs(crs, use_project_crs=False)

self.validate_crs()

def onCrsChanged(self):
"""Handle change in custom CRS selection."""
if self.useCustomCrsRadioButton.isChecked():
crs = self.crsSelector.crs()
success, msg = self.data_manager.set_model_crs(crs, use_project_crs=False)
self.validate_crs()

def update_crs_ui(self, crs, use_project_crs):
"""Update UI when model CRS changes externally.

Parameters
----------
crs : QgsCoordinateReferenceSystem or None
The new model CRS
use_project_crs : bool
Whether to use project CRS
"""
# Block signals to avoid recursive updates
self.useProjectCrsRadioButton.blockSignals(True)
self.useCustomCrsRadioButton.blockSignals(True)
self.crsSelector.blockSignals(True)

try:
if use_project_crs:
self.useProjectCrsRadioButton.setChecked(True)
self.crsSelector.setEnabled(False)
self.crsSelector.setCrs(crs)

else:
self.useCustomCrsRadioButton.setChecked(True)
self.crsSelector.setEnabled(True)
if crs is not None and crs.isValid():
self.crsSelector.setCrs(crs)

self.validate_crs()
finally:
# Unblock signals
self.useProjectCrsRadioButton.blockSignals(False)
self.useCustomCrsRadioButton.blockSignals(False)
self.crsSelector.blockSignals(False)

def _onProjectCrsChanged(self, crs=None):
"""Handle project CRS changes and update UI when the widget is using the project CRS.

Accept an optional `crs` argument because different QGIS versions may emit the
new CRS or emit no arguments when the project's CRS changes.
"""
# If the signal didn't provide a CRS, try to obtain it from the project's current CRS
if crs is None:
try:
project = getattr(self.data_manager, 'project', None) or QgsProject.instance()
crs = project.crs()
except Exception:
crs = None

# Only update the UI if the model is configured to use the project CRS
try:
if getattr(self.data_manager, '_use_project_crs', False):
# Update the UI to reflect the new project CRS
self.update_crs_ui(crs, use_project_crs=True)
except Exception:
pass

def validate_crs(self):
"""Validate the selected CRS and update warning label."""
crs = self.data_manager.get_model_crs()

if crs is None or not crs.isValid():
self.crsWarningLabel.setText("⚠ Invalid CRS selected. Model cannot be initialized.")
return False

if crs.isGeographic():
# Safely get CRS description
try:
crs_desc = crs.description() or crs.authid() or "Unknown"
except Exception:
crs_desc = crs.authid() if hasattr(crs, 'authid') else "Unknown"

self.crsWarningLabel.setText(
f"⚠ CRS must be projected (in meters), not geographic.\n" f"Selected: {crs_desc}"
)
return False

# CRS is valid and projected
self.crsWarningLabel.setText("")
return True

def set_bounding_box(self, bounding_box):
"""Populate UI controls with values from a BoundingBox object.

Expand Down
53 changes: 53 additions & 0 deletions loopstructural/gui/modelling/model_definition/bounding_box.ui
Original file line numberDiff line numberDiff line change
Expand Up@@ -162,6 +162,52 @@
</item>
</layout>
</item>
<item>
<widget class="QGroupBox" name="crsGroupBox">
<property name="title">
<string>Coordinate Reference System (CRS)</string>
</property>
<layout class="QVBoxLayout" name="crsVerticalLayout">
<item>
<widget class="QRadioButton" name="useProjectCrsRadioButton">
<property name="text">
<string>Use Project CRS</string>
</property>
<property name="checked">
<bool>true</bool>
</property>
</widget>
</item>
<item>
<widget class="QRadioButton" name="useCustomCrsRadioButton">
<property name="text">
<string>Use Custom CRS</string>
</property>
</widget>
</item>
<item>
<widget class="QgsProjectionSelectionWidget" name="crsSelector">
<property name="enabled">
<bool>false</bool>
</property>
</widget>
</item>
<item>
<widget class="QLabel" name="crsWarningLabel">
<property name="text">
<string/>
</property>
<property name="wordWrap">
<bool>true</bool>
</property>
<property name="styleSheet">
<string>color: red; font-weight: bold;</string>
</property>
</widget>
</item>
</layout>
</widget>
</item>
<item>
<widget class="QPushButton" name="selectFromCurrentLayerButton">
<property name="text">
Expand All@@ -185,6 +231,13 @@
</item>
</layout>
</widget>
<customwidgets>
<customwidget>
<class>QgsProjectionSelectionWidget</class>
<extends>QWidget</extends>
<header>qgis.gui</header>
</customwidget>
</customwidgets>
<resources/>
<connections/>
</ui>
Loading