Uh oh!
There was an error while loading. Please reload this page.
Listen for notification when Insulin Delivery Store updates its cache - #1150
Listen for notification when Insulin Delivery Store updates its cache#1150aranasaurus wants to merge 3 commits into
Conversation
Uh oh!
There was an error while loading. Please reload this page.
ps2
left a comment
There was a problem hiding this comment.
Looks good. Just a small comment change request, and please update from dev and then tests should pass for this.
Thanks!
| queue: OperationQueue.main | ||
| ) { (note) in | ||
| self.dataAccessQueue.async { | ||
| self.logger.default("Received notification of cached dosing changing") |
There was a problem hiding this comment.
"cached dosing" -> "insulin delivery store cache"
Uh oh!
There was an error while loading. Please reload this page.
ps2
commented
Oct 30, 2019
Doing a little cleanup on names: |
| self.notify(forChange: .bolus) | ||
| } | ||
| }, | ||
| NotificationCenter.default.addObserver( |
There was a problem hiding this comment.
The addObserver above this is not specifying a name for notifications from doseStore. Could you add the right name? I believe it is DoseStore.valuesDidChange.
There was a problem hiding this comment.
Yep I’ll probably be able to do that tomorrow night or this weekend.
This can be merged if it is rebased on dev and updated with the new notification name. |
This addresses #1037 and requires changes in LoopKit/LoopKit#304