Skip to content

updating remote-override branches - #3

Closed
Kdisimone wants to merge 1 commit into
LoopKit:remote-overridesfrom
Kdisimone:update-submodules
Closed

updating remote-override branches#3
Kdisimone wants to merge 1 commit into
LoopKit:remote-overridesfrom
Kdisimone:update-submodules

Conversation

@Kdisimone

Copy link
Copy Markdown

No description provided.

@Kdisimone

Copy link
Copy Markdown
Author

Remote-overrides was coming in with master branches.

@ps2ps2 closed this May 19, 2020
ddaniels1 pushed a commit to ddaniels1/LoopWorkspace that referenced this pull request May 23, 2020
treed6386 added a commit to treed6386/LoopWorkspace that referenced this pull request Jan 7, 2024
treed6386 added a commit to treed6386/LoopWorkspace that referenced this pull request Jan 7, 2024
codebymini pushed a commit to codebymini/LoopWorkspace that referenced this pull request Sep 2, 2025
codebymini pushed a commit to codebymini/LoopWorkspace that referenced this pull request Sep 2, 2025
kinterra added a commit to kinterra-org/LoopWorkspace that referenced this pull request Jan 28, 2026
fix alignment. L&L code copy & paste failed.
threecee pushed a commit to threecee/LoopWorkspace that referenced this pull request May 2, 2026
Picks up:
- OmniBLE (b4-start..5fb011a, 4 commits): payload validity 60s → 600s
+ doc comment (LoopKit#6); PhoneWatchSettingsSync v2 with automaticDosing
fields + protocol version bump (LoopKit#3); shared HandoffState.currentOwner
extension for policy-engine wiring (LoopKit#2).
- Loop (b4-start..b5e94f7a, 4 commits): iOS LoopAppManager wires
settingsSyncProvider closure (closes production gap discovered
during planning) + watch WatchSettingsSnapshot reads dosing flags
from sync (LoopKit#3); HandoffOrchestrator wires HandoffPolicyEngine
markX hooks on both sides via Combine reachability subscription
with 60s debounce (LoopKit#2); review-fix renames + safety comment.
After this, the watch can self-drive when the phone reports
automaticDosingEnabled, the auto-revert path is live (was dead code
since B.3.a), and the cached-pod-state safety gate is active.
BEHAVIOR CHANGE: auto-revert from watch back to phone WILL FIRE in
.automatic and .manualWithAutoRevert modes when the phone reconnects
after being out of range for >=60s. Worth deliberate hardware testing
on the next install.
Verified:
- OmniBLETests targeted (3 suites): 26/26 PASS
- LoopTests targeted (3 suites): 27/27 PASS
- WatchApp ExtensionTests targeted (2 suites): 19/19 PASS
- Release archive: ARCHIVE SUCCEEDED (iOS, generic destination)
threecee-claude
threecee pushed a commit to threecee/LoopWorkspace that referenced this pull request May 2, 2026
Picks up:
- OmniBLE (b5.2-start..HEAD, 2 commits): commandsAllowedCheck gate
widened to runTemporaryBasalProgram, cancelBolus, suspendDelivery
(#5b); PhoneWatchSettingsSync.timeZone: String? field + protocol
bump 3 -> 4 (LoopKit#3).
- Loop (b5.2-start..HEAD, 1 commit): HandoffBlockedError +
StatusTableViewController handoff-blocked rendering for cancelBolus
(#5b); HandoffOrchestrator + LoopAppManager populate timeZone (LoopKit#3) +
observe NSSystemTimeZoneDidChangeNotification (#3b);
WatchAlgorithmDriver resolves scheduleZone from sync.timeZone and
threads to all 4 dailyItems schedule constructors (LoopKit#3).
After this:
- The 3 newly-gated pump methods short-circuit during the sub-second
handoff window. cancelBolus's iOS UI renders "Handoff in progress,
please try again in a moment" via HandoffBlockedError; suspendDelivery
is OmniBLE-PumpManagerUI-only (out of Loop UI scope).
- Watch interprets all 4 dailyItems schedules in the phone's zone;
phone-side TZ changes propagate to the watch within one WCSession
round-trip via the new NSSystemTimeZoneDidChangeNotification observer.
Verified:
- OmniBLETests targeted: all suites green (104 tests; WatchAlgorithmEndToEndTests
5/5 after retry to clear cold-start noPodsFound flake)
- LoopTests targeted: 31/31 green
- WatchApp ExtensionTests targeted: 36/36 green
- Release archive: ARCHIVE SUCCEEDED (iOS, generic destination)
threecee-claude
threecee pushed a commit to threecee/LoopWorkspace that referenced this pull request May 3, 2026
…nciliation
Loop: AlgorithmStateSnapshotEmitter populates rolling buffers from
runner inputs. WatchAlgorithmDriver.applyAlgorithmStateSnapshot writes
buffers to watch stores via upstream LoopKit batch-insert APIs (with
NewGlucoseSample/NewCarbEntry projections; doses pass through).
WatchAlgorithmDriver's .skipWarmup case hydrates inside the switch
(snapshot is in scope via WarmUpDecision's associated value). Phase 6
caught + fixed a production bug: DoseStore.addDoses calls its
completion handler twice; Phase 3's continuation now NSLock-guarded.
Wire format: file-pointer fallback for oversized snapshots (Phase 1
measured 21.25KB; >8KB threshold). Phone writes to AppGroup/snapshot.json,
sends pointer message via applicationContext. Watch reads file on
pointer receipt, validates monotonic sequence.
LoopAlgorithmReconciliationTests harness ships with placeholder fixtures
+ stub runForReconciliation body. Tests XCTSkip cleanly. Real fixtures
captured manually via Phase 5a's #if DEBUG instrumentation in follow-up.
OmniBLE: AlgorithmStateSnapshot.isFreshEnoughForSkipWarmup helper.
PhoneWatchMessage.algorithmStateSnapshotPointer(sequence:) wire-format
case + PhoneWatchProtocol.currentVersion bumped 5 to 6.
Closes Codex adversarial review Loop LoopKit#3 high. Closes the umbrella
B.8.x adversarial-review-hardening series. algorithm-fidelity-audit
PASS verified at /tmp/algorithm-fidelity-audit-2026-05-03.md.
Tagged b8.4-complete on all three repos. Build 876 prep.
threecee-claude
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Kdisimone@ps2