Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
总述
修复用户自助管理自动签到时错误复用全局签到配置的问题,使鸣潮与战双的用户配置入口分别由对应的独立开关控制。
问题
此前,鸣潮和战双的用户配置命令均通过
get_signin_config()判断是否允许执行,而该函数实际检查的是:这两个配置项分别用于全量签到和定时签到,不应作为用户自助配置入口的可用性判断条件,导致:
UserPGRSignin开关。举例:
修改
UserWavesSignin;get_pgr_signin_config();UserPGRSignin;SigninMaster、SchedSignin原有职责,不调整全量签到和定时签到执行逻辑。现在
配置职责调整如下:
UserWavesSigninUserPGRSigninSigninMasterSchedSignin用户自助配置入口不再错误依赖全量签到或定时签到开关,鸣潮与战双的配置控制实现逻辑隔离。
涉及范围
本次修改仅调整用户配置命令的开关判断逻辑,不涉及数据库结构、签到接口、全量签到流程或定时任务调度逻辑。