Solaris Fixes by HeinrichHartmann · Pull Request #1 · LuaDist/lpeg

HeinrichHartmann · 2016-06-01T12:38:44Z

On operating systems like Solaris and Illumos where the stack grows down, lightuserdata and user data cannot be assigned from the stack. This commit patch fixes this behaviour by moving the allocations to the heap (using calloc).

We also ran into symbol collisions (compile) when linking the library with our codebase. This is also addressed in a separate commit.

as provided by http://www.inf.puc-rio.br/~roberto/lpeg/ on 2016-05-26 `MD5 (lpeg-1.0.0.tar.gz) = 0aec64ccd13996202ad0c099e2877ece`

Solaris (OmniOS, Illumos) version of luajit does not support support allocation of lightuserdata on the stack. This gives errors like this: ``` $ luajit test.lua General tests for LPeg library version 1.0.0 luajit: bad light userdata pointer stack traceback: [C]: in function 'match' test.lua:58: in main chunk [C]: at 0x00402d50 ``` This commit patch fixes this behavior by moving the allocations to the heap.

Original Author: Jonas Kunze.

harningt · 2016-06-01T14:16:56Z

 const char *match (lua_State *L, const char *o, const char *s, const char *e,
 Instruction *op, Capture *capture, int ptop) {
- Stack stackbase[INITBACK];
+ Stack *stackbase = calloc(INITBACK, sizeof(Stack));


No sanity check present in case of failure.

By using the assert macro the process will exit if calloc fails. There is little chance to recover from a failed allocation. Moreover assert() is used at other places already.

HeinrichHartmann · 2016-06-01T12:38:44Z

On operating systems like Solaris and Illumos where the stack grows down, lightuserdata and user data cannot be assigned from the stack. This commit patch fixes this behaviour by moving the allocations to the heap (using calloc).

We also ran into symbol collisions (compile) when linking the library with our codebase. This is also addressed in a separate commit.

as provided by http://www.inf.puc-rio.br/~roberto/lpeg/ on 2016-05-26 `MD5 (lpeg-1.0.0.tar.gz) = 0aec64ccd13996202ad0c099e2877ece`

Solaris (OmniOS, Illumos) version of luajit does not support support allocation of lightuserdata on the stack. This gives errors like this: ``` $ luajit test.lua General tests for LPeg library version 1.0.0 luajit: bad light userdata pointer stack traceback: [C]: in function 'match' test.lua:58: in main chunk [C]: at 0x00402d50 ``` This commit patch fixes this behavior by moving the allocations to the heap.

Original Author: Jonas Kunze.

harningt · 2016-06-01T14:16:56Z

 const char *match (lua_State *L, const char *o, const char *s, const char *e,
 Instruction *op, Capture *capture, int ptop) {
- Stack stackbase[INITBACK];
+ Stack *stackbase = calloc(INITBACK, sizeof(Stack));


No sanity check present in case of failure.

By using the assert macro the process will exit if calloc fails. There is little chance to recover from a failed allocation. Moreover assert() is used at other places already.

HeinrichHartmann · 2016-06-01T12:38:44Z

On operating systems like Solaris and Illumos where the stack grows down, lightuserdata and user data cannot be assigned from the stack. This commit patch fixes this behaviour by moving the allocations to the heap (using calloc).

We also ran into symbol collisions (compile) when linking the library with our codebase. This is also addressed in a separate commit.

as provided by http://www.inf.puc-rio.br/~roberto/lpeg/ on 2016-05-26 `MD5 (lpeg-1.0.0.tar.gz) = 0aec64ccd13996202ad0c099e2877ece`

Solaris (OmniOS, Illumos) version of luajit does not support support allocation of lightuserdata on the stack. This gives errors like this: ``` $ luajit test.lua General tests for LPeg library version 1.0.0 luajit: bad light userdata pointer stack traceback: [C]: in function 'match' test.lua:58: in main chunk [C]: at 0x00402d50 ``` This commit patch fixes this behavior by moving the allocations to the heap.

Original Author: Jonas Kunze.

harningt · 2016-06-01T14:16:56Z

 const char *match (lua_State *L, const char *o, const char *s, const char *e,
 Instruction *op, Capture *capture, int ptop) {
- Stack stackbase[INITBACK];
+ Stack *stackbase = calloc(INITBACK, sizeof(Stack));


No sanity check present in case of failure.

By using the assert macro the process will exit if calloc fails. There is little chance to recover from a failed allocation. Moreover assert() is used at other places already.

HeinrichHartmann · 2016-06-01T12:38:44Z

On operating systems like Solaris and Illumos where the stack grows down, lightuserdata and user data cannot be assigned from the stack. This commit patch fixes this behaviour by moving the allocations to the heap (using calloc).

We also ran into symbol collisions (compile) when linking the library with our codebase. This is also addressed in a separate commit.

as provided by http://www.inf.puc-rio.br/~roberto/lpeg/ on 2016-05-26 `MD5 (lpeg-1.0.0.tar.gz) = 0aec64ccd13996202ad0c099e2877ece`

Solaris (OmniOS, Illumos) version of luajit does not support support allocation of lightuserdata on the stack. This gives errors like this: ``` $ luajit test.lua General tests for LPeg library version 1.0.0 luajit: bad light userdata pointer stack traceback: [C]: in function 'match' test.lua:58: in main chunk [C]: at 0x00402d50 ``` This commit patch fixes this behavior by moving the allocations to the heap.

Original Author: Jonas Kunze.

harningt · 2016-06-01T14:16:56Z

 const char *match (lua_State *L, const char *o, const char *s, const char *e,
 Instruction *op, Capture *capture, int ptop) {
- Stack stackbase[INITBACK];
+ Stack *stackbase = calloc(INITBACK, sizeof(Stack));


No sanity check present in case of failure.

By using the assert macro the process will exit if calloc fails. There is little chance to recover from a failed allocation. Moreover assert() is used at other places already.

HeinrichHartmann · 2016-06-01T12:38:44Z

On operating systems like Solaris and Illumos where the stack grows down, lightuserdata and user data cannot be assigned from the stack. This commit patch fixes this behaviour by moving the allocations to the heap (using calloc).

We also ran into symbol collisions (compile) when linking the library with our codebase. This is also addressed in a separate commit.

as provided by http://www.inf.puc-rio.br/~roberto/lpeg/ on 2016-05-26 `MD5 (lpeg-1.0.0.tar.gz) = 0aec64ccd13996202ad0c099e2877ece`

Solaris (OmniOS, Illumos) version of luajit does not support support allocation of lightuserdata on the stack. This gives errors like this: ``` $ luajit test.lua General tests for LPeg library version 1.0.0 luajit: bad light userdata pointer stack traceback: [C]: in function 'match' test.lua:58: in main chunk [C]: at 0x00402d50 ``` This commit patch fixes this behavior by moving the allocations to the heap.

Original Author: Jonas Kunze.

harningt · 2016-06-01T14:16:56Z

 const char *match (lua_State *L, const char *o, const char *s, const char *e,
 Instruction *op, Capture *capture, int ptop) {
- Stack stackbase[INITBACK];
+ Stack *stackbase = calloc(INITBACK, sizeof(Stack));


No sanity check present in case of failure.

By using the assert macro the process will exit if calloc fails. There is little chance to recover from a failed allocation. Moreover assert() is used at other places already.

HeinrichHartmann · 2016-06-01T12:38:44Z

On operating systems like Solaris and Illumos where the stack grows down, lightuserdata and user data cannot be assigned from the stack. This commit patch fixes this behaviour by moving the allocations to the heap (using calloc).

We also ran into symbol collisions (compile) when linking the library with our codebase. This is also addressed in a separate commit.

as provided by http://www.inf.puc-rio.br/~roberto/lpeg/ on 2016-05-26 `MD5 (lpeg-1.0.0.tar.gz) = 0aec64ccd13996202ad0c099e2877ece`

Solaris (OmniOS, Illumos) version of luajit does not support support allocation of lightuserdata on the stack. This gives errors like this: ``` $ luajit test.lua General tests for LPeg library version 1.0.0 luajit: bad light userdata pointer stack traceback: [C]: in function 'match' test.lua:58: in main chunk [C]: at 0x00402d50 ``` This commit patch fixes this behavior by moving the allocations to the heap.

Original Author: Jonas Kunze.

harningt · 2016-06-01T14:16:56Z

 const char *match (lua_State *L, const char *o, const char *s, const char *e,
 Instruction *op, Capture *capture, int ptop) {
- Stack stackbase[INITBACK];
+ Stack *stackbase = calloc(INITBACK, sizeof(Stack));


No sanity check present in case of failure.

By using the assert macro the process will exit if calloc fails. There is little chance to recover from a failed allocation. Moreover assert() is used at other places already.

HeinrichHartmann · 2016-06-01T12:38:44Z

On operating systems like Solaris and Illumos where the stack grows down, lightuserdata and user data cannot be assigned from the stack. This commit patch fixes this behaviour by moving the allocations to the heap (using calloc).

We also ran into symbol collisions (compile) when linking the library with our codebase. This is also addressed in a separate commit.

as provided by http://www.inf.puc-rio.br/~roberto/lpeg/ on 2016-05-26 `MD5 (lpeg-1.0.0.tar.gz) = 0aec64ccd13996202ad0c099e2877ece`

Solaris (OmniOS, Illumos) version of luajit does not support support allocation of lightuserdata on the stack. This gives errors like this: ``` $ luajit test.lua General tests for LPeg library version 1.0.0 luajit: bad light userdata pointer stack traceback: [C]: in function 'match' test.lua:58: in main chunk [C]: at 0x00402d50 ``` This commit patch fixes this behavior by moving the allocations to the heap.

Original Author: Jonas Kunze.

harningt · 2016-06-01T14:16:56Z

 const char *match (lua_State *L, const char *o, const char *s, const char *e,
 Instruction *op, Capture *capture, int ptop) {
- Stack stackbase[INITBACK];
+ Stack *stackbase = calloc(INITBACK, sizeof(Stack));


No sanity check present in case of failure.

By using the assert macro the process will exit if calloc fails. There is little chance to recover from a failed allocation. Moreover assert() is used at other places already.

HeinrichHartmann · 2016-06-01T12:38:44Z

On operating systems like Solaris and Illumos where the stack grows down, lightuserdata and user data cannot be assigned from the stack. This commit patch fixes this behaviour by moving the allocations to the heap (using calloc).

We also ran into symbol collisions (compile) when linking the library with our codebase. This is also addressed in a separate commit.

as provided by http://www.inf.puc-rio.br/~roberto/lpeg/ on 2016-05-26 `MD5 (lpeg-1.0.0.tar.gz) = 0aec64ccd13996202ad0c099e2877ece`

Solaris (OmniOS, Illumos) version of luajit does not support support allocation of lightuserdata on the stack. This gives errors like this: ``` $ luajit test.lua General tests for LPeg library version 1.0.0 luajit: bad light userdata pointer stack traceback: [C]: in function 'match' test.lua:58: in main chunk [C]: at 0x00402d50 ``` This commit patch fixes this behavior by moving the allocations to the heap.

Original Author: Jonas Kunze.

harningt · 2016-06-01T14:16:56Z

 const char *match (lua_State *L, const char *o, const char *s, const char *e,
 Instruction *op, Capture *capture, int ptop) {
- Stack stackbase[INITBACK];
+ Stack *stackbase = calloc(INITBACK, sizeof(Stack));


No sanity check present in case of failure.

By using the assert macro the process will exit if calloc fails. There is little chance to recover from a failed allocation. Moreover assert() is used at other places already.

HeinrichHartmann added 3 commits May 26, 2016 18:41

Upgrade to Version 1.0
158cce3
as provided by http://www.inf.puc-rio.br/~roberto/lpeg/ on 2016-05-26 `MD5 (lpeg-1.0.0.tar.gz) = 0aec64ccd13996202ad0c099e2877ece`

Enforce usage of our compile() implementation by renaming it
76f742a
Original Author: Jonas Kunze.