Uh oh!
There was an error while loading. Please reload this page.
fix osdate field types to match Lua manual - #3416
Conversation
`osdate` (return type of `os.date()`) fields are all integers (not `integer|string`), except for `isdst` which is `boolean` and may be absent if the information is not available. The `integer|string` union belongs on `osdateparam` (used by `os.time()`), not the return type.
There was a problem hiding this comment.
Code Review
This pull request updates the type annotations for the osdate class in meta/template/os.lua by changing the fields year, month, day, hour, min, sec, wday, and yday from integer|string to integer, and making isdst optional (boolean?). There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Uh oh!
There was an error while loading. Please reload this page.
osdate(return type ofos.date()) fields are all integers (notinteger|string), except forisdstwhich isbooleanand may be absent if the information is not available. Theinteger|stringunion belongs onosdateparam(used byos.time()), not the return type.