Uh oh!
There was an error while loading. Please reload this page.
Fix offlineplayer issues - #40
Open
cerqiest wants to merge 4 commits into
Open
Conversation
cerqiest
commented
Apr 21, 2025
CollaboratorAuthor
I did not mean to open this as an actual PR and cannot figure out how to convert it to a draft. |
Qodana Community for JVM47 new problems were found
☁️ View the detailed Qodana report Contact Qodana teamContact us at qodana-support@jetbrains.com
|
cerqiest
commented
Apr 21, 2025
CollaboratorAuthor
Ready to merge. |
| } | ||
| } | ||
| open val location | ||
| get() = offlinePlayer.location?.let { LuaLocation.fromBukkit(it) } |
Contributor
There was a problem hiding this comment.
Surely this doesn't work since the player is offline...
| get() = offlinePlayer.player | ||
| @TwineNativeProperty("player") | ||
| open val playerLuaProperty | ||
| get() = offlinePlayer.player?.let { LuaPlayer(it) } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are some dumb issues and other fixed that I probably could've caught in testing (or in review!) but nevertheless need to be fixed.