AllowNullCollections=false not honored for ICollection

[tboby]

Source/destination types

 public class Foo
 {
 public List<int> fooList = null;
 }

 public class FooDB
 {
 public ICollection<int> fooList = null;
 }

Mapping configuration

 public class ExplicitGlobalDefaultProfile : Profile
 {
 public ExplicitGlobalDefaultProfile()
 {
 AllowNullCollections = false;
 AllowNullDestinationValues = true;
 CreateMap<Foo, FooDB>();
 }
 }

 public class ImplicitGlobalDefaultProfile : Profile {
 public ImplicitGlobalDefaultProfile()
 {
 CreateMap<Foo, FooDB>();
 }
 }

Version: x.y.z

6.1.0

Expected behavior

I expect fooDB.fooList to be an empty collection of some kind.
In 6.0.2 (and 5.2.0) this is the actual behaviour.

Actual behavior

fooList is null.

Steps to reproduce

 var explicitGlobalConfig = new MapperConfiguration(cfg => { cfg.AddProfile<ExplicitGlobalDefaultProfile>(); });
 var implicitGlobalConfig = new MapperConfiguration(cfg => { cfg.AddProfile<ImplicitGlobalDefaultProfile>(); });
 var explicitMapper = explicitGlobalConfig.CreateMapper();
 var implicitMapper = implicitGlobalConfig.CreateMapper();
 var foo = new Foo();
 var explicitFooDB = explicitMapper.Map<Foo, FooDB>(foo);
 var implicitFooDB = implicitMapper.Map<Foo, FooDB>(foo);

[tboby]

Looks like 251cf52 in #2115 made this change. This seems to be the addition of a interface check that ignores allownullcollections. Was this intentional?

[SuperJMN]

I'm eagerly waiting for this fix to be released in a new NuGet package :) The issue happened to me using IReadOnlyCollection in the source collection.

[lbargaoanu]

Try the MyGet build.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.