fix(builder/parser): correct JSON filtering and deterministic filter order

[pcfreak30]

Fixes JSON pattern matching on MySQL by unquoting extracted string values and applying an explicit case-insensitive collation, aligning behavior with SQLite.

Makes QueryParamParser emit filters in deterministic key order, removing an intermittent serializer failure caused by randomized Go map iteration.

Resolves pre-existing failures in the json_startswith_filter, json_not_contains_case-sensitive_filter, and json_field_with_explicit_null_value tests while preserving backwards-compatible OpNull semantics.

---

Based on the code changes, this pull request addresses two main issues:

Summary

This PR fixes JSON filtering behavior across different database dialects and ensures deterministic filter ordering in query parameter parsing.

Key Changes

1. Fixed JSON Filtering for MySQL/MariaDB Pattern Matching

Problem: MySQL's JSON_EXTRACT() function preserves surrounding quotes on string values, which breaks pattern matching operations (e.g., LIKE 'dar%' would fail against "dark" instead of matching dark).

Solution:

• Added a new jsonExtractExpr() helper method that wraps MySQL/MariaDB JSON_EXTRACT() in JSON_UNQUOTE() to strip quotes and match SQLite's json_extract() behavior
• For MySQL/MariaDB, added explicit case-insensitive collation (COLLATE utf8mb4_0900_ai_ci) to LIKE operations to match SQLite's default case-insensitive behavior
• Refactored the JSON pattern matching clause builder to use consistent SQL construction across all operators (contains, not contains, starts with, ends with, and their case-sensitive/negative variants)

2. Fixed Non-Deterministic Filter Ordering

Problem: Go map iteration order is randomized, causing inconsistent filter application order when parsing query parameters.

Solution: Added sorting of map keys before building filters to ensure deterministic, reproducible filter ordering based on alphabetical key order.

3. Corrected NULL JSON Path Filtering Test

Updated test expectations to correctly reflect that OpNull matches missing JSON paths (treating them as NULL), consistent with documented JSON null filtering behavior.

4. Code Cleanup

• Extracted dialect name constants for better maintainability
• Removed empty error handling blocks in the parser code
• Added documentation comments for the new JSON extraction helper

[kody-ai]

The new buildJSONClause method constructs raw SQL clauses with LIKE/NOT LIKE operators via conditionBuilderDB.Where(...) without a context timeout, allowing queries to run indefinitely. Add .WithContext(ctx) before the .Where() call or wrap query construction in a db.RetryableComponentLock.

Kody rule violation: Disallow GORM queries without timeout

[github-actions]

Code Coverage Report

Total Coverage: 88.8%

Generated from commit: 569e0e7
Repository: LumeWeb/queryutil

[kody-ai]

The added line at 184 uses b.baseTx.Raw("SELECT VERSION()").Scan(&version) without a context with timeout, which can hang indefinitely if the database is unresponsive. Per the rule, all GORM operations must use .WithContext(ctx). Although this is a raw SQL call via GORM, it still performs a database operation and should be given a timeout context to prevent blocking the query builder. Consider adding a context with a reasonable timeout (e.g., context.WithTimeout(...)) and passing it via .WithContext(ctx) before .Raw(...). This aligns with the rule's intent to prevent unbounded database queries.

Kody rule violation: Disallow GORM queries without timeout

[kody-ai]

The new detectMySQLFlavor function executes SELECT VERSION() without a context, which can block indefinitely if the database is unresponsive. Use db.WithContext(ctx) with a caller-provided timeout context to bound the query execution.

Kody rule violation: Disallow GORM queries without timeout

[kody-ai]

In detectMySQLFlavor, the db.Raw("SELECT VERSION()").Scan(&version) call lacks a timeout context, executing without a timeout and potentially hanging if the database is unresponsive, which could block the builder indefinitely. Add a context with a timeout via db.WithContext(ctx) before calling Raw to prevent unbounded query execution. Note that this call is not inside a db.RetryableComponentLock, so the exception does not apply.

Kody rule violation: Disallow GORM queries without timeout

[kody-ai]

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

• Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

• Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.

• Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Bug	✅
Performance	✅
Security	✅
Business Logic	✅

Access your configuration settings here.

​